Since commit 7e7487166b02aa41d42e96a1dfccaceda7fefc12, Guix System treats devices starting with "/dev/" as special and won't even try to mount them if the whole string isn't an existing file name. This strict naming policy is (AFAIK?) Guix-specific and breaks things like booting multi-device bcachefs file systems: waiting for partition '/dev/sda1:/dev/sdb1' to appear... waiting for partition '/dev/sda1:/dev/sdb1' to appear... …ad infinitum until crashing to a Guile prompt. Guix must not enforce custom naming policies like this. On the contrary: we should defer mounting to the kernel whenever possible, and handle failures only when they occur. We can still delay mounts, retry failed mounts, and try to set up favourable mount conditions based on what we think the mount(2) SOURCE looks like, without adding our own arbitrary rules.
Waits for devices specified by a string. Fixes: #6134 Change-Id: I430483deccb70fad44fe0e141afc050ae41308dc Signed-off-by: Maxim Cournoyer <maxim@guixotic.coop>
When a device with a UUID is missing, canonicalize-device-spec will throw an error. This error is not handled for mount-may-fail? devices. That means that if you use UUID device and it isn't available, the boot will hang on the user-file-systems not being started. All user services depend on that service. Also added a test for this behavior. * gnu/build/file-systems.scm (mount-file-system): Guard canonicalize-device-spec call. (canonicalize-device-spec): Throw &partition-lookup-error on missing partition. (&partition-lookup-error): New variable. * gnu/tests/base.scm (%test-missing-file-system): New variable. Change-Id: I3b8d652251cef421cff6d2fdafb8d9d7d1fc74b5 Reported-By: renbus, on IRC Signed-off-by: Maxim Cournoyer <maxim@guixotic.coop>
This allows remounting file systems which are already mounted by the initrd with custom mount options (e.g. /proc with hidepid=2). * gnu/build/file-systems.scm (mount-flags->bit-mask): Map 'remount to MS_REMOUNT. * gnu/system/file-systems.scm (invalid-file-system-flags): Add 'remount to the list of KNOWN-FLAGS. * doc/guix.texi (File Systems): Document it. Fixes: guix/guix#3849 Change-Id: I0ab116a5b4f7bd201e955ecf022e260c63828dc4 Signed-off-by: Ludovic Courtès <ludo@gnu.org>
* gnu/build/file-systems.scm (linux-swap-superblock?) (read-linux-swap-superblock, bcachefs-superblock?): Use "a" instead of "an" before consonant sounds. Change-Id: Ifb36a125733ff898ecbef0a0a546819130707fba Signed-off-by: Ludovic Courtès <ludo@gnu.org>
* gnu/build/file-systems.scm (%linux-swsuspend-magic): New variable. (linux-swsuspend-superblock?, read-linux-swsuspend-superblock): New procedures. (%partition-label-readers, %partition-uuid-readers): Add readers for linux-swsuspend superblocks. Change-Id: If77ca9b4ae1f72c4e9ce52149b10d331566b0030 Signed-off-by: Ludovic Courtès <ludo@gnu.org>
This reverts commit a7db92d9b389cbe565395523882c34c6eff2c21a, this time with the more careful command, to avoid a world rebuild: grep -rl --exclude-dir=build --exclude-dir=patches --exclude=ld-wrapper.in \ --exclude=sitecustomize.py --exclude=guix-emacs.el maxim.cournoyer@gmail.com | xargs sed -i 's/maxim.cournoyer@gmail.com/maxim@guixotic.coop/g' Change-Id: I0871f5cf9ace79e34e78e24154d0da6ea95a3a91
This reverts commit d0d87a744d724b7e7d5ac013c586039652087bb3. Oops! This caused a world rebuild. Change-Id: I25fff644b2b61d0ee93d69b457b04c72b5b74d15
The change was automated via:
git grep -l maxim.cournoyer@gmail.com |
xargs sed -i 's/maxim.cournoyer@gmail.com/maxim@guixotic.coop/g'
* .mailmap: New entry.
Change-Id: Iaa88b1e51c94159c49138fb43910badb990eb169
* gnu/build/file-systems.scm (fat16-superblock?): Support FAT12. Change-Id: Ia14899134e02bda54b0796efb0bc1c6f89e95c0d Signed-off-by: Danny Milosavljevic <dannym@friendly-machines.com>