summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLudovic Courtès <ludo@gnu.org>2019-04-23 15:08:31 +0200
committerLudovic Courtès <ludo@gnu.org>2019-04-23 16:38:12 +0200
commit86b8869ffffad96e06e98d523f287b25684a6fa6 (patch)
tree259bdfc90218042ab6e0728390f1c613f733f6c9
parent051b279fd08eec80cda248aa12e6875005b7dc4f (diff)
linux-container: Remove '%containerized-shepherd-service' hack.
This hack worked around a defect in the Shepherd 0.5.0 and is no longer needed. * gnu/services/shepherd.scm (%containerized-shepherd-service): Remove. * gnu/system/linux-container.scm (container-essential-services): Don't use it.
-rw-r--r--gnu/services/shepherd.scm16
-rw-r--r--gnu/system/linux-container.scm3
2 files changed, 1 insertions, 18 deletions
diff --git a/gnu/services/shepherd.scm b/gnu/services/shepherd.scm
index 21baacbaf70..45c67e04ebc 100644
--- a/gnu/services/shepherd.scm
+++ b/gnu/services/shepherd.scm
@@ -60,7 +60,6 @@
60 %default-modules 60 %default-modules
61 61
62 shepherd-service-file 62 shepherd-service-file
63 %containerized-shepherd-service
64 63
65 shepherd-service-lookup-procedure 64 shepherd-service-lookup-procedure
66 shepherd-service-back-edges 65 shepherd-service-back-edges
@@ -346,21 +345,6 @@ symbols provided/required by a service."
346 (lambda (service) 345 (lambda (service)
347 (vhash-foldq* cons '() service edges))) 346 (vhash-foldq* cons '() service edges)))
348 347
349(define %containerized-shepherd-service
350 ;; XXX: This service works around a bug in the Shepherd 0.5.0: shepherd
351 ;; calls reboot(2) (via 'disable-reboot-on-ctrl-alt-del') when it starts,
352 ;; but in a container that fails with EINVAL. This was fixed in Shepherd
353 ;; commit 92e806bac1abaeeaf5d60f0ab50d1ae85ba6a62f.
354 (simple-service 'containerized-shepherd
355 shepherd-root-service-type
356 (list (shepherd-service
357 (provision '(containerized-shepherd))
358 (start #~(lambda ()
359 (set! (@@ (shepherd)
360 disable-reboot-on-ctrl-alt-del)
361 (const #t))
362 #t))))))
363
364(define (shepherd-service-upgrade live target) 348(define (shepherd-service-upgrade live target)
365 "Return two values: the subset of LIVE (a list of <live-service>) that needs 349 "Return two values: the subset of LIVE (a list of <live-service>) that needs
366to be unloaded, and the subset of TARGET (a list of <shepherd-service>) that 350to be unloaded, and the subset of TARGET (a list of <shepherd-service>) that
diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.scm
index 37a053cdc38..149c3d08a32 100644
--- a/gnu/system/linux-container.scm
+++ b/gnu/system/linux-container.scm
@@ -29,7 +29,6 @@
29 #:use-module (gnu build linux-container) 29 #:use-module (gnu build linux-container)
30 #:use-module (gnu services) 30 #:use-module (gnu services)
31 #:use-module (gnu services base) 31 #:use-module (gnu services base)
32 #:use-module (gnu services shepherd)
33 #:use-module (gnu system) 32 #:use-module (gnu system)
34 #:use-module (gnu system file-systems) 33 #:use-module (gnu system file-systems)
35 #:export (system-container 34 #:export (system-container
@@ -52,7 +51,7 @@ from OS that are needed on the bare metal and not in a container."
52 (let ((locale (operating-system-locale-directory os))) 51 (let ((locale (operating-system-locale-directory os)))
53 (with-monad %store-monad 52 (with-monad %store-monad
54 (return `(("locale" ,locale)))))) 53 (return `(("locale" ,locale))))))
55 (append base (list %containerized-shepherd-service)))) 54 base))
56 55
57(define (containerized-operating-system os mappings) 56(define (containerized-operating-system os mappings)
58 "Return an operating system based on OS for use in a Linux container 57 "Return an operating system based on OS for use in a Linux container