summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReepca Russelstein <reepca@russelstein.xyz>2025-04-29 08:17:38 -0500
committerJohn Kehayias <john.kehayias@protonmail.com>2025-06-24 10:07:58 -0400
commitc659f977bb09de6d5615e6aa9efddedc1d9ff458 (patch)
tree16aa5273c64981b6abfe25e851ad2e61cbcd4df2
parentfb42611b8f27960304db5a1c0d33b8371dcde2a8 (diff)
daemon: add seccomp filter for slirp4netns.
The container that slirp4netns runs in should already be quite difficult to do anything malicious in beyond basic denial of service or sending of network traffic. There is, however, one hole remaining in the case in which there is an adversary able to run code locally: abstract unix sockets. Because these are governed by network namespaces, not IPC namespaces, and slirp4netns is in the root network namespace, any process in the root network namespace can cooperate with the slirp4netns process to take over its user. To close this, we use seccomp to block the creation of unix-domain sockets by slirp4netns. This requires some finesse, since slirp4netns absolutely needs to be able to create other types of sockets - at minimum AF_INET and AF_INET6 Seccomp has many, many pitfalls. To name a few: 1. Seccomp provides you with an "arch" field, but this does not uniquely determine the ABI being used; the actual meaning of a system call number depends on both the number (which is often the result of ORing a related system call with a flag for an alternate ABI) and the architecture. 2. Seccomp provides no direct way of knowing what the native value for the arch field should be; the user must do configure/compile-time testing for every architecture+ABI combination they want to support. Amusingly enough, the linux-internal header files have this exact information (SECCOMP_ARCH_NATIVE), but they aren't sharing it. 3. The only system call numbers we naturally have are the native ones in asm/unistd.h. __NR_socket will always refer to the system call number for the target system's ABI. 4. Seccomp can only manipulate 32-bit words, but represents every system call argument as a uint64. 5. New system call numbers with as-yet-unknown semantics can be added to the kernel at any time. 6. Based on this comment in arch/x86/entry/syscalls/syscall_32.tbl: # 251 is available for reuse (was briefly sys_set_zone_reclaim) previously-invalid system call numbers may later be reused for new system calls. 7. Most architecture+ABI combinations have system call tables with many gaps in them. arm-eabi, for example, has 35 such gaps (note: this is just the number of distinct gaps, not the number of system call numbers contained in those gaps). 8. Seccomp's BPF filters require a fully-acyclic control flow graph. Any operation on a data structure must therefore first be fully unrolled before it can be run. 9. Seccomp cannot dereference pointers. Only the raw bits provided to the system calls can be inspected. 10. Some architecture+ABI combos have multiplexer system calls. For example, socketcall can perform any socket-related system call. The arguments to the multiplexed system call are passed indirectly, via a pointer to user memory. They therefore cannot be inspected by seccomp. 11. Some valid system calls are not listed in any table in the kernel source. For example, __ARM_NR_cacheflush is an "ARM private" system call. It does not appear in any *.tbl file. 12. Conditional branches are limited to relative jumps of at most 256 instructions forward. 13. Prior to Linux 4.8, any process able to spawn another process and call ptrace could bypass seccomp restrictions. To address (1), (2), and (3), we include preprocessor checks to identify the native architecture value, and reject all system calls that don't use the native architecture. To address (4), we use the AC_C_BIGENDIAN autoconf check to conditionally define WORDS_BIGENDIAN, and match up the proper portions of any uint64 we test for with the value in the accumulator being tested against. To address (5) and (6), we use system call pinning. That is, we hardcode a snapshot of all the valid system call numbers at the time of writing, and reject any system call numbers not in the recorded set. A set is recorded for every architecture+ABI combo, and the native one is chosen at compile-time. This ensures that not only are non-native architectures rejected, but so are non-native ABIs. For the sake of conciseness, we represent these sets as sets of disjoint ranges. Due to (7), checking each range in turn could add a lot of overhead to each system call, so we instead binary search through the ranges. Due to (8), this binary search has to be fully unrolled, so we do that too. It can be tedious and error-prone to manually produce the syscall ranges by looking at linux's *.tbl files, since the gaps are often small and uncommented. To address this, a script, build-aux/extract-syscall-ranges.sh, is added that will produce them given a *.tbl filename and an ABI regex (some tables seem to abuse the ABI field with strange values like "memfd_secret"). Note that producing the final values still requires looking at the proper asm/unistd.h file to find any private numbers and to identify any offsets and ABI variants used. (10) used to have no good solution, but in the past decade most architectures have gained dedicated system call alternatives to at least socketcall, so we can (hopefully) just block it entirely. To address (13), we block ptrace also. * build-aux/extract-syscall-ranges.sh: new script. * Makefile.am (EXTRA_DIST): register it. * config-daemon.ac: use AC_C_BIGENDIAN. * nix/libutil/spawn.cc (setNoNewPrivsAction, addSeccompFilterAction): new functions. * nix/libutil/spawn.hh (setNoNewPrivsAction, addSeccompFilterAction): new declarations. (SpawnContext)[setNoNewPrivs, addSeccompFilter]: new fields. * nix/libutil/seccomp.hh: new header file. * nix/libutil/seccomp.cc: new file. * nix/local.mk (libutil_a_SOURCES, libutil_headers): register them. * nix/libstore/build.cc (slirpSeccompFilter, writeSeccompFilterDot): new functions. (spawnSlirp4netns): use them, set seccomp filter for slirp4netns. Change-Id: Ic92c7f564ab12596b87ed0801b22f88fbb543b95 Signed-off-by: John Kehayias <john.kehayias@protonmail.com>
-rw-r--r--Makefile.am1
-rwxr-xr-xbuild-aux/extract-syscall-ranges.sh80
-rw-r--r--config-daemon.ac4
-rw-r--r--nix/libstore/build.cc219
-rw-r--r--nix/libutil/seccomp.cc162
-rw-r--r--nix/libutil/seccomp.hh222
-rw-r--r--nix/libutil/spawn.cc36
-rw-r--r--nix/libutil/spawn.hh10
-rw-r--r--nix/local.mk6
9 files changed, 738 insertions, 2 deletions
diff --git a/Makefile.am b/Makefile.am
index a4737fe9d53..8b33734f38a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -746,6 +746,7 @@ EXTRA_DIST += \
746 build-aux/compile-as-derivation.scm \ 746 build-aux/compile-as-derivation.scm \
747 build-aux/config.rpath \ 747 build-aux/config.rpath \
748 build-aux/convert-xref.scm \ 748 build-aux/convert-xref.scm \
749 build-aux/extract-syscall-ranges.sh \
749 build-aux/generate-authors.scm \ 750 build-aux/generate-authors.scm \
750 build-aux/git-version-gen \ 751 build-aux/git-version-gen \
751 build-aux/mdate-from-git.scm \ 752 build-aux/mdate-from-git.scm \
diff --git a/build-aux/extract-syscall-ranges.sh b/build-aux/extract-syscall-ranges.sh
new file mode 100755
index 00000000000..3826fc25fe3
--- /dev/null
+++ b/build-aux/extract-syscall-ranges.sh
@@ -0,0 +1,80 @@
1#!/bin/sh
2
3if test "$#" -lt 1 || test "$#" -gt 2
4then
5 echo "Usage: extract-syscall-ranges.sh FILENAME [abiname_regex]"
6 exit 1
7fi
8
9numbers_to_ranges()
10{
11 if ! read number
12 then
13 printf '{}\n'
14 return
15 fi
16 low="$number"
17 high="$number"
18 while true
19 do
20 if read number
21 then
22 if test "$number" -eq "$((high + 1))"
23 then
24 high="$number"
25 else
26 break
27 fi
28 else
29 printf '{ {%d, %d} }\n' "$low" "$high"
30 return
31 fi
32 done
33 printf '{ {%d, %d}' "$low" "$high"
34 low="$number"
35 high="$number"
36 while true
37 do
38 if read number
39 then
40 if test "$number" -eq "$((high + 1))"
41 then
42 high="$number"
43 else
44 printf ', {%d, %d}' "$low" "$high"
45 low="$number"
46 high="$number"
47 fi
48 else
49 printf ', {%d, %d} }\n' "$low" "$high"
50 return
51 fi
52 done
53}
54
55if test "$#" -eq 2
56then
57 abi_regex="$2"
58 getnumbers()
59 {
60 # delete comment lines and space-only lines
61 sed -e '/^[[:space:]]*#/d ; /^[[:space:]]*$/d' |
62 # filter to only include lines with target abi or "common"
63 grep -E "^[0-9]+[[:space:]]+(common|(${abi_regex}))[[:space:]]" |
64 # limit to only syscall number
65 sed -e 's/\([0-9]\+\).*/\1/g'
66 }
67else
68 getnumbers()
69 {
70 # delete comment lines and space-only lines and limit to syscall number
71 sed -e '/^[[:space:]]*#/d ; /^[[:space:]]*$/d ; s/\([0-9]\+\).*/\1/g'
72 }
73fi
74
75getnumbers < "$1" |
76 sort -n |
77 uniq | # Yes, there are duplicate syscall entries...
78 numbers_to_ranges
79
80
diff --git a/config-daemon.ac b/config-daemon.ac
index fe73b893ece..2929664140b 100644
--- a/config-daemon.ac
+++ b/config-daemon.ac
@@ -152,6 +152,10 @@ if test "x$guix_build_daemon" = "xyes"; then
152 AC_PATH_PROG([SLIRP4NETNS], [slirp4netns], [slirp4netns]) 152 AC_PATH_PROG([SLIRP4NETNS], [slirp4netns], [slirp4netns])
153 AC_DEFINE_UNQUOTED([SLIRP4NETNS], ["$SLIRP4NETNS"], 153 AC_DEFINE_UNQUOTED([SLIRP4NETNS], ["$SLIRP4NETNS"],
154 [Path to the slirp4netns program, if any.]) 154 [Path to the slirp4netns program, if any.])
155
156 dnl needed for inspecting 64-bit system call arguments in seccomp's Berkeley
157 dnl Packet Filter VM, which only directly operates on 32-bit words.
158 AC_C_BIGENDIAN
155fi 159fi
156 160
157AM_CONDITIONAL([HAVE_LIBBZ2], [test "x$HAVE_LIBBZ2" = "xyes"]) 161AM_CONDITIONAL([HAVE_LIBBZ2], [test "x$HAVE_LIBBZ2" = "xyes"])
diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
index 1a688f3b56c..eee3a33a58d 100644
--- a/nix/libstore/build.cc
+++ b/nix/libstore/build.cc
@@ -85,6 +85,13 @@
85/* This header isn't documented in 'man netdevice', but there doesn't seem to 85/* This header isn't documented in 'man netdevice', but there doesn't seem to
86 be any other way to get 'struct in6_ifreq'... */ 86 be any other way to get 'struct in6_ifreq'... */
87#include <linux/ipv6.h> 87#include <linux/ipv6.h>
88#include <linux/filter.h>
89#include <linux/seccomp.h>
90#include <seccomp.hh>
91
92/* Set to 1 to debug the seccomp filter. */
93#define DEBUG_SECCOMP_FILTER 0
94
88#endif 95#endif
89#endif 96#endif
90 97
@@ -1815,6 +1822,7 @@ static void setupTap(int send_fd_socket, bool ipv6Enabled)
1815 sendFD(send_fd_socket, tapfd); 1822 sendFD(send_fd_socket, tapfd);
1816} 1823}
1817 1824
1825
1818struct ChrootBuildSpawnContext : CloneSpawnContext { 1826struct ChrootBuildSpawnContext : CloneSpawnContext {
1819 bool ipv6Enabled = false; 1827 bool ipv6Enabled = false;
1820}; 1828};
@@ -1933,6 +1941,212 @@ static void remapIdsTo0Action(SpawnContext & sctx)
1933} 1941}
1934 1942
1935 1943
1944static std::vector<struct sock_filter> slirpSeccompFilter()
1945{
1946 std::vector<struct sock_filter> out;
1947 struct sock_filter allow = BPF_STMT(BPF_RET | BPF_K, SECCOMP_RET_ALLOW);
1948 struct sock_filter deny = BPF_STMT(BPF_RET | BPF_K,
1949 /* Could also use
1950 * SECCOMP_RET_KILL_THREAD, but this
1951 * gives nicer error messages. */
1952 SECCOMP_RET_ERRNO | ENOSYS);
1953 struct sock_filter silentDeny = BPF_STMT(BPF_RET | BPF_K,
1954 SECCOMP_RET_ERRNO | 0);
1955
1956 /* instructions to check for AF_INET or AF_INET6 in the first argument */
1957 std::vector<struct sock_filter> allowInet;
1958 seccompMatchu64(allowInet,
1959 AF_INET,
1960 {allow},
1961 offsetof(struct seccomp_data, args[0]));
1962 seccompMatchu64(allowInet,
1963 AF_INET6,
1964 {allow},
1965 offsetof(struct seccomp_data, args[0]));
1966 /* ... and deny otherwise */
1967 std::vector<struct sock_filter> denyNonInet;
1968 denyNonInet.insert(denyNonInet.begin(), allowInet.begin(), allowInet.end());
1969 denyNonInet.push_back(deny);
1970
1971 /* ... and silent variant. */
1972 std::vector<struct sock_filter> silentDenyNonInet;
1973
1974 silentDenyNonInet.insert(silentDenyNonInet.begin(), allowInet.begin(), allowInet.end());
1975 silentDenyNonInet.push_back(silentDeny);
1976
1977 /* accumulator <-- data.arch */
1978 out.push_back(BPF_STMT(BPF_LD | BPF_W | BPF_ABS, (offsetof(struct seccomp_data, arch))));
1979 /* Deny if non-native arch. This simplifies checks as we can now just use
1980 * the __NR_* syscall numbers. */
1981 out.push_back(BPF_JUMP(BPF_JMP | BPF_JEQ | BPF_K,
1982 AUDIT_ARCH_NATIVE,
1983 1,
1984 0));
1985 out.push_back(deny);
1986
1987 std::vector<Uint32RangeAction> specialCaseActions;
1988
1989#ifdef __NR_socket
1990 Uint32RangeAction socketAction;
1991 socketAction.low = __NR_socket;
1992 socketAction.high = __NR_socket;
1993 socketAction.instructions = denyNonInet;
1994 specialCaseActions.push_back(socketAction);
1995#endif
1996
1997#ifdef __NR_socketpair
1998 /* socketpair can be used to create unix sockets. Presumably they can't
1999 * be re-bound or reconnected to use the abstract unix socket namespace,
2000 * since they're already connected, but let's not risk it - slirp4netns
2001 * shouldn't have a reason to use any IPC anyway. */
2002 Uint32RangeAction socketpairAction;
2003 socketpairAction.low = __NR_socketpair;
2004 socketpairAction.high = __NR_socketpair;
2005 /* The silent variant is necessary for socketpair because slirp4netns
2006 unconditionally creates a unix socket using socketpair for using setns
2007 to exfiltrate a tapfd, despite not actually needing to do that at all
2008 since we pass it the tapfd directly. It will refuse to start if
2009 socketpair returns anything but 0, so we have no choice but to do that.
2010 The would-be-returned socket fds are never used. */
2011 socketpairAction.instructions = silentDenyNonInet;
2012 specialCaseActions.push_back(socketpairAction);
2013#endif
2014
2015#ifdef __NR_socketcall
2016 /* Some architectures include a system call "socketcall" for multiplexing
2017 * all the socket-related calls. This system call only accepts two
2018 * arguments: a number to indicate which socket-related system call to
2019 * invoke, and a pointer to an array holding the arguments for it.
2020 * Seccomp can't inspect the contents of memory, only the raw bits passed
2021 * to the kernel, so there's no way to only disallow certain invocations
2022 * of a socket-related system call. In the past decade, most linux
2023 * architectures which relied on "socketcall" have since added dedicated
2024 * system calls (socket, socketpair, connect, etc) that can be used
2025 * instead of socketcall, and it was mostly uncommon architectures that
2026 * relied on it in the first place, so we should be fine to just block it
2027 * outright. */
2028 Uint32RangeAction socketcallAction;
2029 socketcallAction.low = __NR_socketcall;
2030 socketcallAction.high = __NR_socketcall;
2031 socketcallAction.instructions = {deny};
2032 specialCaseActions.push_back(socketcallAction);
2033#endif
2034
2035 /* Kernels before 4.8 allow a process to bypass seccomp restrictions by
2036 * spawning another process to ptrace it and modify a system call after
2037 * the seccomp check. */
2038 Uint32RangeAction ptraceAction;
2039 ptraceAction.low = __NR_ptrace;
2040 ptraceAction.high = __NR_ptrace;
2041 ptraceAction.instructions = { deny };
2042 specialCaseActions.push_back(ptraceAction);
2043
2044 std::vector<struct sock_filter> specialCases =
2045 rangeActionsToFilter(specialCaseActions);
2046
2047 /* accumulator <-- data.nr */
2048 out.push_back(BPF_STMT(BPF_LD | BPF_W | BPF_ABS, (offsetof(struct seccomp_data, nr))));
2049
2050 out.insert(out.end(), specialCases.begin(), specialCases.end());
2051
2052 /* accumulator <-- data.nr again */
2053 out.push_back(BPF_STMT(BPF_LD | BPF_W | BPF_ABS, (offsetof(struct seccomp_data, nr))));
2054
2055 std::vector<Uint32RangeAction> pinnedSyscallRanges = NATIVE_SYSCALL_RANGES;
2056 if(pinnedSyscallRanges.size() != 0) {
2057 for(auto & i : pinnedSyscallRanges) {
2058 i.instructions.push_back(allow);
2059 }
2060 std::vector<struct sock_filter> pinnedWhitelist = rangeActionsToFilter(pinnedSyscallRanges);
2061 out.insert(out.end(), pinnedWhitelist.begin(), pinnedWhitelist.end());
2062 out.push_back(deny);
2063 }
2064 else {
2065 /* Couldn't determine pinned system calls, resort to allowing by
2066 * default. */
2067 out.push_back(allow);
2068 }
2069 return out;
2070}
2071
2072
2073#if DEBUG_SECCOMP_FILTER
2074
2075/* Note: limited to only the subset we actually use, makes various
2076 * assumptions, not general-purpose. */
2077static void writeSeccompFilterDot(std::vector<struct sock_filter> filter, FILE *f)
2078{
2079 fprintf(f, "digraph filter { \n");
2080 for(size_t j = 0; j < filter.size(); j++) {
2081 switch(BPF_CLASS(filter[j].code)) {
2082 case BPF_LD:
2083 fprintf(f, "\"%zu\" [label=\"load into accumulator from offset %u\"];\n",
2084 j, filter[j].k);
2085 fprintf(f, "\"%zu\" -> \"%zu\";\n", j, j + 1);
2086 break;
2087 case BPF_JMP:
2088 switch(BPF_OP(filter[j].code)) {
2089 case BPF_JA:
2090 fprintf(f, "\"%zu\" [label=\"unconditional jump\"];\n", j);
2091 fprintf(f, "\"%zu\" -> \"%zu\";\n", j, j + filter[j].k + 1);
2092 break;
2093 case BPF_JEQ:
2094 fprintf(f, "\"%zu\" [label=\"jump if accumulator = %u\"];\n", j,
2095 filter[j].k);
2096 fprintf(f, "\"%zu\" -> \"%zu\" [label=\"true\"];\n", j,
2097 j + filter[j].jt + 1);
2098 fprintf(f, "\"%zu\" -> \"%zu\" [label=\"false\"];\n", j,
2099 j + filter[j].jf + 1);
2100 break;
2101 case BPF_JGT:
2102 fprintf(f, "\"%zu\" [label=\"jump if accumulator > %u\"];\n", j,
2103 filter[j].k);
2104 fprintf(f, "\"%zu\" -> \"%zu\" [label=\"true\"];\n", j,
2105 j + filter[j].jt + 1);
2106 fprintf(f, "\"%zu\" -> \"%zu\" [label=\"false\"];\n", j,
2107 j + filter[j].jf + 1);
2108 break;
2109 case BPF_JGE:
2110 fprintf(f, "\"%zu\" [label=\"jump if accumulator >= %u\"];\n", j,
2111 filter[j].k);
2112 fprintf(f, "\"%zu\" -> \"%zu\" [label=\"true\"];\n", j,
2113 j + filter[j].jt + 1);
2114 fprintf(f, "\"%zu\" -> \"%zu\" [label=\"false\"];\n", j,
2115 j + filter[j].jf + 1);
2116 break;
2117 default:
2118 fprintf(stderr, "unrecognized jump operation at %zu: %d\n", j, BPF_OP(filter[j].code));
2119 }
2120 break;
2121 case BPF_RET:
2122 switch(filter[j].k & SECCOMP_RET_ACTION_FULL) {
2123 case SECCOMP_RET_KILL_PROCESS:
2124 fprintf(f, "\"%zu\" [label=\"kill the process\"];\n", j);
2125 break;
2126 case SECCOMP_RET_KILL_THREAD:
2127 fprintf(f, "\"%zu\" [label=\"kill the thread\"];\n", j);
2128 break;
2129 case SECCOMP_RET_ERRNO:
2130 fprintf(f, "\"%zu\" [label=\"return errno for \\\"%s\\\"\"];\n",
2131 j, strerror(filter[j].k & SECCOMP_RET_DATA));
2132 break;
2133 case SECCOMP_RET_ALLOW:
2134 fprintf(f, "\"%zu\" [label=\"allow system call\"];\n", j);
2135 break;
2136 default:
2137 fprintf(stderr, "unrecognized return operation at %zu: %d\n", j, filter[j].k);
2138 break;
2139 }
2140 break;
2141 default:
2142 fprintf(stderr, "unrecognized bpf class at %zu: %d\n", j, BPF_CLASS(filter[j].code));
2143 }
2144 }
2145 fprintf(f, "}\n");
2146}
2147
2148#endif
2149
1936/* Spawn 'slirp4netns' in separate namespaces as the given user and group; 2150/* Spawn 'slirp4netns' in separate namespaces as the given user and group;
1937 'tapfd' must correspond to a /dev/net/tun connection. Configure it to 2151 'tapfd' must correspond to a /dev/net/tun connection. Configure it to
1938 write to 'notifyReadyFD' once it's up and running. */ 2152 write to 'notifyReadyFD' once it's up and running. */
@@ -2016,6 +2230,11 @@ static pid_t spawnSlirp4netns(int tapfd, int notifyReadyFD,
2016 slirpCtx.logFD = devNullFd; 2230 slirpCtx.logFD = devNullFd;
2017 } 2231 }
2018 2232
2233#if DEBUG_SECCOMP_FILTER
2234 writeSeccompFilterDot(slirpCtx.seccompFilter, stderr);
2235 fflush(stderr);
2236#endif
2237
2019 addPhaseAfter(slirpCtx.phases, 2238 addPhaseAfter(slirpCtx.phases,
2020 "makeChrootSeparateFilesystem", 2239 "makeChrootSeparateFilesystem",
2021 "prepareSlirpChroot", 2240 "prepareSlirpChroot",
diff --git a/nix/libutil/seccomp.cc b/nix/libutil/seccomp.cc
new file mode 100644
index 00000000000..585442d70b5
--- /dev/null
+++ b/nix/libutil/seccomp.cc
@@ -0,0 +1,162 @@
1#if __linux__
2#include <util.hh>
3#include <seccomp.hh>
4#include <algorithm>
5
6namespace nix {
7
8struct FilterInstruction {
9 struct sock_filter instruction;
10 bool fallthroughJt = false;
11 bool fallthroughJf = false;
12 bool fallthroughK = false;
13};
14
15/* Note: instructions in "out" should have already verified that sysno is
16 * >= ranges[lowIndex].low. The value to compare against should already be
17 * in the accumulator. */
18static void
19rangeActionsToFilter(std::vector<Uint32RangeAction> & ranges,
20 size_t lowIndex, /* Inclusive */
21 size_t end, /* Exclusive */
22 std::vector<FilterInstruction> & out)
23{
24 if(lowIndex >= end) return;
25
26 if(end == lowIndex + 1) {
27 FilterInstruction branch;
28 Uint32RangeAction range = ranges.at(lowIndex);
29 branch.instruction = BPF_JUMP(BPF_JMP | BPF_JGT | BPF_K,
30 range.high,
31 /* To be fixed up */
32 0,
33 0);
34 branch.fallthroughJt = true;
35 out.push_back(branch);
36 for(auto & i : range.instructions) {
37 FilterInstruction f;
38 f.instruction = i;
39 out.push_back(f);
40 }
41 FilterInstruction fallthroughBranch;
42 fallthroughBranch.instruction = BPF_JUMP(BPF_JMP | BPF_JA | BPF_K,
43 /* To be fixed up */
44 0,
45 0,
46 0);
47 fallthroughBranch.fallthroughK = true;
48 out.push_back(fallthroughBranch);
49 return;
50 }
51
52 size_t middle = lowIndex + ((end - lowIndex) / 2);
53 Uint32RangeAction range = ranges.at(middle);
54 FilterInstruction branch;
55 size_t branchIndex = out.size();
56 branch.instruction = BPF_JUMP(BPF_JMP | BPF_JGE | BPF_K,
57 range.low,
58 0,
59 /* To be fixed up a little farther down */
60 0);
61 out.push_back(branch);
62 rangeActionsToFilter(ranges, middle, end, out);
63 size_t elseIndex = out.size();
64 out[branchIndex].instruction.jf = (elseIndex - branchIndex - 1);
65 rangeActionsToFilter(ranges, lowIndex, middle, out);
66}
67
68
69static bool compareRanges(Uint32RangeAction a, Uint32RangeAction b)
70{
71 return (a.low < b.low);
72}
73
74
75/* Produce a loop-unrolled binary search of RANGES for the u32 currently in
76 * the accumulator. If the binary search finds a range that contains it, it
77 * will execute the corresponding instructions. If these instructions fall
78 * through, or if no containing range is found, control resumes after the last
79 * instruction in the returned sequence. */
80std::vector<struct sock_filter>
81rangeActionsToFilter(std::vector<Uint32RangeAction> & ranges)
82{
83 if(ranges.size() == 0) return {};
84 std::sort(ranges.begin(), ranges.end(), compareRanges);
85 if(ranges.size() > 1) {
86 for(auto & i : ranges)
87 if(i.low > i.high)
88 throw Error("Invalid range in rangeActionsToFilter");
89 for(size_t j = 1; j < ranges.size(); j++)
90 if(ranges[j].low <= ranges[j - 1].high)
91 throw Error("Overlapping ranges in rangeActionsToFilter");
92 }
93 std::vector<FilterInstruction> out;
94 Uint32RangeAction first = ranges.at(0);
95 FilterInstruction branch;
96 /* Verify accumulator value is >= first.low, to satisfy initial invariant */
97 branch.instruction = BPF_JUMP(BPF_JMP | BPF_JGE | BPF_K,
98 first.low,
99 0,
100 /* to be fixed up */
101 0);
102 branch.fallthroughJf = true;
103 out.push_back(branch);
104 rangeActionsToFilter(ranges, 0, ranges.size(), out);
105 size_t fallthrough = out.size();
106 std::vector<struct sock_filter> out2;
107 for(size_t j = 0; j < out.size(); j++) {
108 if(out[j].fallthroughJt) out[j].instruction.jt = (fallthrough - j - 1);
109 if(out[j].fallthroughJf) out[j].instruction.jf = (fallthrough - j - 1);
110 if(out[j].fallthroughK) out[j].instruction.k = (fallthrough - j - 1);
111 out2.push_back(out[j].instruction);
112 }
113 return out2;
114}
115
116
117/* If the uint64 at offset OFFSET has value VALUE, run INSTRUCTIONS.
118 * Otherwise, or if INSTRUCTIONS falls through, continue past the last
119 * instruction of OUT at the time seccompMatchu64 returns. Clobbers
120 * accumulator! */
121std::vector<struct sock_filter> seccompMatchu64(std::vector<struct sock_filter> & out,
122 uint64_t value,
123 std::vector<struct sock_filter> instructions,
124 uint32_t offset)
125{
126 /* Note: this only works where the order of bytes in uint64 is big or
127 * little endian, and the same order holds for uint32. */
128 /* Load lower-addressed 32 bits */
129 out.push_back(BPF_STMT(BPF_LD | BPF_W | BPF_ABS, offset));
130 size_t jmp1Index = out.size();
131
132 out.push_back(BPF_JUMP(BPF_JMP | BPF_JEQ | BPF_K,
133#ifdef WORDS_BIGENDIAN
134 (uint32_t)((value >> 32) & 0xffffffff),
135#else
136 (uint32_t)(value & 0xffffffff),
137#endif
138 0,
139 /* To be fixed up */
140 0));
141 /* Load higher-addressed 32 bits */
142 out.push_back(BPF_STMT(BPF_LD | BPF_W | BPF_ABS, offset + (uint32_t)sizeof(uint32_t)));
143 size_t jmp2Index = out.size();
144 out.push_back(BPF_JUMP(BPF_JMP | BPF_JEQ | BPF_K,
145#ifdef WORDS_BIGENDIAN
146 (uint32_t)(value & 0xffffffff),
147#else
148 (uint32_t)((value >> 32) & 0xffffffff),
149#endif
150 0,
151 /* To be fixed up */
152 0));
153
154 out.insert(out.end(), instructions.begin(), instructions.end());
155 out[jmp1Index].jf = (out.size() - jmp1Index - 1);
156 out[jmp2Index].jf = (out.size() - jmp2Index - 1);
157 return out;
158}
159
160}
161
162#endif
diff --git a/nix/libutil/seccomp.hh b/nix/libutil/seccomp.hh
new file mode 100644
index 00000000000..634dfad5f8e
--- /dev/null
+++ b/nix/libutil/seccomp.hh
@@ -0,0 +1,222 @@
1#pragma once
2
3#include "util.hh"
4#include <linux/audit.h> /* For AUDIT_ARCH_* */
5#include <linux/seccomp.h>
6#include <linux/filter.h>
7
8
9/* This file provides two preprocessor macros (among other things):
10 1. AUDIT_ARCH_NATIVE, which evaluates to whichever of the AUDIT_ARCH_*
11 values best represents the target system. Linux's internal headers have
12 a SECCOMP_ARCH_NATIVE since 2020, but it's not user-visible. Detection
13 of this is based on src/arch.c in libseccomp.
14 2. NATIVE_SYSCALL_RANGES, an array initializer for an array of two-element
15 objects, the first of which is an integral number representing the
16 start (inclusive) of a range of valid syscall numbers, and the second
17 of which is an integral number representing the end (inclusive) of that
18 range of valid syscall numbers. The ranges provided are all
19 non-overlapping and strictly ascending (that is, the start of a range is
20 strictly higher than any of the numbers in any of the ranges that
21 precede it). All numbers involved fit into a long.
22
23 These ranges were generated from the various syscall.tbl,
24 syscall_32.tbl, and syscall_64.tbl files lying around in the linux
25 kernel source. Some were derived from
26 include/uapi/asm-generic/unistd.h. The kernel source used was commit
27 b3ee1e460951 of https://github.com/torvalds/linux.git, read on
28 2025-04-23. Not all of the gaps in the files have any comments pointing
29 them out, so I recommend using build-aux/extract-syscall-ranges.sh for
30 the *.tbl files.
31
32 The intent behind saving these ranges is to be able to use a
33 default-allow seccomp policy that nevertheless disallows future
34 syscalls. This ensures that our security analysis can work with a
35 static, well-defined set of system calls that won't grow in the future
36 unless someone explicitly revisits the system call tables to consider
37 the implications of the new additions. */
38
39/* Both ends are inclusive. Some of the .tbl files use strange entries for
40 * the "abi" field, check arch/$ARCH/kernel/Makefile.syscalls to see what it
41 * specifies for syscall_abis_32 and syscall_abis_64 in addition to 32 or 64
42 * and "common" (added in Makefile.asm-headers). Also check what, if
43 * anything, the makefile uses as the --offset flag to syscallhdr.sh. And
44 * look at arch/$ARCH/include/uapi/asm/unistd.h to see what value the offset
45 * takes in what configurations. */
46
47#ifndef AUDIT_ARCH_NATIVE
48
49#if __i386__
50#define AUDIT_ARCH_NATIVE AUDIT_ARCH_I386
51#define NATIVE_SYSCALL_RANGES { {0, 221}, {224, 250}, {252, 284}, {286, 386}, \
52 {393, 414}, {416, 466} }
53#elif __x86_64__
54#define AUDIT_ARCH_NATIVE AUDIT_ARCH_X86_64
55#ifdef __ILP32__
56#include <asm/unistd.h>
57#define X32RANGE(low, high) { (low | __X32_SYSCALL_BIT), (high | __X32_SYSCALL_BIT) }
58#define NATIVE_SYSCALL_RANGES \
59 { X32RANGE(0, 12), X32RANGE(14, 14), X32RANGE(17, 18), X32RANGE(21, 44), X32RANGE(48, 53), \
60 X32RANGE(56, 58), X32RANGE(60, 100), X32RANGE(102, 126), X32RANGE(130, 130), \
61 X32RANGE(132, 133), X32RANGE(135, 155), X32RANGE(157, 173), X32RANGE(175, 176), \
62 X32RANGE(179, 179), X32RANGE(181, 204), X32RANGE(207, 208), X32RANGE(210, 210), \
63 X32RANGE(212, 213), X32RANGE(216, 221), X32RANGE(223, 235), X32RANGE(237, 243), \
64 X32RANGE(245, 245), X32RANGE(248, 272), X32RANGE(275, 277), X32RANGE(280, 294), \
65 X32RANGE(298, 298), X32RANGE(300, 306), X32RANGE(308, 309), X32RANGE(312, 321), \
66 X32RANGE(323, 326), X32RANGE(329, 335), X32RANGE(424, 466), X32RANGE(512, 547) }
67#else
68#define NATIVE_SYSCALL_RANGES { {0, 335}, {424, 466} }
69#endif
70#elif __arm__
71#define AUDIT_ARCH_NATIVE AUDIT_ARCH_ARM
72/* Note: there are at present 6 extra ARM syscall numbers not listed in
73 arch/arm/tools/syscall.tbl, namely __ARM_NR_breakpoint through
74 __ARM_NR_get_tls. */
75#ifdef __ARM_EABI__
76#include <asm/unistd.h>
77#define NATIVE_SYSCALL_RANGES \
78 { {0, 6}, {8, 12}, {14, 16}, {19, 21}, {23, 24}, {26, 26}, {29, 29}, \
79 {33, 34}, {36, 43}, {45, 47}, {49, 52}, {54, 55}, {57, 57}, {60, 67}, \
80 {70, 75}, {77, 81}, {83, 83}, {85, 88}, {91, 97}, {99, 100}, {103, 108}, \
81 {111, 111}, {114, 116}, {118, 122}, {124, 126}, {128, 129}, {131, 136}, \
82 {138, 165}, {168, 187}, {190, 221}, {224, 253}, {256, 401}, {403, 414}, \
83 {416, 446}, {448, 466}, {(__ARM_NR_BASE + 1), (__ARM_NR_BASE + 6)} }
84#else
85#include <asm/unistd.h>
86#define OABIRANGE(low, high) { (low | __NR_OABI_SYSCALL_BASE), (high | __NR_OABI_SYSCALL_BASE) }
87#define NATIVE_SYSCALL_RANGES \
88 { OABIRANGE(0, 6), OABIRANGE(8, 16), OABIRANGE(19, 27), OABIRANGE(29, 30), \
89 OABIRANGE(33, 34), OABIRANGE(36, 43), OABIRANGE(45, 47), OABIRANGE(49, 52), \
90 OABIRANGE(54, 55), OABIRANGE(57, 57), OABIRANGE(60, 67), OABIRANGE(70, 83), \
91 OABIRANGE(85, 97), OABIRANGE(99, 100), OABIRANGE(102, 108), \
92 OABIRANGE(111, 111), OABIRANGE(113, 122), OABIRANGE(124, 126), \
93 OABIRANGE(128, 129), OABIRANGE(131, 136), OABIRANGE(138, 165), \
94 OABIRANGE(168, 187), OABIRANGE(190, 221), OABIRANGE(224, 253), \
95 OABIRANGE(256, 401), OABIRANGE(403, 414), OABIRANGE(416, 446), \
96 OABIRANGE(448, 466), {(__ARM_NR_BASE + 1), (__ARM_NR_BASE + 6)} }
97#endif
98#elif __aarch64__
99#define AUDIT_ARCH_NATIVE AUDIT_ARCH_AARCH64
100/* extract-syscall-ranges.sh $LINUXSOURCE/arch/arm64/tools/syscall_64.tbl \
101 '64|renameat|rlimit|memfd_secret'
102
103 the extra ABIs are taken from arch/arm64/kernel/Makefile.syscalls and
104 scripts/Makefile.asm-headers */
105#define NATIVE_SYSCALL_RANGES { {0, 243}, {260, 294}, {424, 466} }
106/* To my knowledge there is no x32 equivalent for aarch64 in mainline linux */
107#elif __mips__ && _MIPS_SIM == _MIPS_SIM_ABI32
108/* o32 abi in both endianness cases */
109#include <asm/unistd.h>
110#define SYSRANGE(low, high) {(low) + __NR_Linux, (high) + __NR_Linux}
111#define NATIVE_SYSCALL_RANGES \
112 { SYSRANGE(0, 278), SYSRANGE(280, 368), SYSRANGE(393, 414), \
113 SYSRANGE(416, 446), SYSRANGE(448, 466) }
114#if __MIPSEB__
115#define AUDIT_ARCH_NATIVE AUDIT_ARCH_MIPS;
116#elif __MIPSEL__
117#define AUDIT_ARCH_NATIVE AUDIT_ARCH_MIPSEL
118#endif
119#elif __mips__ && _MIPS_SIM == _MIPS_SIM_ABI64
120/* n64 abi in both endianness cases */
121#include <asm/unistd.h>
122#define SYSRANGE(low, high) {(low) + __NR_Linux, (high) + __NR_Linux}
123#define NATIVE_SYSCALL_RANGES \
124 { SYSRANGE(0, 237), SYSRANGE(239, 328), SYSRANGE(424, 446), SYSRANGE(448, 466) }
125#if __MIPSEB__
126#define AUDIT_ARCH_NATIVE AUDIT_ARCH_MIPS64
127#elif __MIPSEL__
128#define AUDIT_ARCH_NATIVE AUDIT_ARCH_MIPSEL64
129#endif /* _MIPS_SIM_ABI64 */
130#elif __mips__ && _MIPS_SIM == _MIPS_SIM_NABI32
131/* n32 abi in both endianness cases */
132#include <asm/unistd.h>
133#define SYSRANGE(low, high) {(low) + __NR_Linux, (high) + __NR_Linux}
134#define NATIVE_SYSCALL_RANGES \
135 { SYSRANGE(0, 241), SYSRANGE(243, 332), SYSRANGE(403, 414), \
136 SYSRANGE(416, 446), SYSRANGE(448, 466) }
137#if __MIPSEB__
138#define AUDIT_ARCH_NATIVE AUDIT_ARCH_MIPS64N32
139#elif __MIPSEL__
140#define AUDIT_ARCH_NATIVE AUDIT_ARCH_MIPSEL64N32
141#endif /* _MIPS_SIM_NABI32 */
142#elif __hppa64__ /* hppa64 must be checked before hppa */
143#define NATIVE_SYSCALL_RANGES \
144 { {0, 101}, {103, 126}, {128, 129}, {131, 136}, {138, 166}, \
145 {168, 168}, {170, 195}, {198, 202}, {206, 212}, {215, 219}, \
146 {222, 262}, {264, 302}, {304, 356}, {424, 446}, {448, 466} }
147#define AUDIT_ARCH_NATIVE AUDIT_ARCH_PARISC64
148#elif __hppa__
149#define NATIVE_SYSCALL_RANGES \
150 { {0, 101}, {103, 126}, {128, 129}, {131, 136}, {138, 166}, \
151 {168, 168}, {170, 195}, {198, 202}, {206, 212}, {215, 219}, \
152 {222, 262}, {264, 302}, {304, 356}, {403, 414}, {416, 446}, {448, 466} }
153#define AUDIT_ARCH_NATIVE AUDIT_ARCH_PARISC
154#elif __PPC64__
155#define NATIVE_SYSCALL_RANGES \
156 { {0, 191}, {198, 203}, {205, 223}, {225, 225}, {227, 253}, \
157 {255, 256}, {258, 365}, {378, 388}, {392, 402}, {424, 446}, {448, 466} }
158#ifdef __BIG_ENDIAN__
159#define AUDIT_ARCH_NATIVE AUDIT_ARCH_PPC64
160#else
161#define AUDIT_ARCH_NATIVE AUDIT_ARCH_PPC64LE
162#endif
163#elif __PPC__
164#define NATIVE_SYSCALL_RANGES \
165 { {0, 223}, {225, 256}, {258, 365}, {378, 388}, {393, 414}, \
166 {416, 446}, {448, 466} }
167#define AUDIT_ARCH_NATIVE AUDIT_ARCH_PPC
168#elif __s390x__ /* s390x must be checked before s390 */
169#define NATIVE_SYSCALL_RANGES \
170 { {1, 12}, {14, 15}, {19, 22}, {26, 27}, {29, 30}, {33, 34}, \
171 {36, 43}, {45, 45}, {48, 48}, {51, 52}, {54, 55}, {57, 57}, \
172 {60, 67}, {72, 75}, {77, 79}, {83, 83}, {85, 94}, {96, 97}, \
173 {99, 100}, {102, 108}, {110, 112}, {114, 122}, {124, 137}, \
174 {141, 163}, {167, 169}, {172, 181}, {183, 191}, {198, 220}, \
175 {222, 222}, {224, 241}, {243, 262}, {265, 386}, {392, 402}, {424, 466} }
176#define AUDIT_ARCH_NATIVE AUDIT_ARCH_S390X
177#elif __s390__
178#define NATIVE_SYSCALL_RANGES \
179 { {1, 16}, {19, 27}, {29, 30}, {33, 34}, {36, 43}, {45, 52}, \
180 {54, 55}, {57, 57}, {60, 67}, {70, 81}, {83, 83}, {85, 97}, \
181 {99, 108}, {110, 112}, {114, 122}, {124, 165}, {167, 241}, \
182 {243, 262}, {264, 386}, {393, 414}, {416, 466} }
183#define AUDIT_ARCH_NATIVE AUDIT_ARCH_S390
184#elif __riscv && __riscv_xlen == 64
185#define NATIVE_SYSCALL_RANGES { {0, 37}, {39, 243}, {258, 294}, {424, 466} }
186#define AUDIT_ARCH_NATIVE AUDIT_ARCH_RISCV64
187#elif __riscv && __riscv_xlen == 32
188#define NATIVE_SYSCALL_RANGES \
189 { {0, 3}, {5, 37}, {39, 71}, {74, 78}, {81, 85}, {89, 97}, {99, 100}, \
190 {102, 107}, {109, 109}, {111, 111}, {116, 126}, {128, 136}, {138, 162}, \
191 {165, 168}, {172, 181}, {184, 191}, {193, 242}, {258, 259}, {261, 265}, \
192 {267, 291}, {293, 294}, {403, 414}, {416, 466} }
193#define AUDIT_ARCH_NATIVE AUDIT_ARCH_RISCV32
194#else
195#error cannot determine which AUDIT_ARCH_* value to use for AUDIT_ARCH_NATIVE
196#endif
197
198#else
199#ifndef NATIVE_SYSCALL_RANGES
200/* Fall back to default-allow if the user specified (with
201 -DAUDIT_ARCH_NATIVE=...) an arch but not NATIVE_SYSCALL_RANGES */
202#define NATIVE_SYSCALL_RANGES {}
203#endif
204#endif /* #ifndef AUDIT_ARCH_NATIVE */
205
206namespace nix {
207
208struct Uint32RangeAction {
209 uint32_t low; /* inclusive */
210 uint32_t high; /* inclusive */
211 std::vector<struct sock_filter> instructions;
212};
213
214std::vector<struct sock_filter> rangeActionsToFilter(std::vector<Uint32RangeAction> & ranges);
215
216
217std::vector<struct sock_filter>
218seccompMatchu64(std::vector<struct sock_filter> & out,
219 uint64_t value,
220 std::vector<struct sock_filter> instructions,
221 uint32_t offset);
222}
diff --git a/nix/libutil/spawn.cc b/nix/libutil/spawn.cc
index 93bab9f59e4..414849b6f04 100644
--- a/nix/libutil/spawn.cc
+++ b/nix/libutil/spawn.cc
@@ -51,6 +51,8 @@
51 51
52#ifdef __linux__ 52#ifdef __linux__
53#include <sys/personality.h> 53#include <sys/personality.h>
54#include <linux/seccomp.h>
55#include <linux/filter.h>
54#endif 56#endif
55 57
56#if defined(SYS_pivot_root) 58#if defined(SYS_pivot_root)
@@ -281,6 +283,36 @@ void setIDsAction(SpawnContext & ctx)
281 throw SysError("setuid failed"); 283 throw SysError("setuid failed");
282} 284}
283 285
286void setNoNewPrivsAction(SpawnContext & ctx)
287{
288 if(ctx.setNoNewPrivs)
289#if __linux__ && defined(PR_SET_NO_NEW_PRIVS)
290 if(prctl(PR_SET_NO_NEW_PRIVS, 0, 0, 0, 0) == -1)
291 throw SysError("setting PR_SET_NO_NEW_PRIVS");
292#else
293 throw Error("setting PR_SET_NO_NEW_PRIVS not supported on this system");
294#endif
295}
296
297void addSeccompFilterAction(SpawnContext & ctx)
298{
299 if(ctx.addSeccompFilter) {
300#if __linux__ && defined(PR_SET_SECCOMP) && defined(SECCOMP_MODE_FILTER)
301 /* We use no extra functionality from the seccomp system call, so
302 * just use prctl. */
303 if(ctx.seccompFilter.size() > USHRT_MAX)
304 throw Error("seccomp filter too large");
305 struct sock_fprog prog;
306 prog.len = (unsigned short) ctx.seccompFilter.size();
307 prog.filter = ctx.seccompFilter.data();
308 if(prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog) == -1)
309 throw SysError("installing seccomp filter");
310#else
311 throw Error("setting seccomp filter not supported on this system");
312#endif
313 }
314}
315
284 316
285void restoreSIGPIPEAction(SpawnContext & ctx) 317void restoreSIGPIPEAction(SpawnContext & ctx)
286{ 318{
@@ -336,6 +368,8 @@ Phases getBasicSpawnPhases()
336 { "setPersonality", setPersonalityAction }, 368 { "setPersonality", setPersonalityAction },
337 { "oomSacrifice", oomSacrificeAction }, 369 { "oomSacrifice", oomSacrificeAction },
338 { "setIDs", setIDsAction }, 370 { "setIDs", setIDsAction },
371 { "setNoNewPrivs", setNoNewPrivsAction },
372 { "addSeccompFilter", addSeccompFilterAction },
339 { "restoreSIGPIPE", restoreSIGPIPEAction }, 373 { "restoreSIGPIPE", restoreSIGPIPEAction },
340 { "setupSuccess", setupSuccessAction }, 374 { "setupSuccess", setupSuccessAction },
341 { "exec", execAction } }; 375 { "exec", execAction } };
@@ -773,6 +807,8 @@ Phases getCloneSpawnPhases()
773 CloneSpawnContext.lockMountsMapAll = true. */ 807 CloneSpawnContext.lockMountsMapAll = true. */
774 { "lockMounts", lockMountsAction }, 808 { "lockMounts", lockMountsAction },
775 { "setIDs", setIDsAction }, 809 { "setIDs", setIDsAction },
810 { "setNoNewPrivs", setNoNewPrivsAction },
811 { "addSeccompFilter", addSeccompFilterAction },
776 { "restoreSIGPIPE", restoreSIGPIPEAction }, 812 { "restoreSIGPIPE", restoreSIGPIPEAction },
777 { "setupSuccess", setupSuccessAction }, 813 { "setupSuccess", setupSuccessAction },
778 { "exec", execAction }}; 814 { "exec", execAction }};
diff --git a/nix/libutil/spawn.hh b/nix/libutil/spawn.hh
index edc528312db..5e75bcfb097 100644
--- a/nix/libutil/spawn.hh
+++ b/nix/libutil/spawn.hh
@@ -3,6 +3,9 @@
3#include <util.hh> 3#include <util.hh>
4#include <map> 4#include <map>
5#include <stddef.h> 5#include <stddef.h>
6#ifdef __linux__
7#include <linux/filter.h>
8#endif
6 9
7namespace nix { 10namespace nix {
8struct SpawnContext; /* Forward declaration */ 11struct SpawnContext; /* Forward declaration */
@@ -57,6 +60,11 @@ struct SpawnContext {
57 bool dropAmbientCapabilities = false; /* Whether to drop ambient 60 bool dropAmbientCapabilities = false; /* Whether to drop ambient
58 * capabilities if on a system that 61 * capabilities if on a system that
59 * supports them. */ 62 * supports them. */
63 bool setNoNewPrivs = false;
64 bool addSeccompFilter = false;
65#if __linux__
66 std::vector<struct sock_filter> seccompFilter;
67#endif
60 bool doChroot = false; 68 bool doChroot = false;
61 Path chrootRootDir; 69 Path chrootRootDir;
62 void * extraData; /* Extra user data */ 70 void * extraData; /* Extra user data */
@@ -118,6 +126,8 @@ Action closeMostFDsAction;
118Action setPersonalityAction; 126Action setPersonalityAction;
119Action oomSacrificeAction; 127Action oomSacrificeAction;
120Action setIDsAction; 128Action setIDsAction;
129Action setNoNewPrivsAction;
130Action addSeccompFilterAction;
121Action restoreSIGPIPEAction; 131Action restoreSIGPIPEAction;
122Action setupSuccessAction; 132Action setupSuccessAction;
123Action execAction; 133Action execAction;
diff --git a/nix/local.mk b/nix/local.mk
index 9f21550af2d..7c1b81e9a65 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -57,7 +57,8 @@ libutil_a_SOURCES = \
57 %D%/libutil/serialise.cc \ 57 %D%/libutil/serialise.cc \
58 %D%/libutil/util.cc \ 58 %D%/libutil/util.cc \
59 %D%/libutil/hash.cc \ 59 %D%/libutil/hash.cc \
60 %D%/libutil/spawn.cc 60 %D%/libutil/spawn.cc \
61 %D%/libutil/seccomp.cc
61 62
62libutil_headers = \ 63libutil_headers = \
63 %D%/libutil/affinity.hh \ 64 %D%/libutil/affinity.hh \
@@ -66,7 +67,8 @@ libutil_headers = \
66 %D%/libutil/util.hh \ 67 %D%/libutil/util.hh \
67 %D%/libutil/archive.hh \ 68 %D%/libutil/archive.hh \
68 %D%/libutil/types.hh \ 69 %D%/libutil/types.hh \
69 %D%/libutil/spawn.hh 70 %D%/libutil/spawn.hh \
71 %D%/libutil/seccomp.hh
70 72
71libutil_a_CPPFLAGS = \ 73libutil_a_CPPFLAGS = \
72 -I$(top_builddir)/nix \ 74 -I$(top_builddir)/nix \