diff options
| author | Ludovic Courtès <ludo@gnu.org> | 2025-12-19 09:34:47 +0100 |
|---|---|---|
| committer | Ludovic Courtès <ludo@gnu.org> | 2025-12-22 15:10:52 +0100 |
| commit | 0ac2a0fd1813fb5c04b22f6443d8f8a96d3c9645 (patch) | |
| tree | 045d39546054363d7376f4d44151cce005a35fd8 /tests | |
| parent | 5d6dfd8981ac9ab65012de0e9a9ed26301e5b8fd (diff) | |
authenticate: Report failure to load keys to the daemon.
Previously, when failing to load a signing key, ‘guix authenticate’ would
print a backtrace and exit with a non-zero code. That, in turn, would lead
the guix-daemon child process to crash with:
nix/libutil/serialise.cc:15: virtual nix::BufferedSink::~BufferedSink(): Assertion `!bufPos' failed.
This patch fixes it by reporting the error to the daemon as was intended.
* guix/scripts/authenticate.scm (guix-authenticate): Arrange to call
‘load-key-pair’ from within ‘with-reply’.
* tests/guix-authenticate.sh: Test it.
Fixes: guix/guix#4928
Reported-by: Rutherther <rutherther@ditigal.xyz>
Change-Id: I8654ad6fdfbe18c55e1e85647d0c49f408d0574a
Signed-off-by: Ludovic Courtès <ludo@gnu.org>
Merges: #4961
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/guix-authenticate.sh | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/tests/guix-authenticate.sh b/tests/guix-authenticate.sh index 0de6da18784..ddd39d09c44 100644 --- a/tests/guix-authenticate.sh +++ b/tests/guix-authenticate.sh | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | # GNU Guix --- Functional package management for GNU | 1 | # GNU Guix --- Functional package management for GNU |
| 2 | # Copyright © 2013, 2014, 2020 Ludovic Courtès <ludo@gnu.org> | 2 | # Copyright © 2013, 2014, 2020, 2025 Ludovic Courtès <ludo@gnu.org> |
| 3 | # | 3 | # |
| 4 | # This file is part of GNU Guix. | 4 | # This file is part of GNU Guix. |
| 5 | # | 5 | # |
| @@ -85,3 +85,8 @@ sed -i "$sig" -e's/^0 //g' | |||
| 85 | echo "verify $(cat $sig)" | guix authenticate | 85 | echo "verify $(cat $sig)" | guix authenticate |
| 86 | hash2="$(echo "verify $(cat $sig)" | guix authenticate | cut -f2 -d ' ')" | 86 | hash2="$(echo "verify $(cat $sig)" | guix authenticate | cut -f2 -d ' ')" |
| 87 | test "$(echo $hash2 | cut -d : -f 2)" = "$hash" | 87 | test "$(echo $hash2 | cut -d : -f 2)" = "$hash" |
| 88 | |||
| 89 | # Make sure an error is properly reported for unreadable key pairs, with exit | ||
| 90 | # code zero (the process would keep running commands on standard input). | ||
| 91 | echo "sign 9:/dev/null $hash_len:$hash" | guix authenticate | ||
| 92 | test $(echo "sign 9:/dev/null $hash_len:$hash" | guix authenticate | cut -f1 -d ' ') = 500 | ||