gnu: heroic-client: Fix .desktop file.

* nongnu/packages/game-client.scm (heroic-client)[arguments]<#:phases>: Add
fix-desktop-file phase to set the "Exec" line to "heroic" to run the correct
binary.  Remove setting the full store path in the .desktop file in the
setup-cwd phase.  Delete the patch-dot-desktop-files phase (not needed).

1 files changed, 10 insertions, 5 deletions

diff --git a/nongnu/packages/game-client.scm b/nongnu/packages/game-client.scm
index f7cb4c1..b434285 100644
--- a/nongnu/packages/game-client.scm
+++ b/nongnu/packages/game-client.scm
@@ -81,11 +81,16 @@
                    ;; Use the more standard lib directory for everything.
                    (rename-file "opt/" "lib")
                    ;; Remove unneeded files.
-                   (delete-file-recursively "usr")
-                   ;; Fix the .desktop file binary location.
-                   (substitute* '("share/applications/heroic.desktop")
-                     (("/opt/Heroic/")
-                      (string-append #$output "/bin/")))))
+                   (delete-file-recursively "usr")))
+               ;; Fix the .desktop file "Exec" line to just be "heroic" in
+               ;; order for this desktop file to be useful to launch heroic in
+               ;; the container (heroic package) as well.
+               (add-after 'patch-dot-desktop-files 'fix-desktop-file
+                 (lambda _
+                   (substitute*
+                       (string-append #$output "/share/applications/heroic.desktop")
+                     (("Exec=.*/heroic") "Exec=heroic"))))
+               (delete 'patch-dot-desktop-files)
                (add-after 'install 'symlink-binary-file
                  (lambda _
                    (mkdir-p (string-append #$output "/bin"))