attempt to make the plugin more async-y

1 files changed, 54 insertions, 22 deletions

diff --git a/elfeed-custom-feeds-github.el b/elfeed-custom-feeds-github.el
index 660350d..a857963 100644
--- a/elfeed-custom-feeds-github.el
+++ b/elfeed-custom-feeds-github.el
@@ -57,15 +57,15 @@
                                        (funcall cb r dn items))))
                                  nil t)))))
 
-(defun elfeed-custom-feeds-github--prs-to-elfeed (repo display-name prs)
-  "Convert GitHub PRS to elfeed entries for REPO with DISPLAY-NAME."
+(defun elfeed-custom-feeds-github--prs-to-elfeed (repo display-name prs completion-callback)
+  "Convert GitHub PRS to elfeed entries for REPO with DISPLAY-NAME.
+Call COMPLETION-CALLBACK with (repo display-name new-entries) when done."
   (let ((feed-url (format "https://github.com/%s/pulls" repo))
-        (new-count 0)
         (new-entries ()))
     (let ((feed (elfeed-db-get-feed feed-url)))
       (setf (elfeed-feed-url feed) feed-url
             (elfeed-feed-title feed) (format "GitHub: %s [%s]" repo display-name)))
-    
+
     (dolist (pr prs)
       (let* ((number (alist-get 'number pr))
              (title-text (alist-get 'title pr))
@@ -86,7 +86,7 @@
                                   (format "<p><strong>Labels:</strong> %s</p>"
                                           (mapconcat 'identity labels ", "))
                                 "")
-                              (replace-regexp-in-string "<" "&lt;" 
+                              (replace-regexp-in-string "<" "&lt;"
                                                         (replace-regexp-in-string ">" "&gt;" body)))))
         (unless (elfeed-db-get-entry entry-id)
           (let ((entry (elfeed-entry--create
@@ -98,27 +98,59 @@
                         :content-type 'html
                         :feed-id feed-url
                         :tags '(unread github))))
-            (push entry new-entries)
-            (setq new-count (1+ new-count))))))
-    
-    (when new-entries
-      (elfeed-db-add (nreverse new-entries)))
-    
-    (message "GitHub feed %s [%s]: %d new entries" repo display-name new-count)
-    (when (get-buffer "*elfeed-search*")
-      (with-current-buffer "*elfeed-search*"
-        (elfeed-search-update--force)))))
+            (push entry new-entries)))))
+
+    ;; Call completion callback with results
+    (funcall completion-callback repo display-name (nreverse new-entries))))
 
 ;;;###autoload
 (defun elfeed-custom-feeds-github-update ()
-  "Update all GitHub PR feeds."
+  "Update all GitHub PR feeds asynchronously.
+Batches all entries and updates UI once at the end to avoid blocking."
   (interactive)
-  (cl-loop for (repo query display-name) in elfeed-custom-github-pr-queries
-           for i from 0
-           for delay = (* i elfeed-custom-github-request-delay)
-           do (elfeed-custom-feeds-github--fetch-prs repo query display-name
-                                                     #'elfeed-custom-feeds-github--prs-to-elfeed 
-                                                     delay)))
+  (let* ((total (length elfeed-custom-github-pr-queries))
+         (processed 0)
+         (all-new-entries '())
+         (results '()))
+
+    (when (zerop total)
+      (message "No GitHub PR queries configured")
+      (cl-return-from elfeed-custom-feeds-github-update nil))
+
+    ;; Completion callback that batches everything
+    (let ((completion-callback
+           (lambda (repo display-name new-entries)
+             (setq processed (1+ processed))
+             (when new-entries
+               (setq all-new-entries (append all-new-entries new-entries)))
+             (push (list repo display-name (length new-entries)) results)
+
+             ;; When all queries are done, batch add to DB and update UI once
+             (when (= processed total)
+               (let ((total-count (length all-new-entries)))
+                 (when (> total-count 0)
+                   (elfeed-db-add all-new-entries))
+                 ;; Report results for each feed
+                 (dolist (result (nreverse results))
+                   (message "GitHub feed %s [%s]: %d new entries"
+                            (nth 0 result) (nth 1 result) (nth 2 result)))
+                 ;; Defer UI update to avoid blocking
+                 (run-with-idle-timer 0.1 nil
+                                      (lambda ()
+                                        (when (get-buffer "*elfeed-search*")
+                                          (with-current-buffer "*elfeed-search*"
+                                            (elfeed-search-update--force))))))))))
+
+      ;; Start all async fetches
+      (cl-loop for (repo query display-name) in elfeed-custom-github-pr-queries
+               for i from 0
+               for delay = (* i elfeed-custom-github-request-delay)
+               do (elfeed-custom-feeds-github--fetch-prs
+                   repo query display-name
+                   (lambda (r dn items)
+                     (elfeed-custom-feeds-github--prs-to-elfeed r dn items completion-callback))
+                   delay)))
+    nil))
 
 (provide 'elfeed-custom-feeds-github)