tests: git: Avoid nested checks for submodules.

Follow up of 8d27b1158de3cc1823d33847cb722722c769a27e discussed in #9231.

* tests/git.scm ("update-cached-checkout, recursive submodules follow ref"):
Replace the nested 'let' by 'let*'.

Merges: #9683
Change-Id: Ibd212bbd2b6fbf02f6fcae0ecb21922686b5f8bc

1 files changed, 15 insertions, 15 deletions

diff --git a/tests/git.scm b/tests/git.scm
index 35ddc884941..12f17d4a7b9 100644
--- a/tests/git.scm
+++ b/tests/git.scm
@@ -296,24 +296,24 @@
                (submodule-checkout "modules/sub" ,sub-v2)
                (commit "release uses submodule v2")
                (checkout "primary"))
-           (let ((checkout1 commit1 relation1
+           (let* ((checkout1 commit1 relation1
                              (update-cached-checkout main
                                                      #:recursive? #t
-                                                     #:cache-directory cache)))
+                                                     #:cache-directory cache))
+                  (head-cached1 (git-output "-C"
+                                            (in-vicinity checkout1 "modules/sub")
+                                            "rev-parse" "HEAD"))
+                  (checkout2 commit2 relation2
+                             (update-cached-checkout main
+                                                     #:recursive? #t
+                                                     #:ref '(branch . "release")
+                                                     #:cache-directory cache))
+                  (head-cached2 (git-output "-C"
+                                            (in-vicinity checkout2 "modules/sub")
+                                            "rev-parse" "HEAD")))
              (and
-              (string=? sub-v1
-                        (git-output "-C"
-                                    (in-vicinity checkout1 "modules/sub")
-                                    "rev-parse" "HEAD"))
-              (let ((checkout2 commit2 relation2
-                                (update-cached-checkout main
-                                                        #:recursive? #t
-                                                        #:ref '(branch . "release")
-                                                        #:cache-directory cache)))
-                (string=? sub-v2
-                          (git-output "-C"
-                                      (in-vicinity checkout2 "modules/sub")
-                                      "rev-parse" "HEAD")))))))))))
+              (string=? sub-v1 head-cached1)
+              (string=? sub-v2 head-cached2)))))))))
 
 (test-assert "update-cached-checkout, untracked files removed"
   (call-with-temporary-directory