diff options
| author | Andy Wingo <wingo@igalia.com> | 2017-08-23 21:26:05 +0200 |
|---|---|---|
| committer | Andy Wingo <wingo@igalia.com> | 2017-08-23 22:23:06 +0200 |
| commit | ba015ce9c04e2cd8e686add647109b514c3fa244 (patch) | |
| tree | 36194cb52ef83eeb6da6f0b2c05536e9e013c7a3 | |
| parent | f81039058cb2c7b0b4986109fca584a87112a9b9 (diff) | |
gnu: scripts: Cleanup regarding "gnu system" bootloader devices.
* guix/scripts/system.scm (install-bootloader, install): Remove unused
"device" argument.
(reinstall-bootloader, perform-action): Adapt callers.
| -rw-r--r-- | guix/scripts/system.scm | 19 |
1 files changed, 7 insertions, 12 deletions
diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 5a2811e75b2..44d2c8f20c3 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm | |||
| @@ -150,7 +150,7 @@ TARGET, and register them." | |||
| 150 | (define* (install-bootloader installer-drv | 150 | (define* (install-bootloader installer-drv |
| 151 | #:key | 151 | #:key |
| 152 | bootcfg bootcfg-file | 152 | bootcfg bootcfg-file |
| 153 | device target) | 153 | target) |
| 154 | "Call INSTALLER-DRV with error handling, in %STORE-MONAD." | 154 | "Call INSTALLER-DRV with error handling, in %STORE-MONAD." |
| 155 | (with-monad %store-monad | 155 | (with-monad %store-monad |
| 156 | (let* ((gc-root (string-append target %gc-roots-directory | 156 | (let* ((gc-root (string-append target %gc-roots-directory |
| @@ -169,7 +169,7 @@ TARGET, and register them." | |||
| 169 | (when install | 169 | (when install |
| 170 | (save-load-path-excursion (primitive-load install))))) | 170 | (save-load-path-excursion (primitive-load install))))) |
| 171 | (delete-file temp-gc-root) | 171 | (delete-file temp-gc-root) |
| 172 | (leave (G_ "failed to install bootloader on device ~a '~a'~%") install device)) | 172 | (leave (G_ "failed to install bootloader ~a~%") install)) |
| 173 | 173 | ||
| 174 | ;; Register bootloader config file as a GC root so that its dependencies | 174 | ;; Register bootloader config file as a GC root so that its dependencies |
| 175 | ;; (background image, font, etc.) are not reclaimed. | 175 | ;; (background image, font, etc.) are not reclaimed. |
| @@ -179,13 +179,12 @@ TARGET, and register them." | |||
| 179 | (define* (install os-drv target | 179 | (define* (install os-drv target |
| 180 | #:key (log-port (current-output-port)) | 180 | #:key (log-port (current-output-port)) |
| 181 | bootloader-installer install-bootloader? | 181 | bootloader-installer install-bootloader? |
| 182 | bootcfg bootcfg-file | 182 | bootcfg bootcfg-file) |
| 183 | device) | ||
| 184 | "Copy the closure of BOOTCFG, which includes the output of OS-DRV, to | 183 | "Copy the closure of BOOTCFG, which includes the output of OS-DRV, to |
| 185 | directory TARGET. TARGET must be an absolute directory name since that's what | 184 | directory TARGET. TARGET must be an absolute directory name since that's what |
| 186 | 'guix-register' expects. | 185 | 'guix-register' expects. |
| 187 | 186 | ||
| 188 | When INSTALL-BOOTLOADER? is true, install bootloader on DEVICE, using BOOTCFG." | 187 | When INSTALL-BOOTLOADER? is true, install bootloader using BOOTCFG." |
| 189 | (define (maybe-copy to-copy) | 188 | (define (maybe-copy to-copy) |
| 190 | (with-monad %store-monad | 189 | (with-monad %store-monad |
| 191 | (if (string=? target "/") | 190 | (if (string=? target "/") |
| @@ -227,7 +226,6 @@ the ownership of '~a' may be incorrect!~%") | |||
| 227 | (install-bootloader bootloader-installer | 226 | (install-bootloader bootloader-installer |
| 228 | #:bootcfg bootcfg | 227 | #:bootcfg bootcfg |
| 229 | #:bootcfg-file bootcfg-file | 228 | #:bootcfg-file bootcfg-file |
| 230 | #:device device | ||
| 231 | #:target target))))) | 229 | #:target target))))) |
| 232 | 230 | ||
| 233 | 231 | ||
| @@ -457,12 +455,11 @@ STORE is an open connection to the store." | |||
| 457 | (mbegin %store-monad | 455 | (mbegin %store-monad |
| 458 | (show-what-to-build* drvs) | 456 | (show-what-to-build* drvs) |
| 459 | (built-derivations drvs) | 457 | (built-derivations drvs) |
| 460 | ;; Only install bootloader configuration file. Thus, no installer | 458 | ;; Only install bootloader configuration file. Thus, no installer is |
| 461 | ;; nor device is provided here. | 459 | ;; provided here. |
| 462 | (install-bootloader #f | 460 | (install-bootloader #f |
| 463 | #:bootcfg bootcfg | 461 | #:bootcfg bootcfg |
| 464 | #:bootcfg-file bootcfg-file | 462 | #:bootcfg-file bootcfg-file |
| 465 | #:device #f | ||
| 466 | #:target target)))))) | 463 | #:target target)))))) |
| 467 | 464 | ||
| 468 | 465 | ||
| @@ -697,7 +694,6 @@ output when building a system derivation, such as a disk image." | |||
| 697 | (install-bootloader bootloader-installer | 694 | (install-bootloader bootloader-installer |
| 698 | #:bootcfg bootcfg | 695 | #:bootcfg bootcfg |
| 699 | #:bootcfg-file bootcfg-file | 696 | #:bootcfg-file bootcfg-file |
| 700 | #:device device | ||
| 701 | #:target "/")))) | 697 | #:target "/")))) |
| 702 | ((init) | 698 | ((init) |
| 703 | (newline) | 699 | (newline) |
| @@ -707,8 +703,7 @@ output when building a system derivation, such as a disk image." | |||
| 707 | #:install-bootloader? install-bootloader? | 703 | #:install-bootloader? install-bootloader? |
| 708 | #:bootcfg bootcfg | 704 | #:bootcfg bootcfg |
| 709 | #:bootcfg-file bootcfg-file | 705 | #:bootcfg-file bootcfg-file |
| 710 | #:bootloader-installer bootloader-installer | 706 | #:bootloader-installer bootloader-installer)) |
| 711 | #:device device)) | ||
| 712 | (else | 707 | (else |
| 713 | ;; All we had to do was to build SYS and maybe register an | 708 | ;; All we had to do was to build SYS and maybe register an |
| 714 | ;; indirect GC root. | 709 | ;; indirect GC root. |
