diff options
| author | Efraim Flashner <efraim@flashner.co.il> | 2025-06-29 10:21:12 +0300 |
|---|---|---|
| committer | Efraim Flashner <efraim@flashner.co.il> | 2025-07-28 13:57:53 +0300 |
| commit | cc588d8eb6a5e05bc8c9d41855685a1d8ce70187 (patch) | |
| tree | 8f1091354927a109b82ba558dd7637061479b787 /nix | |
| parent | cf6868187a68feea41b3cde9bd37670df7192fed (diff) | |
guix gc: Adjust size suffix based on the amount of data.
* guix/ui.scm (number->size): New procedure.
* guix/scripts/gc.scm (guix-gc)[actions]: Display the amount of
collected-garbage using more specific units.
[ensure-free-space]: Display the size using an appropriate size unit.
* nix/libstore/gc.cc (deletePathRecursive, removeUnusedLinks): Same.
* nix/libstore/optimise-store.cc (showBytes): Move function ...
* nix/libstore/misc.cc: ... to here. Expand to adjust the output based
on the amount of bytes received.
Change-Id: Idceb1a13f8e45f959d327f53d1a8accb29d2678b
Diffstat (limited to 'nix')
| -rw-r--r-- | nix/libstore/gc.cc | 7 | ||||
| -rw-r--r-- | nix/libstore/misc.cc | 21 | ||||
| -rw-r--r-- | nix/libstore/misc.hh | 1 | ||||
| -rw-r--r-- | nix/libstore/optimise-store.cc | 6 |
4 files changed, 26 insertions, 9 deletions
diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc index 1766a684122..08638b51153 100644 --- a/nix/libstore/gc.cc +++ b/nix/libstore/gc.cc | |||
| @@ -433,8 +433,7 @@ void LocalStore::deletePathRecursive(GCState & state, const Path & path) | |||
| 433 | printMsg(lvlInfo, format("[%1%%%] deleting '%2%'") % percentage % path); | 433 | printMsg(lvlInfo, format("[%1%%%] deleting '%2%'") % percentage % path); |
| 434 | } else { | 434 | } else { |
| 435 | auto freed = state.results.bytesFreed + state.bytesInvalidated; | 435 | auto freed = state.results.bytesFreed + state.bytesInvalidated; |
| 436 | freed /= 1024ULL * 1024ULL; | 436 | printMsg(lvlInfo, format("[%1%] deleting '%2%'") % showBytes(freed) % path); |
| 437 | printMsg(lvlInfo, format("[%1% MiB] deleting '%2%'") % freed % path); | ||
| 438 | } | 437 | } |
| 439 | 438 | ||
| 440 | state.results.paths.insert(path); | 439 | state.results.paths.insert(path); |
| @@ -629,9 +628,9 @@ void LocalStore::removeUnusedLinks(const GCState & state) | |||
| 629 | if (stat(linksDir.c_str(), &st) == -1) | 628 | if (stat(linksDir.c_str(), &st) == -1) |
| 630 | throw SysError(format("statting `%1%'") % linksDir); | 629 | throw SysError(format("statting `%1%'") % linksDir); |
| 631 | long long overhead = st.st_size; | 630 | long long overhead = st.st_size; |
| 631 | long long freedbytes = (unsharedSize - actualSize - overhead); | ||
| 632 | 632 | ||
| 633 | printMsg(lvlInfo, format("note: currently hard linking saves %.2f MiB") | 633 | printMsg(lvlInfo, format("note: currently hard linking saves %1%") % showBytes(freedbytes)); |
| 634 | % ((unsharedSize - actualSize - overhead) / (1024.0 * 1024.0))); | ||
| 635 | } | 634 | } |
| 636 | 635 | ||
| 637 | 636 | ||
diff --git a/nix/libstore/misc.cc b/nix/libstore/misc.cc index bc5dec88bf2..e9904f3c4f4 100644 --- a/nix/libstore/misc.cc +++ b/nix/libstore/misc.cc | |||
| @@ -1,4 +1,5 @@ | |||
| 1 | #include "misc.hh" | 1 | #include "misc.hh" |
| 2 | #include <math.h> | ||
| 2 | #include "store-api.hh" | 3 | #include "store-api.hh" |
| 3 | #include "local-store.hh" | 4 | #include "local-store.hh" |
| 4 | #include "globals.hh" | 5 | #include "globals.hh" |
| @@ -94,5 +95,25 @@ Paths topoSortPaths(StoreAPI & store, const PathSet & paths) | |||
| 94 | return sorted; | 95 | return sorted; |
| 95 | } | 96 | } |
| 96 | 97 | ||
| 98 | /* Max of LLONG_MAX is 8 EiB */ | ||
| 99 | string showBytes(long long bytes) | ||
| 100 | { | ||
| 101 | if (llabs(bytes > exp2l(60))) { | ||
| 102 | return (format("%7.2f EiB") % (bytes / exp2l(60))).str(); | ||
| 103 | } else if (llabs(bytes > exp2l(50))) { | ||
| 104 | return (format("%7.2f PiB") % (bytes / exp2l(50))).str(); | ||
| 105 | } else if (llabs(bytes > exp2l(40))) { | ||
| 106 | return (format("%7.2f TiB") % (bytes / exp2l(40))).str(); | ||
| 107 | } else if (llabs(bytes > exp2l(30))) { | ||
| 108 | return (format("%7.2f GiB") % (bytes / exp2l(30))).str(); | ||
| 109 | } else if (llabs(bytes > exp2l(20))) { | ||
| 110 | return (format("%7.2f MiB") % (bytes / exp2l(20))).str(); | ||
| 111 | } else if (llabs(bytes > exp2l(10))) { | ||
| 112 | return (format("%7.2f KiB") % (bytes / exp2l(10))).str(); | ||
| 113 | } else { | ||
| 114 | return (format("%4f bytes") % bytes).str(); | ||
| 115 | } | ||
| 116 | } | ||
| 117 | |||
| 97 | 118 | ||
| 98 | } | 119 | } |
diff --git a/nix/libstore/misc.hh b/nix/libstore/misc.hh index f70cda9fd0c..1d36ccf9dce 100644 --- a/nix/libstore/misc.hh +++ b/nix/libstore/misc.hh | |||
| @@ -25,5 +25,6 @@ bool willBuildLocally(const Derivation & drv); | |||
| 25 | 25 | ||
| 26 | bool substitutesAllowed(const Derivation & drv); | 26 | bool substitutesAllowed(const Derivation & drv); |
| 27 | 27 | ||
| 28 | string showBytes(long long bytes); | ||
| 28 | 29 | ||
| 29 | } | 30 | } |
diff --git a/nix/libstore/optimise-store.cc b/nix/libstore/optimise-store.cc index 8d5bf28da9d..e17d9160d6c 100644 --- a/nix/libstore/optimise-store.cc +++ b/nix/libstore/optimise-store.cc | |||
| @@ -1,5 +1,6 @@ | |||
| 1 | #include "config.h" | 1 | #include "config.h" |
| 2 | 2 | ||
| 3 | #include "misc.hh" | ||
| 3 | #include "util.hh" | 4 | #include "util.hh" |
| 4 | #include "local-store.hh" | 5 | #include "local-store.hh" |
| 5 | #include "globals.hh" | 6 | #include "globals.hh" |
| @@ -252,11 +253,6 @@ void LocalStore::optimiseStore(OptimiseStats & stats) | |||
| 252 | } | 253 | } |
| 253 | } | 254 | } |
| 254 | 255 | ||
| 255 | static string showBytes(unsigned long long bytes) | ||
| 256 | { | ||
| 257 | return (format("%.2f MiB") % (bytes / (1024.0 * 1024.0))).str(); | ||
| 258 | } | ||
| 259 | |||
| 260 | void LocalStore::optimiseStore() | 256 | void LocalStore::optimiseStore() |
| 261 | { | 257 | { |
| 262 | OptimiseStats stats; | 258 | OptimiseStats stats; |
