diff options
| author | Shokara Kou <kou@13f0.net> | 2022-06-08 08:42:07 -0400 |
|---|---|---|
| committer | Shokara Kou <kou@13f0.net> | 2022-06-08 08:42:07 -0400 |
| commit | 8fe8e03bb8c52fac64b52839d7af4f47b718f405 (patch) | |
| tree | 87e8b4f26377ba6acbbdaa4c66e3491c5425f22d /www/chromium-uc/patches/core/ungoogled-chromium/remove-unused-preferences-fields.patch | |
| parent | 2be1931967e4073a55d7ac3e3ecdff7c825a63f4 (diff) | |
Revert "update ugc to 102.0.5005.61-3"
This reverts commit 2be1931967e4073a55d7ac3e3ecdff7c825a63f4.
Diffstat (limited to 'www/chromium-uc/patches/core/ungoogled-chromium/remove-unused-preferences-fields.patch')
| -rw-r--r-- | www/chromium-uc/patches/core/ungoogled-chromium/remove-unused-preferences-fields.patch | 2243 |
1 files changed, 1044 insertions, 1199 deletions
diff --git a/www/chromium-uc/patches/core/ungoogled-chromium/remove-unused-preferences-fields.patch b/www/chromium-uc/patches/core/ungoogled-chromium/remove-unused-preferences-fields.patch index d6d7e41..0527dde 100644 --- a/www/chromium-uc/patches/core/ungoogled-chromium/remove-unused-preferences-fields.patch +++ b/www/chromium-uc/patches/core/ungoogled-chromium/remove-unused-preferences-fields.patch | |||
| @@ -2,17 +2,17 @@ | |||
| 2 | # TODO: This patch should probably be split up and merged into | 2 | # TODO: This patch should probably be split up and merged into |
| 3 | # disable-signin.patch and fix-building-without-safebrowsing.patch | 3 | # disable-signin.patch and fix-building-without-safebrowsing.patch |
| 4 | 4 | ||
| 5 | --- a/android_webview/browser/aw_browser_context.cc | 5 | --- android_webview/browser/aw_browser_context.cc.orig |
| 6 | +++ b/android_webview/browser/aw_browser_context.cc | 6 | +++ android_webview/browser/aw_browser_context.cc |
| 7 | @@ -48,7 +48,6 @@ | 7 | @@ -49,7 +49,6 @@ |
| 8 | #include "components/prefs/pref_service_factory.h" | 8 | #include "components/prefs/pref_service_factory.h" |
| 9 | #include "components/prefs/segregated_pref_store.h" | 9 | #include "components/prefs/segregated_pref_store.h" |
| 10 | #include "components/profile_metrics/browser_profile_type.h" | 10 | #include "components/profile_metrics/browser_profile_type.h" |
| 11 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 11 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 12 | #include "components/url_formatter/url_fixer.h" | 12 | #include "components/url_formatter/url_fixer.h" |
| 13 | #include "components/user_prefs/user_prefs.h" | 13 | #include "components/user_prefs/user_prefs.h" |
| 14 | #include "components/variations/variations_client.h" | 14 | #include "components/visitedlink/browser/visitedlink_writer.h" |
| 15 | @@ -519,8 +518,6 @@ void AwBrowserContext::RebuildTable( | 15 | @@ -470,8 +469,6 @@ void AwBrowserContext::RebuildTable( |
| 16 | } | 16 | } |
| 17 | 17 | ||
| 18 | void AwBrowserContext::SetExtendedReportingAllowed(bool allowed) { | 18 | void AwBrowserContext::SetExtendedReportingAllowed(bool allowed) { |
| @@ -21,9 +21,9 @@ | |||
| 21 | } | 21 | } |
| 22 | 22 | ||
| 23 | // TODO(amalova): Make sure NetworkContextParams is configured correctly when | 23 | // TODO(amalova): Make sure NetworkContextParams is configured correctly when |
| 24 | --- a/chrome/app/settings_strings.grdp | 24 | --- chrome/app/settings_strings.grdp.orig |
| 25 | +++ b/chrome/app/settings_strings.grdp | 25 | +++ chrome/app/settings_strings.grdp |
| 26 | @@ -1842,69 +1842,9 @@ | 26 | @@ -1591,78 +1591,9 @@ |
| 27 | <message name="IDS_SETTINGS_NETWORK_PREDICTION_ENABLED_DESC_COOKIES_PAGE" desc="On the cookies page, the secondary text next to the checkbox that enables prediction of network actions."> | 27 | <message name="IDS_SETTINGS_NETWORK_PREDICTION_ENABLED_DESC_COOKIES_PAGE" desc="On the cookies page, the secondary text next to the checkbox that enables prediction of network actions."> |
| 28 | Preloads pages that Chrome thinks you might visit. To do this, Chrome may use cookies, if you allow cookies, and may encrypt and send pages through Google to hide your identity from sites. | 28 | Preloads pages that Chrome thinks you might visit. To do this, Chrome may use cookies, if you allow cookies, and may encrypt and send pages through Google to hide your identity from sites. |
| 29 | </message> | 29 | </message> |
| @@ -33,6 +33,9 @@ | |||
| 33 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENABLEPROTECTION_DESC" desc="Checkbox label: should Chrome protect user and user's device from dangerous sites"> | 33 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENABLEPROTECTION_DESC" desc="Checkbox label: should Chrome protect user and user's device from dangerous sites"> |
| 34 | - Sends URLs of some pages you visit to Google, when your security is at risk | 34 | - Sends URLs of some pages you visit to Google, when your security is at risk |
| 35 | - </message> | 35 | - </message> |
| 36 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENABLE_REPORTING" desc="The section title of the extended safe browsing checkbox to help improve safe browsing"> | ||
| 37 | - Help improve Chrome security | ||
| 38 | - </message> | ||
| 36 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENABLE_REPORTING_DESC" desc="Description for extended safe browsing"> | 39 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENABLE_REPORTING_DESC" desc="Description for extended safe browsing"> |
| 37 | - Sends URLs of some pages you visit, limited system information, and some page content to Google, to help discover new threats and protect everyone on the web. | 40 | - Sends URLs of some pages you visit, limited system information, and some page content to Google, to help discover new threats and protect everyone on the web. |
| 38 | - </message> | 41 | - </message> |
| @@ -51,6 +54,9 @@ | |||
| 51 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENHANCED_BULLET_ONE" desc="First bullet point under the safe browsing enhanced protection mode"> | 54 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENHANCED_BULLET_ONE" desc="First bullet point under the safe browsing enhanced protection mode"> |
| 52 | - Predicts and warns you about dangerous events before they happen | 55 | - Predicts and warns you about dangerous events before they happen |
| 53 | - </message> | 56 | - </message> |
| 57 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENHANCED_BULLET_TWO" desc="Second bullet point under the safe browsing enhanced protection mode"> | ||
| 58 | - Keeps you safe on Chrome and may be used to improve your security in other Google apps when you are signed in | ||
| 59 | - </message> | ||
| 54 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENHANCED_BULLET_THREE" desc="Third bullet point under the safe browsing enhanced protection mode"> | 60 | - <message name="IDS_SETTINGS_SAFEBROWSING_ENHANCED_BULLET_THREE" desc="Third bullet point under the safe browsing enhanced protection mode"> |
| 55 | - Improves security for you and everyone on the web | 61 | - Improves security for you and everyone on the web |
| 56 | - </message> | 62 | - </message> |
| @@ -64,7 +70,7 @@ | |||
| 64 | - Standard protection | 70 | - Standard protection |
| 65 | - </message> | 71 | - </message> |
| 66 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_DESC" desc="Description for safe browsing standard protection mode"> | 72 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_DESC" desc="Description for safe browsing standard protection mode"> |
| 67 | - Standard protection against websites, downloads, and extensions that are known to be dangerous | 73 | - Standard protection against websites, downloads, and extensions that are known to be dangerous. |
| 68 | - </message> | 74 | - </message> |
| 69 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_EXPAND_ACCESSIBILITY_LABEL" desc="Label for the button that toggles showing the detailed description of safe browsing standard protection. Only visible by screen reader software."> | 75 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_EXPAND_ACCESSIBILITY_LABEL" desc="Label for the button that toggles showing the detailed description of safe browsing standard protection. Only visible by screen reader software."> |
| 70 | - Show standard protection details | 76 | - Show standard protection details |
| @@ -72,6 +78,9 @@ | |||
| 72 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_BULLET_ONE" desc="First bullet point under the safe browsing standard protection mode"> | 78 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_BULLET_ONE" desc="First bullet point under the safe browsing standard protection mode"> |
| 73 | - Detects and warns you about dangerous events when they happen | 79 | - Detects and warns you about dangerous events when they happen |
| 74 | - </message> | 80 | - </message> |
| 81 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_BULLET_TWO" desc="First bullet point under the safe browsing standard protection mode"> | ||
| 82 | - Checks URLs with a list of unsafe sites stored in Chrome. If a site tries to steal your password, or when you download a harmful file, Chrome may also send URLs, including bits of page content, to Safe Browsing. | ||
| 83 | - </message> | ||
| 75 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_HELP_IMPROVE" desc="The name of the toggle to enable reporting to help improve safe browsing"> | 84 | - <message name="IDS_SETTINGS_SAFEBROWSING_STANDARD_HELP_IMPROVE" desc="The name of the toggle to enable reporting to help improve safe browsing"> |
| 76 | - Help improve security on the web for everyone | 85 | - Help improve security on the web for everyone |
| 77 | - </message> | 86 | - </message> |
| @@ -93,9 +102,9 @@ | |||
| 93 | <message name="IDS_SETTINGS_ENABLE_DO_NOT_TRACK" desc="The label of the checkbox to enable/disable sending the 'Do Not track' header"> | 102 | <message name="IDS_SETTINGS_ENABLE_DO_NOT_TRACK" desc="The label of the checkbox to enable/disable sending the 'Do Not track' header"> |
| 94 | Send a "Do Not Track" request with your browsing traffic | 103 | Send a "Do Not Track" request with your browsing traffic |
| 95 | </message> | 104 | </message> |
| 96 | --- a/chrome/browser/android/signin/signin_manager_android.cc | 105 | --- chrome/browser/android/signin/signin_manager_android.cc.orig |
| 97 | +++ b/chrome/browser/android/signin/signin_manager_android.cc | 106 | +++ chrome/browser/android/signin/signin_manager_android.cc |
| 98 | @@ -15,7 +15,6 @@ | 107 | @@ -14,7 +14,6 @@ |
| 99 | #include "chrome/android/chrome_jni_headers/SigninManagerImpl_jni.h" | 108 | #include "chrome/android/chrome_jni_headers/SigninManagerImpl_jni.h" |
| 100 | #include "chrome/common/pref_names.h" | 109 | #include "chrome/common/pref_names.h" |
| 101 | #include "components/prefs/pref_service.h" | 110 | #include "components/prefs/pref_service.h" |
| @@ -103,7 +112,7 @@ | |||
| 103 | #include "google_apis/gaia/gaia_auth_util.h" | 112 | #include "google_apis/gaia/gaia_auth_util.h" |
| 104 | 113 | ||
| 105 | #include "base/android/callback_android.h" | 114 | #include "base/android/callback_android.h" |
| 106 | @@ -31,7 +30,6 @@ | 115 | @@ -30,7 +29,6 @@ |
| 107 | #include "components/policy/core/browser/browser_policy_connector.h" | 116 | #include "components/policy/core/browser/browser_policy_connector.h" |
| 108 | #include "components/policy/core/common/cloud/user_cloud_policy_manager.h" | 117 | #include "components/policy/core/common/cloud/user_cloud_policy_manager.h" |
| 109 | #include "components/prefs/pref_service.h" | 118 | #include "components/prefs/pref_service.h" |
| @@ -111,7 +120,7 @@ | |||
| 111 | #include "components/signin/public/identity_manager/accounts_cookie_mutator.h" | 120 | #include "components/signin/public/identity_manager/accounts_cookie_mutator.h" |
| 112 | #include "components/signin/public/identity_manager/identity_manager.h" | 121 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 113 | #include "content/public/browser/browser_context.h" | 122 | #include "content/public/browser/browser_context.h" |
| 114 | @@ -96,8 +94,6 @@ class ProfileDataRemover : public conten | 123 | @@ -95,8 +93,6 @@ class ProfileDataRemover : public conten |
| 115 | // All the Profile data has been wiped. Clear the last signed in username | 124 | // All the Profile data has been wiped. Clear the last signed in username |
| 116 | // as well, so that the next signin doesn't trigger the account | 125 | // as well, so that the next signin doesn't trigger the account |
| 117 | // change dialog. | 126 | // change dialog. |
| @@ -120,7 +129,7 @@ | |||
| 120 | } | 129 | } |
| 121 | 130 | ||
| 122 | origin_runner_->PostTask(FROM_HERE, std::move(callback_)); | 131 | origin_runner_->PostTask(FROM_HERE, std::move(callback_)); |
| 123 | @@ -133,11 +129,6 @@ SigninManagerAndroid::SigninManagerAndro | 132 | @@ -132,11 +128,6 @@ SigninManagerAndroid::SigninManagerAndro |
| 124 | DCHECK(user_cloud_policy_manager_); | 133 | DCHECK(user_cloud_policy_manager_); |
| 125 | DCHECK(user_policy_signin_service_); | 134 | DCHECK(user_policy_signin_service_); |
| 126 | 135 | ||
| @@ -132,7 +141,7 @@ | |||
| 132 | force_browser_signin_.Init(prefs::kForceBrowserSignin, | 141 | force_browser_signin_.Init(prefs::kForceBrowserSignin, |
| 133 | g_browser_process->local_state()); | 142 | g_browser_process->local_state()); |
| 134 | 143 | ||
| 135 | @@ -161,7 +152,7 @@ void SigninManagerAndroid::Shutdown() { | 144 | @@ -160,7 +151,7 @@ void SigninManagerAndroid::Shutdown() { |
| 136 | } | 145 | } |
| 137 | 146 | ||
| 138 | bool SigninManagerAndroid::IsSigninAllowed() const { | 147 | bool SigninManagerAndroid::IsSigninAllowed() const { |
| @@ -141,11 +150,11 @@ | |||
| 141 | } | 150 | } |
| 142 | 151 | ||
| 143 | jboolean SigninManagerAndroid::IsSigninAllowedByPolicy(JNIEnv* env) const { | 152 | jboolean SigninManagerAndroid::IsSigninAllowedByPolicy(JNIEnv* env) const { |
| 144 | --- a/chrome/browser/android/signin/signin_manager_android.h | 153 | --- chrome/browser/android/signin/signin_manager_android.h.orig |
| 145 | +++ b/chrome/browser/android/signin/signin_manager_android.h | 154 | +++ chrome/browser/android/signin/signin_manager_android.h |
| 146 | @@ -117,9 +117,6 @@ class SigninManagerAndroid : public Keye | 155 | @@ -117,9 +117,6 @@ class SigninManagerAndroid : public Keye |
| 147 | 156 | ||
| 148 | const raw_ptr<Profile> profile_ = nullptr; | 157 | Profile* const profile_ = nullptr; |
| 149 | 158 | ||
| 150 | - // Handler for prefs::kSigninAllowed set in user's profile. | 159 | - // Handler for prefs::kSigninAllowed set in user's profile. |
| 151 | - BooleanPrefMember signin_allowed_; | 160 | - BooleanPrefMember signin_allowed_; |
| @@ -153,8 +162,8 @@ | |||
| 153 | // Handler for prefs::kForceBrowserSignin. This preference is set in Local | 162 | // Handler for prefs::kForceBrowserSignin. This preference is set in Local |
| 154 | // State, not in user prefs. | 163 | // State, not in user prefs. |
| 155 | BooleanPrefMember force_browser_signin_; | 164 | BooleanPrefMember force_browser_signin_; |
| 156 | --- a/chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl.cc | 165 | --- chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl.cc.orig |
| 157 | +++ b/chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl.cc | 166 | +++ chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl.cc |
| 158 | @@ -18,7 +18,6 @@ | 167 | @@ -18,7 +18,6 @@ |
| 159 | #include "chrome/browser/profiles/profile_manager.h" | 168 | #include "chrome/browser/profiles/profile_manager.h" |
| 160 | #include "chrome/common/pref_names.h" | 169 | #include "chrome/common/pref_names.h" |
| @@ -172,19 +181,19 @@ | |||
| 172 | return; | 181 | return; |
| 173 | } | 182 | } |
| 174 | 183 | ||
| 175 | --- a/chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl_unittest.cc | 184 | --- chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl_unittest.cc.orig |
| 176 | +++ b/chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl_unittest.cc | 185 | +++ chrome/browser/ash/lock_screen_apps/lock_screen_profile_creator_impl_unittest.cc |
| 177 | @@ -37,7 +37,6 @@ | 186 | @@ -37,7 +37,6 @@ |
| 178 | #include "chromeos/dbus/dbus_thread_manager.h" | 187 | #include "components/arc/session/arc_session.h" |
| 179 | #include "components/crx_file/id_util.h" | 188 | #include "components/crx_file/id_util.h" |
| 180 | #include "components/prefs/pref_service.h" | 189 | #include "components/prefs/pref_service.h" |
| 181 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 190 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 182 | #include "content/public/test/browser_task_environment.h" | 191 | #include "content/public/test/browser_task_environment.h" |
| 183 | #include "extensions/common/extension.h" | 192 | #include "extensions/common/extension.h" |
| 184 | #include "extensions/common/extension_builder.h" | 193 | #include "extensions/common/extension_builder.h" |
| 185 | --- a/chrome/browser/ash/login/signin/device_id_browsertest.cc | 194 | --- chrome/browser/ash/login/signin/device_id_browsertest.cc.orig |
| 186 | +++ b/chrome/browser/ash/login/signin/device_id_browsertest.cc | 195 | +++ chrome/browser/ash/login/signin/device_id_browsertest.cc |
| 187 | @@ -25,7 +25,6 @@ | 196 | @@ -24,7 +24,6 @@ |
| 188 | #include "chrome/common/chrome_switches.h" | 197 | #include "chrome/common/chrome_switches.h" |
| 189 | #include "chrome/test/base/in_process_browser_test.h" | 198 | #include "chrome/test/base/in_process_browser_test.h" |
| 190 | #include "components/prefs/pref_service.h" | 199 | #include "components/prefs/pref_service.h" |
| @@ -192,7 +201,7 @@ | |||
| 192 | #include "components/user_manager/known_user.h" | 201 | #include "components/user_manager/known_user.h" |
| 193 | #include "components/user_manager/user_manager.h" | 202 | #include "components/user_manager/user_manager.h" |
| 194 | #include "content/public/test/browser_test.h" | 203 | #include "content/public/test/browser_test.h" |
| 195 | @@ -256,15 +255,6 @@ IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE | 204 | @@ -249,15 +248,6 @@ IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE |
| 196 | SignInOnline(FakeGaiaMixin::kFakeUserEmail, FakeGaiaMixin::kFakeUserPassword, | 205 | SignInOnline(FakeGaiaMixin::kFakeUserEmail, FakeGaiaMixin::kFakeUserPassword, |
| 197 | kRefreshToken1, FakeGaiaMixin::kFakeUserGaiaId); | 206 | kRefreshToken1, FakeGaiaMixin::kFakeUserGaiaId); |
| 198 | 207 | ||
| @@ -207,8 +216,8 @@ | |||
| 207 | - | 216 | - |
| 208 | // Can't use SetKnownUserDeviceId here, because it forbids changing a device | 217 | // Can't use SetKnownUserDeviceId here, because it forbids changing a device |
| 209 | // ID. | 218 | // ID. |
| 210 | user_manager::KnownUser known_user(g_browser_process->local_state()); | 219 | user_manager::known_user::SetStringPref( |
| 211 | @@ -290,13 +280,6 @@ IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE | 220 | @@ -282,13 +272,6 @@ IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE |
| 212 | SignInOnline(FakeGaiaMixin::kFakeUserEmail, FakeGaiaMixin::kFakeUserPassword, | 221 | SignInOnline(FakeGaiaMixin::kFakeUserEmail, FakeGaiaMixin::kFakeUserPassword, |
| 213 | kRefreshToken1, FakeGaiaMixin::kFakeUserGaiaId); | 222 | kRefreshToken1, FakeGaiaMixin::kFakeUserGaiaId); |
| 214 | 223 | ||
| @@ -221,10 +230,10 @@ | |||
| 221 | - | 230 | - |
| 222 | // Can't use SetKnownUserDeviceId here, because it forbids changing a device | 231 | // Can't use SetKnownUserDeviceId here, because it forbids changing a device |
| 223 | // ID. | 232 | // ID. |
| 224 | user_manager::KnownUser known_user(g_browser_process->local_state()); | 233 | user_manager::known_user::SetStringPref( |
| 225 | --- a/chrome/browser/chrome_content_browser_client.cc | 234 | --- chrome/browser/chrome_content_browser_client.cc.orig |
| 226 | +++ b/chrome/browser/chrome_content_browser_client.cc | 235 | +++ chrome/browser/chrome_content_browser_client.cc |
| 227 | @@ -236,7 +236,6 @@ | 236 | @@ -225,7 +225,6 @@ |
| 228 | #include "components/safe_browsing/core/browser/realtime/url_lookup_service.h" | 237 | #include "components/safe_browsing/core/browser/realtime/url_lookup_service.h" |
| 229 | #include "components/safe_browsing/core/browser/url_checker_delegate.h" | 238 | #include "components/safe_browsing/core/browser/url_checker_delegate.h" |
| 230 | #include "components/safe_browsing/core/common/features.h" | 239 | #include "components/safe_browsing/core/common/features.h" |
| @@ -232,19 +241,9 @@ | |||
| 232 | #include "components/security_interstitials/content/insecure_form_navigation_throttle.h" | 241 | #include "components/security_interstitials/content/insecure_form_navigation_throttle.h" |
| 233 | #include "components/security_interstitials/content/origin_policy_ui.h" | 242 | #include "components/security_interstitials/content/origin_policy_ui.h" |
| 234 | #include "components/security_interstitials/content/ssl_cert_reporter.h" | 243 | #include "components/security_interstitials/content/ssl_cert_reporter.h" |
| 235 | --- a/chrome/browser/download/bubble/download_bubble_prefs.cc | 244 | --- chrome/browser/download/download_browsertest.cc.orig |
| 236 | +++ b/chrome/browser/download/bubble/download_bubble_prefs.cc | 245 | +++ chrome/browser/download/download_browsertest.cc |
| 237 | @@ -11,7 +11,6 @@ | 246 | @@ -103,7 +103,6 @@ |
| 238 | #include "chrome/common/pref_names.h" | ||
| 239 | #include "components/prefs/pref_service.h" | ||
| 240 | #include "components/safe_browsing/core/common/features.h" | ||
| 241 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | ||
| 242 | |||
| 243 | namespace download { | ||
| 244 | |||
| 245 | --- a/chrome/browser/download/download_browsertest.cc | ||
| 246 | +++ b/chrome/browser/download/download_browsertest.cc | ||
| 247 | @@ -101,7 +101,6 @@ | ||
| 248 | #include "components/safe_browsing/content/browser/safe_browsing_service_interface.h" | 247 | #include "components/safe_browsing/content/browser/safe_browsing_service_interface.h" |
| 249 | #include "components/safe_browsing/content/common/proto/download_file_types.pb.h" | 248 | #include "components/safe_browsing/content/common/proto/download_file_types.pb.h" |
| 250 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 249 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -252,9 +251,9 @@ | |||
| 252 | #include "components/security_state/core/features.h" | 251 | #include "components/security_state/core/features.h" |
| 253 | #include "components/security_state/core/security_state.h" | 252 | #include "components/security_state/core/security_state.h" |
| 254 | #include "components/services/quarantine/test_support.h" | 253 | #include "components/services/quarantine/test_support.h" |
| 255 | --- a/chrome/browser/download/download_item_model.cc | 254 | --- chrome/browser/download/download_item_model.cc.orig |
| 256 | +++ b/chrome/browser/download/download_item_model.cc | 255 | +++ chrome/browser/download/download_item_model.cc |
| 257 | @@ -830,6 +830,7 @@ void DownloadItemModel::ExecuteCommand(D | 256 | @@ -783,6 +783,7 @@ void DownloadItemModel::ExecuteCommand(D |
| 258 | DownloadUIModel::ExecuteCommand(download_commands, command); | 257 | DownloadUIModel::ExecuteCommand(download_commands, command); |
| 259 | break; | 258 | break; |
| 260 | case DownloadCommands::DEEP_SCAN: | 259 | case DownloadCommands::DEEP_SCAN: |
| @@ -262,7 +261,7 @@ | |||
| 262 | safe_browsing::SafeBrowsingService* sb_service = | 261 | safe_browsing::SafeBrowsingService* sb_service = |
| 263 | g_browser_process->safe_browsing_service(); | 262 | g_browser_process->safe_browsing_service(); |
| 264 | if (!sb_service) | 263 | if (!sb_service) |
| 265 | @@ -855,6 +856,7 @@ void DownloadItemModel::ExecuteCommand(D | 264 | @@ -808,6 +809,7 @@ void DownloadItemModel::ExecuteCommand(D |
| 266 | safe_browsing::DeepScanningRequest::DeepScanTrigger:: | 265 | safe_browsing::DeepScanningRequest::DeepScanTrigger:: |
| 267 | TRIGGER_APP_PROMPT, | 266 | TRIGGER_APP_PROMPT, |
| 268 | safe_browsing::DownloadCheckResult::UNKNOWN, std::move(settings)); | 267 | safe_browsing::DownloadCheckResult::UNKNOWN, std::move(settings)); |
| @@ -270,8 +269,8 @@ | |||
| 270 | break; | 269 | break; |
| 271 | } | 270 | } |
| 272 | } | 271 | } |
| 273 | --- a/chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc | 272 | --- chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc.orig |
| 274 | +++ b/chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc | 273 | +++ chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc |
| 275 | @@ -38,7 +38,6 @@ | 274 | @@ -38,7 +38,6 @@ |
| 276 | #include "components/policy/core/common/chrome_schema.h" | 275 | #include "components/policy/core/common/chrome_schema.h" |
| 277 | #include "components/prefs/pref_service.h" | 276 | #include "components/prefs/pref_service.h" |
| @@ -280,33 +279,35 @@ | |||
| 280 | #include "components/url_matcher/url_matcher.h" | 279 | #include "components/url_matcher/url_matcher.h" |
| 281 | #include "content/public/browser/web_contents.h" | 280 | #include "content/public/browser/web_contents.h" |
| 282 | #include "crypto/secure_hash.h" | 281 | #include "crypto/secure_hash.h" |
| 283 | --- a/chrome/browser/enterprise/connectors/connectors_manager.cc | 282 | --- chrome/browser/enterprise/connectors/connectors_manager.cc.orig |
| 284 | +++ b/chrome/browser/enterprise/connectors/connectors_manager.cc | 283 | +++ chrome/browser/enterprise/connectors/connectors_manager.cc |
| 285 | @@ -6,12 +6,12 @@ | 284 | @@ -6,6 +6,7 @@ |
| 286 | 285 | ||
| 287 | #include <memory> | 286 | #include <memory> |
| 288 | 287 | ||
| 289 | +#include "base/bind.h" | 288 | +#include "base/bind.h" |
| 290 | #include "base/feature_list.h" | 289 | #include "base/feature_list.h" |
| 290 | #include "base/no_destructor.h" | ||
| 291 | #include "base/values.h" | 291 | #include "base/values.h" |
| 292 | #include "chrome/browser/browser_process.h" | 292 | @@ -13,7 +14,6 @@ |
| 293 | #include "chrome/browser/enterprise/connectors/connectors_prefs.h" | 293 | #include "chrome/browser/enterprise/connectors/connectors_prefs.h" |
| 294 | #include "components/policy/core/browser/url_util.h" | ||
| 294 | #include "components/prefs/pref_service.h" | 295 | #include "components/prefs/pref_service.h" |
| 295 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 296 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 296 | #include "components/url_matcher/url_matcher.h" | 297 | #include "components/url_matcher/url_matcher.h" |
| 297 | #include "url/gurl.h" | 298 | #include "url/gurl.h" |
| 298 | 299 | ||
| 299 | --- a/chrome/browser/enterprise/connectors/connectors_service.cc | 300 | --- chrome/browser/enterprise/connectors/connectors_service.cc.orig |
| 300 | +++ b/chrome/browser/enterprise/connectors/connectors_service.cc | 301 | +++ chrome/browser/enterprise/connectors/connectors_service.cc |
| 301 | @@ -38,7 +38,6 @@ | 302 | @@ -36,7 +36,6 @@ |
| 302 | #include "components/policy/core/common/cloud/machine_level_user_cloud_policy_store.h" | 303 | #include "components/policy/core/common/cloud/machine_level_user_cloud_policy_store.h" |
| 303 | #include "components/policy/core/common/cloud/user_cloud_policy_manager.h" | 304 | #include "components/policy/core/common/cloud/user_cloud_policy_manager.h" |
| 304 | #include "components/policy/core/common/policy_types.h" | 305 | #include "components/policy/core/common/policy_types.h" |
| 305 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 306 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 306 | #include "components/signin/public/base/consent_level.h" | 307 | #include "components/signin/public/identity_manager/consent_level.h" |
| 307 | #include "components/signin/public/identity_manager/identity_manager.h" | 308 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 308 | #include "components/user_prefs/user_prefs.h" | 309 | #include "components/user_prefs/user_prefs.h" |
| 309 | @@ -391,8 +390,7 @@ std::string ConnectorsService::GetManage | 310 | @@ -406,8 +405,7 @@ std::string ConnectorsService::GetManage |
| 310 | 311 | ||
| 311 | absl::optional<policy::PolicyScope> scope = absl::nullopt; | 312 | absl::optional<policy::PolicyScope> scope = absl::nullopt; |
| 312 | for (const char* scope_pref : | 313 | for (const char* scope_pref : |
| @@ -315,8 +316,8 @@ | |||
| 315 | + {ConnectorScopePref(AnalysisConnector::FILE_ATTACHED), | 316 | + {ConnectorScopePref(AnalysisConnector::FILE_ATTACHED), |
| 316 | ConnectorScopePref(AnalysisConnector::FILE_DOWNLOADED), | 317 | ConnectorScopePref(AnalysisConnector::FILE_DOWNLOADED), |
| 317 | ConnectorScopePref(AnalysisConnector::BULK_DATA_ENTRY), | 318 | ConnectorScopePref(AnalysisConnector::BULK_DATA_ENTRY), |
| 318 | ConnectorScopePref(AnalysisConnector::PRINT), | 319 | ConnectorScopePref(ReportingConnector::SECURITY_EVENT)}) { |
| 319 | @@ -444,20 +442,6 @@ std::string ConnectorsService::GetManage | 320 | @@ -458,20 +456,6 @@ std::string ConnectorsService::GetManage |
| 320 | 321 | ||
| 321 | absl::optional<std::string> ConnectorsService::GetDMTokenForRealTimeUrlCheck() | 322 | absl::optional<std::string> ConnectorsService::GetDMTokenForRealTimeUrlCheck() |
| 322 | const { | 323 | const { |
| @@ -337,9 +338,9 @@ | |||
| 337 | return absl::nullopt; | 338 | return absl::nullopt; |
| 338 | } | 339 | } |
| 339 | 340 | ||
| 340 | --- a/chrome/browser/enterprise/connectors/connectors_service.h | 341 | --- chrome/browser/enterprise/connectors/connectors_service.h.orig |
| 341 | +++ b/chrome/browser/enterprise/connectors/connectors_service.h | 342 | +++ chrome/browser/enterprise/connectors/connectors_service.h |
| 342 | @@ -15,7 +15,6 @@ | 343 | @@ -13,7 +13,6 @@ |
| 343 | #include "components/keyed_service/content/browser_context_keyed_service_factory.h" | 344 | #include "components/keyed_service/content/browser_context_keyed_service_factory.h" |
| 344 | #include "components/keyed_service/core/keyed_service.h" | 345 | #include "components/keyed_service/core/keyed_service.h" |
| 345 | #include "components/policy/core/common/policy_types.h" | 346 | #include "components/policy/core/common/policy_types.h" |
| @@ -347,9 +348,9 @@ | |||
| 347 | #include "content/public/browser/browser_context.h" | 348 | #include "content/public/browser/browser_context.h" |
| 348 | 349 | ||
| 349 | namespace base { | 350 | namespace base { |
| 350 | --- a/chrome/browser/enterprise/signals/context_info_fetcher.cc | 351 | --- chrome/browser/enterprise/signals/context_info_fetcher.cc.orig |
| 351 | +++ b/chrome/browser/enterprise/signals/context_info_fetcher.cc | 352 | +++ chrome/browser/enterprise/signals/context_info_fetcher.cc |
| 352 | @@ -218,11 +218,6 @@ void ContextInfoFetcher::Fetch(ContextIn | 353 | @@ -183,11 +183,6 @@ void ContextInfoFetcher::Fetch(ContextIn |
| 353 | info.third_party_blocking_enabled = | 354 | info.third_party_blocking_enabled = |
| 354 | utils::GetThirdPartyBlockingEnabled(g_browser_process->local_state()); | 355 | utils::GetThirdPartyBlockingEnabled(g_browser_process->local_state()); |
| 355 | 356 | ||
| @@ -359,19 +360,19 @@ | |||
| 359 | - info.password_protection_warning_trigger = | 360 | - info.password_protection_warning_trigger = |
| 360 | - utils::GetPasswordProtectionWarningTrigger(profile->GetPrefs()); | 361 | - utils::GetPasswordProtectionWarningTrigger(profile->GetPrefs()); |
| 361 | 362 | ||
| 362 | #if BUILDFLAG(IS_WIN) | 363 | #if defined(OS_WIN) |
| 363 | base::ThreadPool::CreateCOMSTATaskRunner({base::MayBlock()}) | 364 | base::ThreadPool::CreateCOMSTATaskRunner({base::MayBlock()}) |
| 364 | --- a/chrome/browser/enterprise/signals/context_info_fetcher.h | 365 | --- chrome/browser/enterprise/signals/context_info_fetcher.h.orig |
| 365 | +++ b/chrome/browser/enterprise/signals/context_info_fetcher.h | 366 | +++ chrome/browser/enterprise/signals/context_info_fetcher.h |
| 366 | @@ -13,7 +13,6 @@ | 367 | @@ -12,7 +12,6 @@ |
| 367 | #include "base/memory/raw_ptr.h" | 368 | #include "base/callback_forward.h" |
| 368 | #include "build/build_config.h" | 369 | #include "build/build_config.h" |
| 369 | #include "chrome/browser/enterprise/signals/signals_common.h" | 370 | #include "chrome/browser/enterprise/signals/signals_common.h" |
| 370 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 371 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 371 | 372 | ||
| 372 | namespace content { | 373 | namespace content { |
| 373 | class BrowserContext; | 374 | class BrowserContext; |
| 374 | @@ -40,11 +39,8 @@ struct ContextInfo { | 375 | @@ -39,11 +38,8 @@ struct ContextInfo { |
| 375 | std::vector<std::string> on_bulk_data_entry_providers; | 376 | std::vector<std::string> on_bulk_data_entry_providers; |
| 376 | std::vector<std::string> on_security_event_providers; | 377 | std::vector<std::string> on_security_event_providers; |
| 377 | std::string browser_version; | 378 | std::string browser_version; |
| @@ -383,18 +384,18 @@ | |||
| 383 | absl::optional<bool> chrome_cleanup_enabled; | 384 | absl::optional<bool> chrome_cleanup_enabled; |
| 384 | bool chrome_remote_desktop_app_blocked; | 385 | bool chrome_remote_desktop_app_blocked; |
| 385 | absl::optional<bool> third_party_blocking_enabled; | 386 | absl::optional<bool> third_party_blocking_enabled; |
| 386 | --- a/chrome/browser/enterprise/signals/signals_utils.cc | 387 | --- chrome/browser/enterprise/signals/signals_utils.cc.orig |
| 387 | +++ b/chrome/browser/enterprise/signals/signals_utils.cc | 388 | +++ chrome/browser/enterprise/signals/signals_utils.cc |
| 388 | @@ -10,7 +10,6 @@ | 389 | @@ -10,7 +10,6 @@ |
| 389 | #include "components/policy/content/policy_blocklist_service.h" | 390 | #include "components/policy/content/policy_blocklist_service.h" |
| 390 | #include "components/policy/core/browser/url_blocklist_manager.h" | 391 | #include "components/policy/core/browser/url_blocklist_manager.h" |
| 391 | #include "components/prefs/pref_service.h" | 392 | #include "components/prefs/pref_service.h" |
| 392 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 393 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 393 | 394 | ||
| 394 | #if BUILDFLAG(IS_WIN) | 395 | #if defined(OS_WIN) |
| 395 | #include "components/component_updater/pref_names.h" | 396 | #include "components/component_updater/pref_names.h" |
| 396 | --- a/chrome/browser/enterprise/signals/signals_utils.h | 397 | --- chrome/browser/enterprise/signals/signals_utils.h.orig |
| 397 | +++ b/chrome/browser/enterprise/signals/signals_utils.h | 398 | +++ chrome/browser/enterprise/signals/signals_utils.h |
| 398 | @@ -5,8 +5,6 @@ | 399 | @@ -5,8 +5,6 @@ |
| 399 | #ifndef CHROME_BROWSER_ENTERPRISE_SIGNALS_SIGNALS_UTILS_H_ | 400 | #ifndef CHROME_BROWSER_ENTERPRISE_SIGNALS_SIGNALS_UTILS_H_ |
| 400 | #define CHROME_BROWSER_ENTERPRISE_SIGNALS_SIGNALS_UTILS_H_ | 401 | #define CHROME_BROWSER_ENTERPRISE_SIGNALS_SIGNALS_UTILS_H_ |
| @@ -404,8 +405,8 @@ | |||
| 404 | #include "third_party/abseil-cpp/absl/types/optional.h" | 405 | #include "third_party/abseil-cpp/absl/types/optional.h" |
| 405 | 406 | ||
| 406 | class PolicyBlocklistService; | 407 | class PolicyBlocklistService; |
| 407 | --- a/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc | 408 | --- chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc.orig |
| 408 | +++ b/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc | 409 | +++ chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc |
| 409 | @@ -77,45 +77,10 @@ api::enterprise_reporting_private::Conte | 410 | @@ -77,45 +77,10 @@ api::enterprise_reporting_private::Conte |
| 410 | info.browser_version = std::move(signals.browser_version); | 411 | info.browser_version = std::move(signals.browser_version); |
| 411 | info.built_in_dns_client_enabled = signals.built_in_dns_client_enabled; | 412 | info.built_in_dns_client_enabled = signals.built_in_dns_client_enabled; |
| @@ -456,9 +457,9 @@ | |||
| 456 | 457 | ||
| 457 | return info; | 458 | return info; |
| 458 | } | 459 | } |
| 459 | --- a/chrome/browser/extensions/api/identity/identity_apitest.cc | 460 | --- chrome/browser/extensions/api/identity/identity_apitest.cc.orig |
| 460 | +++ b/chrome/browser/extensions/api/identity/identity_apitest.cc | 461 | +++ chrome/browser/extensions/api/identity/identity_apitest.cc |
| 461 | @@ -57,7 +57,6 @@ | 462 | @@ -56,7 +56,6 @@ |
| 462 | #include "components/prefs/pref_service.h" | 463 | #include "components/prefs/pref_service.h" |
| 463 | #include "components/signin/core/browser/account_reconcilor.h" | 464 | #include "components/signin/core/browser/account_reconcilor.h" |
| 464 | #include "components/signin/public/base/list_accounts_test_utils.h" | 465 | #include "components/signin/public/base/list_accounts_test_utils.h" |
| @@ -466,9 +467,9 @@ | |||
| 466 | #include "components/signin/public/base/signin_switches.h" | 467 | #include "components/signin/public/base/signin_switches.h" |
| 467 | #include "components/signin/public/identity_manager/accounts_mutator.h" | 468 | #include "components/signin/public/identity_manager/accounts_mutator.h" |
| 468 | #include "components/signin/public/identity_manager/identity_manager.h" | 469 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 469 | --- a/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc | 470 | --- chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc.orig |
| 470 | +++ b/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc | 471 | +++ chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc |
| 471 | @@ -29,7 +29,6 @@ | 472 | @@ -30,7 +30,6 @@ |
| 472 | #include "chrome/common/channel_info.h" | 473 | #include "chrome/common/channel_info.h" |
| 473 | #include "chrome/common/extensions/api/identity.h" | 474 | #include "chrome/common/extensions/api/identity.h" |
| 474 | #include "components/prefs/pref_service.h" | 475 | #include "components/prefs/pref_service.h" |
| @@ -476,7 +477,7 @@ | |||
| 476 | #include "components/signin/public/base/signin_switches.h" | 477 | #include "components/signin/public/base/signin_switches.h" |
| 477 | #include "components/signin/public/identity_manager/access_token_info.h" | 478 | #include "components/signin/public/identity_manager/access_token_info.h" |
| 478 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" | 479 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" |
| 479 | @@ -63,7 +62,7 @@ const char* const kExtensionsIdentityAPI | 480 | @@ -64,7 +63,7 @@ const char* const kExtensionsIdentityAPI |
| 480 | "extensions_identity_api"; | 481 | "extensions_identity_api"; |
| 481 | 482 | ||
| 482 | bool IsBrowserSigninAllowed(Profile* profile) { | 483 | bool IsBrowserSigninAllowed(Profile* profile) { |
| @@ -485,8 +486,8 @@ | |||
| 485 | } | 486 | } |
| 486 | 487 | ||
| 487 | std::string GetOAuth2MintTokenFlowVersion() { | 488 | std::string GetOAuth2MintTokenFlowVersion() { |
| 488 | --- a/chrome/browser/extensions/api/preference/preference_api.cc | 489 | --- chrome/browser/extensions/api/preference/preference_api.cc.orig |
| 489 | +++ b/chrome/browser/extensions/api/preference/preference_api.cc | 490 | +++ chrome/browser/extensions/api/preference/preference_api.cc |
| 490 | @@ -35,7 +35,6 @@ | 491 | @@ -35,7 +35,6 @@ |
| 491 | #include "components/prefs/pref_service.h" | 492 | #include "components/prefs/pref_service.h" |
| 492 | #include "components/privacy_sandbox/privacy_sandbox_prefs.h" | 493 | #include "components/privacy_sandbox/privacy_sandbox_prefs.h" |
| @@ -494,8 +495,8 @@ | |||
| 494 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 495 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 495 | #include "components/spellcheck/browser/pref_names.h" | 496 | #include "components/spellcheck/browser/pref_names.h" |
| 496 | #include "components/translate/core/browser/translate_pref_names.h" | 497 | #include "components/translate/core/browser/translate_pref_names.h" |
| 497 | #include "extensions/browser/api/content_settings/content_settings_service.h" | 498 | #include "extensions/browser/extension_pref_value_map.h" |
| 498 | @@ -110,11 +109,6 @@ const PrefMappingEntry kPrefMapping[] = | 499 | @@ -109,11 +108,6 @@ const PrefMappingEntry kPrefMapping[] = |
| 499 | APIPermissionID::kPrivacy}, | 500 | APIPermissionID::kPrivacy}, |
| 500 | {"doNotTrackEnabled", prefs::kEnableDoNotTrack, APIPermissionID::kPrivacy, | 501 | {"doNotTrackEnabled", prefs::kEnableDoNotTrack, APIPermissionID::kPrivacy, |
| 501 | APIPermissionID::kPrivacy}, | 502 | APIPermissionID::kPrivacy}, |
| @@ -507,7 +508,7 @@ | |||
| 507 | {"searchSuggestEnabled", prefs::kSearchSuggestEnabled, | 508 | {"searchSuggestEnabled", prefs::kSearchSuggestEnabled, |
| 508 | APIPermissionID::kPrivacy, APIPermissionID::kPrivacy}, | 509 | APIPermissionID::kPrivacy, APIPermissionID::kPrivacy}, |
| 509 | {"spellingServiceEnabled", spellcheck::prefs::kSpellCheckUseSpellingService, | 510 | {"spellingServiceEnabled", spellcheck::prefs::kSpellCheckUseSpellingService, |
| 510 | @@ -845,18 +839,6 @@ ExtensionFunction::ResponseAction SetPre | 511 | @@ -844,18 +838,6 @@ ExtensionFunction::ResponseAction SetPre |
| 511 | base::Value(browser_pref_value->GetBool())); | 512 | base::Value(browser_pref_value->GetBool())); |
| 512 | } | 513 | } |
| 513 | 514 | ||
| @@ -526,7 +527,7 @@ | |||
| 526 | preference_api->SetExtensionControlledPref( | 527 | preference_api->SetExtensionControlledPref( |
| 527 | extension_id(), browser_pref, scope, | 528 | extension_id(), browser_pref, scope, |
| 528 | base::Value::FromUniquePtrValue(std::move(browser_pref_value))); | 529 | base::Value::FromUniquePtrValue(std::move(browser_pref_value))); |
| 529 | @@ -909,18 +891,6 @@ ExtensionFunction::ResponseAction ClearP | 530 | @@ -908,18 +890,6 @@ ExtensionFunction::ResponseAction ClearP |
| 530 | PreferenceAPI::Get(browser_context()) | 531 | PreferenceAPI::Get(browser_context()) |
| 531 | ->RemoveExtensionControlledPref(extension_id(), browser_pref, scope); | 532 | ->RemoveExtensionControlledPref(extension_id(), browser_pref, scope); |
| 532 | 533 | ||
| @@ -545,9 +546,9 @@ | |||
| 545 | return RespondNow(NoArguments()); | 546 | return RespondNow(NoArguments()); |
| 546 | } | 547 | } |
| 547 | 548 | ||
| 548 | --- a/chrome/browser/extensions/api/preference/preference_apitest.cc | 549 | --- chrome/browser/extensions/api/preference/preference_apitest.cc.orig |
| 549 | +++ b/chrome/browser/extensions/api/preference/preference_apitest.cc | 550 | +++ chrome/browser/extensions/api/preference/preference_apitest.cc |
| 550 | @@ -31,7 +31,6 @@ | 551 | @@ -28,7 +28,6 @@ |
| 551 | #include "components/keep_alive_registry/scoped_keep_alive.h" | 552 | #include "components/keep_alive_registry/scoped_keep_alive.h" |
| 552 | #include "components/password_manager/core/common/password_manager_pref_names.h" | 553 | #include "components/password_manager/core/common/password_manager_pref_names.h" |
| 553 | #include "components/prefs/pref_service.h" | 554 | #include "components/prefs/pref_service.h" |
| @@ -555,43 +556,43 @@ | |||
| 555 | #include "components/translate/core/browser/translate_pref_names.h" | 556 | #include "components/translate/core/browser/translate_pref_names.h" |
| 556 | #include "content/public/browser/notification_service.h" | 557 | #include "content/public/browser/notification_service.h" |
| 557 | #include "content/public/test/browser_test.h" | 558 | #include "content/public/test/browser_test.h" |
| 558 | @@ -86,7 +85,6 @@ class ExtensionPreferenceApiTest | 559 | @@ -73,7 +72,6 @@ class ExtensionPreferenceApiTest : publi |
| 559 | prefs->GetInteger(prefetch::prefs::kNetworkPredictionOptions)); | 560 | prefs->GetInteger(prefs::kNetworkPredictionOptions)); |
| 560 | EXPECT_TRUE( | 561 | EXPECT_TRUE( |
| 561 | prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService)); | 562 | prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService)); |
| 562 | - EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); | 563 | - EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); |
| 563 | EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); | 564 | EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); |
| 564 | } | 565 | } |
| 565 | 566 | ||
| 566 | @@ -112,7 +110,6 @@ class ExtensionPreferenceApiTest | 567 | @@ -99,7 +97,6 @@ class ExtensionPreferenceApiTest : publi |
| 567 | prefs->GetInteger(prefetch::prefs::kNetworkPredictionOptions)); | 568 | prefs->GetInteger(prefs::kNetworkPredictionOptions)); |
| 568 | EXPECT_FALSE( | 569 | EXPECT_FALSE( |
| 569 | prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService)); | 570 | prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService)); |
| 570 | - EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); | 571 | - EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); |
| 571 | EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); | 572 | EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); |
| 572 | } | 573 | } |
| 573 | 574 | ||
| 574 | @@ -185,7 +182,6 @@ IN_PROC_BROWSER_TEST_P(ExtensionPreferen | 575 | @@ -163,7 +160,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionPreferen |
| 575 | prefetch::prefs::kNetworkPredictionOptions, | 576 | prefs->SetInteger(prefs::kNetworkPredictionOptions, |
| 576 | static_cast<int>(prefetch::NetworkPredictionOptions::kDisabled)); | 577 | chrome_browser_net::NETWORK_PREDICTION_NEVER); |
| 577 | prefs->SetBoolean(password_manager::prefs::kCredentialsEnableService, false); | 578 | prefs->SetBoolean(password_manager::prefs::kCredentialsEnableService, false); |
| 578 | - prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); | 579 | - prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); |
| 579 | prefs->SetBoolean(prefs::kSearchSuggestEnabled, false); | 580 | prefs->SetBoolean(prefs::kSearchSuggestEnabled, false); |
| 580 | prefs->SetString(prefs::kWebRTCIPHandlingPolicy, | 581 | prefs->SetString(prefs::kWebRTCIPHandlingPolicy, |
| 581 | blink::kWebRTCIPHandlingDefaultPublicInterfaceOnly); | 582 | blink::kWebRTCIPHandlingDefaultPublicInterfaceOnly); |
| 582 | --- a/chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.cc | 583 | --- chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.cc.orig |
| 583 | +++ b/chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.cc | 584 | +++ chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.cc |
| 584 | @@ -39,7 +39,6 @@ | 585 | @@ -36,7 +36,6 @@ |
| 585 | #include "components/policy/core/common/cloud/user_cloud_policy_manager.h" | 586 | #include "components/policy/core/common/cloud/user_cloud_policy_manager.h" |
| 586 | #include "components/prefs/pref_service.h" | 587 | #include "components/prefs/pref_service.h" |
| 587 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" | 588 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" |
| 588 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 589 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 589 | #include "components/signin/public/identity_manager/identity_manager.h" | 590 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 590 | #include "components/url_matcher/url_matcher.h" | 591 | #include "content/public/browser/browser_context.h" |
| 591 | #include "components/url_matcher/url_util.h" | 592 | #include "extensions/browser/event_router.h" |
| 592 | --- a/chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router_unittest.cc | 593 | --- chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router_unittest.cc.orig |
| 593 | +++ b/chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router_unittest.cc | 594 | +++ chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router_unittest.cc |
| 594 | @@ -36,7 +36,6 @@ | 595 | @@ -35,7 +35,6 @@ |
| 595 | #include "components/policy/core/common/cloud/mock_cloud_policy_client.h" | 596 | #include "components/policy/core/common/cloud/mock_cloud_policy_client.h" |
| 596 | #include "components/policy/core/common/cloud/realtime_reporting_job_configuration.h" | 597 | #include "components/policy/core/common/cloud/realtime_reporting_job_configuration.h" |
| 597 | #include "components/safe_browsing/core/common/features.h" | 598 | #include "components/safe_browsing/core/common/features.h" |
| @@ -599,8 +600,8 @@ | |||
| 599 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 600 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 600 | #include "content/public/test/browser_task_environment.h" | 601 | #include "content/public/test/browser_task_environment.h" |
| 601 | #include "extensions/browser/test_event_router.h" | 602 | #include "extensions/browser/test_event_router.h" |
| 602 | --- a/chrome/browser/extensions/api/settings_private/prefs_util.cc | 603 | --- chrome/browser/extensions/api/settings_private/prefs_util.cc.orig |
| 603 | +++ b/chrome/browser/extensions/api/settings_private/prefs_util.cc | 604 | +++ chrome/browser/extensions/api/settings_private/prefs_util.cc |
| 604 | @@ -43,7 +43,6 @@ | 605 | @@ -43,7 +43,6 @@ |
| 605 | #include "components/prefs/pref_service.h" | 606 | #include "components/prefs/pref_service.h" |
| 606 | #include "components/privacy_sandbox/privacy_sandbox_prefs.h" | 607 | #include "components/privacy_sandbox/privacy_sandbox_prefs.h" |
| @@ -609,7 +610,7 @@ | |||
| 609 | #include "components/search_engines/default_search_manager.h" | 610 | #include "components/search_engines/default_search_manager.h" |
| 610 | #include "components/spellcheck/browser/pref_names.h" | 611 | #include "components/spellcheck/browser/pref_names.h" |
| 611 | #include "components/translate/core/browser/translate_pref_names.h" | 612 | #include "components/translate/core/browser/translate_pref_names.h" |
| 612 | @@ -295,16 +294,6 @@ const PrefsUtil::TypedPrefMap& PrefsUtil | 613 | @@ -283,16 +282,6 @@ const PrefsUtil::TypedPrefMap& PrefsUtil |
| 613 | settings_api::PrefType::PREF_TYPE_BOOLEAN; | 614 | settings_api::PrefType::PREF_TYPE_BOOLEAN; |
| 614 | 615 | ||
| 615 | // Security page | 616 | // Security page |
| @@ -626,9 +627,9 @@ | |||
| 626 | (*s_allowlist)[::prefs::kHttpsOnlyModeEnabled] = | 627 | (*s_allowlist)[::prefs::kHttpsOnlyModeEnabled] = |
| 627 | settings_api::PrefType::PREF_TYPE_BOOLEAN; | 628 | settings_api::PrefType::PREF_TYPE_BOOLEAN; |
| 628 | 629 | ||
| 629 | --- a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc | 630 | --- chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc.orig |
| 630 | +++ b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc | 631 | +++ chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc |
| 631 | @@ -649,9 +649,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstore | 632 | @@ -647,9 +647,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstore |
| 632 | IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateGetReferrerChainApiTest, | 633 | IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateGetReferrerChainApiTest, |
| 633 | GetReferrerChainForNonSafeBrowsingUser) { | 634 | GetReferrerChainForNonSafeBrowsingUser) { |
| 634 | PrefService* pref_service = browser()->profile()->GetPrefs(); | 635 | PrefService* pref_service = browser()->profile()->GetPrefs(); |
| @@ -638,9 +639,9 @@ | |||
| 638 | 639 | ||
| 639 | GURL page_url = GetTestServerURLWithReferrers("empty_referrer_chain.html"); | 640 | GURL page_url = GetTestServerURLWithReferrers("empty_referrer_chain.html"); |
| 640 | ASSERT_TRUE(OpenTestURL(page_url)); | 641 | ASSERT_TRUE(OpenTestURL(page_url)); |
| 641 | --- a/chrome/browser/extensions/extension_allowlist.cc | 642 | --- chrome/browser/extensions/extension_allowlist.cc.orig |
| 642 | +++ b/chrome/browser/extensions/extension_allowlist.cc | 643 | +++ chrome/browser/extensions/extension_allowlist.cc |
| 643 | @@ -10,7 +10,6 @@ | 644 | @@ -9,7 +9,6 @@ |
| 644 | #include "chrome/browser/profiles/profile.h" | 645 | #include "chrome/browser/profiles/profile.h" |
| 645 | #include "chrome/browser/safe_browsing/safe_browsing_metrics_collector_factory.h" | 646 | #include "chrome/browser/safe_browsing/safe_browsing_metrics_collector_factory.h" |
| 646 | #include "components/safe_browsing/core/browser/safe_browsing_metrics_collector.h" | 647 | #include "components/safe_browsing/core/browser/safe_browsing_metrics_collector.h" |
| @@ -648,7 +649,7 @@ | |||
| 648 | #include "extensions/browser/allowlist_state.h" | 649 | #include "extensions/browser/allowlist_state.h" |
| 649 | #include "extensions/browser/extension_registry.h" | 650 | #include "extensions/browser/extension_registry.h" |
| 650 | #include "extensions/browser/extension_system.h" | 651 | #include "extensions/browser/extension_system.h" |
| 651 | @@ -69,10 +68,6 @@ ExtensionAllowlist::ExtensionAllowlist(P | 652 | @@ -68,10 +67,6 @@ ExtensionAllowlist::ExtensionAllowlist(P |
| 652 | // Register to Enhanced Safe Browsing setting changes for allowlist | 653 | // Register to Enhanced Safe Browsing setting changes for allowlist |
| 653 | // enforcements. | 654 | // enforcements. |
| 654 | pref_change_registrar_.Init(profile_->GetPrefs()); | 655 | pref_change_registrar_.Init(profile_->GetPrefs()); |
| @@ -659,7 +660,7 @@ | |||
| 659 | } | 660 | } |
| 660 | 661 | ||
| 661 | ExtensionAllowlist::~ExtensionAllowlist() = default; | 662 | ExtensionAllowlist::~ExtensionAllowlist() = default; |
| 662 | @@ -241,15 +236,8 @@ void ExtensionAllowlist::OnExtensionInst | 663 | @@ -240,15 +235,8 @@ void ExtensionAllowlist::OnExtensionInst |
| 663 | } | 664 | } |
| 664 | 665 | ||
| 665 | void ExtensionAllowlist::SetAllowlistEnforcementFields() { | 666 | void ExtensionAllowlist::SetAllowlistEnforcementFields() { |
| @@ -675,7 +676,7 @@ | |||
| 675 | } | 676 | } |
| 676 | 677 | ||
| 677 | // `ApplyEnforcement` can be called when an extension becomes not allowlisted or | 678 | // `ApplyEnforcement` can be called when an extension becomes not allowlisted or |
| 678 | @@ -399,15 +387,6 @@ void ExtensionAllowlist::NotifyExtension | 679 | @@ -398,15 +386,6 @@ void ExtensionAllowlist::NotifyExtension |
| 679 | } | 680 | } |
| 680 | 681 | ||
| 681 | void ExtensionAllowlist::ReportExtensionReEnabledEvent() { | 682 | void ExtensionAllowlist::ReportExtensionReEnabledEvent() { |
| @@ -691,17 +692,9 @@ | |||
| 691 | } | 692 | } |
| 692 | 693 | ||
| 693 | } // namespace extensions | 694 | } // namespace extensions |
| 694 | --- a/chrome/browser/extensions/installed_loader.cc | 695 | --- chrome/browser/extensions/installed_loader.cc.orig |
| 695 | +++ b/chrome/browser/extensions/installed_loader.cc | 696 | +++ chrome/browser/extensions/installed_loader.cc |
| 696 | @@ -28,7 +28,6 @@ | 697 | @@ -797,12 +797,6 @@ void InstalledLoader::RecordExtensionsMe |
| 697 | #include "chrome/common/extensions/chrome_manifest_url_handlers.h" | ||
| 698 | #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler.h" | ||
| 699 | #include "chrome/common/webui_url_constants.h" | ||
| 700 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | ||
| 701 | #include "content/public/browser/browser_thread.h" | ||
| 702 | #include "content/public/browser/notification_service.h" | ||
| 703 | #include "content/public/common/url_constants.h" | ||
| 704 | @@ -798,12 +797,6 @@ void InstalledLoader::RecordExtensionsMe | ||
| 705 | enabled_not_allowlisted_count); | 698 | enabled_not_allowlisted_count); |
| 706 | base::UmaHistogramCounts100("Extensions.NotAllowlistedDisabled", | 699 | base::UmaHistogramCounts100("Extensions.NotAllowlistedDisabled", |
| 707 | disabled_not_allowlisted_count); | 700 | disabled_not_allowlisted_count); |
| @@ -714,9 +707,9 @@ | |||
| 714 | } | 707 | } |
| 715 | 708 | ||
| 716 | int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) { | 709 | int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) { |
| 717 | --- a/chrome/browser/net/profile_network_context_service.cc | 710 | --- chrome/browser/net/profile_network_context_service.cc.orig |
| 718 | +++ b/chrome/browser/net/profile_network_context_service.cc | 711 | +++ chrome/browser/net/profile_network_context_service.cc |
| 719 | @@ -46,7 +46,6 @@ | 712 | @@ -43,7 +43,6 @@ |
| 720 | #include "components/pref_registry/pref_registry_syncable.h" | 713 | #include "components/pref_registry/pref_registry_syncable.h" |
| 721 | #include "components/prefs/pref_registry_simple.h" | 714 | #include "components/prefs/pref_registry_simple.h" |
| 722 | #include "components/prefs/pref_service.h" | 715 | #include "components/prefs/pref_service.h" |
| @@ -724,24 +717,22 @@ | |||
| 724 | #include "content/public/browser/browser_context.h" | 717 | #include "content/public/browser/browser_context.h" |
| 725 | #include "content/public/browser/browser_thread.h" | 718 | #include "content/public/browser/browser_thread.h" |
| 726 | #include "content/public/browser/network_service_instance.h" | 719 | #include "content/public/browser/network_service_instance.h" |
| 727 | @@ -806,15 +805,8 @@ void ProfileNetworkContextService::Confi | 720 | @@ -741,13 +740,6 @@ void ProfileNetworkContextService::Confi |
| 728 | network_context_params->enable_certificate_reporting = true; | 721 | network_context_params->enable_certificate_reporting = true; |
| 729 | network_context_params->enable_expect_ct_reporting = true; | 722 | network_context_params->enable_expect_ct_reporting = true; |
| 730 | 723 | ||
| 731 | - SCTReportingService* sct_reporting_service = | 724 | - // Initialize the network context to do SCT auditing only if the current |
| 732 | - SCTReportingServiceFactory::GetForBrowserContext(profile_); | 725 | - // profile is opted in to Safe Browsing Extended Reporting. |
| 733 | - if (sct_reporting_service) { | 726 | - if (!profile_->IsOffTheRecord() && |
| 734 | - network_context_params->sct_auditing_mode = | 727 | - safe_browsing::IsExtendedReportingEnabled(*profile_->GetPrefs())) { |
| 735 | - sct_reporting_service->GetReportingMode(); | 728 | - network_context_params->enable_sct_auditing = true; |
| 736 | - } else { | ||
| 737 | network_context_params->sct_auditing_mode = | ||
| 738 | network::mojom::SCTAuditingMode::kDisabled; | ||
| 739 | - } | 729 | - } |
| 740 | 730 | - | |
| 741 | network_context_params->ct_policy = GetCTPolicy(); | 731 | network_context_params->ct_policy = GetCTPolicy(); |
| 742 | 732 | ||
| 743 | --- a/chrome/browser/net/trial_comparison_cert_verifier_browsertest.cc | 733 | #if BUILDFLAG(TRIAL_COMPARISON_CERT_VERIFIER_SUPPORTED) |
| 744 | +++ b/chrome/browser/net/trial_comparison_cert_verifier_browsertest.cc | 734 | --- chrome/browser/net/trial_comparison_cert_verifier_browsertest.cc.orig |
| 735 | +++ chrome/browser/net/trial_comparison_cert_verifier_browsertest.cc | ||
| 745 | @@ -11,7 +11,6 @@ | 736 | @@ -11,7 +11,6 @@ |
| 746 | #include "chrome/test/base/in_process_browser_test.h" | 737 | #include "chrome/test/base/in_process_browser_test.h" |
| 747 | #include "chrome/test/base/ui_test_utils.h" | 738 | #include "chrome/test/base/ui_test_utils.h" |
| @@ -750,9 +741,9 @@ | |||
| 750 | #include "content/public/test/browser_test.h" | 741 | #include "content/public/test/browser_test.h" |
| 751 | #include "net/base/features.h" | 742 | #include "net/base/features.h" |
| 752 | #include "net/cert/trial_comparison_cert_verifier.h" | 743 | #include "net/cert/trial_comparison_cert_verifier.h" |
| 753 | --- a/chrome/browser/net/trial_comparison_cert_verifier_controller.cc | 744 | --- chrome/browser/net/trial_comparison_cert_verifier_controller.cc.orig |
| 754 | +++ b/chrome/browser/net/trial_comparison_cert_verifier_controller.cc | 745 | +++ chrome/browser/net/trial_comparison_cert_verifier_controller.cc |
| 755 | @@ -18,7 +18,6 @@ | 746 | @@ -19,7 +19,6 @@ |
| 756 | #include "chrome/browser/safe_browsing/certificate_reporting_service.h" | 747 | #include "chrome/browser/safe_browsing/certificate_reporting_service.h" |
| 757 | #include "chrome/browser/safe_browsing/certificate_reporting_service_factory.h" | 748 | #include "chrome/browser/safe_browsing/certificate_reporting_service_factory.h" |
| 758 | #include "chrome/common/channel_info.h" | 749 | #include "chrome/common/channel_info.h" |
| @@ -760,7 +751,7 @@ | |||
| 760 | #include "components/security_interstitials/content/certificate_error_report.h" | 751 | #include "components/security_interstitials/content/certificate_error_report.h" |
| 761 | #include "content/public/browser/browser_task_traits.h" | 752 | #include "content/public/browser/browser_task_traits.h" |
| 762 | #include "content/public/browser/browser_thread.h" | 753 | #include "content/public/browser/browser_thread.h" |
| 763 | @@ -41,12 +40,6 @@ TrialComparisonCertVerifierController::T | 754 | @@ -42,12 +41,6 @@ TrialComparisonCertVerifierController::T |
| 764 | // enabled. | 755 | // enabled. |
| 765 | return; | 756 | return; |
| 766 | } | 757 | } |
| @@ -773,7 +764,7 @@ | |||
| 773 | } | 764 | } |
| 774 | 765 | ||
| 775 | TrialComparisonCertVerifierController:: | 766 | TrialComparisonCertVerifierController:: |
| 776 | @@ -100,9 +93,7 @@ bool TrialComparisonCertVerifierControll | 767 | @@ -101,9 +94,7 @@ bool TrialComparisonCertVerifierControll |
| 777 | if (!MaybeAllowedForProfile(profile_)) | 768 | if (!MaybeAllowedForProfile(profile_)) |
| 778 | return false; | 769 | return false; |
| 779 | 770 | ||
| @@ -784,8 +775,8 @@ | |||
| 784 | } | 775 | } |
| 785 | 776 | ||
| 786 | void TrialComparisonCertVerifierController::SendTrialReport( | 777 | void TrialComparisonCertVerifierController::SendTrialReport( |
| 787 | --- a/chrome/browser/net/trial_comparison_cert_verifier_controller.h | 778 | --- chrome/browser/net/trial_comparison_cert_verifier_controller.h.orig |
| 788 | +++ b/chrome/browser/net/trial_comparison_cert_verifier_controller.h | 779 | +++ chrome/browser/net/trial_comparison_cert_verifier_controller.h |
| 789 | @@ -14,7 +14,6 @@ | 780 | @@ -14,7 +14,6 @@ |
| 790 | #include "base/memory/ref_counted.h" | 781 | #include "base/memory/ref_counted.h" |
| 791 | #include "base/memory/weak_ptr.h" | 782 | #include "base/memory/weak_ptr.h" |
| @@ -797,13 +788,13 @@ | |||
| 797 | @@ -77,7 +76,6 @@ class TrialComparisonCertVerifierControl | 788 | @@ -77,7 +76,6 @@ class TrialComparisonCertVerifierControl |
| 798 | void RefreshState(); | 789 | void RefreshState(); |
| 799 | 790 | ||
| 800 | raw_ptr<Profile> profile_; | 791 | Profile* profile_; |
| 801 | - PrefChangeRegistrar pref_change_registrar_; | 792 | - PrefChangeRegistrar pref_change_registrar_; |
| 802 | 793 | ||
| 803 | mojo::ReceiverSet< | 794 | mojo::ReceiverSet< |
| 804 | cert_verifier::mojom::TrialComparisonCertVerifierReportClient> | 795 | cert_verifier::mojom::TrialComparisonCertVerifierReportClient> |
| 805 | --- a/chrome/browser/net/trial_comparison_cert_verifier_controller_unittest.cc | 796 | --- chrome/browser/net/trial_comparison_cert_verifier_controller_unittest.cc.orig |
| 806 | +++ b/chrome/browser/net/trial_comparison_cert_verifier_controller_unittest.cc | 797 | +++ chrome/browser/net/trial_comparison_cert_verifier_controller_unittest.cc |
| 807 | @@ -20,7 +20,6 @@ | 798 | @@ -20,7 +20,6 @@ |
| 808 | #include "chrome/test/base/testing_browser_process.h" | 799 | #include "chrome/test/base/testing_browser_process.h" |
| 809 | #include "chrome/test/base/testing_profile.h" | 800 | #include "chrome/test/base/testing_profile.h" |
| @@ -812,17 +803,17 @@ | |||
| 812 | #include "components/security_interstitials/content/cert_logger.pb.h" | 803 | #include "components/security_interstitials/content/cert_logger.pb.h" |
| 813 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 804 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 814 | #include "content/public/browser/browser_task_traits.h" | 805 | #include "content/public/browser/browser_task_traits.h" |
| 815 | --- a/chrome/browser/password_manager/generated_password_leak_detection_pref.cc | 806 | --- chrome/browser/password_manager/generated_password_leak_detection_pref.cc.orig |
| 816 | +++ b/chrome/browser/password_manager/generated_password_leak_detection_pref.cc | 807 | +++ chrome/browser/password_manager/generated_password_leak_detection_pref.cc |
| 817 | @@ -14,7 +14,6 @@ | 808 | @@ -13,7 +13,6 @@ |
| 818 | #include "components/password_manager/core/common/password_manager_features.h" | 809 | #include "chrome/common/extensions/api/settings_private.h" |
| 819 | #include "components/password_manager/core/common/password_manager_pref_names.h" | 810 | #include "components/password_manager/core/common/password_manager_pref_names.h" |
| 820 | #include "components/prefs/pref_service.h" | 811 | #include "components/prefs/pref_service.h" |
| 821 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 812 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 822 | #include "components/signin/public/identity_manager/identity_manager.h" | 813 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 823 | 814 | ||
| 824 | namespace { | 815 | namespace { |
| 825 | @@ -37,8 +36,7 @@ bool IsUserAllowedToUseLeakDetection(Pro | 816 | @@ -43,8 +42,7 @@ bool IsUserSignedInAndSyncing(Profile* p |
| 826 | // Returns whether the effective value of the Safe Browsing preferences for | 817 | // Returns whether the effective value of the Safe Browsing preferences for |
| 827 | // |profile| is standard protection. | 818 | // |profile| is standard protection. |
| 828 | bool IsSafeBrowsingStandard(Profile* profile) { | 819 | bool IsSafeBrowsingStandard(Profile* profile) { |
| @@ -832,7 +823,7 @@ | |||
| 832 | } | 823 | } |
| 833 | 824 | ||
| 834 | } // namespace | 825 | } // namespace |
| 835 | @@ -57,16 +55,6 @@ GeneratedPasswordLeakDetectionPref::Gene | 826 | @@ -63,16 +61,6 @@ GeneratedPasswordLeakDetectionPref::Gene |
| 836 | base::BindRepeating( | 827 | base::BindRepeating( |
| 837 | &GeneratedPasswordLeakDetectionPref::OnSourcePreferencesChanged, | 828 | &GeneratedPasswordLeakDetectionPref::OnSourcePreferencesChanged, |
| 838 | base::Unretained(this))); | 829 | base::Unretained(this))); |
| @@ -849,8 +840,8 @@ | |||
| 849 | 840 | ||
| 850 | if (auto* identity_manager = IdentityManagerFactory::GetForProfile(profile)) | 841 | if (auto* identity_manager = IdentityManagerFactory::GetForProfile(profile)) |
| 851 | identity_manager_observer_.Observe(identity_manager); | 842 | identity_manager_observer_.Observe(identity_manager); |
| 852 | --- a/chrome/browser/permissions/abusive_origin_permission_revocation_request.cc | 843 | --- chrome/browser/permissions/abusive_origin_permission_revocation_request.cc.orig |
| 853 | +++ b/chrome/browser/permissions/abusive_origin_permission_revocation_request.cc | 844 | +++ chrome/browser/permissions/abusive_origin_permission_revocation_request.cc |
| 854 | @@ -17,7 +17,6 @@ | 845 | @@ -17,7 +17,6 @@ |
| 855 | #include "components/permissions/permissions_client.h" | 846 | #include "components/permissions/permissions_client.h" |
| 856 | #include "components/prefs/pref_service.h" | 847 | #include "components/prefs/pref_service.h" |
| @@ -859,18 +850,18 @@ | |||
| 859 | 850 | ||
| 860 | namespace { | 851 | namespace { |
| 861 | constexpr char kExcludedKey[] = "exempted"; | 852 | constexpr char kExcludedKey[] = "exempted"; |
| 862 | --- a/chrome/browser/permissions/prediction_based_permission_ui_selector.cc | 853 | --- chrome/browser/permissions/prediction_based_permission_ui_selector.cc.orig |
| 863 | +++ b/chrome/browser/permissions/prediction_based_permission_ui_selector.cc | 854 | +++ chrome/browser/permissions/prediction_based_permission_ui_selector.cc |
| 864 | @@ -26,7 +26,6 @@ | 855 | @@ -23,7 +23,6 @@ |
| 865 | #include "components/permissions/prediction_service/prediction_service.h" | 856 | #include "components/permissions/prediction_service/prediction_service.h" |
| 866 | #include "components/permissions/prediction_service/prediction_service_messages.pb.h" | 857 | #include "components/permissions/prediction_service/prediction_service_messages.pb.h" |
| 867 | #include "components/prefs/pref_service.h" | 858 | #include "components/prefs/pref_service.h" |
| 868 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 859 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 869 | 860 | ||
| 870 | #if BUILDFLAG(BUILD_WITH_TFLITE_LIB) | 861 | namespace { |
| 871 | #include "chrome/browser/permissions/prediction_model_handler_factory.h" | 862 | |
| 872 | --- a/chrome/browser/policy/browser_signin_policy_handler.cc | 863 | --- chrome/browser/policy/browser_signin_policy_handler.cc.orig |
| 873 | +++ b/chrome/browser/policy/browser_signin_policy_handler.cc | 864 | +++ chrome/browser/policy/browser_signin_policy_handler.cc |
| 874 | @@ -15,7 +15,6 @@ | 865 | @@ -15,7 +15,6 @@ |
| 875 | #include "components/policy/core/common/policy_map.h" | 866 | #include "components/policy/core/common/policy_map.h" |
| 876 | #include "components/policy/policy_constants.h" | 867 | #include "components/policy/policy_constants.h" |
| @@ -879,13 +870,13 @@ | |||
| 879 | 870 | ||
| 880 | namespace policy { | 871 | namespace policy { |
| 881 | BrowserSigninPolicyHandler::BrowserSigninPolicyHandler(Schema chrome_schema) | 872 | BrowserSigninPolicyHandler::BrowserSigninPolicyHandler(Schema chrome_schema) |
| 882 | @@ -49,28 +48,18 @@ void BrowserSigninPolicyHandler::ApplyPo | 873 | @@ -48,28 +47,18 @@ void BrowserSigninPolicyHandler::ApplyPo |
| 883 | #endif | 874 | #endif |
| 884 | [[fallthrough]]; | 875 | FALLTHROUGH; |
| 885 | case BrowserSigninMode::kEnabled: | 876 | case BrowserSigninMode::kEnabled: |
| 886 | +#if !BUILDFLAG(IS_ANDROID) | 877 | +#if !defined(OS_ANDROID) |
| 887 | prefs->SetValue( | 878 | prefs->SetValue( |
| 888 | -#if BUILDFLAG(IS_ANDROID) | 879 | -#if defined(OS_ANDROID) |
| 889 | - // The new kSigninAllowedOnNextStartup pref is only used on Desktop. | 880 | - // The new kSigninAllowedOnNextStartup pref is only used on Desktop. |
| 890 | - // Keep the old kSigninAllowed pref for Android until the policy is | 881 | - // Keep the old kSigninAllowed pref for Android until the policy is |
| 891 | - // fully deprecated in M71 and can be removed. | 882 | - // fully deprecated in M71 and can be removed. |
| @@ -897,9 +888,9 @@ | |||
| 897 | +#endif | 888 | +#endif |
| 898 | break; | 889 | break; |
| 899 | case BrowserSigninMode::kDisabled: | 890 | case BrowserSigninMode::kDisabled: |
| 900 | +#if !BUILDFLAG(IS_ANDROID) | 891 | +#if !defined(OS_ANDROID) |
| 901 | prefs->SetValue( | 892 | prefs->SetValue( |
| 902 | -#if BUILDFLAG(IS_ANDROID) | 893 | -#if defined(OS_ANDROID) |
| 903 | - // The new kSigninAllowedOnNextStartup pref is only used on Desktop. | 894 | - // The new kSigninAllowedOnNextStartup pref is only used on Desktop. |
| 904 | - // Keep the old kSigninAllowed pref for Android until the policy is | 895 | - // Keep the old kSigninAllowed pref for Android until the policy is |
| 905 | - // fully deprecated in M71 and can be removed. | 896 | - // fully deprecated in M71 and can be removed. |
| @@ -912,12 +903,12 @@ | |||
| 912 | break; | 903 | break; |
| 913 | } | 904 | } |
| 914 | } | 905 | } |
| 915 | --- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc | 906 | --- chrome/browser/policy/configuration_policy_handler_list_factory.cc.orig |
| 916 | +++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc | 907 | +++ chrome/browser/policy/configuration_policy_handler_list_factory.cc |
| 917 | @@ -94,12 +94,9 @@ | 908 | @@ -83,12 +83,9 @@ |
| 909 | #include "components/policy/core/common/schema.h" | ||
| 910 | #include "components/policy/policy_constants.h" | ||
| 918 | #include "components/proxy_config/proxy_policy_handler.h" | 911 | #include "components/proxy_config/proxy_policy_handler.h" |
| 919 | #include "components/safe_browsing/buildflags.h" | ||
| 920 | #include "components/safe_browsing/content/common/file_type_policies_prefs.h" | ||
| 921 | -#include "components/safe_browsing/core/common/safe_browsing_policy_handler.h" | 912 | -#include "components/safe_browsing/core/common/safe_browsing_policy_handler.h" |
| 922 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 913 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 923 | #include "components/search_engines/default_search_policy_handler.h" | 914 | #include "components/search_engines/default_search_policy_handler.h" |
| @@ -927,76 +918,39 @@ | |||
| 927 | #include "components/spellcheck/spellcheck_buildflags.h" | 918 | #include "components/spellcheck/spellcheck_buildflags.h" |
| 928 | #include "components/sync/base/pref_names.h" | 919 | #include "components/sync/base/pref_names.h" |
| 929 | #include "components/sync/driver/sync_policy_handler.h" | 920 | #include "components/sync/driver/sync_policy_handler.h" |
| 930 | @@ -207,9 +204,6 @@ const PolicyToPreferenceMapEntry kSimple | 921 | @@ -209,15 +206,6 @@ const PolicyToPreferenceMapEntry kSimple |
| 931 | { key::kDefaultPopupsSetting, | 922 | { key::kQuicAllowed, |
| 932 | prefs::kManagedDefaultPopupsSetting, | 923 | prefs::kQuicAllowed, |
| 933 | base::Value::Type::INTEGER }, | ||
| 934 | - { key::kDisableSafeBrowsingProceedAnyway, | ||
| 935 | - prefs::kSafeBrowsingProceedAnywayDisabled, | ||
| 936 | - base::Value::Type::BOOLEAN }, | ||
| 937 | { key::kEditBookmarksEnabled, | ||
| 938 | bookmarks::prefs::kEditBookmarksEnabled, | ||
| 939 | base::Value::Type::BOOLEAN }, | 924 | base::Value::Type::BOOLEAN }, |
| 940 | @@ -230,9 +224,6 @@ const PolicyToPreferenceMapEntry kSimple | ||
| 941 | prefs::kPrintingEnabled, | ||
| 942 | base::Value::Type::BOOLEAN }, | ||
| 943 | #endif // BUILDFLAG(ENABLE_PRINTING) | ||
| 944 | - { key::kSafeBrowsingEnabled, | 925 | - { key::kSafeBrowsingEnabled, |
| 945 | - prefs::kSafeBrowsingEnabled, | 926 | - prefs::kSafeBrowsingEnabled, |
| 946 | - base::Value::Type::BOOLEAN }, | 927 | - base::Value::Type::BOOLEAN }, |
| 947 | { key::kSavingBrowserHistoryDisabled, | 928 | - { key::kSafeBrowsingForTrustedSourcesEnabled, |
| 948 | prefs::kSavingBrowserHistoryDisabled, | 929 | - prefs::kSafeBrowsingForTrustedSourcesEnabled, |
| 949 | base::Value::Type::BOOLEAN }, | 930 | - base::Value::Type::BOOLEAN }, |
| 950 | @@ -291,9 +282,6 @@ const PolicyToPreferenceMapEntry kSimple | 931 | - { key::kSafeBrowsingExtendedReportingEnabled, |
| 951 | { key::kAdsSettingForIntrusiveAdsSites, | 932 | - prefs::kSafeBrowsingScoutReportingEnabled, |
| 952 | prefs::kManagedDefaultAdsSetting, | ||
| 953 | base::Value::Type::INTEGER }, | ||
| 954 | - { key::kAdvancedProtectionAllowed, | ||
| 955 | - prefs::kAdvancedProtectionAllowed, | ||
| 956 | - base::Value::Type::BOOLEAN }, | 933 | - base::Value::Type::BOOLEAN }, |
| 957 | { key::kAllowCrossOriginAuthPrompt, | 934 | { key::kUrlKeyedAnonymizedDataCollectionEnabled, |
| 958 | prefs::kAllowCrossOriginAuthPrompt, | 935 | unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled, |
| 959 | base::Value::Type::BOOLEAN }, | 936 | base::Value::Type::BOOLEAN }, |
| 960 | @@ -482,15 +470,6 @@ const PolicyToPreferenceMapEntry kSimple | 937 | @@ -353,15 +341,6 @@ const PolicyToPreferenceMapEntry kSimple |
| 961 | { key::kPasswordDismissCompromisedAlertEnabled, | 938 | { key::kGloballyScopeHTTPAuthCacheEnabled, |
| 962 | password_manager::prefs::kPasswordDismissCompromisedAlertEnabled, | 939 | prefs::kGloballyScopeHTTPAuthCacheEnabled, |
| 963 | base::Value::Type::BOOLEAN }, | 940 | base::Value::Type::BOOLEAN }, |
| 964 | - { key::kPasswordProtectionChangePasswordURL, | ||
| 965 | - prefs::kPasswordProtectionChangePasswordURL, | ||
| 966 | - base::Value::Type::STRING }, | ||
| 967 | - { key::kPasswordProtectionLoginURLs, | ||
| 968 | - prefs::kPasswordProtectionLoginURLs, | ||
| 969 | - base::Value::Type::LIST }, | ||
| 970 | - { key::kPasswordProtectionWarningTrigger, | 941 | - { key::kPasswordProtectionWarningTrigger, |
| 971 | - prefs::kPasswordProtectionWarningTrigger, | 942 | - prefs::kPasswordProtectionWarningTrigger, |
| 972 | - base::Value::Type::INTEGER }, | 943 | - base::Value::Type::INTEGER }, |
| 973 | { key::kPolicyRefreshRate, | 944 | - { key::kPasswordProtectionLoginURLs, |
| 974 | policy_prefs::kUserPolicyRefreshRate, | 945 | - prefs::kPasswordProtectionLoginURLs, |
| 975 | base::Value::Type::INTEGER }, | ||
| 976 | @@ -526,9 +505,6 @@ const PolicyToPreferenceMapEntry kSimple | ||
| 977 | { key::kRestoreOnStartupURLs, | ||
| 978 | prefs::kURLsToRestoreOnStartup, | ||
| 979 | base::Value::Type::LIST }, | ||
| 980 | - { key::kSafeBrowsingAllowlistDomains, | ||
| 981 | - prefs::kSafeBrowsingAllowlistDomains, | ||
| 982 | - base::Value::Type::LIST }, | 946 | - base::Value::Type::LIST }, |
| 947 | - { key::kPasswordProtectionChangePasswordURL, | ||
| 948 | - prefs::kPasswordProtectionChangePasswordURL, | ||
| 949 | - base::Value::Type::STRING }, | ||
| 983 | { key::kSafeSitesFilterBehavior, | 950 | { key::kSafeSitesFilterBehavior, |
| 984 | policy_prefs::kSafeSitesFilterBehavior, | 951 | policy_prefs::kSafeSitesFilterBehavior, |
| 985 | base::Value::Type::INTEGER }, | 952 | base::Value::Type::INTEGER }, |
| 986 | @@ -653,12 +629,6 @@ const PolicyToPreferenceMapEntry kSimple | 953 | @@ -470,18 +449,12 @@ const PolicyToPreferenceMapEntry kSimple |
| 987 | { key::kAdditionalDnsQueryTypesEnabled, | ||
| 988 | prefs::kAdditionalDnsQueryTypesEnabled, | ||
| 989 | base::Value::Type::BOOLEAN }, | ||
| 990 | - { key::kSafeBrowsingForTrustedSourcesEnabled, | ||
| 991 | - prefs::kSafeBrowsingForTrustedSourcesEnabled, | ||
| 992 | - base::Value::Type::BOOLEAN }, | ||
| 993 | - { key::kSafeBrowsingExtendedReportingEnabled, | ||
| 994 | - prefs::kSafeBrowsingScoutReportingEnabled, | ||
| 995 | - base::Value::Type::BOOLEAN }, | ||
| 996 | { key::kForceGoogleSafeSearch, | ||
| 997 | prefs::kForceGoogleSafeSearch, | ||
| 998 | base::Value::Type::BOOLEAN }, | ||
| 999 | @@ -816,9 +786,6 @@ const PolicyToPreferenceMapEntry kSimple | ||
| 1000 | { key::kMaxConnectionsPerProxy, | 954 | { key::kMaxConnectionsPerProxy, |
| 1001 | prefs::kMaxConnectionsPerProxy, | 955 | prefs::kMaxConnectionsPerProxy, |
| 1002 | base::Value::Type::INTEGER }, | 956 | base::Value::Type::INTEGER }, |
| @@ -1006,10 +960,48 @@ | |||
| 1006 | { key::kDefaultWebBluetoothGuardSetting, | 960 | { key::kDefaultWebBluetoothGuardSetting, |
| 1007 | prefs::kManagedDefaultWebBluetoothGuardSetting, | 961 | prefs::kManagedDefaultWebBluetoothGuardSetting, |
| 1008 | base::Value::Type::INTEGER }, | 962 | base::Value::Type::INTEGER }, |
| 1009 | @@ -1782,12 +1749,6 @@ std::unique_ptr<ConfigurationPolicyHandl | 963 | { key::kDefaultMediaStreamSetting, |
| 1010 | SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED, | 964 | prefs::kManagedDefaultMediaStreamSetting, |
| 1011 | SimpleSchemaValidatingPolicyHandler::MANDATORY_ALLOWED)); | 965 | base::Value::Type::INTEGER }, |
| 1012 | 966 | - { key::kDisableSafeBrowsingProceedAnyway, | |
| 967 | - prefs::kSafeBrowsingProceedAnywayDisabled, | ||
| 968 | - base::Value::Type::BOOLEAN }, | ||
| 969 | { key::kCECPQ2Enabled, | ||
| 970 | prefs::kCECPQ2Enabled, | ||
| 971 | base::Value::Type::BOOLEAN }, | ||
| 972 | @@ -684,9 +657,6 @@ const PolicyToPreferenceMapEntry kSimple | ||
| 973 | { key::kIntranetRedirectBehavior, | ||
| 974 | omnibox::kIntranetRedirectBehavior, | ||
| 975 | base::Value::Type::INTEGER }, | ||
| 976 | - { key::kAdvancedProtectionAllowed, | ||
| 977 | - prefs::kAdvancedProtectionAllowed, | ||
| 978 | - base::Value::Type::BOOLEAN }, | ||
| 979 | { key::kAccessibilityImageLabelsEnabled, | ||
| 980 | prefs::kAccessibilityImageLabelsEnabled, | ||
| 981 | base::Value::Type::BOOLEAN }, | ||
| 982 | @@ -1642,8 +1612,6 @@ std::unique_ptr<ConfigurationPolicyHandl | ||
| 983 | handlers->AddHandler(std::make_unique<JavascriptPolicyHandler>()); | ||
| 984 | handlers->AddHandler(std::make_unique<NetworkPredictionPolicyHandler>()); | ||
| 985 | handlers->AddHandler(std::make_unique<RestoreOnStartupPolicyHandler>()); | ||
| 986 | - handlers->AddHandler( | ||
| 987 | - std::make_unique<safe_browsing::SafeBrowsingPolicyHandler>()); | ||
| 988 | handlers->AddHandler(std::make_unique<SimpleDeprecatingPolicyHandler>( | ||
| 989 | std::make_unique<SimplePolicyHandler>(key::kAuthServerWhitelist, | ||
| 990 | prefs::kAuthServerAllowlist, | ||
| 991 | @@ -1667,9 +1635,6 @@ std::unique_ptr<ConfigurationPolicyHandl | ||
| 992 | key::kWindowOcclusionEnabled, | ||
| 993 | policy::policy_prefs::kNativeWindowOcclusionEnabled, | ||
| 994 | base::Value::Type::BOOLEAN))); | ||
| 995 | - handlers->AddHandler(std::make_unique<SimplePolicyHandler>( | ||
| 996 | - key::kSafeBrowsingAllowlistDomains, prefs::kSafeBrowsingAllowlistDomains, | ||
| 997 | - base::Value::Type::LIST)); | ||
| 998 | handlers->AddHandler(std::make_unique<syncer::SyncPolicyHandler>()); | ||
| 999 | handlers->AddHandler(std::make_unique<BrowsingHistoryPolicyHandler>()); | ||
| 1000 | |||
| 1001 | @@ -1762,12 +1727,6 @@ std::unique_ptr<ConfigurationPolicyHandl | ||
| 1002 | key::kOnSecurityEventEnterpriseConnector, | ||
| 1003 | enterprise_connectors::kOnSecurityEventPref, | ||
| 1004 | enterprise_connectors::kOnSecurityEventScopePref, chrome_schema)); | ||
| 1013 | - handlers->AddHandler( | 1005 | - handlers->AddHandler( |
| 1014 | - std::make_unique< | 1006 | - std::make_unique< |
| 1015 | - enterprise_connectors::EnterpriseConnectorsPolicyHandler>( | 1007 | - enterprise_connectors::EnterpriseConnectorsPolicyHandler>( |
| @@ -1017,56 +1009,55 @@ | |||
| 1017 | - prefs::kSafeBrowsingEnterpriseRealTimeUrlCheckMode, | 1009 | - prefs::kSafeBrowsingEnterpriseRealTimeUrlCheckMode, |
| 1018 | - prefs::kSafeBrowsingEnterpriseRealTimeUrlCheckScope, chrome_schema)); | 1010 | - prefs::kSafeBrowsingEnterpriseRealTimeUrlCheckScope, chrome_schema)); |
| 1019 | 1011 | ||
| 1020 | handlers->AddHandler( | 1012 | handlers->AddHandler(std::make_unique<BrowsingDataLifetimePolicyHandler>( |
| 1021 | std::make_unique<ManagedAccountRestrictionsPolicyHandler>(chrome_schema)); | 1013 | key::kClearBrowsingDataOnExitList, |
| 1022 | @@ -1959,17 +1920,6 @@ std::unique_ptr<ConfigurationPolicyHandl | 1014 | @@ -1806,17 +1765,6 @@ std::unique_ptr<ConfigurationPolicyHandl |
| 1023 | signin_legacy_policies.push_back(std::make_unique<SimplePolicyHandler>( | 1015 | signin_legacy_policies.push_back(std::make_unique<SimplePolicyHandler>( |
| 1024 | key::kForceBrowserSignin, prefs::kForceBrowserSignin, | 1016 | key::kForceBrowserSignin, prefs::kForceBrowserSignin, |
| 1025 | base::Value::Type::BOOLEAN)); | 1017 | base::Value::Type::BOOLEAN)); |
| 1026 | - signin_legacy_policies.push_back(std::make_unique<SimplePolicyHandler>( | 1018 | - signin_legacy_policies.push_back(std::make_unique<SimplePolicyHandler>( |
| 1027 | - key::kSigninAllowed, | 1019 | - key::kSigninAllowed, |
| 1028 | -#if BUILDFLAG(IS_ANDROID) | 1020 | -#if defined(OS_ANDROID) |
| 1029 | - // The new kSigninAllowedOnNextStartup pref is only used on Desktop. | 1021 | - // The new kSigninAllowedOnNextStartup pref is only used on Desktop. |
| 1030 | - // Keep the old kSigninAllowed pref for Android until the policy is | 1022 | - // Keep the old kSigninAllowed pref for Android until the policy is |
| 1031 | - // fully deprecated in M71 and can be removed. | 1023 | - // fully deprecated in M71 and can be removed. |
| 1032 | - prefs::kSigninAllowed, | 1024 | - prefs::kSigninAllowed, |
| 1033 | -#else // BUILDFLAG(IS_ANDROID) | 1025 | -#else // defined(OS_ANDROID) |
| 1034 | - prefs::kSigninAllowedOnNextStartup, | 1026 | - prefs::kSigninAllowedOnNextStartup, |
| 1035 | -#endif // BUILDFLAG(IS_ANDROID) | 1027 | -#endif // defined(OS_ANDROID) |
| 1036 | - base::Value::Type::BOOLEAN)); | 1028 | - base::Value::Type::BOOLEAN)); |
| 1037 | handlers->AddHandler(std::make_unique<LegacyPoliciesDeprecatingPolicyHandler>( | 1029 | handlers->AddHandler(std::make_unique<LegacyPoliciesDeprecatingPolicyHandler>( |
| 1038 | std::move(signin_legacy_policies), | 1030 | std::move(signin_legacy_policies), |
| 1039 | std::make_unique<BrowserSigninPolicyHandler>(chrome_schema))); | 1031 | std::make_unique<BrowserSigninPolicyHandler>(chrome_schema))); |
| 1040 | --- a/chrome/browser/prefs/browser_prefs.cc | 1032 | --- chrome/browser/prefs/browser_prefs.cc.orig |
| 1041 | +++ b/chrome/browser/prefs/browser_prefs.cc | 1033 | +++ chrome/browser/prefs/browser_prefs.cc |
| 1042 | @@ -134,7 +134,6 @@ | 1034 | @@ -139,7 +139,6 @@ |
| 1035 | #include "components/prefs/pref_service.h" | ||
| 1043 | #include "components/privacy_sandbox/privacy_sandbox_prefs.h" | 1036 | #include "components/privacy_sandbox/privacy_sandbox_prefs.h" |
| 1044 | #include "components/proxy_config/pref_proxy_config_tracker_impl.h" | 1037 | #include "components/proxy_config/pref_proxy_config_tracker_impl.h" |
| 1045 | #include "components/safe_browsing/content/common/file_type_policies_prefs.h" | ||
| 1046 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 1038 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 1047 | #include "components/search_engines/template_url_prepopulate_data.h" | 1039 | #include "components/search_engines/template_url_prepopulate_data.h" |
| 1048 | #include "components/security_interstitials/content/insecure_form_blocking_page.h" | 1040 | #include "components/security_interstitials/content/insecure_form_blocking_page.h" |
| 1049 | #include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h" | 1041 | #include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h" |
| 1050 | @@ -1014,7 +1013,6 @@ void RegisterLocalState(PrefRegistrySimp | 1042 | @@ -921,7 +920,6 @@ void RegisterLocalState(PrefRegistrySimp |
| 1051 | ProfileNetworkContextService::RegisterLocalStatePrefs(registry); | 1043 | ProfileNetworkContextService::RegisterLocalStatePrefs(registry); |
| 1052 | profiles::RegisterPrefs(registry); | 1044 | profiles::RegisterPrefs(registry); |
| 1053 | RegisterScreenshotPrefs(registry); | 1045 | RegisterScreenshotPrefs(registry); |
| 1054 | - safe_browsing::RegisterLocalStatePrefs(registry); | 1046 | - safe_browsing::RegisterLocalStatePrefs(registry); |
| 1055 | secure_origin_allowlist::RegisterPrefs(registry); | 1047 | secure_origin_allowlist::RegisterPrefs(registry); |
| 1056 | #if !BUILDFLAG(IS_ANDROID) | 1048 | #if !defined(OS_ANDROID) |
| 1057 | SerialPolicyAllowedPorts::RegisterPrefs(registry); | 1049 | SerialPolicyAllowedPorts::RegisterPrefs(registry); |
| 1058 | @@ -1275,8 +1273,6 @@ void RegisterProfilePrefs(user_prefs::Pr | 1050 | @@ -1171,7 +1169,6 @@ void RegisterProfilePrefs(user_prefs::Pr |
| 1059 | PushMessagingAppIdentifier::RegisterProfilePrefs(registry); | 1051 | PushMessagingAppIdentifier::RegisterProfilePrefs(registry); |
| 1060 | QuietNotificationPermissionUiState::RegisterProfilePrefs(registry); | 1052 | QuietNotificationPermissionUiState::RegisterProfilePrefs(registry); |
| 1061 | RegisterBrowserUserPrefs(registry); | 1053 | RegisterBrowserUserPrefs(registry); |
| 1062 | - safe_browsing::file_type::RegisterProfilePrefs(registry); | ||
| 1063 | - safe_browsing::RegisterProfilePrefs(registry); | 1054 | - safe_browsing::RegisterProfilePrefs(registry); |
| 1064 | SearchPrefetchService::RegisterProfilePrefs(registry); | 1055 | SearchPrefetchService::RegisterProfilePrefs(registry); |
| 1065 | blocked_content::SafeBrowsingTriggeredPopupBlocker::RegisterProfilePrefs( | 1056 | blocked_content::SafeBrowsingTriggeredPopupBlocker::RegisterProfilePrefs( |
| 1066 | registry); | 1057 | registry); |
| 1067 | --- a/chrome/browser/prefs/chrome_command_line_pref_store.cc | 1058 | --- chrome/browser/prefs/chrome_command_line_pref_store.cc.orig |
| 1068 | +++ b/chrome/browser/prefs/chrome_command_line_pref_store.cc | 1059 | +++ chrome/browser/prefs/chrome_command_line_pref_store.cc |
| 1069 | @@ -25,7 +25,6 @@ | 1060 | @@ -31,7 +31,6 @@ |
| 1070 | #include "components/language/core/browser/pref_names.h" | 1061 | #include "components/language/core/browser/pref_names.h" |
| 1071 | #include "components/proxy_config/proxy_config_dictionary.h" | 1062 | #include "components/proxy_config/proxy_config_dictionary.h" |
| 1072 | #include "components/proxy_config/proxy_config_pref_names.h" | 1063 | #include "components/proxy_config/proxy_config_pref_names.h" |
| @@ -1074,18 +1065,18 @@ | |||
| 1074 | #include "components/safe_browsing/core/common/safebrowsing_switches.h" | 1065 | #include "components/safe_browsing/core/common/safebrowsing_switches.h" |
| 1075 | #include "components/sync/base/pref_names.h" | 1066 | #include "components/sync/base/pref_names.h" |
| 1076 | #include "content/public/common/content_switches.h" | 1067 | #include "content/public/common/content_switches.h" |
| 1077 | @@ -75,8 +74,6 @@ const CommandLinePrefStore::BooleanSwitc | 1068 | @@ -78,8 +77,6 @@ const CommandLinePrefStore::BooleanSwitc |
| 1078 | {switches::kAllowCrossOriginAuthPrompt, | 1069 | {switches::kAllowCrossOriginAuthPrompt, |
| 1079 | prefs::kAllowCrossOriginAuthPrompt, true}, | 1070 | prefs::kAllowCrossOriginAuthPrompt, true}, |
| 1080 | {switches::kDisablePrintPreview, prefs::kPrintPreviewDisabled, true}, | 1071 | {switches::kDisablePrintPreview, prefs::kPrintPreviewDisabled, true}, |
| 1081 | - {safe_browsing::switches::kSbEnableEnhancedProtection, | 1072 | - {safe_browsing::switches::kSbEnableEnhancedProtection, |
| 1082 | - prefs::kSafeBrowsingEnhanced, true}, | 1073 | - prefs::kSafeBrowsingEnhanced, true}, |
| 1083 | #if BUILDFLAG(IS_CHROMEOS_ASH) | 1074 | #if BUILDFLAG(IS_CHROMEOS_ASH) |
| 1084 | {ash::switches::kEnableTouchpadThreeFingerClick, | 1075 | {chromeos::switches::kEnableTouchpadThreeFingerClick, |
| 1085 | prefs::kEnableTouchpadThreeFingerClick, true}, | 1076 | prefs::kEnableTouchpadThreeFingerClick, true}, |
| 1086 | --- a/chrome/browser/prefs/chrome_pref_service_factory.cc | 1077 | --- chrome/browser/prefs/chrome_pref_service_factory.cc.orig |
| 1087 | +++ b/chrome/browser/prefs/chrome_pref_service_factory.cc | 1078 | +++ chrome/browser/prefs/chrome_pref_service_factory.cc |
| 1088 | @@ -49,10 +49,8 @@ | 1079 | @@ -48,10 +48,8 @@ |
| 1089 | #include "components/prefs/pref_service.h" | 1080 | #include "components/prefs/pref_service.h" |
| 1090 | #include "components/prefs/pref_store.h" | 1081 | #include "components/prefs/pref_store.h" |
| 1091 | #include "components/prefs/pref_value_store.h" | 1082 | #include "components/prefs/pref_value_store.h" |
| @@ -1096,7 +1087,7 @@ | |||
| 1096 | #include "components/sync/base/model_type.h" | 1087 | #include "components/sync/base/model_type.h" |
| 1097 | #include "components/sync/base/pref_names.h" | 1088 | #include "components/sync/base/pref_names.h" |
| 1098 | #include "components/sync_preferences/pref_model_associator.h" | 1089 | #include "components/sync_preferences/pref_model_associator.h" |
| 1099 | @@ -122,8 +120,6 @@ const prefs::TrackedPreferenceMetadata k | 1090 | @@ -121,8 +119,6 @@ const prefs::TrackedPreferenceMetadata k |
| 1100 | {5, extensions::pref_names::kExtensions, EnforcementLevel::NO_ENFORCEMENT, | 1091 | {5, extensions::pref_names::kExtensions, EnforcementLevel::NO_ENFORCEMENT, |
| 1101 | PrefTrackingStrategy::SPLIT, ValueType::IMPERSONAL}, | 1092 | PrefTrackingStrategy::SPLIT, ValueType::IMPERSONAL}, |
| 1102 | #endif | 1093 | #endif |
| @@ -1104,17 +1095,17 @@ | |||
| 1104 | - PrefTrackingStrategy::ATOMIC, ValueType::PERSONAL}, | 1095 | - PrefTrackingStrategy::ATOMIC, ValueType::PERSONAL}, |
| 1105 | {7, prefs::kSearchProviderOverrides, EnforcementLevel::ENFORCE_ON_LOAD, | 1096 | {7, prefs::kSearchProviderOverrides, EnforcementLevel::ENFORCE_ON_LOAD, |
| 1106 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, | 1097 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, |
| 1107 | #if !BUILDFLAG(IS_ANDROID) | 1098 | #if !defined(OS_ANDROID) |
| 1108 | @@ -147,8 +143,6 @@ const prefs::TrackedPreferenceMetadata k | 1099 | @@ -146,8 +142,6 @@ const prefs::TrackedPreferenceMetadata k |
| 1109 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, | 1100 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, |
| 1110 | // kSyncRemainingRollbackTries is deprecated and will be removed a few | 1101 | // kSyncRemainingRollbackTries is deprecated and will be removed a few |
| 1111 | // releases after M50. | 1102 | // releases after M50. |
| 1112 | - {18, prefs::kSafeBrowsingIncidentsSent, EnforcementLevel::ENFORCE_ON_LOAD, | 1103 | - {18, prefs::kSafeBrowsingIncidentsSent, EnforcementLevel::ENFORCE_ON_LOAD, |
| 1113 | - PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, | 1104 | - PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, |
| 1114 | #if BUILDFLAG(IS_WIN) | 1105 | #if defined(OS_WIN) |
| 1115 | {19, prefs::kSwReporterPromptVersion, EnforcementLevel::ENFORCE_ON_LOAD, | 1106 | {19, prefs::kSwReporterPromptVersion, EnforcementLevel::ENFORCE_ON_LOAD, |
| 1116 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, | 1107 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, |
| 1117 | @@ -157,10 +151,6 @@ const prefs::TrackedPreferenceMetadata k | 1108 | @@ -156,10 +150,6 @@ const prefs::TrackedPreferenceMetadata k |
| 1118 | {22, prefs::kSwReporterPromptSeed, EnforcementLevel::ENFORCE_ON_LOAD, | 1109 | {22, prefs::kSwReporterPromptSeed, EnforcementLevel::ENFORCE_ON_LOAD, |
| 1119 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, | 1110 | PrefTrackingStrategy::ATOMIC, ValueType::IMPERSONAL}, |
| 1120 | #endif | 1111 | #endif |
| @@ -1122,11 +1113,11 @@ | |||
| 1122 | - PrefTrackingStrategy::ATOMIC, ValueType::PERSONAL}, | 1113 | - PrefTrackingStrategy::ATOMIC, ValueType::PERSONAL}, |
| 1123 | - {24, prefs::kGoogleServicesLastAccountId, EnforcementLevel::ENFORCE_ON_LOAD, | 1114 | - {24, prefs::kGoogleServicesLastAccountId, EnforcementLevel::ENFORCE_ON_LOAD, |
| 1124 | - PrefTrackingStrategy::ATOMIC, ValueType::PERSONAL}, | 1115 | - PrefTrackingStrategy::ATOMIC, ValueType::PERSONAL}, |
| 1125 | #if BUILDFLAG(IS_WIN) | 1116 | #if defined(OS_WIN) |
| 1126 | {25, prefs::kSettingsResetPromptPromptWave, | 1117 | {25, prefs::kSettingsResetPromptPromptWave, |
| 1127 | EnforcementLevel::ENFORCE_ON_LOAD, PrefTrackingStrategy::ATOMIC, | 1118 | EnforcementLevel::ENFORCE_ON_LOAD, PrefTrackingStrategy::ATOMIC, |
| 1128 | --- a/chrome/browser/prefs/pref_functional_browsertest.cc | 1119 | --- chrome/browser/prefs/pref_functional_browsertest.cc.orig |
| 1129 | +++ b/chrome/browser/prefs/pref_functional_browsertest.cc | 1120 | +++ chrome/browser/prefs/pref_functional_browsertest.cc |
| 1130 | @@ -24,7 +24,6 @@ | 1121 | @@ -24,7 +24,6 @@ |
| 1131 | #include "components/content_settings/core/common/content_settings_types.h" | 1122 | #include "components/content_settings/core/common/content_settings_types.h" |
| 1132 | #include "components/content_settings/core/common/pref_names.h" | 1123 | #include "components/content_settings/core/common/pref_names.h" |
| @@ -1136,8 +1127,8 @@ | |||
| 1136 | #include "content/public/browser/web_contents.h" | 1127 | #include "content/public/browser/web_contents.h" |
| 1137 | #include "content/public/test/browser_test.h" | 1128 | #include "content/public/test/browser_test.h" |
| 1138 | @@ -220,9 +219,6 @@ IN_PROC_BROWSER_TEST_F(PrefsFunctionalTe | 1129 | @@ -220,9 +219,6 @@ IN_PROC_BROWSER_TEST_F(PrefsFunctionalTe |
| 1139 | prefetch::SetPreloadPagesState(prefs, | 1130 | prefs->SetInteger(prefs::kNetworkPredictionOptions, |
| 1140 | prefetch::PreloadPagesState::kNoPreloading); | 1131 | chrome_browser_net::NETWORK_PREDICTION_NEVER); |
| 1141 | 1132 | ||
| 1142 | - EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); | 1133 | - EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); |
| 1143 | - prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); | 1134 | - prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); |
| @@ -1147,25 +1138,25 @@ | |||
| 1147 | 1138 | ||
| 1148 | @@ -236,7 +232,6 @@ IN_PROC_BROWSER_TEST_F(PrefsFunctionalTe | 1139 | @@ -236,7 +232,6 @@ IN_PROC_BROWSER_TEST_F(PrefsFunctionalTe |
| 1149 | 1140 | ||
| 1150 | EXPECT_EQ(prefetch::PreloadPagesState::kNoPreloading, | 1141 | EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_NEVER, |
| 1151 | prefetch::GetPreloadPagesState(*prefs)); | 1142 | prefs->GetInteger(prefs::kNetworkPredictionOptions)); |
| 1152 | - EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); | 1143 | - EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); |
| 1153 | EXPECT_FALSE( | 1144 | EXPECT_FALSE( |
| 1154 | prefs->GetBoolean(embedder_support::kAlternateErrorPagesEnabled)); | 1145 | prefs->GetBoolean(embedder_support::kAlternateErrorPagesEnabled)); |
| 1155 | EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); | 1146 | EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); |
| 1156 | --- a/chrome/browser/profiles/gaia_info_update_service.cc | 1147 | --- chrome/browser/profiles/gaia_info_update_service.cc.orig |
| 1157 | +++ b/chrome/browser/profiles/gaia_info_update_service.cc | 1148 | +++ chrome/browser/profiles/gaia_info_update_service.cc |
| 1158 | @@ -20,7 +20,6 @@ | 1149 | @@ -19,7 +19,6 @@ |
| 1150 | #include "chrome/common/pref_names.h" | ||
| 1159 | #include "components/prefs/pref_service.h" | 1151 | #include "components/prefs/pref_service.h" |
| 1160 | #include "components/signin/public/base/avatar_icon_util.h" | 1152 | #include "components/signin/public/base/avatar_icon_util.h" |
| 1161 | #include "components/signin/public/base/consent_level.h" | ||
| 1162 | -#include "components/signin/public/base/signin_pref_names.h" | 1153 | -#include "components/signin/public/base/signin_pref_names.h" |
| 1163 | #include "components/signin/public/identity_manager/account_info.h" | 1154 | #include "components/signin/public/identity_manager/account_info.h" |
| 1164 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" | 1155 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" |
| 1165 | #include "content/public/browser/notification_details.h" | 1156 | #include "components/signin/public/identity_manager/consent_level.h" |
| 1166 | --- a/chrome/browser/profiles/gaia_info_update_service_unittest.cc | 1157 | --- chrome/browser/profiles/gaia_info_update_service_unittest.cc.orig |
| 1167 | +++ b/chrome/browser/profiles/gaia_info_update_service_unittest.cc | 1158 | +++ chrome/browser/profiles/gaia_info_update_service_unittest.cc |
| 1168 | @@ -28,7 +28,6 @@ | 1159 | @@ -27,7 +27,6 @@ |
| 1169 | #include "chrome/test/base/testing_profile_manager.h" | 1160 | #include "chrome/test/base/testing_profile_manager.h" |
| 1170 | #include "components/prefs/pref_service.h" | 1161 | #include "components/prefs/pref_service.h" |
| 1171 | #include "components/profile_metrics/state.h" | 1162 | #include "components/profile_metrics/state.h" |
| @@ -1173,9 +1164,9 @@ | |||
| 1173 | #include "components/signin/public/identity_manager/account_info.h" | 1164 | #include "components/signin/public/identity_manager/account_info.h" |
| 1174 | #include "components/sync_preferences/pref_service_syncable.h" | 1165 | #include "components/sync_preferences/pref_service_syncable.h" |
| 1175 | #include "content/public/test/browser_task_environment.h" | 1166 | #include "content/public/test/browser_task_environment.h" |
| 1176 | --- a/chrome/browser/profiles/profile_attributes_entry.cc | 1167 | --- chrome/browser/profiles/profile_attributes_entry.cc.orig |
| 1177 | +++ b/chrome/browser/profiles/profile_attributes_entry.cc | 1168 | +++ chrome/browser/profiles/profile_attributes_entry.cc |
| 1178 | @@ -26,7 +26,6 @@ | 1169 | @@ -29,7 +29,6 @@ |
| 1179 | #include "components/prefs/pref_service.h" | 1170 | #include "components/prefs/pref_service.h" |
| 1180 | #include "components/prefs/scoped_user_pref_update.h" | 1171 | #include "components/prefs/scoped_user_pref_update.h" |
| 1181 | #include "components/profile_metrics/state.h" | 1172 | #include "components/profile_metrics/state.h" |
| @@ -1183,7 +1174,7 @@ | |||
| 1183 | #include "components/signin/public/identity_manager/account_info.h" | 1174 | #include "components/signin/public/identity_manager/account_info.h" |
| 1184 | #include "third_party/abseil-cpp/absl/types/optional.h" | 1175 | #include "third_party/abseil-cpp/absl/types/optional.h" |
| 1185 | #include "ui/base/resource/resource_bundle.h" | 1176 | #include "ui/base/resource/resource_bundle.h" |
| 1186 | @@ -486,7 +485,7 @@ bool ProfileAttributesEntry::IsUsingDefa | 1177 | @@ -490,7 +489,7 @@ bool ProfileAttributesEntry::IsUsingDefa |
| 1187 | } | 1178 | } |
| 1188 | 1179 | ||
| 1189 | bool ProfileAttributesEntry::IsSignedInWithCredentialProvider() const { | 1180 | bool ProfileAttributesEntry::IsSignedInWithCredentialProvider() const { |
| @@ -1192,7 +1183,7 @@ | |||
| 1192 | } | 1183 | } |
| 1193 | 1184 | ||
| 1194 | size_t ProfileAttributesEntry::GetAvatarIconIndex() const { | 1185 | size_t ProfileAttributesEntry::GetAvatarIconIndex() const { |
| 1195 | @@ -666,9 +665,6 @@ void ProfileAttributesEntry::SetLastDown | 1186 | @@ -672,9 +671,6 @@ void ProfileAttributesEntry::SetLastDown |
| 1196 | } | 1187 | } |
| 1197 | 1188 | ||
| 1198 | void ProfileAttributesEntry::SetSignedInWithCredentialProvider(bool value) { | 1189 | void ProfileAttributesEntry::SetSignedInWithCredentialProvider(bool value) { |
| @@ -1202,9 +1193,9 @@ | |||
| 1202 | } | 1193 | } |
| 1203 | 1194 | ||
| 1204 | void ProfileAttributesEntry::LockForceSigninProfile(bool is_lock) { | 1195 | void ProfileAttributesEntry::LockForceSigninProfile(bool is_lock) { |
| 1205 | --- a/chrome/browser/profiles/profile_attributes_storage.cc | 1196 | --- chrome/browser/profiles/profile_attributes_storage.cc.orig |
| 1206 | +++ b/chrome/browser/profiles/profile_attributes_storage.cc | 1197 | +++ chrome/browser/profiles/profile_attributes_storage.cc |
| 1207 | @@ -38,7 +38,6 @@ | 1198 | @@ -36,7 +36,6 @@ |
| 1208 | #include "components/prefs/scoped_user_pref_update.h" | 1199 | #include "components/prefs/scoped_user_pref_update.h" |
| 1209 | #include "components/profile_metrics/state.h" | 1200 | #include "components/profile_metrics/state.h" |
| 1210 | #include "components/signin/public/base/persistent_repeating_timer.h" | 1201 | #include "components/signin/public/base/persistent_repeating_timer.h" |
| @@ -1212,7 +1203,7 @@ | |||
| 1212 | #include "content/public/browser/browser_task_traits.h" | 1203 | #include "content/public/browser/browser_task_traits.h" |
| 1213 | #include "content/public/browser/browser_thread.h" | 1204 | #include "content/public/browser/browser_thread.h" |
| 1214 | #include "third_party/icu/source/i18n/unicode/coll.h" | 1205 | #include "third_party/icu/source/i18n/unicode/coll.h" |
| 1215 | @@ -376,8 +375,6 @@ void ProfileAttributesStorage::AddProfil | 1206 | @@ -374,8 +373,6 @@ void ProfileAttributesStorage::AddProfil |
| 1216 | if (params.account_id.HasAccountIdKey()) | 1207 | if (params.account_id.HasAccountIdKey()) |
| 1217 | info.SetStringKey(ProfileAttributesEntry::kAccountIdKey, | 1208 | info.SetStringKey(ProfileAttributesEntry::kAccountIdKey, |
| 1218 | params.account_id.GetAccountIdKey()); | 1209 | params.account_id.GetAccountIdKey()); |
| @@ -1221,9 +1212,9 @@ | |||
| 1221 | attributes->SetKey(key, std::move(info)); | 1212 | attributes->SetKey(key, std::move(info)); |
| 1222 | 1213 | ||
| 1223 | ProfileAttributesEntry* entry = InitEntryWithKey(key, params.is_omitted); | 1214 | ProfileAttributesEntry* entry = InitEntryWithKey(key, params.is_omitted); |
| 1224 | --- a/chrome/browser/profiles/profile_impl.cc | 1215 | --- chrome/browser/profiles/profile_impl.cc.orig |
| 1225 | +++ b/chrome/browser/profiles/profile_impl.cc | 1216 | +++ chrome/browser/profiles/profile_impl.cc |
| 1226 | @@ -149,7 +149,6 @@ | 1217 | @@ -150,7 +150,6 @@ |
| 1227 | #include "components/prefs/scoped_user_pref_update.h" | 1218 | #include "components/prefs/scoped_user_pref_update.h" |
| 1228 | #include "components/profile_metrics/browser_profile_type.h" | 1219 | #include "components/profile_metrics/browser_profile_type.h" |
| 1229 | #include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h" | 1220 | #include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h" |
| @@ -1231,17 +1222,17 @@ | |||
| 1231 | #include "components/signin/public/identity_manager/identity_manager.h" | 1222 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 1232 | #include "components/site_isolation/site_isolation_policy.h" | 1223 | #include "components/site_isolation/site_isolation_policy.h" |
| 1233 | #include "components/spellcheck/spellcheck_buildflags.h" | 1224 | #include "components/spellcheck/spellcheck_buildflags.h" |
| 1234 | --- a/chrome/browser/profiles/profile_manager.cc | 1225 | --- chrome/browser/profiles/profile_manager.cc.orig |
| 1235 | +++ b/chrome/browser/profiles/profile_manager.cc | 1226 | +++ chrome/browser/profiles/profile_manager.cc |
| 1236 | @@ -93,7 +93,6 @@ | 1227 | @@ -94,7 +94,6 @@ |
| 1237 | #include "components/signin/public/base/consent_level.h" | 1228 | #include "components/search_engines/default_search_manager.h" |
| 1238 | #include "components/signin/public/base/signin_buildflags.h" | 1229 | #include "components/signin/public/base/signin_buildflags.h" |
| 1239 | #include "components/signin/public/base/signin_metrics.h" | 1230 | #include "components/signin/public/base/signin_metrics.h" |
| 1240 | -#include "components/signin/public/base/signin_pref_names.h" | 1231 | -#include "components/signin/public/base/signin_pref_names.h" |
| 1232 | #include "components/signin/public/identity_manager/consent_level.h" | ||
| 1241 | #include "components/signin/public/identity_manager/identity_manager.h" | 1233 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 1242 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | 1234 | #include "components/signin/public/identity_manager/primary_account_mutator.h" |
| 1243 | #include "components/sync/base/stop_source.h" | 1235 | @@ -2105,8 +2104,7 @@ void ProfileManager::AddProfileToStorage |
| 1244 | @@ -2228,8 +2227,7 @@ void ProfileManager::AddProfileToStorage | ||
| 1245 | entry->SetAuthInfo(account_info.gaia, username, | 1236 | entry->SetAuthInfo(account_info.gaia, username, |
| 1246 | is_consented_primary_account); | 1237 | is_consented_primary_account); |
| 1247 | 1238 | ||
| @@ -1249,9 +1240,9 @@ | |||
| 1249 | - prefs::kSignedInWithCredentialProvider)); | 1240 | - prefs::kSignedInWithCredentialProvider)); |
| 1250 | + entry->SetSignedInWithCredentialProvider(false); | 1241 | + entry->SetSignedInWithCredentialProvider(false); |
| 1251 | 1242 | ||
| 1252 | #if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH) | 1243 | #if !defined(OS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH) |
| 1253 | // Sign out if force-sign-in policy is enabled and profile is not signed | 1244 | // Sign out if force-sign-in policy is enabled and profile is not signed |
| 1254 | @@ -2284,14 +2282,13 @@ void ProfileManager::AddProfileToStorage | 1245 | @@ -2161,14 +2159,13 @@ void ProfileManager::AddProfileToStorage |
| 1255 | 1246 | ||
| 1256 | init_params.is_ephemeral = IsEphemeral(profile); | 1247 | init_params.is_ephemeral = IsEphemeral(profile); |
| 1257 | init_params.is_signed_in_with_credential_provider = | 1248 | init_params.is_signed_in_with_credential_provider = |
| @@ -1267,9 +1258,9 @@ | |||
| 1267 | prefs->SetBoolean(bookmarks::prefs::kEditBookmarksEnabled, false); | 1258 | prefs->SetBoolean(bookmarks::prefs::kEditBookmarksEnabled, false); |
| 1268 | prefs->SetBoolean(bookmarks::prefs::kShowBookmarkBar, false); | 1259 | prefs->SetBoolean(bookmarks::prefs::kShowBookmarkBar, false); |
| 1269 | prefs->ClearPref(DefaultSearchManager::kDefaultSearchProviderDataPrefName); | 1260 | prefs->ClearPref(DefaultSearchManager::kDefaultSearchProviderDataPrefName); |
| 1270 | --- a/chrome/browser/profiles/profile_window.cc | 1261 | --- chrome/browser/profiles/profile_window.cc.orig |
| 1271 | +++ b/chrome/browser/profiles/profile_window.cc | 1262 | +++ chrome/browser/profiles/profile_window.cc |
| 1272 | @@ -41,7 +41,6 @@ | 1263 | @@ -40,7 +40,6 @@ |
| 1273 | #include "chrome/common/url_constants.h" | 1264 | #include "chrome/common/url_constants.h" |
| 1274 | #include "components/flags_ui/pref_service_flags_storage.h" | 1265 | #include "components/flags_ui/pref_service_flags_storage.h" |
| 1275 | #include "components/prefs/pref_service.h" | 1266 | #include "components/prefs/pref_service.h" |
| @@ -1277,8 +1268,8 @@ | |||
| 1277 | #include "components/signin/public/identity_manager/account_info.h" | 1268 | #include "components/signin/public/identity_manager/account_info.h" |
| 1278 | #include "components/signin/public/identity_manager/identity_manager.h" | 1269 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 1279 | #include "content/public/browser/browser_thread.h" | 1270 | #include "content/public/browser/browser_thread.h" |
| 1280 | --- a/chrome/browser/profiles/profiles_state.cc | 1271 | --- chrome/browser/profiles/profiles_state.cc.orig |
| 1281 | +++ b/chrome/browser/profiles/profiles_state.cc | 1272 | +++ chrome/browser/profiles/profiles_state.cc |
| 1282 | @@ -42,7 +42,6 @@ | 1273 | @@ -42,7 +42,6 @@ |
| 1283 | #include <algorithm> | 1274 | #include <algorithm> |
| 1284 | #include "chrome/browser/profiles/gaia_info_update_service.h" | 1275 | #include "chrome/browser/profiles/gaia_info_update_service.h" |
| @@ -1287,24 +1278,24 @@ | |||
| 1287 | #endif | 1278 | #endif |
| 1288 | 1279 | ||
| 1289 | #if BUILDFLAG(IS_CHROMEOS_LACROS) | 1280 | #if BUILDFLAG(IS_CHROMEOS_LACROS) |
| 1290 | --- a/chrome/browser/resources/settings/privacy_page/disable_safebrowsing_dialog.html | 1281 | --- chrome/browser/resources/settings/privacy_page/disable_safebrowsing_dialog.html.orig |
| 1291 | +++ b/chrome/browser/resources/settings/privacy_page/disable_safebrowsing_dialog.html | 1282 | +++ chrome/browser/resources/settings/privacy_page/disable_safebrowsing_dialog.html |
| 1292 | @@ -1,12 +1,9 @@ | 1283 | @@ -1,12 +1,9 @@ |
| 1293 | <cr-dialog id="dialog" close-text="$i18n{close}"> | 1284 | <cr-dialog id="dialog" close-text="$i18n{close}"> |
| 1294 | - <div slot="title">$i18n{safeBrowsingDisableDialog}</div> | 1285 | - <div slot="title">$i18n{safeBrowsingDisableDialog}</div> |
| 1295 | - <div slot="body">$i18n{safeBrowsingDisableDialogDesc}</div> | 1286 | - <div slot="body">$i18n{safeBrowsingDisableDialogDesc}</div> |
| 1296 | <div slot="button-container"> | 1287 | <div slot="button-container"> |
| 1297 | <cr-button id="cancel" class="cancel-button" on-click="onDialogCancel_"> | 1288 | <cr-button class="cancel-button" on-click="onDialogCancel_"> |
| 1298 | $i18n{cancel} | 1289 | $i18n{cancel} |
| 1299 | </cr-button> | 1290 | </cr-button> |
| 1300 | <cr-button id="confirm" class="action-button" on-click="onDialogConfirm_"> | 1291 | <cr-button class="action-button" on-click="onDialogConfirm_"> |
| 1301 | - $i18n{safeBrowsingDisableDialogConfirm} | 1292 | - $i18n{safeBrowsingDisableDialogConfirm} |
| 1302 | </cr-button> | 1293 | </cr-button> |
| 1303 | </div> | 1294 | </div> |
| 1304 | </cr-dialog> | 1295 | </cr-dialog> |
| 1305 | --- a/chrome/browser/resources/settings/privacy_page/privacy_page.html | 1296 | --- chrome/browser/resources/settings/privacy_page/privacy_page.html.orig |
| 1306 | +++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html | 1297 | +++ chrome/browser/resources/settings/privacy_page/privacy_page.html |
| 1307 | @@ -565,7 +565,7 @@ | 1298 | @@ -535,7 +535,7 @@ |
| 1308 | </category-setting-exceptions> | 1299 | </category-setting-exceptions> |
| 1309 | </settings-subpage> | 1300 | </settings-subpage> |
| 1310 | </template> | 1301 | </template> |
| @@ -1313,9 +1304,9 @@ | |||
| 1313 | no-search> | 1304 | no-search> |
| 1314 | <template is="dom-if" route-path="/content/ads" no-search> | 1305 | <template is="dom-if" route-path="/content/ads" no-search> |
| 1315 | <settings-subpage page-title="$i18n{siteSettingsAds}" | 1306 | <settings-subpage page-title="$i18n{siteSettingsAds}" |
| 1316 | --- a/chrome/browser/resources/settings/privacy_page/privacy_page.ts | 1307 | --- chrome/browser/resources/settings/privacy_page/privacy_page.ts.orig |
| 1317 | +++ b/chrome/browser/resources/settings/privacy_page/privacy_page.ts | 1308 | +++ chrome/browser/resources/settings/privacy_page/privacy_page.ts |
| 1318 | @@ -102,7 +102,7 @@ export class SettingsPrivacyPageElement | 1309 | @@ -90,7 +90,7 @@ export class SettingsPrivacyPageElement |
| 1319 | enableSafeBrowsingSubresourceFilter_: { | 1310 | enableSafeBrowsingSubresourceFilter_: { |
| 1320 | type: Boolean, | 1311 | type: Boolean, |
| 1321 | value() { | 1312 | value() { |
| @@ -1324,8 +1315,8 @@ | |||
| 1324 | } | 1315 | } |
| 1325 | }, | 1316 | }, |
| 1326 | 1317 | ||
| 1327 | --- a/chrome/browser/resources/settings/privacy_page/security_page.html | 1318 | --- chrome/browser/resources/settings/privacy_page/security_page.html.orig |
| 1328 | +++ b/chrome/browser/resources/settings/privacy_page/security_page.html | 1319 | +++ chrome/browser/resources/settings/privacy_page/security_page.html |
| 1329 | @@ -53,105 +53,6 @@ | 1320 | @@ -53,105 +53,6 @@ |
| 1330 | <img id="banner" alt="" | 1321 | <img id="banner" alt="" |
| 1331 | src="chrome://settings/images/safe_browsing_banner.svg"> | 1322 | src="chrome://settings/images/safe_browsing_banner.svg"> |
| @@ -1432,7 +1423,7 @@ | |||
| 1432 | <div class="cr-row first"> | 1423 | <div class="cr-row first"> |
| 1433 | <h2>$i18n{advancedPageTitle}</h2> | 1424 | <h2>$i18n{advancedPageTitle}</h2> |
| 1434 | </div> | 1425 | </div> |
| 1435 | @@ -213,8 +114,3 @@ | 1426 | @@ -202,8 +103,3 @@ |
| 1436 | on-click="onAdvancedProtectionProgramLinkClick_" | 1427 | on-click="onAdvancedProtectionProgramLinkClick_" |
| 1437 | external> | 1428 | external> |
| 1438 | </cr-link-row> | 1429 | </cr-link-row> |
| @@ -1441,27 +1432,25 @@ | |||
| 1441 | - on-close="onDisableSafebrowsingDialogClose_"> | 1432 | - on-close="onDisableSafebrowsingDialogClose_"> |
| 1442 | - </settings-disable-safebrowsing-dialog> | 1433 | - </settings-disable-safebrowsing-dialog> |
| 1443 | - </template> | 1434 | - </template> |
| 1444 | --- a/chrome/browser/resources/settings/privacy_page/security_page.ts | 1435 | --- chrome/browser/resources/settings/privacy_page/security_page.ts.orig |
| 1445 | +++ b/chrome/browser/resources/settings/privacy_page/security_page.ts | 1436 | +++ chrome/browser/resources/settings/privacy_page/security_page.ts |
| 1446 | @@ -200,17 +200,6 @@ export class SettingsSecurityPageElement | 1437 | @@ -182,15 +182,6 @@ export class SettingsSecurityPageElement |
| 1447 | 1438 | ||
| 1448 | override ready() { | 1439 | ready() { |
| 1449 | super.ready(); | 1440 | super.ready(); |
| 1450 | - | 1441 | - |
| 1451 | - CrSettingsPrefs.initialized.then(() => { | 1442 | - // Expand initial pref value manually because automatic |
| 1452 | - // Expand initial pref value manually because automatic | 1443 | - // expanding is disabled. |
| 1453 | - // expanding is disabled. | 1444 | - const prefValue = this.getPref('generated.safe_browsing').value; |
| 1454 | - const prefValue = this.getPref('generated.safe_browsing').value; | 1445 | - if (prefValue === SafeBrowsingSetting.ENHANCED) { |
| 1455 | - if (prefValue === SafeBrowsingSetting.ENHANCED) { | 1446 | - this.$.safeBrowsingEnhanced.expanded = true; |
| 1456 | - this.$.safeBrowsingEnhanced.expanded = true; | 1447 | - } else if (prefValue === SafeBrowsingSetting.STANDARD) { |
| 1457 | - } else if (prefValue === SafeBrowsingSetting.STANDARD) { | 1448 | - this.$.safeBrowsingStandard.expanded = true; |
| 1458 | - this.$.safeBrowsingStandard.expanded = true; | 1449 | - } |
| 1459 | - } | ||
| 1460 | - }); | ||
| 1461 | } | 1450 | } |
| 1462 | 1451 | ||
| 1463 | /** | 1452 | /** |
| 1464 | @@ -259,8 +248,7 @@ export class SettingsSecurityPageElement | 1453 | @@ -239,8 +230,7 @@ export class SettingsSecurityPageElement |
| 1465 | } | 1454 | } |
| 1466 | 1455 | ||
| 1467 | private getDisabledExtendedSafeBrowsing_(): boolean { | 1456 | private getDisabledExtendedSafeBrowsing_(): boolean { |
| @@ -1471,9 +1460,9 @@ | |||
| 1471 | } | 1460 | } |
| 1472 | 1461 | ||
| 1473 | private getPasswordsLeakToggleSubLabel_(): string { | 1462 | private getPasswordsLeakToggleSubLabel_(): string { |
| 1474 | --- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.ts | 1463 | --- chrome/browser/resources/settings/site_settings_page/site_settings_page.ts.orig |
| 1475 | +++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.ts | 1464 | +++ chrome/browser/resources/settings/site_settings_page/site_settings_page.ts |
| 1476 | @@ -48,7 +48,7 @@ function getCategoryItemMap(): Map<Conte | 1465 | @@ -47,7 +47,7 @@ function getCategoryItemMap(): Map<Conte |
| 1477 | enabledLabel: 'siteSettingsAdsAllowed', | 1466 | enabledLabel: 'siteSettingsAdsAllowed', |
| 1478 | disabledLabel: 'siteSettingsAdsBlocked', | 1467 | disabledLabel: 'siteSettingsAdsBlocked', |
| 1479 | shouldShow: () => | 1468 | shouldShow: () => |
| @@ -1482,8 +1471,8 @@ | |||
| 1482 | }, | 1471 | }, |
| 1483 | { | 1472 | { |
| 1484 | route: routes.SITE_SETTINGS_AR, | 1473 | route: routes.SITE_SETTINGS_AR, |
| 1485 | --- a/chrome/browser/safe_browsing/ad_redirect_trigger_browsertest.cc | 1474 | --- chrome/browser/safe_browsing/ad_redirect_trigger_browsertest.cc.orig |
| 1486 | +++ b/chrome/browser/safe_browsing/ad_redirect_trigger_browsertest.cc | 1475 | +++ chrome/browser/safe_browsing/ad_redirect_trigger_browsertest.cc |
| 1487 | @@ -19,7 +19,6 @@ | 1476 | @@ -19,7 +19,6 @@ |
| 1488 | #include "components/prefs/testing_pref_service.h" | 1477 | #include "components/prefs/testing_pref_service.h" |
| 1489 | #include "components/safe_browsing/content/browser/triggers/ad_redirect_trigger.h" | 1478 | #include "components/safe_browsing/content/browser/triggers/ad_redirect_trigger.h" |
| @@ -1492,16 +1481,16 @@ | |||
| 1492 | #include "content/public/browser/render_frame_host.h" | 1481 | #include "content/public/browser/render_frame_host.h" |
| 1493 | #include "content/public/browser/web_contents.h" | 1482 | #include "content/public/browser/web_contents.h" |
| 1494 | #include "content/public/test/browser_test.h" | 1483 | #include "content/public/test/browser_test.h" |
| 1495 | --- a/chrome/browser/safe_browsing/advanced_protection_status_manager.cc | 1484 | --- chrome/browser/safe_browsing/advanced_protection_status_manager.cc.orig |
| 1496 | +++ b/chrome/browser/safe_browsing/advanced_protection_status_manager.cc | 1485 | +++ chrome/browser/safe_browsing/advanced_protection_status_manager.cc |
| 1497 | @@ -13,7 +13,6 @@ | 1486 | @@ -13,7 +13,6 @@ |
| 1498 | #include "chrome/browser/signin/identity_manager_factory.h" | 1487 | #include "chrome/browser/signin/identity_manager_factory.h" |
| 1499 | #include "components/prefs/pref_service.h" | 1488 | #include "components/prefs/pref_service.h" |
| 1500 | #include "components/safe_browsing/core/common/features.h" | 1489 | #include "components/safe_browsing/core/common/features.h" |
| 1501 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 1490 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 1502 | #include "components/signin/public/base/consent_level.h" | ||
| 1503 | #include "components/signin/public/identity_manager/account_info.h" | 1491 | #include "components/signin/public/identity_manager/account_info.h" |
| 1504 | #include "components/signin/public/identity_manager/accounts_mutator.h" | 1492 | #include "components/signin/public/identity_manager/accounts_mutator.h" |
| 1493 | #include "components/signin/public/identity_manager/consent_level.h" | ||
| 1505 | @@ -63,9 +62,7 @@ void AdvancedProtectionStatusManager::Ma | 1494 | @@ -63,9 +62,7 @@ void AdvancedProtectionStatusManager::Ma |
| 1506 | 1495 | ||
| 1507 | is_under_advanced_protection_ = core_info.is_under_advanced_protection; | 1496 | is_under_advanced_protection_ = core_info.is_under_advanced_protection; |
| @@ -1535,8 +1524,8 @@ | |||
| 1535 | } | 1524 | } |
| 1536 | 1525 | ||
| 1537 | bool AdvancedProtectionStatusManager::IsUnconsentedPrimaryAccount( | 1526 | bool AdvancedProtectionStatusManager::IsUnconsentedPrimaryAccount( |
| 1538 | --- a/chrome/browser/safe_browsing/advanced_protection_status_manager_unittest.cc | 1527 | --- chrome/browser/safe_browsing/advanced_protection_status_manager_unittest.cc.orig |
| 1539 | +++ b/chrome/browser/safe_browsing/advanced_protection_status_manager_unittest.cc | 1528 | +++ chrome/browser/safe_browsing/advanced_protection_status_manager_unittest.cc |
| 1540 | @@ -10,7 +10,6 @@ | 1529 | @@ -10,7 +10,6 @@ |
| 1541 | #include "base/test/task_environment.h" | 1530 | #include "base/test/task_environment.h" |
| 1542 | #include "build/chromeos_buildflags.h" | 1531 | #include "build/chromeos_buildflags.h" |
| @@ -1545,18 +1534,18 @@ | |||
| 1545 | #include "components/signin/public/identity_manager/account_info.h" | 1534 | #include "components/signin/public/identity_manager/account_info.h" |
| 1546 | #include "components/signin/public/identity_manager/accounts_mutator.h" | 1535 | #include "components/signin/public/identity_manager/accounts_mutator.h" |
| 1547 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 1536 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 1548 | --- a/chrome/browser/safe_browsing/android/services_delegate_android.h | 1537 | --- chrome/browser/safe_browsing/android/services_delegate_android.h.orig |
| 1549 | +++ b/chrome/browser/safe_browsing/android/services_delegate_android.h | 1538 | +++ chrome/browser/safe_browsing/android/services_delegate_android.h |
| 1550 | @@ -6,7 +6,6 @@ | 1539 | @@ -7,7 +7,6 @@ |
| 1551 | #define CHROME_BROWSER_SAFE_BROWSING_ANDROID_SERVICES_DELEGATE_ANDROID_H_ | ||
| 1552 | 1540 | ||
| 1541 | #include "base/macros.h" | ||
| 1553 | #include "chrome/browser/safe_browsing/services_delegate.h" | 1542 | #include "chrome/browser/safe_browsing/services_delegate.h" |
| 1554 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 1543 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 1555 | 1544 | ||
| 1556 | namespace safe_browsing { | 1545 | namespace safe_browsing { |
| 1557 | 1546 | ||
| 1558 | --- a/chrome/browser/safe_browsing/certificate_reporting_service.cc | 1547 | --- chrome/browser/safe_browsing/certificate_reporting_service.cc.orig |
| 1559 | +++ b/chrome/browser/safe_browsing/certificate_reporting_service.cc | 1548 | +++ chrome/browser/safe_browsing/certificate_reporting_service.cc |
| 1560 | @@ -14,7 +14,6 @@ | 1549 | @@ -14,7 +14,6 @@ |
| 1561 | #include "chrome/browser/profiles/profile.h" | 1550 | #include "chrome/browser/profiles/profile.h" |
| 1562 | #include "chrome/browser/safe_browsing/safe_browsing_service.h" | 1551 | #include "chrome/browser/safe_browsing/safe_browsing_service.h" |
| @@ -1565,9 +1554,9 @@ | |||
| 1565 | #include "components/security_interstitials/content/certificate_error_report.h" | 1554 | #include "components/security_interstitials/content/certificate_error_report.h" |
| 1566 | #include "content/public/browser/browser_thread.h" | 1555 | #include "content/public/browser/browser_thread.h" |
| 1567 | #include "services/network/public/cpp/shared_url_loader_factory.h" | 1556 | #include "services/network/public/cpp/shared_url_loader_factory.h" |
| 1568 | --- a/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc | 1557 | --- chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc.orig |
| 1569 | +++ b/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc | 1558 | +++ chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc |
| 1570 | @@ -25,7 +25,6 @@ | 1559 | @@ -27,7 +27,6 @@ |
| 1571 | #include "chrome/test/base/in_process_browser_test.h" | 1560 | #include "chrome/test/base/in_process_browser_test.h" |
| 1572 | #include "chrome/test/base/ui_test_utils.h" | 1561 | #include "chrome/test/base/ui_test_utils.h" |
| 1573 | #include "components/prefs/pref_service.h" | 1562 | #include "components/prefs/pref_service.h" |
| @@ -1575,8 +1564,8 @@ | |||
| 1575 | #include "components/security_interstitials/content/cert_report_helper.h" | 1564 | #include "components/security_interstitials/content/cert_report_helper.h" |
| 1576 | #include "components/security_interstitials/content/certificate_error_report.h" | 1565 | #include "components/security_interstitials/content/certificate_error_report.h" |
| 1577 | #include "components/variations/variations_params_manager.h" | 1566 | #include "components/variations/variations_params_manager.h" |
| 1578 | --- a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc | 1567 | --- chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc.orig |
| 1579 | +++ b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc | 1568 | +++ chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc |
| 1580 | @@ -43,7 +43,6 @@ | 1569 | @@ -43,7 +43,6 @@ |
| 1581 | #include "components/component_updater/component_updater_service.h" | 1570 | #include "components/component_updater/component_updater_service.h" |
| 1582 | #include "components/component_updater/pref_names.h" | 1571 | #include "components/component_updater/pref_names.h" |
| @@ -1585,9 +1574,9 @@ | |||
| 1585 | #include "content/public/browser/browser_task_traits.h" | 1574 | #include "content/public/browser/browser_task_traits.h" |
| 1586 | #include "content/public/browser/browser_thread.h" | 1575 | #include "content/public/browser/browser_thread.h" |
| 1587 | #include "net/http/http_status_code.h" | 1576 | #include "net/http/http_status_code.h" |
| 1588 | --- a/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc | 1577 | --- chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc.orig |
| 1589 | +++ b/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc | 1578 | +++ chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc |
| 1590 | @@ -43,7 +43,6 @@ | 1579 | @@ -44,7 +44,6 @@ |
| 1591 | #include "components/policy/core/common/mock_configuration_policy_provider.h" | 1580 | #include "components/policy/core/common/mock_configuration_policy_provider.h" |
| 1592 | #include "components/policy/policy_constants.h" | 1581 | #include "components/policy/policy_constants.h" |
| 1593 | #include "components/prefs/pref_service.h" | 1582 | #include "components/prefs/pref_service.h" |
| @@ -1595,8 +1584,8 @@ | |||
| 1595 | #include "content/public/test/browser_test.h" | 1584 | #include "content/public/test/browser_test.h" |
| 1596 | #include "testing/gmock/include/gmock/gmock.h" | 1585 | #include "testing/gmock/include/gmock/gmock.h" |
| 1597 | #include "testing/gtest/include/gtest/gtest.h" | 1586 | #include "testing/gtest/include/gtest/gtest.h" |
| 1598 | --- a/chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc | 1587 | --- chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc.orig |
| 1599 | +++ b/chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc | 1588 | +++ chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc |
| 1600 | @@ -12,7 +12,6 @@ | 1589 | @@ -12,7 +12,6 @@ |
| 1601 | #include "chrome/browser/profiles/profile.h" | 1590 | #include "chrome/browser/profiles/profile.h" |
| 1602 | #include "chrome/browser/profiles/profile_manager.h" | 1591 | #include "chrome/browser/profiles/profile_manager.h" |
| @@ -1605,9 +1594,9 @@ | |||
| 1605 | #include "components/version_info/version_info.h" | 1594 | #include "components/version_info/version_info.h" |
| 1606 | 1595 | ||
| 1607 | namespace safe_browsing { | 1596 | namespace safe_browsing { |
| 1608 | --- a/chrome/browser/safe_browsing/chrome_password_protection_service.cc | 1597 | --- chrome/browser/safe_browsing/chrome_password_protection_service.cc.orig |
| 1609 | +++ b/chrome/browser/safe_browsing/chrome_password_protection_service.cc | 1598 | +++ chrome/browser/safe_browsing/chrome_password_protection_service.cc |
| 1610 | @@ -65,7 +65,6 @@ | 1599 | @@ -63,7 +63,6 @@ |
| 1611 | #include "components/safe_browsing/core/browser/verdict_cache_manager.h" | 1600 | #include "components/safe_browsing/core/browser/verdict_cache_manager.h" |
| 1612 | #include "components/safe_browsing/core/common/features.h" | 1601 | #include "components/safe_browsing/core/common/features.h" |
| 1613 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 1602 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -1615,7 +1604,7 @@ | |||
| 1615 | #include "components/safe_browsing/core/common/safebrowsing_constants.h" | 1604 | #include "components/safe_browsing/core/common/safebrowsing_constants.h" |
| 1616 | #include "components/safe_browsing/core/common/utils.h" | 1605 | #include "components/safe_browsing/core/common/utils.h" |
| 1617 | #include "components/security_interstitials/content/unsafe_resource_util.h" | 1606 | #include "components/security_interstitials/content/unsafe_resource_util.h" |
| 1618 | @@ -1212,14 +1211,6 @@ bool ChromePasswordProtectionService::Ha | 1607 | @@ -1220,14 +1219,6 @@ bool ChromePasswordProtectionService::Ha |
| 1619 | } | 1608 | } |
| 1620 | 1609 | ||
| 1621 | void ChromePasswordProtectionService::OnWarningTriggerChanged() { | 1610 | void ChromePasswordProtectionService::OnWarningTriggerChanged() { |
| @@ -1630,7 +1619,7 @@ | |||
| 1630 | // Clears captured enterprise password hashes or GSuite sync password hashes. | 1619 | // Clears captured enterprise password hashes or GSuite sync password hashes. |
| 1631 | password_manager::PasswordReuseManager* reuse_manager = | 1620 | password_manager::PasswordReuseManager* reuse_manager = |
| 1632 | GetPasswordReuseManager(); | 1621 | GetPasswordReuseManager(); |
| 1633 | @@ -1378,7 +1369,7 @@ PrefService* ChromePasswordProtectionSer | 1622 | @@ -1385,7 +1376,7 @@ PrefService* ChromePasswordProtectionSer |
| 1634 | } | 1623 | } |
| 1635 | 1624 | ||
| 1636 | bool ChromePasswordProtectionService::IsSafeBrowsingEnabled() { | 1625 | bool ChromePasswordProtectionService::IsSafeBrowsingEnabled() { |
| @@ -1639,7 +1628,7 @@ | |||
| 1639 | } | 1628 | } |
| 1640 | 1629 | ||
| 1641 | bool ChromePasswordProtectionService::IsExtendedReporting() { | 1630 | bool ChromePasswordProtectionService::IsExtendedReporting() { |
| 1642 | @@ -1398,44 +1389,7 @@ bool ChromePasswordProtectionService::Is | 1631 | @@ -1405,44 +1396,7 @@ bool ChromePasswordProtectionService::Is |
| 1643 | bool ChromePasswordProtectionService::IsPingingEnabled( | 1632 | bool ChromePasswordProtectionService::IsPingingEnabled( |
| 1644 | LoginReputationClientRequest::TriggerType trigger_type, | 1633 | LoginReputationClientRequest::TriggerType trigger_type, |
| 1645 | ReusedPasswordAccountType password_type) { | 1634 | ReusedPasswordAccountType password_type) { |
| @@ -1667,7 +1656,7 @@ | |||
| 1667 | -// Only saved password and GAIA password reuse warnings are shown to users on | 1656 | -// Only saved password and GAIA password reuse warnings are shown to users on |
| 1668 | -// Android, so other types of password reuse events should be gated by Safe | 1657 | -// Android, so other types of password reuse events should be gated by Safe |
| 1669 | -// Browsing extended reporting. | 1658 | -// Browsing extended reporting. |
| 1670 | -#if BUILDFLAG(IS_ANDROID) | 1659 | -#if defined(OS_ANDROID) |
| 1671 | - if (password_type.account_type() == | 1660 | - if (password_type.account_type() == |
| 1672 | - ReusedPasswordAccountType::SAVED_PASSWORD || | 1661 | - ReusedPasswordAccountType::SAVED_PASSWORD || |
| 1673 | - IsSyncingGMAILPasswordWithSignedInProtectionEnabled(password_type)) { | 1662 | - IsSyncingGMAILPasswordWithSignedInProtectionEnabled(password_type)) { |
| @@ -1685,8 +1674,8 @@ | |||
| 1685 | } | 1674 | } |
| 1686 | 1675 | ||
| 1687 | RequestOutcome ChromePasswordProtectionService::GetPingNotSentReason( | 1676 | RequestOutcome ChromePasswordProtectionService::GetPingNotSentReason( |
| 1688 | @@ -1664,22 +1618,6 @@ MaybeCreateCommitDeferringCondition( | 1677 | @@ -1661,22 +1615,6 @@ MaybeCreateNavigationThrottle(content::N |
| 1689 | : nullptr; | 1678 | : nullptr; |
| 1690 | } | 1679 | } |
| 1691 | 1680 | ||
| 1692 | -PasswordProtectionTrigger | 1681 | -PasswordProtectionTrigger |
| @@ -1708,9 +1697,9 @@ | |||
| 1708 | bool ChromePasswordProtectionService::IsURLAllowlistedForPasswordEntry( | 1697 | bool ChromePasswordProtectionService::IsURLAllowlistedForPasswordEntry( |
| 1709 | const GURL& url) const { | 1698 | const GURL& url) const { |
| 1710 | if (!profile_) | 1699 | if (!profile_) |
| 1711 | --- a/chrome/browser/safe_browsing/chrome_password_protection_service.h | 1700 | --- chrome/browser/safe_browsing/chrome_password_protection_service.h.orig |
| 1712 | +++ b/chrome/browser/safe_browsing/chrome_password_protection_service.h | 1701 | +++ chrome/browser/safe_browsing/chrome_password_protection_service.h |
| 1713 | @@ -215,13 +215,6 @@ class ChromePasswordProtectionService : | 1702 | @@ -211,13 +211,6 @@ class ChromePasswordProtectionService : |
| 1714 | bool UserClickedThroughSBInterstitial( | 1703 | bool UserClickedThroughSBInterstitial( |
| 1715 | PasswordProtectionRequest* request) override; | 1704 | PasswordProtectionRequest* request) override; |
| 1716 | 1705 | ||
| @@ -1724,9 +1713,9 @@ | |||
| 1724 | // If |url| matches Safe Browsing allowlist domains, password protection | 1713 | // If |url| matches Safe Browsing allowlist domains, password protection |
| 1725 | // change password URL, or password protection login URLs in the enterprise | 1714 | // change password URL, or password protection login URLs in the enterprise |
| 1726 | // policy. | 1715 | // policy. |
| 1727 | --- a/chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc | 1716 | --- chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc.orig |
| 1728 | +++ b/chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc | 1717 | +++ chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc |
| 1729 | @@ -39,7 +39,6 @@ | 1718 | @@ -38,7 +38,6 @@ |
| 1730 | #include "components/safe_browsing/content/browser/password_protection/password_protection_test_util.h" | 1719 | #include "components/safe_browsing/content/browser/password_protection/password_protection_test_util.h" |
| 1731 | #include "components/safe_browsing/core/browser/password_protection/metrics_util.h" | 1720 | #include "components/safe_browsing/core/browser/password_protection/metrics_util.h" |
| 1732 | #include "components/safe_browsing/core/common/features.h" | 1721 | #include "components/safe_browsing/core/common/features.h" |
| @@ -1734,9 +1723,9 @@ | |||
| 1734 | #include "components/security_state/core/security_state.h" | 1723 | #include "components/security_state/core/security_state.h" |
| 1735 | #include "components/signin/public/identity_manager/account_info.h" | 1724 | #include "components/signin/public/identity_manager/account_info.h" |
| 1736 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 1725 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 1737 | --- a/chrome/browser/safe_browsing/chrome_password_protection_service_sync_browsertest.cc | 1726 | --- chrome/browser/safe_browsing/chrome_password_protection_service_sync_browsertest.cc.orig |
| 1738 | +++ b/chrome/browser/safe_browsing/chrome_password_protection_service_sync_browsertest.cc | 1727 | +++ chrome/browser/safe_browsing/chrome_password_protection_service_sync_browsertest.cc |
| 1739 | @@ -29,9 +29,7 @@ | 1728 | @@ -28,9 +28,7 @@ |
| 1740 | #include "components/prefs/pref_service.h" | 1729 | #include "components/prefs/pref_service.h" |
| 1741 | #include "components/prefs/scoped_user_pref_update.h" | 1730 | #include "components/prefs/scoped_user_pref_update.h" |
| 1742 | #include "components/safe_browsing/content/browser/password_protection/password_protection_request_content.h" | 1731 | #include "components/safe_browsing/content/browser/password_protection/password_protection_request_content.h" |
| @@ -1746,9 +1735,9 @@ | |||
| 1746 | #include "components/signin/public/identity_manager/identity_manager.h" | 1735 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 1747 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 1736 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 1748 | #include "components/sync/driver/sync_service.h" | 1737 | #include "components/sync/driver/sync_service.h" |
| 1749 | --- a/chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc | 1738 | --- chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc.orig |
| 1750 | +++ b/chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc | 1739 | +++ chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc |
| 1751 | @@ -36,7 +36,6 @@ | 1740 | @@ -34,7 +34,6 @@ |
| 1752 | #include "components/prefs/pref_service.h" | 1741 | #include "components/prefs/pref_service.h" |
| 1753 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" | 1742 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" |
| 1754 | #include "components/safe_browsing/core/common/features.h" | 1743 | #include "components/safe_browsing/core/common/features.h" |
| @@ -1756,9 +1745,9 @@ | |||
| 1756 | 1745 | ||
| 1757 | #include "content/public/browser/browser_task_traits.h" | 1746 | #include "content/public/browser/browser_task_traits.h" |
| 1758 | #include "content/public/browser/browser_thread.h" | 1747 | #include "content/public/browser/browser_thread.h" |
| 1759 | --- a/chrome/browser/safe_browsing/download_protection/check_client_download_request.cc | 1748 | --- chrome/browser/safe_browsing/download_protection/check_client_download_request.cc.orig |
| 1760 | +++ b/chrome/browser/safe_browsing/download_protection/check_client_download_request.cc | 1749 | +++ chrome/browser/safe_browsing/download_protection/check_client_download_request.cc |
| 1761 | @@ -37,7 +37,6 @@ | 1750 | @@ -38,7 +38,6 @@ |
| 1762 | #include "components/safe_browsing/content/common/file_type_policies.h" | 1751 | #include "components/safe_browsing/content/common/file_type_policies.h" |
| 1763 | #include "components/safe_browsing/core/common/features.h" | 1752 | #include "components/safe_browsing/core/common/features.h" |
| 1764 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 1753 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -1766,8 +1755,8 @@ | |||
| 1766 | #include "components/safe_browsing/core/common/utils.h" | 1755 | #include "components/safe_browsing/core/common/utils.h" |
| 1767 | #include "components/url_matcher/url_matcher.h" | 1756 | #include "components/url_matcher/url_matcher.h" |
| 1768 | #include "content/public/browser/browser_context.h" | 1757 | #include "content/public/browser/browser_context.h" |
| 1769 | --- a/chrome/browser/safe_browsing/download_protection/check_client_download_request_base.cc | 1758 | --- chrome/browser/safe_browsing/download_protection/check_client_download_request_base.cc.orig |
| 1770 | +++ b/chrome/browser/safe_browsing/download_protection/check_client_download_request_base.cc | 1759 | +++ chrome/browser/safe_browsing/download_protection/check_client_download_request_base.cc |
| 1771 | @@ -24,7 +24,6 @@ | 1760 | @@ -24,7 +24,6 @@ |
| 1772 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" | 1761 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" |
| 1773 | #include "components/safe_browsing/content/common/file_type_policies.h" | 1762 | #include "components/safe_browsing/content/common/file_type_policies.h" |
| @@ -1776,9 +1765,9 @@ | |||
| 1776 | #include "components/safe_browsing/core/common/utils.h" | 1765 | #include "components/safe_browsing/core/common/utils.h" |
| 1777 | #include "content/public/browser/browser_context.h" | 1766 | #include "content/public/browser/browser_context.h" |
| 1778 | #include "content/public/browser/browser_task_traits.h" | 1767 | #include "content/public/browser/browser_task_traits.h" |
| 1779 | --- a/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc | 1768 | --- chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc.orig |
| 1780 | +++ b/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc | 1769 | +++ chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc |
| 1781 | @@ -95,7 +95,6 @@ | 1770 | @@ -93,7 +93,6 @@ |
| 1782 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" | 1771 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" |
| 1783 | #include "components/safe_browsing/core/common/features.h" | 1772 | #include "components/safe_browsing/core/common/features.h" |
| 1784 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 1773 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -1786,8 +1775,8 @@ | |||
| 1786 | #include "components/safe_browsing/core/common/safebrowsing_switches.h" | 1775 | #include "components/safe_browsing/core/common/safebrowsing_switches.h" |
| 1787 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 1776 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 1788 | #include "content/public/browser/browser_task_traits.h" | 1777 | #include "content/public/browser/browser_task_traits.h" |
| 1789 | --- a/chrome/browser/safe_browsing/generated_safe_browsing_pref.cc | 1778 | --- chrome/browser/safe_browsing/generated_safe_browsing_pref.cc.orig |
| 1790 | +++ b/chrome/browser/safe_browsing/generated_safe_browsing_pref.cc | 1779 | +++ chrome/browser/safe_browsing/generated_safe_browsing_pref.cc |
| 1791 | @@ -7,7 +7,6 @@ | 1780 | @@ -7,7 +7,6 @@ |
| 1792 | #include "chrome/browser/profiles/profile.h" | 1781 | #include "chrome/browser/profiles/profile.h" |
| 1793 | #include "chrome/common/extensions/api/settings_private.h" | 1782 | #include "chrome/common/extensions/api/settings_private.h" |
| @@ -1818,7 +1807,7 @@ | |||
| 1818 | } | 1807 | } |
| 1819 | 1808 | ||
| 1820 | extensions::settings_private::SetPrefResult GeneratedSafeBrowsingPref::SetPref( | 1809 | extensions::settings_private::SetPrefResult GeneratedSafeBrowsingPref::SetPref( |
| 1821 | @@ -48,37 +32,14 @@ extensions::settings_private::SetPrefRes | 1810 | @@ -48,31 +32,14 @@ extensions::settings_private::SetPrefRes |
| 1822 | return extensions::settings_private::SetPrefResult::PREF_TYPE_MISMATCH; | 1811 | return extensions::settings_private::SetPrefResult::PREF_TYPE_MISMATCH; |
| 1823 | 1812 | ||
| 1824 | // If SBER is forcefully disabled, Enhanced cannot be selected by the user. | 1813 | // If SBER is forcefully disabled, Enhanced cannot be selected by the user. |
| @@ -1849,16 +1838,10 @@ | |||
| 1849 | - profile_->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnhanced, | 1838 | - profile_->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnhanced, |
| 1850 | - selection == SafeBrowsingSetting::ENHANCED); | 1839 | - selection == SafeBrowsingSetting::ENHANCED); |
| 1851 | - | 1840 | - |
| 1852 | - // Set ESB not set in sync with Account ESB through TailoredSecurity. | ||
| 1853 | - if (selection == SafeBrowsingSetting::ENHANCED) { | ||
| 1854 | - profile_->GetPrefs()->SetBoolean( | ||
| 1855 | - prefs::kEnhancedProtectionEnabledViaTailoredSecurity, false); | ||
| 1856 | - } | ||
| 1857 | - | ||
| 1858 | return extensions::settings_private::SetPrefResult::SUCCESS; | 1841 | return extensions::settings_private::SetPrefResult::SUCCESS; |
| 1859 | } | 1842 | } |
| 1860 | 1843 | ||
| 1861 | @@ -89,10 +50,8 @@ GeneratedSafeBrowsingPref::GetPrefObject | 1844 | @@ -83,10 +50,8 @@ GeneratedSafeBrowsingPref::GetPrefObject |
| 1862 | pref_object->key = kGeneratedSafeBrowsingPref; | 1845 | pref_object->key = kGeneratedSafeBrowsingPref; |
| 1863 | pref_object->type = extensions::api::settings_private::PREF_TYPE_NUMBER; | 1846 | pref_object->type = extensions::api::settings_private::PREF_TYPE_NUMBER; |
| 1864 | 1847 | ||
| @@ -1871,7 +1854,7 @@ | |||
| 1871 | 1854 | ||
| 1872 | if (safe_browsing_enhanced_enabled && safe_browsing_enabled) { | 1855 | if (safe_browsing_enhanced_enabled && safe_browsing_enabled) { |
| 1873 | pref_object->value = std::make_unique<base::Value>( | 1856 | pref_object->value = std::make_unique<base::Value>( |
| 1874 | @@ -122,29 +81,18 @@ void GeneratedSafeBrowsingPref::ApplySaf | 1857 | @@ -116,29 +81,18 @@ void GeneratedSafeBrowsingPref::ApplySaf |
| 1875 | // three different preferences. It is possible that these may be in | 1858 | // three different preferences. It is possible that these may be in |
| 1876 | // temporarily conflicting managed states. The enabled preference is always | 1859 | // temporarily conflicting managed states. The enabled preference is always |
| 1877 | // taken as the canonical source of management. | 1860 | // taken as the canonical source of management. |
| @@ -1907,7 +1890,7 @@ | |||
| 1907 | 1890 | ||
| 1908 | if (!enabled_enforced && !enabled_recommended && !reporting_enforced) { | 1891 | if (!enabled_enforced && !enabled_recommended && !reporting_enforced) { |
| 1909 | // No relevant policies are applied. | 1892 | // No relevant policies are applied. |
| 1910 | @@ -154,8 +102,6 @@ void GeneratedSafeBrowsingPref::ApplySaf | 1893 | @@ -148,8 +102,6 @@ void GeneratedSafeBrowsingPref::ApplySaf |
| 1911 | if (enabled_enforced) { | 1894 | if (enabled_enforced) { |
| 1912 | // Preference is fully controlled. | 1895 | // Preference is fully controlled. |
| 1913 | pref_object->enforcement = settings_api::Enforcement::ENFORCEMENT_ENFORCED; | 1896 | pref_object->enforcement = settings_api::Enforcement::ENFORCEMENT_ENFORCED; |
| @@ -1916,7 +1899,7 @@ | |||
| 1916 | return; | 1899 | return; |
| 1917 | } | 1900 | } |
| 1918 | 1901 | ||
| 1919 | @@ -180,8 +126,6 @@ void GeneratedSafeBrowsingPref::ApplySaf | 1902 | @@ -174,8 +126,6 @@ void GeneratedSafeBrowsingPref::ApplySaf |
| 1920 | // Reporting has been forcefully disabled by policy. Enhanced protection is | 1903 | // Reporting has been forcefully disabled by policy. Enhanced protection is |
| 1921 | // thus also implicitly disabled by the same policy. | 1904 | // thus also implicitly disabled by the same policy. |
| 1922 | pref_object->enforcement = settings_api::Enforcement::ENFORCEMENT_ENFORCED; | 1905 | pref_object->enforcement = settings_api::Enforcement::ENFORCEMENT_ENFORCED; |
| @@ -1925,9 +1908,9 @@ | |||
| 1925 | 1908 | ||
| 1926 | pref_object->user_selectable_values = | 1909 | pref_object->user_selectable_values = |
| 1927 | std::make_unique<std::vector<std::unique_ptr<base::Value>>>(); | 1910 | std::make_unique<std::vector<std::unique_ptr<base::Value>>>(); |
| 1928 | --- a/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc | 1911 | --- chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc.orig |
| 1929 | +++ b/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc | 1912 | +++ chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc |
| 1930 | @@ -23,7 +23,6 @@ | 1913 | @@ -22,7 +22,6 @@ |
| 1931 | #include "chrome/test/base/testing_profile.h" | 1914 | #include "chrome/test/base/testing_profile.h" |
| 1932 | #include "chrome/test/base/testing_profile_manager.h" | 1915 | #include "chrome/test/base/testing_profile_manager.h" |
| 1933 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 1916 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -1935,9 +1918,9 @@ | |||
| 1935 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 1918 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 1936 | #include "content/public/test/browser_task_environment.h" | 1919 | #include "content/public/test/browser_task_environment.h" |
| 1937 | #include "content/public/test/test_utils.h" | 1920 | #include "content/public/test/test_utils.h" |
| 1938 | --- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc | 1921 | --- chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc.orig |
| 1939 | +++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc | 1922 | +++ chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc |
| 1940 | @@ -40,7 +40,6 @@ | 1923 | @@ -42,7 +42,6 @@ |
| 1941 | #include "components/prefs/pref_service.h" | 1924 | #include "components/prefs/pref_service.h" |
| 1942 | #include "components/safe_browsing/core/common/features.h" | 1925 | #include "components/safe_browsing/core/common/features.h" |
| 1943 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 1926 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -1945,8 +1928,8 @@ | |||
| 1945 | #include "content/public/browser/browser_thread.h" | 1928 | #include "content/public/browser/browser_thread.h" |
| 1946 | #include "content/public/browser/download_item_utils.h" | 1929 | #include "content/public/browser/download_item_utils.h" |
| 1947 | #include "services/network/public/cpp/shared_url_loader_factory.h" | 1930 | #include "services/network/public/cpp/shared_url_loader_factory.h" |
| 1948 | --- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc | 1931 | --- chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc.orig |
| 1949 | +++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc | 1932 | +++ chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc |
| 1950 | @@ -36,7 +36,6 @@ | 1933 | @@ -36,7 +36,6 @@ |
| 1951 | #include "chrome/test/base/testing_profile.h" | 1934 | #include "chrome/test/base/testing_profile.h" |
| 1952 | #include "chrome/test/base/testing_profile_manager.h" | 1935 | #include "chrome/test/base/testing_profile_manager.h" |
| @@ -1955,8 +1938,8 @@ | |||
| 1955 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 1938 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 1956 | #include "content/public/test/browser_task_environment.h" | 1939 | #include "content/public/test/browser_task_environment.h" |
| 1957 | #include "extensions/browser/quota_service.h" | 1940 | #include "extensions/browser/quota_service.h" |
| 1958 | --- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc | 1941 | --- chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc.orig |
| 1959 | +++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc | 1942 | +++ chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc |
| 1960 | @@ -43,7 +43,6 @@ | 1943 | @@ -43,7 +43,6 @@ |
| 1961 | #include "components/history/core/browser/history_database_params.h" | 1944 | #include "components/history/core/browser/history_database_params.h" |
| 1962 | #include "components/history/core/browser/history_service.h" | 1945 | #include "components/history/core/browser/history_service.h" |
| @@ -1965,8 +1948,8 @@ | |||
| 1965 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 1948 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 1966 | #include "content/public/test/browser_task_environment.h" | 1949 | #include "content/public/test/browser_task_environment.h" |
| 1967 | #include "content/public/test/test_utils.h" | 1950 | #include "content/public/test/test_utils.h" |
| 1968 | --- a/chrome/browser/safe_browsing/incident_reporting/state_store.cc | 1951 | --- chrome/browser/safe_browsing/incident_reporting/state_store.cc.orig |
| 1969 | +++ b/chrome/browser/safe_browsing/incident_reporting/state_store.cc | 1952 | +++ chrome/browser/safe_browsing/incident_reporting/state_store.cc |
| 1970 | @@ -14,7 +14,6 @@ | 1953 | @@ -14,7 +14,6 @@ |
| 1971 | #include "chrome/browser/safe_browsing/incident_reporting/incident.h" | 1954 | #include "chrome/browser/safe_browsing/incident_reporting/incident.h" |
| 1972 | #include "chrome/browser/safe_browsing/incident_reporting/platform_state_store.h" | 1955 | #include "chrome/browser/safe_browsing/incident_reporting/platform_state_store.h" |
| @@ -1975,8 +1958,8 @@ | |||
| 1975 | 1958 | ||
| 1976 | namespace safe_browsing { | 1959 | namespace safe_browsing { |
| 1977 | 1960 | ||
| 1978 | --- a/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc | 1961 | --- chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc.orig |
| 1979 | +++ b/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc | 1962 | +++ chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc |
| 1980 | @@ -21,7 +21,6 @@ | 1963 | @@ -21,7 +21,6 @@ |
| 1981 | #include "chrome/test/base/testing_profile.h" | 1964 | #include "chrome/test/base/testing_profile.h" |
| 1982 | #include "chrome/test/base/testing_profile_manager.h" | 1965 | #include "chrome/test/base/testing_profile_manager.h" |
| @@ -1985,8 +1968,8 @@ | |||
| 1985 | #include "components/sync_preferences/pref_service_syncable.h" | 1968 | #include "components/sync_preferences/pref_service_syncable.h" |
| 1986 | #include "components/sync_preferences/pref_service_syncable_factory.h" | 1969 | #include "components/sync_preferences/pref_service_syncable_factory.h" |
| 1987 | #include "content/public/test/browser_task_environment.h" | 1970 | #include "content/public/test/browser_task_environment.h" |
| 1988 | --- a/chrome/browser/safe_browsing/metrics/safe_browsing_metrics_provider.cc | 1971 | --- chrome/browser/safe_browsing/metrics/safe_browsing_metrics_provider.cc.orig |
| 1989 | +++ b/chrome/browser/safe_browsing/metrics/safe_browsing_metrics_provider.cc | 1972 | +++ chrome/browser/safe_browsing/metrics/safe_browsing_metrics_provider.cc |
| 1990 | @@ -7,7 +7,6 @@ | 1973 | @@ -7,7 +7,6 @@ |
| 1991 | #include "base/metrics/histogram_functions.h" | 1974 | #include "base/metrics/histogram_functions.h" |
| 1992 | #include "chrome/browser/profiles/profile.h" | 1975 | #include "chrome/browser/profiles/profile.h" |
| @@ -1995,9 +1978,9 @@ | |||
| 1995 | 1978 | ||
| 1996 | namespace safe_browsing { | 1979 | namespace safe_browsing { |
| 1997 | 1980 | ||
| 1998 | --- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc | 1981 | --- chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc.orig |
| 1999 | +++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc | 1982 | +++ chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc |
| 2000 | @@ -79,7 +79,6 @@ | 1983 | @@ -74,7 +74,6 @@ |
| 2001 | #include "components/safe_browsing/core/browser/safe_browsing_metrics_collector.h" | 1984 | #include "components/safe_browsing/core/browser/safe_browsing_metrics_collector.h" |
| 2002 | #include "components/safe_browsing/core/browser/verdict_cache_manager.h" | 1985 | #include "components/safe_browsing/core/browser/verdict_cache_manager.h" |
| 2003 | #include "components/safe_browsing/core/common/features.h" | 1986 | #include "components/safe_browsing/core/common/features.h" |
| @@ -2005,9 +1988,9 @@ | |||
| 2005 | #include "components/safe_browsing/core/common/web_ui_constants.h" | 1988 | #include "components/safe_browsing/core/common/web_ui_constants.h" |
| 2006 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" | 1989 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" |
| 2007 | #include "components/security_interstitials/content/security_interstitial_tab_helper.h" | 1990 | #include "components/security_interstitials/content/security_interstitial_tab_helper.h" |
| 2008 | --- a/chrome/browser/safe_browsing/safe_browsing_service.cc | 1991 | --- chrome/browser/safe_browsing/safe_browsing_service.cc.orig |
| 2009 | +++ b/chrome/browser/safe_browsing/safe_browsing_service.cc | 1992 | +++ chrome/browser/safe_browsing/safe_browsing_service.cc |
| 2010 | @@ -121,7 +121,6 @@ base::FilePath SafeBrowsingService::GetB | 1993 | @@ -103,7 +103,6 @@ base::FilePath SafeBrowsingService::GetB |
| 2011 | 1994 | ||
| 2012 | SafeBrowsingService::SafeBrowsingService() | 1995 | SafeBrowsingService::SafeBrowsingService() |
| 2013 | : services_delegate_(ServicesDelegate::Create(this)), | 1996 | : services_delegate_(ServicesDelegate::Create(this)), |
| @@ -2015,7 +1998,7 @@ | |||
| 2015 | shutdown_(false), | 1998 | shutdown_(false), |
| 2016 | enabled_(false), | 1999 | enabled_(false), |
| 2017 | enabled_by_prefs_(false) {} | 2000 | enabled_by_prefs_(false) {} |
| 2018 | @@ -249,8 +248,6 @@ TriggerManager* SafeBrowsingService::tri | 2001 | @@ -257,8 +256,6 @@ TriggerManager* SafeBrowsingService::tri |
| 2019 | 2002 | ||
| 2020 | PasswordProtectionService* SafeBrowsingService::GetPasswordProtectionService( | 2003 | PasswordProtectionService* SafeBrowsingService::GetPasswordProtectionService( |
| 2021 | Profile* profile) const { | 2004 | Profile* profile) const { |
| @@ -2024,7 +2007,7 @@ | |||
| 2024 | return nullptr; | 2007 | return nullptr; |
| 2025 | } | 2008 | } |
| 2026 | 2009 | ||
| 2027 | @@ -342,9 +339,6 @@ void SafeBrowsingService::OnProfileAdded | 2010 | @@ -387,9 +384,6 @@ void SafeBrowsingService::OnProfileAdded |
| 2028 | std::unique_ptr<PrefChangeRegistrar> registrar = | 2011 | std::unique_ptr<PrefChangeRegistrar> registrar = |
| 2029 | std::make_unique<PrefChangeRegistrar>(); | 2012 | std::make_unique<PrefChangeRegistrar>(); |
| 2030 | registrar->Init(pref_service); | 2013 | registrar->Init(pref_service); |
| @@ -2034,7 +2017,7 @@ | |||
| 2034 | // ClientSideDetectionService will need to be refresh the models | 2017 | // ClientSideDetectionService will need to be refresh the models |
| 2035 | // renderers have if extended-reporting changes. | 2018 | // renderers have if extended-reporting changes. |
| 2036 | registrar->Add(prefs::kSafeBrowsingScoutReportingEnabled, | 2019 | registrar->Add(prefs::kSafeBrowsingScoutReportingEnabled, |
| 2037 | @@ -373,14 +367,6 @@ void SafeBrowsingService::OnProfileAdded | 2020 | @@ -418,14 +412,6 @@ void SafeBrowsingService::OnProfileAdded |
| 2038 | NoCachedPopulationReason::kChangeMbbPref)); | 2021 | NoCachedPopulationReason::kChangeMbbPref)); |
| 2039 | user_population_prefs_[pref_service] = std::move(registrar); | 2022 | user_population_prefs_[pref_service] = std::move(registrar); |
| 2040 | 2023 | ||
| @@ -2049,7 +2032,7 @@ | |||
| 2049 | // Extended Reporting metrics are handled together elsewhere. | 2032 | // Extended Reporting metrics are handled together elsewhere. |
| 2050 | RecordExtendedReportingMetrics(*pref_service); | 2033 | RecordExtendedReportingMetrics(*pref_service); |
| 2051 | 2034 | ||
| 2052 | @@ -423,18 +409,6 @@ void SafeBrowsingService::RefreshState() | 2035 | @@ -465,18 +451,6 @@ void SafeBrowsingService::RefreshState() |
| 2053 | 2036 | ||
| 2054 | // Check if any profile requires the service to be active. | 2037 | // Check if any profile requires the service to be active. |
| 2055 | enabled_by_prefs_ = false; | 2038 | enabled_by_prefs_ = false; |
| @@ -2068,9 +2051,9 @@ | |||
| 2068 | 2051 | ||
| 2069 | if (enabled_by_prefs_) | 2052 | if (enabled_by_prefs_) |
| 2070 | Start(); | 2053 | Start(); |
| 2071 | --- a/chrome/browser/safe_browsing/safe_browsing_service.h | 2054 | --- chrome/browser/safe_browsing/safe_browsing_service.h.orig |
| 2072 | +++ b/chrome/browser/safe_browsing/safe_browsing_service.h | 2055 | +++ chrome/browser/safe_browsing/safe_browsing_service.h |
| 2073 | @@ -27,7 +27,6 @@ | 2056 | @@ -28,7 +28,6 @@ |
| 2074 | #include "components/safe_browsing/buildflags.h" | 2057 | #include "components/safe_browsing/buildflags.h" |
| 2075 | #include "components/safe_browsing/content/browser/safe_browsing_service_interface.h" | 2058 | #include "components/safe_browsing/content/browser/safe_browsing_service_interface.h" |
| 2076 | #include "components/safe_browsing/core/browser/db/util.h" | 2059 | #include "components/safe_browsing/core/browser/db/util.h" |
| @@ -2078,7 +2061,7 @@ | |||
| 2078 | #include "content/public/browser/browser_context.h" | 2061 | #include "content/public/browser/browser_context.h" |
| 2079 | #include "content/public/browser/browser_thread.h" | 2062 | #include "content/public/browser/browser_thread.h" |
| 2080 | #include "services/network/public/mojom/network_context.mojom-forward.h" | 2063 | #include "services/network/public/mojom/network_context.mojom-forward.h" |
| 2081 | @@ -94,15 +93,6 @@ class SafeBrowsingService : public SafeB | 2064 | @@ -97,15 +96,6 @@ class SafeBrowsingService : public SafeB |
| 2082 | // Called on the main thread to let us know that the io_thread is going away. | 2065 | // Called on the main thread to let us know that the io_thread is going away. |
| 2083 | void ShutDown(); | 2066 | void ShutDown(); |
| 2084 | 2067 | ||
| @@ -2094,9 +2077,9 @@ | |||
| 2094 | // Get current enabled status. Must be called on IO thread. | 2077 | // Get current enabled status. Must be called on IO thread. |
| 2095 | bool enabled() const { | 2078 | bool enabled() const { |
| 2096 | DCHECK_CURRENTLY_ON(content::BrowserThread::IO); | 2079 | DCHECK_CURRENTLY_ON(content::BrowserThread::IO); |
| 2097 | @@ -267,10 +257,6 @@ class SafeBrowsingService : public SafeB | 2080 | @@ -287,10 +277,6 @@ class SafeBrowsingService : public SafeB |
| 2098 | 2081 | // Provides phishing and malware statistics. Accessed on UI thread. | |
| 2099 | std::unique_ptr<ProxyConfigMonitor> proxy_config_monitor_; | 2082 | std::unique_ptr<PingManager> ping_manager_; |
| 2100 | 2083 | ||
| 2101 | - // Whether SafeBrowsing Extended Reporting is enabled by the current set of | 2084 | - // Whether SafeBrowsing Extended Reporting is enabled by the current set of |
| 2102 | - // profiles. Updated on the UI thread. | 2085 | - // profiles. Updated on the UI thread. |
| @@ -2105,9 +2088,9 @@ | |||
| 2105 | // Whether the service has been shutdown. | 2088 | // Whether the service has been shutdown. |
| 2106 | bool shutdown_; | 2089 | bool shutdown_; |
| 2107 | 2090 | ||
| 2108 | --- a/chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc | 2091 | --- chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc.orig |
| 2109 | +++ b/chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc | 2092 | +++ chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc |
| 2110 | @@ -28,7 +28,6 @@ | 2093 | @@ -27,7 +27,6 @@ |
| 2111 | #include "components/safe_browsing/core/browser/db/database_manager.h" | 2094 | #include "components/safe_browsing/core/browser/db/database_manager.h" |
| 2112 | #include "components/safe_browsing/core/browser/ping_manager.h" | 2095 | #include "components/safe_browsing/core/browser/ping_manager.h" |
| 2113 | #include "components/safe_browsing/core/common/features.h" | 2096 | #include "components/safe_browsing/core/common/features.h" |
| @@ -2115,7 +2098,7 @@ | |||
| 2115 | #include "content/public/browser/browser_task_traits.h" | 2098 | #include "content/public/browser/browser_task_traits.h" |
| 2116 | #include "content/public/browser/browser_thread.h" | 2099 | #include "content/public/browser/browser_thread.h" |
| 2117 | #include "content/public/browser/download_item_utils.h" | 2100 | #include "content/public/browser/download_item_utils.h" |
| 2118 | @@ -141,11 +140,9 @@ bool AndroidTelemetryService::CanSendPin | 2101 | @@ -142,11 +141,9 @@ bool AndroidTelemetryService::CanSendPin |
| 2119 | return false; | 2102 | return false; |
| 2120 | } | 2103 | } |
| 2121 | 2104 | ||
| @@ -2130,9 +2113,9 @@ | |||
| 2130 | 2113 | ||
| 2131 | if (profile_->IsOffTheRecord()) { | 2114 | if (profile_->IsOffTheRecord()) { |
| 2132 | RecordApkDownloadTelemetryOutcome( | 2115 | RecordApkDownloadTelemetryOutcome( |
| 2133 | --- a/chrome/browser/safe_browsing/telemetry/android/android_telemetry_service_unittest.cc | 2116 | --- chrome/browser/safe_browsing/telemetry/android/android_telemetry_service_unittest.cc.orig |
| 2134 | +++ b/chrome/browser/safe_browsing/telemetry/android/android_telemetry_service_unittest.cc | 2117 | +++ chrome/browser/safe_browsing/telemetry/android/android_telemetry_service_unittest.cc |
| 2135 | @@ -19,7 +19,6 @@ | 2118 | @@ -18,7 +18,6 @@ |
| 2136 | #include "components/download/public/common/mock_download_item.h" | 2119 | #include "components/download/public/common/mock_download_item.h" |
| 2137 | #include "components/prefs/pref_service.h" | 2120 | #include "components/prefs/pref_service.h" |
| 2138 | #include "components/safe_browsing/core/common/features.h" | 2121 | #include "components/safe_browsing/core/common/features.h" |
| @@ -2140,8 +2123,8 @@ | |||
| 2140 | #include "content/public/browser/browser_task_traits.h" | 2123 | #include "content/public/browser/browser_task_traits.h" |
| 2141 | #include "content/public/browser/browser_thread.h" | 2124 | #include "content/public/browser/browser_thread.h" |
| 2142 | #include "content/public/browser/download_item_utils.h" | 2125 | #include "content/public/browser/download_item_utils.h" |
| 2143 | --- a/chrome/browser/safe_browsing/url_checker_delegate_impl.cc | 2126 | --- chrome/browser/safe_browsing/url_checker_delegate_impl.cc.orig |
| 2144 | +++ b/chrome/browser/safe_browsing/url_checker_delegate_impl.cc | 2127 | +++ chrome/browser/safe_browsing/url_checker_delegate_impl.cc |
| 2145 | @@ -21,7 +21,6 @@ | 2128 | @@ -21,7 +21,6 @@ |
| 2146 | #include "components/safe_browsing/core/browser/db/database_manager.h" | 2129 | #include "components/safe_browsing/core/browser/db/database_manager.h" |
| 2147 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" | 2130 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" |
| @@ -2150,9 +2133,9 @@ | |||
| 2150 | #include "components/security_interstitials/content/unsafe_resource_util.h" | 2133 | #include "components/security_interstitials/content/unsafe_resource_util.h" |
| 2151 | #include "content/public/browser/browser_task_traits.h" | 2134 | #include "content/public/browser/browser_task_traits.h" |
| 2152 | #include "content/public/browser/browser_thread.h" | 2135 | #include "content/public/browser/browser_thread.h" |
| 2153 | --- a/chrome/browser/signin/account_consistency_mode_manager.cc | 2136 | --- chrome/browser/signin/account_consistency_mode_manager.cc.orig |
| 2154 | +++ b/chrome/browser/signin/account_consistency_mode_manager.cc | 2137 | +++ chrome/browser/signin/account_consistency_mode_manager.cc |
| 2155 | @@ -20,7 +20,6 @@ | 2138 | @@ -19,7 +19,6 @@ |
| 2156 | #include "components/pref_registry/pref_registry_syncable.h" | 2139 | #include "components/pref_registry/pref_registry_syncable.h" |
| 2157 | #include "components/prefs/pref_service.h" | 2140 | #include "components/prefs/pref_service.h" |
| 2158 | #include "components/signin/public/base/signin_buildflags.h" | 2141 | #include "components/signin/public/base/signin_buildflags.h" |
| @@ -2160,7 +2143,7 @@ | |||
| 2160 | #include "google_apis/google_api_keys.h" | 2143 | #include "google_apis/google_api_keys.h" |
| 2161 | 2144 | ||
| 2162 | #if BUILDFLAG(IS_CHROMEOS_ASH) | 2145 | #if BUILDFLAG(IS_CHROMEOS_ASH) |
| 2163 | @@ -97,7 +96,6 @@ AccountConsistencyModeManager::AccountCo | 2146 | @@ -98,7 +97,6 @@ AccountConsistencyModeManager::AccountCo |
| 2164 | // pref. | 2147 | // pref. |
| 2165 | bool signin_allowed = IsDiceSignInAllowed() && | 2148 | bool signin_allowed = IsDiceSignInAllowed() && |
| 2166 | prefs->GetBoolean(prefs::kSigninAllowedOnNextStartup); | 2149 | prefs->GetBoolean(prefs::kSigninAllowedOnNextStartup); |
| @@ -2168,8 +2151,8 @@ | |||
| 2168 | 2151 | ||
| 2169 | UMA_HISTOGRAM_BOOLEAN("Signin.SigninAllowed", signin_allowed); | 2152 | UMA_HISTOGRAM_BOOLEAN("Signin.SigninAllowed", signin_allowed); |
| 2170 | #endif | 2153 | #endif |
| 2171 | @@ -192,16 +190,7 @@ AccountConsistencyModeManager::ComputeAc | 2154 | @@ -196,16 +194,7 @@ AccountConsistencyModeManager::ComputeAc |
| 2172 | return AccountConsistencyMethod::kMirror; | 2155 | // AccountManager is not available, when DICE has been disabled on Lacros. |
| 2173 | #endif | 2156 | #endif |
| 2174 | 2157 | ||
| 2175 | -#if BUILDFLAG(ENABLE_DICE_SUPPORT) | 2158 | -#if BUILDFLAG(ENABLE_DICE_SUPPORT) |
| @@ -2185,9 +2168,9 @@ | |||
| 2185 | - NOTREACHED(); | 2168 | - NOTREACHED(); |
| 2186 | return AccountConsistencyMethod::kDisabled; | 2169 | return AccountConsistencyMethod::kDisabled; |
| 2187 | } | 2170 | } |
| 2188 | --- a/chrome/browser/signin/account_consistency_mode_manager_unittest.cc | 2171 | --- chrome/browser/signin/account_consistency_mode_manager_unittest.cc.orig |
| 2189 | +++ b/chrome/browser/signin/account_consistency_mode_manager_unittest.cc | 2172 | +++ chrome/browser/signin/account_consistency_mode_manager_unittest.cc |
| 2190 | @@ -19,7 +19,6 @@ | 2173 | @@ -20,7 +20,6 @@ |
| 2191 | #include "components/prefs/testing_pref_store.h" | 2174 | #include "components/prefs/testing_pref_store.h" |
| 2192 | #include "components/signin/public/base/account_consistency_method.h" | 2175 | #include "components/signin/public/base/account_consistency_method.h" |
| 2193 | #include "components/signin/public/base/signin_buildflags.h" | 2176 | #include "components/signin/public/base/signin_buildflags.h" |
| @@ -2195,33 +2178,33 @@ | |||
| 2195 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 2178 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 2196 | #include "content/public/test/browser_task_environment.h" | 2179 | #include "content/public/test/browser_task_environment.h" |
| 2197 | #include "testing/gtest/include/gtest/gtest.h" | 2180 | #include "testing/gtest/include/gtest/gtest.h" |
| 2198 | --- a/chrome/browser/signin/chrome_device_id_helper.cc | 2181 | --- chrome/browser/signin/chrome_device_id_helper.cc.orig |
| 2199 | +++ b/chrome/browser/signin/chrome_device_id_helper.cc | 2182 | +++ chrome/browser/signin/chrome_device_id_helper.cc |
| 2200 | @@ -17,7 +17,6 @@ | 2183 | @@ -16,7 +16,6 @@ |
| 2184 | #include "base/logging.h" | ||
| 2201 | #include "chrome/browser/ash/profiles/profile_helper.h" | 2185 | #include "chrome/browser/ash/profiles/profile_helper.h" |
| 2202 | #include "chrome/browser/browser_process.h" | ||
| 2203 | #include "components/prefs/pref_service.h" | 2186 | #include "components/prefs/pref_service.h" |
| 2204 | -#include "components/signin/public/base/signin_pref_names.h" | 2187 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2205 | #include "components/signin/public/base/signin_switches.h" | 2188 | #include "components/signin/public/base/signin_switches.h" |
| 2206 | #include "components/user_manager/known_user.h" | 2189 | #include "components/user_manager/known_user.h" |
| 2207 | #include "components/user_manager/user_manager.h" | 2190 | #include "components/user_manager/user_manager.h" |
| 2208 | @@ -70,21 +69,11 @@ void MigrateSigninScopedDeviceId(Profile | 2191 | @@ -67,21 +66,11 @@ void MigrateSigninScopedDeviceId(Profile |
| 2209 | user_manager::KnownUser known_user(g_browser_process->local_state()); | 2192 | return; |
| 2210 | const AccountId account_id = user->GetAccountId(); | 2193 | const AccountId account_id = user->GetAccountId(); |
| 2211 | if (known_user.GetDeviceId(account_id).empty()) { | 2194 | if (user_manager::known_user::GetDeviceId(account_id).empty()) { |
| 2212 | - const std::string legacy_device_id = profile->GetPrefs()->GetString( | 2195 | - const std::string legacy_device_id = profile->GetPrefs()->GetString( |
| 2213 | - prefs::kGoogleServicesSigninScopedDeviceId); | 2196 | - prefs::kGoogleServicesSigninScopedDeviceId); |
| 2214 | - if (!legacy_device_id.empty()) { | 2197 | - if (!legacy_device_id.empty()) { |
| 2215 | - // Need to move device ID from the old location to the new one, if it has | 2198 | - // Need to move device ID from the old location to the new one, if it has |
| 2216 | - // not been done yet. | 2199 | - // not been done yet. |
| 2217 | - known_user.SetDeviceId(account_id, legacy_device_id); | 2200 | - user_manager::known_user::SetDeviceId(account_id, legacy_device_id); |
| 2218 | - } else { | 2201 | - } else { |
| 2219 | - known_user.SetDeviceId( | 2202 | - user_manager::known_user::SetDeviceId( |
| 2220 | - account_id, GenerateSigninScopedDeviceId( | 2203 | - account_id, GenerateSigninScopedDeviceId( |
| 2221 | - user_manager::UserManager::Get() | 2204 | - user_manager::UserManager::Get() |
| 2222 | - ->IsUserNonCryptohomeDataEphemeral(account_id))); | 2205 | - ->IsUserNonCryptohomeDataEphemeral(account_id))); |
| 2223 | - } | 2206 | - } |
| 2224 | + known_user.SetDeviceId( | 2207 | + user_manager::known_user::SetDeviceId( |
| 2225 | + account_id, GenerateSigninScopedDeviceId( | 2208 | + account_id, GenerateSigninScopedDeviceId( |
| 2226 | + user_manager::UserManager::Get() | 2209 | + user_manager::UserManager::Get() |
| 2227 | + ->IsUserNonCryptohomeDataEphemeral(account_id))); | 2210 | + ->IsUserNonCryptohomeDataEphemeral(account_id))); |
| @@ -2231,8 +2214,8 @@ | |||
| 2231 | } | 2214 | } |
| 2232 | 2215 | ||
| 2233 | #endif | 2216 | #endif |
| 2234 | --- a/chrome/browser/signin/chrome_signin_client.cc | 2217 | --- chrome/browser/signin/chrome_signin_client.cc.orig |
| 2235 | +++ b/chrome/browser/signin/chrome_signin_client.cc | 2218 | +++ chrome/browser/signin/chrome_signin_client.cc |
| 2236 | @@ -38,7 +38,6 @@ | 2219 | @@ -38,7 +38,6 @@ |
| 2237 | #include "components/prefs/pref_service.h" | 2220 | #include "components/prefs/pref_service.h" |
| 2238 | #include "components/signin/core/browser/cookie_settings_util.h" | 2221 | #include "components/signin/core/browser/cookie_settings_util.h" |
| @@ -2241,8 +2224,8 @@ | |||
| 2241 | #include "components/signin/public/identity_manager/access_token_info.h" | 2224 | #include "components/signin/public/identity_manager/access_token_info.h" |
| 2242 | #include "components/signin/public/identity_manager/identity_manager.h" | 2225 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2243 | #include "components/signin/public/identity_manager/scope_set.h" | 2226 | #include "components/signin/public/identity_manager/scope_set.h" |
| 2244 | --- a/chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc | 2227 | --- chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc.orig |
| 2245 | +++ b/chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc | 2228 | +++ chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc |
| 2246 | @@ -21,7 +21,6 @@ | 2229 | @@ -21,7 +21,6 @@ |
| 2247 | #include "components/network_session_configurator/common/network_switches.h" | 2230 | #include "components/network_session_configurator/common/network_switches.h" |
| 2248 | #include "components/prefs/pref_service.h" | 2231 | #include "components/prefs/pref_service.h" |
| @@ -2251,9 +2234,9 @@ | |||
| 2251 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 2234 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 2252 | #include "components/user_manager/user.h" | 2235 | #include "components/user_manager/user.h" |
| 2253 | #include "components/user_manager/user_manager.h" | 2236 | #include "components/user_manager/user_manager.h" |
| 2254 | --- a/chrome/browser/signin/dice_browsertest.cc | 2237 | --- chrome/browser/signin/dice_browsertest.cc.orig |
| 2255 | +++ b/chrome/browser/signin/dice_browsertest.cc | 2238 | +++ chrome/browser/signin/dice_browsertest.cc |
| 2256 | @@ -60,7 +60,6 @@ | 2239 | @@ -59,7 +59,6 @@ |
| 2257 | #include "components/signin/public/base/account_consistency_method.h" | 2240 | #include "components/signin/public/base/account_consistency_method.h" |
| 2258 | #include "components/signin/public/base/signin_client.h" | 2241 | #include "components/signin/public/base/signin_client.h" |
| 2259 | #include "components/signin/public/base/signin_metrics.h" | 2242 | #include "components/signin/public/base/signin_metrics.h" |
| @@ -2261,8 +2244,8 @@ | |||
| 2261 | #include "components/signin/public/identity_manager/identity_manager.h" | 2244 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2262 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 2245 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 2263 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | 2246 | #include "components/signin/public/identity_manager/primary_account_mutator.h" |
| 2264 | --- a/chrome/browser/signin/header_modification_delegate_impl.cc | 2247 | --- chrome/browser/signin/header_modification_delegate_impl.cc.orig |
| 2265 | +++ b/chrome/browser/signin/header_modification_delegate_impl.cc | 2248 | +++ chrome/browser/signin/header_modification_delegate_impl.cc |
| 2266 | @@ -15,7 +15,6 @@ | 2249 | @@ -15,7 +15,6 @@ |
| 2267 | #include "chrome/browser/sync/sync_service_factory.h" | 2250 | #include "chrome/browser/sync/sync_service_factory.h" |
| 2268 | #include "chrome/common/pref_names.h" | 2251 | #include "chrome/common/pref_names.h" |
| @@ -2280,9 +2263,9 @@ | |||
| 2280 | #endif | 2263 | #endif |
| 2281 | cookie_settings_.get()); | 2264 | cookie_settings_.get()); |
| 2282 | } | 2265 | } |
| 2283 | --- a/chrome/browser/signin/mirror_browsertest.cc | 2266 | --- chrome/browser/signin/mirror_browsertest.cc.orig |
| 2284 | +++ b/chrome/browser/signin/mirror_browsertest.cc | 2267 | +++ chrome/browser/signin/mirror_browsertest.cc |
| 2285 | @@ -30,7 +30,6 @@ | 2268 | @@ -31,7 +31,6 @@ |
| 2286 | #include "components/prefs/pref_service.h" | 2269 | #include "components/prefs/pref_service.h" |
| 2287 | #include "components/signin/core/browser/dice_header_helper.h" | 2270 | #include "components/signin/core/browser/dice_header_helper.h" |
| 2288 | #include "components/signin/core/browser/signin_header_helper.h" | 2271 | #include "components/signin/core/browser/signin_header_helper.h" |
| @@ -2290,97 +2273,29 @@ | |||
| 2290 | #include "content/public/common/content_client.h" | 2273 | #include "content/public/common/content_client.h" |
| 2291 | #include "content/public/test/browser_test.h" | 2274 | #include "content/public/test/browser_test.h" |
| 2292 | #include "google_apis/gaia/gaia_urls.h" | 2275 | #include "google_apis/gaia/gaia_urls.h" |
| 2293 | --- a/chrome/browser/signin/primary_account_policy_manager.cc | 2276 | --- chrome/browser/signin/signin_manager.cc.orig |
| 2294 | +++ b/chrome/browser/signin/primary_account_policy_manager.cc | 2277 | +++ chrome/browser/signin/signin_manager.cc |
| 2295 | @@ -14,7 +14,6 @@ | 2278 | @@ -5,7 +5,6 @@ |
| 2296 | #include "chrome/grit/generated_resources.h" | 2279 | #include "chrome/browser/signin/signin_manager.h" |
| 2297 | #include "components/prefs/pref_service.h" | ||
| 2298 | #include "components/signin/public/base/signin_metrics.h" | ||
| 2299 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 2300 | #include "components/signin/public/identity_manager/account_info.h" | ||
| 2301 | #include "components/signin/public/identity_manager/identity_manager.h" | ||
| 2302 | #include "components/signin/public/identity_manager/identity_utils.h" | ||
| 2303 | @@ -178,23 +177,11 @@ void PrimaryAccountPolicyManager::Initia | ||
| 2304 | EnsurePrimaryAccountAllowedForProfile( | ||
| 2305 | profile_, signin_metrics::SIGNIN_NOT_ALLOWED_ON_PROFILE_INIT); | ||
| 2306 | 2280 | ||
| 2307 | - signin_allowed_.Init( | ||
| 2308 | - prefs::kSigninAllowed, profile_->GetPrefs(), | ||
| 2309 | - base::BindRepeating( | ||
| 2310 | - &PrimaryAccountPolicyManager::OnSigninAllowedPrefChanged, | ||
| 2311 | - weak_pointer_factory_.GetWeakPtr())); | ||
| 2312 | - | ||
| 2313 | local_state_pref_registrar_.Init(g_browser_process->local_state()); | ||
| 2314 | - local_state_pref_registrar_.Add( | ||
| 2315 | - prefs::kGoogleServicesUsernamePattern, | ||
| 2316 | - base::BindRepeating( | ||
| 2317 | - &PrimaryAccountPolicyManager::OnGoogleServicesUsernamePatternChanged, | ||
| 2318 | - weak_pointer_factory_.GetWeakPtr())); | ||
| 2319 | } | ||
| 2320 | |||
| 2321 | void PrimaryAccountPolicyManager::Shutdown() { | ||
| 2322 | local_state_pref_registrar_.RemoveAll(); | ||
| 2323 | - signin_allowed_.Destroy(); | ||
| 2324 | } | ||
| 2325 | |||
| 2326 | void PrimaryAccountPolicyManager::OnGoogleServicesUsernamePatternChanged() { | ||
| 2327 | @@ -219,11 +206,6 @@ void PrimaryAccountPolicyManager::Ensure | ||
| 2328 | |||
| 2329 | CoreAccountInfo primary_account = | ||
| 2330 | identity_manager->GetPrimaryAccountInfo(signin::ConsentLevel::kSync); | ||
| 2331 | - if (profile->GetPrefs()->GetBoolean(prefs::kSigninAllowed) && | ||
| 2332 | - signin::IsUsernameAllowedByPatternFromPrefs( | ||
| 2333 | - g_browser_process->local_state(), primary_account.email)) { | ||
| 2334 | - return; | ||
| 2335 | - } | ||
| 2336 | |||
| 2337 | #if BUILDFLAG(IS_CHROMEOS_LACROS) | ||
| 2338 | // Disabling signin in chrome and 'RestrictSigninToPattern' policy | ||
| 2339 | --- a/chrome/browser/signin/primary_account_policy_manager.h | ||
| 2340 | +++ b/chrome/browser/signin/primary_account_policy_manager.h | ||
| 2341 | @@ -61,9 +61,6 @@ class PrimaryAccountPolicyManager : publ | ||
| 2342 | |||
| 2343 | raw_ptr<Profile> profile_; | ||
| 2344 | |||
| 2345 | - // Helper object to listen for changes to the signin allowed preference. | ||
| 2346 | - BooleanPrefMember signin_allowed_; | ||
| 2347 | - | ||
| 2348 | // Helper object to listen for changes to signin preferences stored in non- | ||
| 2349 | // profile-specific local prefs (like kGoogleServicesUsernamePattern). | ||
| 2350 | PrefChangeRegistrar local_state_pref_registrar_; | ||
| 2351 | --- a/chrome/browser/signin/primary_account_policy_manager_unittest.cc | ||
| 2352 | +++ b/chrome/browser/signin/primary_account_policy_manager_unittest.cc | ||
| 2353 | @@ -14,7 +14,6 @@ | ||
| 2354 | #include "chrome/test/base/testing_browser_process.h" | ||
| 2355 | #include "chrome/test/base/testing_profile.h" | ||
| 2356 | #include "chrome/test/base/testing_profile_manager.h" | ||
| 2357 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 2358 | #include "components/signin/public/identity_manager/identity_test_environment.h" | ||
| 2359 | #include "content/public/test/browser_task_environment.h" | ||
| 2360 | #include "testing/gtest/include/gtest/gtest.h" | ||
| 2361 | --- a/chrome/browser/signin/signin_manager.cc | ||
| 2362 | +++ b/chrome/browser/signin/signin_manager.cc | ||
| 2363 | @@ -6,7 +6,6 @@ | ||
| 2364 | |||
| 2365 | #include "base/bind.h" | ||
| 2366 | #include "components/prefs/pref_service.h" | 2281 | #include "components/prefs/pref_service.h" |
| 2367 | -#include "components/signin/public/base/signin_pref_names.h" | 2282 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2368 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" | 2283 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" |
| 2369 | #include "components/signin/public/identity_manager/identity_manager.h" | 2284 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2370 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | 2285 | #include "components/signin/public/identity_manager/primary_account_mutator.h" |
| 2371 | @@ -21,11 +20,6 @@ SigninManager::SigninManager(PrefService | 2286 | @@ -13,11 +12,6 @@ |
| 2372 | signin::IdentityManager* identity_manager, | 2287 | SigninManager::SigninManager(PrefService* prefs, |
| 2373 | SigninClient* client) | 2288 | signin::IdentityManager* identity_manager) |
| 2374 | : prefs_(prefs), identity_manager_(identity_manager) { | 2289 | : prefs_(prefs), identity_manager_(identity_manager) { |
| 2375 | - signin_allowed_.Init( | 2290 | - signin_allowed_.Init( |
| 2376 | - prefs::kSigninAllowed, prefs_, | 2291 | - prefs::kSigninAllowed, prefs_, |
| 2377 | - base::BindRepeating(&SigninManager::OnSigninAllowedPrefChanged, | 2292 | - base::BindRepeating(&SigninManager::OnSigninAllowedPrefChanged, |
| 2378 | - base::Unretained(this))); | 2293 | - base::Unretained(this))); |
| 2379 | - | 2294 | - |
| 2380 | #if BUILDFLAG(IS_CHROMEOS_LACROS) | 2295 | UpdateUnconsentedPrimaryAccount(); |
| 2381 | is_main_profile_ = client->GetInitialPrimaryAccount().has_value(); | 2296 | identity_manager_->AddObserver(this); |
| 2382 | #endif | 2297 | } |
| 2383 | @@ -128,16 +122,6 @@ CoreAccountInfo SigninManager::ComputeUn | 2298 | @@ -63,16 +57,6 @@ SigninManager::ComputeUnconsentedPrimary |
| 2384 | signin::ConsentLevel::kSync); | 2299 | signin::ConsentLevel::kSync); |
| 2385 | } | 2300 | } |
| 2386 | 2301 | ||
| @@ -2392,13 +2307,13 @@ | |||
| 2392 | - // It was considered simpler to keep the logic to update the unconsented | 2307 | - // It was considered simpler to keep the logic to update the unconsented |
| 2393 | - // primary account in a single place. | 2308 | - // primary account in a single place. |
| 2394 | - if (!signin_allowed_.GetValue()) | 2309 | - if (!signin_allowed_.GetValue()) |
| 2395 | - return CoreAccountInfo(); | 2310 | - return absl::nullopt; |
| 2396 | - | 2311 | - |
| 2397 | signin::AccountsInCookieJarInfo cookie_info = | 2312 | signin::AccountsInCookieJarInfo cookie_info = |
| 2398 | identity_manager_->GetAccountsInCookieJar(); | 2313 | identity_manager_->GetAccountsInCookieJar(); |
| 2399 | 2314 | ||
| 2400 | --- a/chrome/browser/signin/signin_promo_util.cc | 2315 | --- chrome/browser/signin/signin_promo_util.cc.orig |
| 2401 | +++ b/chrome/browser/signin/signin_promo_util.cc | 2316 | +++ chrome/browser/signin/signin_promo_util.cc |
| 2402 | @@ -8,7 +8,6 @@ | 2317 | @@ -8,7 +8,6 @@ |
| 2403 | #include "chrome/browser/profiles/profile.h" | 2318 | #include "chrome/browser/profiles/profile.h" |
| 2404 | #include "chrome/browser/signin/identity_manager_factory.h" | 2319 | #include "chrome/browser/signin/identity_manager_factory.h" |
| @@ -2416,18 +2331,37 @@ | |||
| 2416 | return false; | 2331 | return false; |
| 2417 | 2332 | ||
| 2418 | // Display the signin promo if the user is not signed in. | 2333 | // Display the signin promo if the user is not signed in. |
| 2419 | --- a/chrome/browser/signin/signin_ui_util.cc | 2334 | --- chrome/browser/signin/signin_ui_util.cc.orig |
| 2420 | +++ b/chrome/browser/signin/signin_ui_util.cc | 2335 | +++ chrome/browser/signin/signin_ui_util.cc |
| 2421 | @@ -39,7 +39,6 @@ | 2336 | @@ -34,7 +34,6 @@ |
| 2337 | #include "components/feature_engagement/public/tracker.h" | ||
| 2422 | #include "components/prefs/pref_service.h" | 2338 | #include "components/prefs/pref_service.h" |
| 2423 | #include "components/signin/public/base/consent_level.h" | ||
| 2424 | #include "components/signin/public/base/signin_metrics.h" | 2339 | #include "components/signin/public/base/signin_metrics.h" |
| 2425 | -#include "components/signin/public/base/signin_pref_names.h" | 2340 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2426 | #include "components/signin/public/identity_manager/account_info.h" | 2341 | #include "components/signin/public/identity_manager/account_info.h" |
| 2427 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" | 2342 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" |
| 2343 | #include "components/signin/public/identity_manager/consent_level.h" | ||
| 2344 | --- chrome/browser/signin/signin_util.cc.orig | ||
| 2345 | +++ chrome/browser/signin/signin_util.cc | ||
| 2346 | @@ -30,7 +30,6 @@ | ||
| 2347 | #include "components/google/core/common/google_util.h" | ||
| 2348 | #include "components/prefs/pref_service.h" | ||
| 2349 | #include "components/signin/public/base/signin_metrics.h" | ||
| 2350 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 2428 | #include "components/signin/public/identity_manager/identity_manager.h" | 2351 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2429 | --- a/chrome/browser/signin/signin_util_win.cc | 2352 | #include "components/signin/public/identity_manager/identity_utils.h" |
| 2430 | +++ b/chrome/browser/signin/signin_util_win.cc | 2353 | #include "components/signin/public/identity_manager/primary_account_mutator.h" |
| 2354 | @@ -232,7 +231,7 @@ void EnsurePrimaryAccountAllowedForProfi | ||
| 2355 | |||
| 2356 | CoreAccountInfo primary_account = | ||
| 2357 | identity_manager->GetPrimaryAccountInfo(signin::ConsentLevel::kSync); | ||
| 2358 | - if (profile->GetPrefs()->GetBoolean(prefs::kSigninAllowed) && | ||
| 2359 | + if (false && | ||
| 2360 | signin::IsUsernameAllowedByPatternFromPrefs( | ||
| 2361 | g_browser_process->local_state(), primary_account.email)) { | ||
| 2362 | return; | ||
| 2363 | --- chrome/browser/signin/signin_util_win.cc.orig | ||
| 2364 | +++ chrome/browser/signin/signin_util_win.cc | ||
| 2431 | @@ -34,7 +34,6 @@ | 2365 | @@ -34,7 +34,6 @@ |
| 2432 | #include "components/prefs/pref_service.h" | 2366 | #include "components/prefs/pref_service.h" |
| 2433 | #include "components/signin/core/browser/about_signin_internals.h" | 2367 | #include "components/signin/core/browser/about_signin_internals.h" |
| @@ -2436,8 +2370,8 @@ | |||
| 2436 | #include "components/signin/public/identity_manager/accounts_mutator.h" | 2370 | #include "components/signin/public/identity_manager/accounts_mutator.h" |
| 2437 | #include "components/signin/public/identity_manager/identity_manager.h" | 2371 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2438 | 2372 | ||
| 2439 | @@ -134,9 +133,6 @@ void ImportCredentialsFromProvider(Profi | 2373 | @@ -136,9 +135,6 @@ void ImportCredentialsFromProvider(Profi |
| 2440 | account_id, nullptr, profile)); | 2374 | account_id, nullptr)); |
| 2441 | } | 2375 | } |
| 2442 | } | 2376 | } |
| 2443 | - | 2377 | - |
| @@ -2446,7 +2380,7 @@ | |||
| 2446 | } | 2380 | } |
| 2447 | 2381 | ||
| 2448 | // Extracts the |cred_provider_gaia_id| and |cred_provider_email| for the user | 2382 | // Extracts the |cred_provider_gaia_id| and |cred_provider_email| for the user |
| 2449 | @@ -311,20 +307,7 @@ bool ReauthWithCredentialProviderIfPossi | 2383 | @@ -313,20 +309,7 @@ bool ReauthWithCredentialProviderIfPossi |
| 2450 | // - The profile is marked as having been signed in with a system credential. | 2384 | // - The profile is marked as having been signed in with a system credential. |
| 2451 | // - The profile is already signed in. | 2385 | // - The profile is already signed in. |
| 2452 | // - The profile is in an auth error state. | 2386 | // - The profile is in an auth error state. |
| @@ -2467,8 +2401,8 @@ | |||
| 2467 | } | 2401 | } |
| 2468 | 2402 | ||
| 2469 | } // namespace signin_util | 2403 | } // namespace signin_util |
| 2470 | --- a/chrome/browser/signin/signin_util_win_browsertest.cc | 2404 | --- chrome/browser/signin/signin_util_win_browsertest.cc.orig |
| 2471 | +++ b/chrome/browser/signin/signin_util_win_browsertest.cc | 2405 | +++ chrome/browser/signin/signin_util_win_browsertest.cc |
| 2472 | @@ -31,7 +31,6 @@ | 2406 | @@ -31,7 +31,6 @@ |
| 2473 | #include "chrome/test/base/in_process_browser_test.h" | 2407 | #include "chrome/test/base/in_process_browser_test.h" |
| 2474 | #include "chrome/test/base/testing_browser_process.h" | 2408 | #include "chrome/test/base/testing_browser_process.h" |
| @@ -2477,9 +2411,9 @@ | |||
| 2477 | #include "components/signin/public/identity_manager/identity_manager.h" | 2411 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2478 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 2412 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 2479 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | 2413 | #include "components/signin/public/identity_manager/primary_account_mutator.h" |
| 2480 | --- a/chrome/browser/ssl/certificate_reporting_test_utils.cc | 2414 | --- chrome/browser/ssl/certificate_reporting_test_utils.cc.orig |
| 2481 | +++ b/chrome/browser/ssl/certificate_reporting_test_utils.cc | 2415 | +++ chrome/browser/ssl/certificate_reporting_test_utils.cc |
| 2482 | @@ -14,7 +14,6 @@ | 2416 | @@ -15,7 +15,6 @@ |
| 2483 | #include "build/build_config.h" | 2417 | #include "build/build_config.h" |
| 2484 | #include "chrome/browser/profiles/profile.h" | 2418 | #include "chrome/browser/profiles/profile.h" |
| 2485 | #include "components/prefs/pref_service.h" | 2419 | #include "components/prefs/pref_service.h" |
| @@ -2487,38 +2421,29 @@ | |||
| 2487 | #include "components/security_interstitials/content/cert_report_helper.h" | 2421 | #include "components/security_interstitials/content/cert_report_helper.h" |
| 2488 | #include "components/security_interstitials/content/certificate_error_report.h" | 2422 | #include "components/security_interstitials/content/certificate_error_report.h" |
| 2489 | #include "components/variations/variations_associated_data.h" | 2423 | #include "components/variations/variations_associated_data.h" |
| 2490 | --- a/chrome/browser/ssl/sct_reporting_service.cc | 2424 | --- chrome/browser/ssl/sct_reporting_service.cc.orig |
| 2491 | +++ b/chrome/browser/ssl/sct_reporting_service.cc | 2425 | +++ chrome/browser/ssl/sct_reporting_service.cc |
| 2492 | @@ -12,7 +12,6 @@ | 2426 | @@ -9,7 +9,6 @@ |
| 2427 | #include "chrome/browser/net/system_network_context_manager.h" | ||
| 2428 | #include "chrome/browser/safe_browsing/safe_browsing_service.h" | ||
| 2493 | #include "chrome/common/chrome_features.h" | 2429 | #include "chrome/common/chrome_features.h" |
| 2494 | #include "chrome/common/pref_names.h" | ||
| 2495 | #include "components/prefs/pref_service.h" | ||
| 2496 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 2430 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 2497 | #include "content/public/browser/network_service_instance.h" | 2431 | #include "content/public/browser/network_service_instance.h" |
| 2498 | #include "content/public/browser/storage_partition.h" | 2432 | #include "content/public/browser/storage_partition.h" |
| 2499 | #include "google_apis/google_api_keys.h" | 2433 | #include "net/traffic_annotation/network_traffic_annotation.h" |
| 2500 | @@ -199,18 +198,6 @@ void SetSCTAuditingEnabledForStoragePart | 2434 | @@ -119,8 +118,5 @@ void SCTReportingService::SetReportingEn |
| 2501 | } // namespace | ||
| 2502 | |||
| 2503 | network::mojom::SCTAuditingMode SCTReportingService::GetReportingMode() { | ||
| 2504 | - if (profile_->IsOffTheRecord() || | ||
| 2505 | - !base::FeatureList::IsEnabled(features::kSCTAuditing)) { | ||
| 2506 | - return network::mojom::SCTAuditingMode::kDisabled; | ||
| 2507 | - } | ||
| 2508 | - if (safe_browsing::IsSafeBrowsingEnabled(pref_service_)) { | ||
| 2509 | - if (safe_browsing::IsExtendedReportingEnabled(pref_service_)) { | ||
| 2510 | - return network::mojom::SCTAuditingMode::kEnhancedSafeBrowsingReporting; | ||
| 2511 | - } | ||
| 2512 | - if (base::FeatureList::IsEnabled(features::kSCTAuditingHashdance)) { | ||
| 2513 | - return network::mojom::SCTAuditingMode::kHashdance; | ||
| 2514 | - } | ||
| 2515 | - } | ||
| 2516 | return network::mojom::SCTAuditingMode::kDisabled; | ||
| 2517 | } | 2435 | } |
| 2518 | 2436 | ||
| 2519 | --- a/chrome/browser/ssl/ssl_browsertest.cc | 2437 | void SCTReportingService::OnPreferenceChanged() { |
| 2520 | +++ b/chrome/browser/ssl/ssl_browsertest.cc | 2438 | - const bool enabled = safe_browsing_service_ && |
| 2521 | @@ -93,7 +93,6 @@ | 2439 | - safe_browsing_service_->enabled_by_prefs() && |
| 2440 | - safe_browsing::IsExtendedReportingEnabled(pref_service_); | ||
| 2441 | - SetReportingEnabled(enabled); | ||
| 2442 | + SetReportingEnabled(false); | ||
| 2443 | } | ||
| 2444 | --- chrome/browser/ssl/ssl_browsertest.cc.orig | ||
| 2445 | +++ chrome/browser/ssl/ssl_browsertest.cc | ||
| 2446 | @@ -94,7 +94,6 @@ | ||
| 2522 | #include "components/policy/policy_constants.h" | 2447 | #include "components/policy/policy_constants.h" |
| 2523 | #include "components/prefs/testing_pref_service.h" | 2448 | #include "components/prefs/testing_pref_service.h" |
| 2524 | #include "components/safe_browsing/core/common/features.h" | 2449 | #include "components/safe_browsing/core/common/features.h" |
| @@ -2526,9 +2451,9 @@ | |||
| 2526 | #include "components/security_interstitials/content/bad_clock_blocking_page.h" | 2451 | #include "components/security_interstitials/content/bad_clock_blocking_page.h" |
| 2527 | #include "components/security_interstitials/content/captive_portal_blocking_page.h" | 2452 | #include "components/security_interstitials/content/captive_portal_blocking_page.h" |
| 2528 | #include "components/security_interstitials/content/cert_report_helper.h" | 2453 | #include "components/security_interstitials/content/cert_report_helper.h" |
| 2529 | --- a/chrome/browser/ssl/ssl_error_controller_client.cc | 2454 | --- chrome/browser/ssl/ssl_error_controller_client.cc.orig |
| 2530 | +++ b/chrome/browser/ssl/ssl_error_controller_client.cc | 2455 | +++ chrome/browser/ssl/ssl_error_controller_client.cc |
| 2531 | @@ -22,7 +22,6 @@ | 2456 | @@ -23,7 +23,6 @@ |
| 2532 | #include "chrome/browser/ssl/stateful_ssl_host_state_delegate_factory.h" | 2457 | #include "chrome/browser/ssl/stateful_ssl_host_state_delegate_factory.h" |
| 2533 | #include "chrome/common/pref_names.h" | 2458 | #include "chrome/common/pref_names.h" |
| 2534 | #include "chrome/common/url_constants.h" | 2459 | #include "chrome/common/url_constants.h" |
| @@ -2536,17 +2461,17 @@ | |||
| 2536 | #include "components/security_interstitials/content/content_metrics_helper.h" | 2461 | #include "components/security_interstitials/content/content_metrics_helper.h" |
| 2537 | #include "components/security_interstitials/content/settings_page_helper.h" | 2462 | #include "components/security_interstitials/content/settings_page_helper.h" |
| 2538 | #include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h" | 2463 | #include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h" |
| 2539 | --- a/chrome/browser/supervised_user/supervised_user_pref_store.cc | 2464 | --- chrome/browser/supervised_user/supervised_user_pref_store.cc.orig |
| 2540 | +++ b/chrome/browser/supervised_user/supervised_user_pref_store.cc | 2465 | +++ chrome/browser/supervised_user/supervised_user_pref_store.cc |
| 2541 | @@ -25,7 +25,6 @@ | 2466 | @@ -23,7 +23,6 @@ |
| 2542 | #include "chrome/common/pref_names.h" | 2467 | #include "chrome/common/pref_names.h" |
| 2543 | #include "components/feed/core/shared_prefs/pref_names.h" | 2468 | #include "components/feed/core/shared_prefs/pref_names.h" |
| 2544 | #include "components/prefs/pref_value_map.h" | 2469 | #include "components/prefs/pref_value_map.h" |
| 2545 | -#include "components/signin/public/base/signin_pref_names.h" | 2470 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2546 | #include "components/signin/public/base/signin_switches.h" | ||
| 2547 | #include "extensions/buildflags/buildflags.h" | 2471 | #include "extensions/buildflags/buildflags.h" |
| 2548 | 2472 | ||
| 2549 | @@ -58,10 +57,6 @@ SupervisedUserSettingsPrefMappingEntry k | 2473 | namespace { |
| 2474 | @@ -55,10 +54,6 @@ SupervisedUserSettingsPrefMappingEntry k | ||
| 2550 | prefs::kSupervisedUserSafeSites, | 2475 | prefs::kSupervisedUserSafeSites, |
| 2551 | }, | 2476 | }, |
| 2552 | { | 2477 | { |
| @@ -2557,7 +2482,7 @@ | |||
| 2557 | supervised_users::kUserName, | 2482 | supervised_users::kUserName, |
| 2558 | prefs::kProfileName, | 2483 | prefs::kProfileName, |
| 2559 | }, | 2484 | }, |
| 2560 | @@ -127,7 +122,6 @@ void SupervisedUserPrefStore::OnNewSetti | 2485 | @@ -124,7 +119,6 @@ void SupervisedUserPrefStore::OnNewSetti |
| 2561 | prefs_->SetInteger(prefs::kForceYouTubeRestrict, | 2486 | prefs_->SetInteger(prefs::kForceYouTubeRestrict, |
| 2562 | safe_search_util::YOUTUBE_RESTRICT_MODERATE); | 2487 | safe_search_util::YOUTUBE_RESTRICT_MODERATE); |
| 2563 | prefs_->SetBoolean(prefs::kHideWebStoreIcon, false); | 2488 | prefs_->SetBoolean(prefs::kHideWebStoreIcon, false); |
| @@ -2565,8 +2490,8 @@ | |||
| 2565 | prefs_->SetBoolean(feed::prefs::kEnableSnippets, false); | 2490 | prefs_->SetBoolean(feed::prefs::kEnableSnippets, false); |
| 2566 | 2491 | ||
| 2567 | // Copy supervised user settings to prefs. | 2492 | // Copy supervised user settings to prefs. |
| 2568 | --- a/chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc | 2493 | --- chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc.orig |
| 2569 | +++ b/chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc | 2494 | +++ chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc |
| 2570 | @@ -37,7 +37,6 @@ | 2495 | @@ -37,7 +37,6 @@ |
| 2571 | #include "components/autofill/core/common/autofill_features.h" | 2496 | #include "components/autofill/core/common/autofill_features.h" |
| 2572 | #include "components/autofill/core/common/autofill_payments_features.h" | 2497 | #include "components/autofill/core/common/autofill_payments_features.h" |
| @@ -2575,8 +2500,8 @@ | |||
| 2575 | #include "components/signin/public/identity_manager/identity_manager.h" | 2500 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2576 | #include "components/strings/grit/components_strings.h" | 2501 | #include "components/strings/grit/components_strings.h" |
| 2577 | #include "components/sync/driver/sync_service.h" | 2502 | #include "components/sync/driver/sync_service.h" |
| 2578 | --- a/chrome/browser/ui/browser_command_controller.cc | 2503 | --- chrome/browser/ui/browser_command_controller.cc.orig |
| 2579 | +++ b/chrome/browser/ui/browser_command_controller.cc | 2504 | +++ chrome/browser/ui/browser_command_controller.cc |
| 2580 | @@ -57,7 +57,6 @@ | 2505 | @@ -57,7 +57,6 @@ |
| 2581 | #include "components/prefs/pref_service.h" | 2506 | #include "components/prefs/pref_service.h" |
| 2582 | #include "components/sessions/core/tab_restore_service.h" | 2507 | #include "components/sessions/core/tab_restore_service.h" |
| @@ -2585,7 +2510,7 @@ | |||
| 2585 | #include "content/public/browser/native_web_keyboard_event.h" | 2510 | #include "content/public/browser/native_web_keyboard_event.h" |
| 2586 | #include "content/public/browser/navigation_controller.h" | 2511 | #include "content/public/browser/navigation_controller.h" |
| 2587 | #include "content/public/browser/navigation_entry.h" | 2512 | #include "content/public/browser/navigation_entry.h" |
| 2588 | @@ -214,10 +213,6 @@ BrowserCommandController::BrowserCommand | 2513 | @@ -184,10 +183,6 @@ BrowserCommandController::BrowserCommand |
| 2589 | &BrowserCommandController::UpdateCommandsForFullscreenMode, | 2514 | &BrowserCommandController::UpdateCommandsForFullscreenMode, |
| 2590 | base::Unretained(this))); | 2515 | base::Unretained(this))); |
| 2591 | #endif | 2516 | #endif |
| @@ -2596,7 +2521,7 @@ | |||
| 2596 | 2521 | ||
| 2597 | InitCommandState(); | 2522 | InitCommandState(); |
| 2598 | 2523 | ||
| 2599 | @@ -1611,7 +1606,7 @@ void BrowserCommandController::UpdateSho | 2524 | @@ -1526,7 +1521,7 @@ void BrowserCommandController::UpdateSho |
| 2600 | return; | 2525 | return; |
| 2601 | 2526 | ||
| 2602 | command_updater_.UpdateCommandEnabled( | 2527 | command_updater_.UpdateCommandEnabled( |
| @@ -2604,10 +2529,10 @@ | |||
| 2604 | + IDC_SHOW_SIGNIN, false); | 2529 | + IDC_SHOW_SIGNIN, false); |
| 2605 | } | 2530 | } |
| 2606 | 2531 | ||
| 2607 | void BrowserCommandController::UpdateReloadStopState(bool is_loading, | 2532 | // static |
| 2608 | --- a/chrome/browser/ui/browser_command_controller.h | 2533 | --- chrome/browser/ui/browser_command_controller.h.orig |
| 2609 | +++ b/chrome/browser/ui/browser_command_controller.h | 2534 | +++ chrome/browser/ui/browser_command_controller.h |
| 2610 | @@ -212,7 +212,6 @@ class BrowserCommandController : public | 2535 | @@ -211,7 +211,6 @@ class BrowserCommandController : public |
| 2611 | 2536 | ||
| 2612 | PrefChangeRegistrar profile_pref_registrar_; | 2537 | PrefChangeRegistrar profile_pref_registrar_; |
| 2613 | PrefChangeRegistrar local_pref_registrar_; | 2538 | PrefChangeRegistrar local_pref_registrar_; |
| @@ -2615,8 +2540,8 @@ | |||
| 2615 | 2540 | ||
| 2616 | // In locked fullscreen mode disallow enabling/disabling commands. | 2541 | // In locked fullscreen mode disallow enabling/disabling commands. |
| 2617 | bool is_locked_fullscreen_ = false; | 2542 | bool is_locked_fullscreen_ = false; |
| 2618 | --- a/chrome/browser/ui/browser_command_controller_unittest.cc | 2543 | --- chrome/browser/ui/browser_command_controller_unittest.cc.orig |
| 2619 | +++ b/chrome/browser/ui/browser_command_controller_unittest.cc | 2544 | +++ chrome/browser/ui/browser_command_controller_unittest.cc |
| 2620 | @@ -27,7 +27,6 @@ | 2545 | @@ -27,7 +27,6 @@ |
| 2621 | #include "chrome/test/base/test_browser_window.h" | 2546 | #include "chrome/test/base/test_browser_window.h" |
| 2622 | #include "chrome/test/base/testing_browser_process.h" | 2547 | #include "chrome/test/base/testing_browser_process.h" |
| @@ -2625,17 +2550,17 @@ | |||
| 2625 | #include "content/public/browser/native_web_keyboard_event.h" | 2550 | #include "content/public/browser/native_web_keyboard_event.h" |
| 2626 | #include "ui/events/keycodes/dom/dom_code.h" | 2551 | #include "ui/events/keycodes/dom/dom_code.h" |
| 2627 | #include "ui/events/keycodes/keyboard_codes.h" | 2552 | #include "ui/events/keycodes/keyboard_codes.h" |
| 2628 | --- a/chrome/browser/ui/chrome_pages.cc | 2553 | --- chrome/browser/ui/chrome_pages.cc.orig |
| 2629 | +++ b/chrome/browser/ui/chrome_pages.cc | 2554 | +++ chrome/browser/ui/chrome_pages.cc |
| 2630 | @@ -64,7 +64,6 @@ | 2555 | @@ -61,7 +61,6 @@ |
| 2631 | #if !BUILDFLAG(IS_ANDROID) | 2556 | |
| 2632 | #include "base/metrics/histogram_functions.h" | 2557 | #if !defined(OS_ANDROID) |
| 2633 | #include "chrome/browser/signin/identity_manager_factory.h" | 2558 | #include "chrome/browser/signin/identity_manager_factory.h" |
| 2634 | -#include "components/signin/public/base/signin_pref_names.h" | 2559 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2635 | #include "components/signin/public/identity_manager/identity_manager.h" | 2560 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2636 | #endif | 2561 | #endif |
| 2637 | 2562 | ||
| 2638 | @@ -524,13 +523,7 @@ void ShowBrowserSignin(Browser* browser, | 2563 | @@ -484,13 +483,7 @@ void ShowBrowserSignin(Browser* browser, |
| 2639 | 2564 | ||
| 2640 | void ShowBrowserSigninOrSettings(Browser* browser, | 2565 | void ShowBrowserSigninOrSettings(Browser* browser, |
| 2641 | signin_metrics::AccessPoint access_point) { | 2566 | signin_metrics::AccessPoint access_point) { |
| @@ -2650,18 +2575,18 @@ | |||
| 2650 | } | 2575 | } |
| 2651 | #endif | 2576 | #endif |
| 2652 | 2577 | ||
| 2653 | --- a/chrome/browser/ui/hats/trust_safety_sentiment_service.cc | 2578 | --- chrome/browser/ui/hats/trust_safety_sentiment_service.cc.orig |
| 2654 | +++ b/chrome/browser/ui/hats/trust_safety_sentiment_service.cc | 2579 | +++ chrome/browser/ui/hats/trust_safety_sentiment_service.cc |
| 2655 | @@ -22,8 +22,6 @@ | 2580 | @@ -19,8 +19,6 @@ |
| 2581 | #include "components/content_settings/core/common/pref_names.h" | ||
| 2656 | #include "components/password_manager/core/common/password_manager_pref_names.h" | 2582 | #include "components/password_manager/core/common/password_manager_pref_names.h" |
| 2657 | #include "components/prefs/pref_service.h" | 2583 | #include "components/prefs/pref_service.h" |
| 2658 | #include "components/privacy_sandbox/privacy_sandbox_prefs.h" | ||
| 2659 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 2584 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 2660 | -#include "components/signin/public/base/signin_pref_names.h" | 2585 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2661 | #include "components/unified_consent/pref_names.h" | 2586 | #include "components/unified_consent/pref_names.h" |
| 2662 | #include "components/version_info/channel.h" | ||
| 2663 | 2587 | ||
| 2664 | @@ -128,9 +126,6 @@ bool HasNonDefaultPrivacySetting(Profile | 2588 | namespace { |
| 2589 | @@ -81,9 +79,6 @@ bool HasNonDefaultPrivacySetting(Profile | ||
| 2665 | auto* prefs = profile->GetPrefs(); | 2590 | auto* prefs = profile->GetPrefs(); |
| 2666 | 2591 | ||
| 2667 | std::vector<std::string> prefs_to_check = { | 2592 | std::vector<std::string> prefs_to_check = { |
| @@ -2671,7 +2596,7 @@ | |||
| 2671 | prefs::kEnableDoNotTrack, | 2596 | prefs::kEnableDoNotTrack, |
| 2672 | password_manager::prefs::kPasswordLeakDetectionEnabled, | 2597 | password_manager::prefs::kPasswordLeakDetectionEnabled, |
| 2673 | prefs::kCookieControlsMode, | 2598 | prefs::kCookieControlsMode, |
| 2674 | @@ -148,13 +143,9 @@ bool HasNonDefaultPrivacySetting(Profile | 2599 | @@ -101,13 +96,9 @@ bool HasNonDefaultPrivacySetting(Profile |
| 2675 | // Users consenting to sync automatically enable UKM collection | 2600 | // Users consenting to sync automatically enable UKM collection |
| 2676 | auto* ukm_pref = prefs->FindPreference( | 2601 | auto* ukm_pref = prefs->FindPreference( |
| 2677 | unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled); | 2602 | unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled); |
| @@ -2686,9 +2611,9 @@ | |||
| 2686 | 2611 | ||
| 2687 | // Check the default value for each user facing content setting. Note that | 2612 | // Check the default value for each user facing content setting. Note that |
| 2688 | // this will not include content setting exceptions set via permission | 2613 | // this will not include content setting exceptions set via permission |
| 2689 | --- a/chrome/browser/ui/views/page_info/page_info_bubble_view_sync_browsertest.cc | 2614 | --- chrome/browser/ui/views/page_info/page_info_bubble_view_sync_browsertest.cc.orig |
| 2690 | +++ b/chrome/browser/ui/views/page_info/page_info_bubble_view_sync_browsertest.cc | 2615 | +++ chrome/browser/ui/views/page_info/page_info_bubble_view_sync_browsertest.cc |
| 2691 | @@ -19,7 +19,6 @@ | 2616 | @@ -20,7 +20,6 @@ |
| 2692 | #include "components/password_manager/core/browser/password_manager_metrics_util.h" | 2617 | #include "components/password_manager/core/browser/password_manager_metrics_util.h" |
| 2693 | #include "components/safe_browsing/content/browser/password_protection/password_protection_test_util.h" | 2618 | #include "components/safe_browsing/content/browser/password_protection/password_protection_test_util.h" |
| 2694 | #include "components/safe_browsing/core/browser/password_protection/metrics_util.h" | 2619 | #include "components/safe_browsing/core/browser/password_protection/metrics_util.h" |
| @@ -2696,36 +2621,36 @@ | |||
| 2696 | #include "components/signin/public/identity_manager/account_info.h" | 2621 | #include "components/signin/public/identity_manager/account_info.h" |
| 2697 | #include "components/signin/public/identity_manager/identity_manager.h" | 2622 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2698 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 2623 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 2699 | --- a/chrome/browser/ui/views/profiles/profile_menu_view.cc | 2624 | --- chrome/browser/ui/views/profiles/profile_menu_view.cc.orig |
| 2700 | +++ b/chrome/browser/ui/views/profiles/profile_menu_view.cc | 2625 | +++ chrome/browser/ui/views/profiles/profile_menu_view.cc |
| 2701 | @@ -53,7 +53,6 @@ | 2626 | @@ -53,7 +53,6 @@ |
| 2627 | #include "chrome/grit/generated_resources.h" | ||
| 2702 | #include "chrome/grit/theme_resources.h" | 2628 | #include "chrome/grit/theme_resources.h" |
| 2703 | #include "components/signin/core/browser/signin_error_controller.h" | 2629 | #include "components/signin/core/browser/signin_error_controller.h" |
| 2704 | #include "components/signin/public/base/consent_level.h" | ||
| 2705 | -#include "components/signin/public/base/signin_pref_names.h" | 2630 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2631 | #include "components/signin/public/identity_manager/consent_level.h" | ||
| 2706 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | 2632 | #include "components/signin/public/identity_manager/primary_account_mutator.h" |
| 2707 | #include "components/strings/grit/components_strings.h" | 2633 | #include "components/strings/grit/components_strings.h" |
| 2708 | #include "components/vector_icons/vector_icons.h" | 2634 | @@ -501,7 +500,6 @@ void ProfileMenuView::BuildAutofillButto |
| 2709 | @@ -508,7 +507,6 @@ void ProfileMenuView::BuildAutofillButto | ||
| 2710 | 2635 | ||
| 2711 | void ProfileMenuView::BuildSyncInfo() { | 2636 | void ProfileMenuView::BuildSyncInfo() { |
| 2712 | Profile* profile = browser()->profile(); | 2637 | Profile* profile = browser()->profile(); |
| 2713 | - if (!profile->GetPrefs()->GetBoolean(prefs::kSigninAllowed)) | 2638 | - if (!profile->GetPrefs()->GetBoolean(prefs::kSigninAllowed)) |
| 2714 | return; | 2639 | return; |
| 2715 | 2640 | ||
| 2716 | if (!SyncServiceFactory::IsSyncAllowed(profile)) { | 2641 | signin::IdentityManager* identity_manager = |
| 2717 | --- a/chrome/browser/ui/views/profiles/profile_menu_view_browsertest.cc | 2642 | --- chrome/browser/ui/views/profiles/profile_menu_view_browsertest.cc.orig |
| 2718 | +++ b/chrome/browser/ui/views/profiles/profile_menu_view_browsertest.cc | 2643 | +++ chrome/browser/ui/views/profiles/profile_menu_view_browsertest.cc |
| 2719 | @@ -60,7 +60,6 @@ | 2644 | @@ -55,7 +55,6 @@ |
| 2720 | #include "components/google/core/common/google_util.h" | 2645 | #include "components/feature_engagement/public/tracker.h" |
| 2646 | #include "components/feature_engagement/test/test_tracker.h" | ||
| 2721 | #include "components/prefs/pref_service.h" | 2647 | #include "components/prefs/pref_service.h" |
| 2722 | #include "components/signin/public/base/consent_level.h" | ||
| 2723 | -#include "components/signin/public/base/signin_pref_names.h" | 2648 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2649 | #include "components/signin/public/identity_manager/consent_level.h" | ||
| 2724 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 2650 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 2725 | #include "components/sync/driver/sync_service.h" | 2651 | #include "components/sync/driver/sync_service.h" |
| 2726 | #include "components/sync/driver/sync_user_settings.h" | 2652 | --- chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc.orig |
| 2727 | --- a/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc | 2653 | +++ chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc |
| 2728 | +++ b/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc | ||
| 2729 | @@ -122,7 +122,6 @@ PasswordReuseModalWarningDialog::Passwor | 2654 | @@ -122,7 +122,6 @@ PasswordReuseModalWarningDialog::Passwor |
| 2730 | OnWarningDone done_callback) | 2655 | OnWarningDone done_callback) |
| 2731 | : content::WebContentsObserver(web_contents), | 2656 | : content::WebContentsObserver(web_contents), |
| @@ -2767,19 +2692,19 @@ | |||
| 2767 | LogModalWarningDialogLifetime(modal_construction_start_time_); | 2692 | LogModalWarningDialogLifetime(modal_construction_start_time_); |
| 2768 | } | 2693 | } |
| 2769 | 2694 | ||
| 2770 | --- a/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h | 2695 | --- chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h.orig |
| 2771 | +++ b/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h | 2696 | +++ chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h |
| 2772 | @@ -62,7 +62,6 @@ class PasswordReuseModalWarningDialog | 2697 | @@ -60,7 +60,6 @@ class PasswordReuseModalWarningDialog |
| 2773 | 2698 | ||
| 2774 | private: | 2699 | private: |
| 2775 | OnWarningDone done_callback_; | 2700 | OnWarningDone done_callback_; |
| 2776 | - raw_ptr<ChromePasswordProtectionService> service_; | 2701 | - ChromePasswordProtectionService* service_; |
| 2777 | const GURL url_; | 2702 | const GURL url_; |
| 2778 | const ReusedPasswordAccountType password_type_; | 2703 | const ReusedPasswordAccountType password_type_; |
| 2779 | 2704 | ||
| 2780 | --- a/chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc | 2705 | --- chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc.orig |
| 2781 | +++ b/chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc | 2706 | +++ chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc |
| 2782 | @@ -46,7 +46,6 @@ | 2707 | @@ -44,7 +44,6 @@ |
| 2783 | #include "components/keyed_service/content/browser_context_dependency_manager.h" | 2708 | #include "components/keyed_service/content/browser_context_dependency_manager.h" |
| 2784 | #include "components/prefs/pref_service.h" | 2709 | #include "components/prefs/pref_service.h" |
| 2785 | #include "components/prefs/scoped_user_pref_update.h" | 2710 | #include "components/prefs/scoped_user_pref_update.h" |
| @@ -2787,9 +2712,9 @@ | |||
| 2787 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 2712 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 2788 | #include "content/public/browser/render_frame_host.h" | 2713 | #include "content/public/browser/render_frame_host.h" |
| 2789 | #include "content/public/browser/render_process_host.h" | 2714 | #include "content/public/browser/render_process_host.h" |
| 2790 | --- a/chrome/browser/ui/webui/browser_command/browser_command_handler.cc | 2715 | --- chrome/browser/ui/webui/browser_command/browser_command_handler.cc.orig |
| 2791 | +++ b/chrome/browser/ui/webui/browser_command/browser_command_handler.cc | 2716 | +++ chrome/browser/ui/webui/browser_command/browser_command_handler.cc |
| 2792 | @@ -17,7 +17,6 @@ | 2717 | @@ -16,7 +16,6 @@ |
| 2793 | #include "chrome/common/webui_url_constants.h" | 2718 | #include "chrome/common/webui_url_constants.h" |
| 2794 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" | 2719 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" |
| 2795 | #include "components/safe_browsing/core/common/safe_browsing_policy_handler.h" | 2720 | #include "components/safe_browsing/core/common/safe_browsing_policy_handler.h" |
| @@ -2798,8 +2723,8 @@ | |||
| 2798 | #include "ui/base/window_open_disposition.h" | 2723 | #include "ui/base/window_open_disposition.h" |
| 2799 | 2724 | ||
| 2800 | @@ -61,13 +60,6 @@ void BrowserCommandHandler::CanExecuteCo | 2725 | @@ -61,13 +60,6 @@ void BrowserCommandHandler::CanExecuteCo |
| 2801 | case Command::kOpenSafetyCheck: | 2726 | can_execute = |
| 2802 | can_execute = !chrome::enterprise_util::IsBrowserManaged(profile_); | 2727 | !chrome::enterprise_util::HasBrowserPoliciesApplied(profile_); |
| 2803 | break; | 2728 | break; |
| 2804 | - case Command::kOpenSafeBrowsingEnhancedProtectionSettings: { | 2729 | - case Command::kOpenSafeBrowsingEnhancedProtectionSettings: { |
| 2805 | - bool managed = safe_browsing::SafeBrowsingPolicyHandler:: | 2730 | - bool managed = safe_browsing::SafeBrowsingPolicyHandler:: |
| @@ -2811,8 +2736,8 @@ | |||
| 2811 | case Command::kOpenFeedbackForm: | 2736 | case Command::kOpenFeedbackForm: |
| 2812 | can_execute = true; | 2737 | can_execute = true; |
| 2813 | break; | 2738 | break; |
| 2814 | --- a/chrome/browser/ui/webui/downloads/downloads_dom_handler.cc | 2739 | --- chrome/browser/ui/webui/downloads/downloads_dom_handler.cc.orig |
| 2815 | +++ b/chrome/browser/ui/webui/downloads/downloads_dom_handler.cc | 2740 | +++ chrome/browser/ui/webui/downloads/downloads_dom_handler.cc |
| 2816 | @@ -37,7 +37,6 @@ | 2741 | @@ -37,7 +37,6 @@ |
| 2817 | #include "chrome/common/url_constants.h" | 2742 | #include "chrome/common/url_constants.h" |
| 2818 | #include "components/download/public/common/download_item.h" | 2743 | #include "components/download/public/common/download_item.h" |
| @@ -2821,28 +2746,9 @@ | |||
| 2821 | #include "content/public/browser/browser_thread.h" | 2746 | #include "content/public/browser/browser_thread.h" |
| 2822 | #include "content/public/browser/download_manager.h" | 2747 | #include "content/public/browser/download_manager.h" |
| 2823 | #include "content/public/browser/render_process_host.h" | 2748 | #include "content/public/browser/render_process_host.h" |
| 2824 | --- a/chrome/browser/ui/webui/history/history_ui.cc | 2749 | --- chrome/browser/ui/webui/management/management_ui_handler.cc.orig |
| 2825 | +++ b/chrome/browser/ui/webui/history/history_ui.cc | 2750 | +++ chrome/browser/ui/webui/management/management_ui_handler.cc |
| 2826 | @@ -41,7 +41,6 @@ | 2751 | @@ -29,7 +29,6 @@ |
| 2827 | #include "components/history_clusters/core/history_clusters_prefs.h" | ||
| 2828 | #include "components/history_clusters/core/history_clusters_service.h" | ||
| 2829 | #include "components/prefs/pref_service.h" | ||
| 2830 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 2831 | #include "components/signin/public/identity_manager/identity_manager.h" | ||
| 2832 | #include "components/strings/grit/components_strings.h" | ||
| 2833 | #include "content/public/browser/web_ui.h" | ||
| 2834 | @@ -124,8 +123,6 @@ content::WebUIDataSource* CreateHistoryU | ||
| 2835 | source->AddBoolean("allowDeletingHistory", allow_deleting_history); | ||
| 2836 | |||
| 2837 | source->AddBoolean("isGuestSession", profile->IsGuestSession()); | ||
| 2838 | - source->AddBoolean("isSignInAllowed", | ||
| 2839 | - prefs->GetBoolean(prefs::kSigninAllowed)); | ||
| 2840 | |||
| 2841 | source->AddBoolean(kIsUserSignedInKey, IsUserSignedIn(profile)); | ||
| 2842 | |||
| 2843 | --- a/chrome/browser/ui/webui/management/management_ui_handler.cc | ||
| 2844 | +++ b/chrome/browser/ui/webui/management/management_ui_handler.cc | ||
| 2845 | @@ -30,7 +30,6 @@ | ||
| 2846 | #include "chrome/browser/profiles/profile.h" | 2752 | #include "chrome/browser/profiles/profile.h" |
| 2847 | #include "chrome/browser/ui/managed_ui.h" | 2753 | #include "chrome/browser/ui/managed_ui.h" |
| 2848 | #include "chrome/common/pref_names.h" | 2754 | #include "chrome/common/pref_names.h" |
| @@ -2850,8 +2756,8 @@ | |||
| 2850 | #include "components/strings/grit/components_strings.h" | 2756 | #include "components/strings/grit/components_strings.h" |
| 2851 | #include "content/public/browser/storage_partition.h" | 2757 | #include "content/public/browser/storage_partition.h" |
| 2852 | #include "content/public/browser/web_contents.h" | 2758 | #include "content/public/browser/web_contents.h" |
| 2853 | --- a/chrome/browser/ui/webui/profile_info_watcher.cc | 2759 | --- chrome/browser/ui/webui/profile_info_watcher.cc.orig |
| 2854 | +++ b/chrome/browser/ui/webui/profile_info_watcher.cc | 2760 | +++ chrome/browser/ui/webui/profile_info_watcher.cc |
| 2855 | @@ -12,7 +12,6 @@ | 2761 | @@ -12,7 +12,6 @@ |
| 2856 | #include "chrome/browser/signin/identity_manager_factory.h" | 2762 | #include "chrome/browser/signin/identity_manager_factory.h" |
| 2857 | #include "chrome/common/pref_names.h" | 2763 | #include "chrome/common/pref_names.h" |
| @@ -2872,8 +2778,8 @@ | |||
| 2872 | } | 2778 | } |
| 2873 | 2779 | ||
| 2874 | ProfileInfoWatcher::~ProfileInfoWatcher() { | 2780 | ProfileInfoWatcher::~ProfileInfoWatcher() { |
| 2875 | --- a/chrome/browser/ui/webui/profile_info_watcher.h | 2781 | --- chrome/browser/ui/webui/profile_info_watcher.h.orig |
| 2876 | +++ b/chrome/browser/ui/webui/profile_info_watcher.h | 2782 | +++ chrome/browser/ui/webui/profile_info_watcher.h |
| 2877 | @@ -49,7 +49,6 @@ class ProfileInfoWatcher : public Profil | 2783 | @@ -49,7 +49,6 @@ class ProfileInfoWatcher : public Profil |
| 2878 | // Called when the authenticated username changes. | 2784 | // Called when the authenticated username changes. |
| 2879 | base::RepeatingClosure callback_; | 2785 | base::RepeatingClosure callback_; |
| @@ -2882,9 +2788,9 @@ | |||
| 2882 | }; | 2788 | }; |
| 2883 | 2789 | ||
| 2884 | #endif // CHROME_BROWSER_UI_WEBUI_PROFILE_INFO_WATCHER_H_ | 2790 | #endif // CHROME_BROWSER_UI_WEBUI_PROFILE_INFO_WATCHER_H_ |
| 2885 | --- a/chrome/browser/ui/webui/reset_password/reset_password_ui.cc | 2791 | --- chrome/browser/ui/webui/reset_password/reset_password_ui.cc.orig |
| 2886 | +++ b/chrome/browser/ui/webui/reset_password/reset_password_ui.cc | 2792 | +++ chrome/browser/ui/webui/reset_password/reset_password_ui.cc |
| 2887 | @@ -20,7 +20,6 @@ | 2793 | @@ -17,7 +17,6 @@ |
| 2888 | #include "components/safe_browsing/content/browser/password_protection/password_protection_service.h" | 2794 | #include "components/safe_browsing/content/browser/password_protection/password_protection_service.h" |
| 2889 | #include "components/safe_browsing/core/browser/password_protection/metrics_util.h" | 2795 | #include "components/safe_browsing/core/browser/password_protection/metrics_util.h" |
| 2890 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 2796 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -2892,17 +2798,17 @@ | |||
| 2892 | #include "components/strings/grit/components_strings.h" | 2798 | #include "components/strings/grit/components_strings.h" |
| 2893 | #include "components/url_formatter/url_formatter.h" | 2799 | #include "components/url_formatter/url_formatter.h" |
| 2894 | #include "components/user_prefs/user_prefs.h" | 2800 | #include "components/user_prefs/user_prefs.h" |
| 2895 | --- a/chrome/browser/ui/webui/settings/people_handler.cc | 2801 | --- chrome/browser/ui/webui/settings/people_handler.cc.orig |
| 2896 | +++ b/chrome/browser/ui/webui/settings/people_handler.cc | 2802 | +++ chrome/browser/ui/webui/settings/people_handler.cc |
| 2897 | @@ -42,7 +42,6 @@ | 2803 | @@ -41,7 +41,6 @@ |
| 2804 | #include "components/prefs/pref_service.h" | ||
| 2898 | #include "components/signin/core/browser/signin_error_controller.h" | 2805 | #include "components/signin/core/browser/signin_error_controller.h" |
| 2899 | #include "components/signin/public/base/consent_level.h" | ||
| 2900 | #include "components/signin/public/base/signin_metrics.h" | 2806 | #include "components/signin/public/base/signin_metrics.h" |
| 2901 | -#include "components/signin/public/base/signin_pref_names.h" | 2807 | -#include "components/signin/public/base/signin_pref_names.h" |
| 2902 | #include "components/signin/public/identity_manager/accounts_mutator.h" | 2808 | #include "components/signin/public/identity_manager/accounts_mutator.h" |
| 2809 | #include "components/signin/public/identity_manager/consent_level.h" | ||
| 2903 | #include "components/signin/public/identity_manager/identity_manager.h" | 2810 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 2904 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | 2811 | @@ -290,10 +289,6 @@ void PeopleHandler::RegisterMessages() { |
| 2905 | @@ -301,10 +300,6 @@ void PeopleHandler::RegisterMessages() { | ||
| 2906 | void PeopleHandler::OnJavascriptAllowed() { | 2812 | void PeopleHandler::OnJavascriptAllowed() { |
| 2907 | PrefService* prefs = profile_->GetPrefs(); | 2813 | PrefService* prefs = profile_->GetPrefs(); |
| 2908 | profile_pref_registrar_.Init(prefs); | 2814 | profile_pref_registrar_.Init(prefs); |
| @@ -2913,8 +2819,8 @@ | |||
| 2913 | 2819 | ||
| 2914 | signin::IdentityManager* identity_manager( | 2820 | signin::IdentityManager* identity_manager( |
| 2915 | IdentityManagerFactory::GetInstance()->GetForProfile(profile_)); | 2821 | IdentityManagerFactory::GetInstance()->GetForProfile(profile_)); |
| 2916 | --- a/chrome/browser/ui/webui/settings/safety_check_handler.cc | 2822 | --- chrome/browser/ui/webui/settings/safety_check_handler.cc.orig |
| 2917 | +++ b/chrome/browser/ui/webui/settings/safety_check_handler.cc | 2823 | +++ chrome/browser/ui/webui/settings/safety_check_handler.cc |
| 2918 | @@ -28,7 +28,6 @@ | 2824 | @@ -28,7 +28,6 @@ |
| 2919 | #include "chrome/grit/chromium_strings.h" | 2825 | #include "chrome/grit/chromium_strings.h" |
| 2920 | #include "chrome/grit/generated_resources.h" | 2826 | #include "chrome/grit/generated_resources.h" |
| @@ -2923,20 +2829,22 @@ | |||
| 2923 | #include "components/strings/grit/components_strings.h" | 2829 | #include "components/strings/grit/components_strings.h" |
| 2924 | #include "components/version_info/version_info.h" | 2830 | #include "components/version_info/version_info.h" |
| 2925 | #include "content/public/browser/browser_context.h" | 2831 | #include "content/public/browser/browser_context.h" |
| 2926 | --- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc | 2832 | --- chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc.orig |
| 2927 | +++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc | 2833 | +++ chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc |
| 2928 | @@ -66,7 +66,6 @@ | 2834 | @@ -67,7 +67,6 @@ |
| 2835 | #include "components/password_manager/core/browser/manage_passwords_referrer.h" | ||
| 2929 | #include "components/password_manager/core/common/password_manager_features.h" | 2836 | #include "components/password_manager/core/common/password_manager_features.h" |
| 2930 | #include "components/prefs/pref_service.h" | 2837 | #include "components/prefs/pref_service.h" |
| 2931 | #include "components/privacy_sandbox/privacy_sandbox_features.h" | ||
| 2932 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 2838 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 2933 | #include "components/signin/public/base/signin_buildflags.h" | 2839 | #include "components/signin/public/base/signin_buildflags.h" |
| 2934 | #include "components/strings/grit/components_chromium_strings.h" | 2840 | #include "components/strings/grit/components_chromium_strings.h" |
| 2935 | #include "components/strings/grit/components_strings.h" | 2841 | #include "components/strings/grit/components_strings.h" |
| 2936 | @@ -1473,44 +1472,6 @@ void AddPrivacyStrings(content::WebUIDat | 2842 | @@ -1391,46 +1390,6 @@ void AddPrivacyStrings(content::WebUIDat |
| 2937 | {"clearBrowsingData", IDS_SETTINGS_CLEAR_BROWSING_DATA}, | 2843 | {"clearBrowsingData", IDS_SETTINGS_CLEAR_BROWSING_DATA}, |
| 2938 | {"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION}, | 2844 | {"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION}, |
| 2939 | {"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT}, | 2845 | {"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT}, |
| 2846 | - {"safeBrowsingEnableExtendedReporting", | ||
| 2847 | - IDS_SETTINGS_SAFEBROWSING_ENABLE_REPORTING}, | ||
| 2940 | - {"safeBrowsingEnableExtendedReportingDesc", | 2848 | - {"safeBrowsingEnableExtendedReportingDesc", |
| 2941 | - IDS_SETTINGS_SAFEBROWSING_ENABLE_REPORTING_DESC}, | 2849 | - IDS_SETTINGS_SAFEBROWSING_ENABLE_REPORTING_DESC}, |
| 2942 | - {"safeBrowsingEnhanced", IDS_SETTINGS_SAFEBROWSING_ENHANCED}, | 2850 | - {"safeBrowsingEnhanced", IDS_SETTINGS_SAFEBROWSING_ENHANCED}, |
| @@ -2978,7 +2886,7 @@ | |||
| 2978 | {"safeBrowsingSectionLabel", IDS_SETTINGS_SAFEBROWSING_SECTION_LABEL}, | 2886 | {"safeBrowsingSectionLabel", IDS_SETTINGS_SAFEBROWSING_SECTION_LABEL}, |
| 2979 | {"syncAndGoogleServicesPrivacyDescription", | 2887 | {"syncAndGoogleServicesPrivacyDescription", |
| 2980 | IDS_SETTINGS_SYNC_AND_GOOGLE_SERVICES_PRIVACY_DESC_UNIFIED_CONSENT}, | 2888 | IDS_SETTINGS_SYNC_AND_GOOGLE_SERVICES_PRIVACY_DESC_UNIFIED_CONSENT}, |
| 2981 | @@ -2811,11 +2772,6 @@ void AddSiteSettingsStrings(content::Web | 2889 | @@ -2626,11 +2585,6 @@ void AddSiteSettingsStrings(content::Web |
| 2982 | html_source->AddLocalizedStrings(kSensorsLocalizedStrings); | 2890 | html_source->AddLocalizedStrings(kSensorsLocalizedStrings); |
| 2983 | 2891 | ||
| 2984 | html_source->AddBoolean( | 2892 | html_source->AddBoolean( |
| @@ -2990,19 +2898,19 @@ | |||
| 2990 | "enableBlockAutoplayContentSetting", | 2898 | "enableBlockAutoplayContentSetting", |
| 2991 | base::FeatureList::IsEnabled(media::kAutoplayDisableSettings)); | 2899 | base::FeatureList::IsEnabled(media::kAutoplayDisableSettings)); |
| 2992 | 2900 | ||
| 2993 | --- a/chrome/browser/ui/webui/settings/settings_ui.cc | 2901 | --- chrome/browser/ui/webui/settings/settings_ui.cc.orig |
| 2994 | +++ b/chrome/browser/ui/webui/settings/settings_ui.cc | 2902 | +++ chrome/browser/ui/webui/settings/settings_ui.cc |
| 2995 | @@ -71,7 +71,6 @@ | 2903 | @@ -72,7 +72,6 @@ |
| 2996 | #include "components/pref_registry/pref_registry_syncable.h" | 2904 | #include "components/pref_registry/pref_registry_syncable.h" |
| 2997 | #include "components/prefs/pref_service.h" | 2905 | #include "components/prefs/pref_service.h" |
| 2998 | #include "components/safe_browsing/core/common/features.h" | 2906 | #include "components/safe_browsing/core/common/features.h" |
| 2999 | -#include "components/signin/public/base/signin_pref_names.h" | 2907 | -#include "components/signin/public/base/signin_pref_names.h" |
| 3000 | #include "components/signin/public/base/signin_switches.h" | ||
| 3001 | #include "content/public/browser/url_data_source.h" | 2908 | #include "content/public/browser/url_data_source.h" |
| 3002 | #include "content/public/browser/web_contents.h" | 2909 | #include "content/public/browser/web_contents.h" |
| 3003 | @@ -258,9 +257,7 @@ SettingsUI::SettingsUI(content::WebUI* w | 2910 | #include "content/public/browser/web_ui.h" |
| 3004 | std::make_unique<IncompatibleApplicationsHandler>()); | 2911 | @@ -274,9 +273,7 @@ SettingsUI::SettingsUI(content::WebUI* w |
| 3005 | #endif // BUILDFLAG(IS_WIN) && BUILDFLAG(GOOGLE_CHROME_BRANDING) | 2912 | ? "enable-branding-update" |
| 2913 | : ""); | ||
| 3006 | 2914 | ||
| 3007 | - html_source->AddBoolean("signinAllowed", !profile->IsGuestSession() && | 2915 | - html_source->AddBoolean("signinAllowed", !profile->IsGuestSession() && |
| 3008 | - profile->GetPrefs()->GetBoolean( | 2916 | - profile->GetPrefs()->GetBoolean( |
| @@ -3011,8 +2919,38 @@ | |||
| 3011 | 2919 | ||
| 3012 | html_source->AddBoolean("showImportPasswords", | 2920 | html_source->AddBoolean("showImportPasswords", |
| 3013 | base::FeatureList::IsEnabled( | 2921 | base::FeatureList::IsEnabled( |
| 3014 | --- a/chrome/browser/ui/webui/signin/inline_login_handler.cc | 2922 | --- chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc.orig |
| 3015 | +++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc | 2923 | +++ chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc |
| 2924 | @@ -46,7 +46,6 @@ | ||
| 2925 | #include "components/policy/core/common/management/management_service.h" | ||
| 2926 | #include "components/prefs/pref_service.h" | ||
| 2927 | #include "components/signin/public/base/signin_metrics.h" | ||
| 2928 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 2929 | #include "components/signin/public/identity_manager/accounts_mutator.h" | ||
| 2930 | #include "components/signin/public/identity_manager/identity_manager.h" | ||
| 2931 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | ||
| 2932 | @@ -248,8 +247,7 @@ DiceTurnSyncOnHelper::DiceTurnSyncOnHelp | ||
| 2933 | // last authenticated account of the current profile, then Chrome will show a | ||
| 2934 | // confirmation dialog before starting sync. | ||
| 2935 | // TODO(skym): Warn for high risk upgrade scenario (https://crbug.com/572754). | ||
| 2936 | - std::string last_email = | ||
| 2937 | - profile_->GetPrefs()->GetString(prefs::kGoogleServicesLastUsername); | ||
| 2938 | + std::string last_email; | ||
| 2939 | delegate_->ShowMergeSyncDataConfirmation( | ||
| 2940 | last_email, account_info_.email, | ||
| 2941 | base::BindOnce(&DiceTurnSyncOnHelper::OnMergeAccountConfirmation, | ||
| 2942 | --- chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc.orig | ||
| 2943 | +++ chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc | ||
| 2944 | @@ -38,7 +38,6 @@ | ||
| 2945 | #include "components/prefs/pref_service.h" | ||
| 2946 | #include "components/signin/public/base/account_consistency_method.h" | ||
| 2947 | #include "components/signin/public/base/signin_metrics.h" | ||
| 2948 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 2949 | #include "components/signin/public/identity_manager/identity_manager.h" | ||
| 2950 | #include "components/signin/public/identity_manager/identity_test_environment.h" | ||
| 2951 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | ||
| 2952 | --- chrome/browser/ui/webui/signin/inline_login_handler.cc.orig | ||
| 2953 | +++ chrome/browser/ui/webui/signin/inline_login_handler.cc | ||
| 3016 | @@ -27,7 +27,6 @@ | 2954 | @@ -27,7 +27,6 @@ |
| 3017 | #include "chrome/common/pref_names.h" | 2955 | #include "chrome/common/pref_names.h" |
| 3018 | #include "components/metrics/metrics_pref_names.h" | 2956 | #include "components/metrics/metrics_pref_names.h" |
| @@ -3021,7 +2959,7 @@ | |||
| 3021 | #include "content/public/browser/storage_partition.h" | 2959 | #include "content/public/browser/storage_partition.h" |
| 3022 | #include "content/public/browser/web_contents.h" | 2960 | #include "content/public/browser/web_contents.h" |
| 3023 | #include "content/public/browser/web_ui.h" | 2961 | #include "content/public/browser/web_ui.h" |
| 3024 | @@ -138,8 +137,6 @@ void InlineLoginHandler::ContinueHandleI | 2962 | @@ -127,8 +126,6 @@ void InlineLoginHandler::ContinueHandleI |
| 3025 | std::string default_email; | 2963 | std::string default_email; |
| 3026 | if (reason == signin_metrics::Reason::kSigninPrimaryAccount || | 2964 | if (reason == signin_metrics::Reason::kSigninPrimaryAccount || |
| 3027 | reason == signin_metrics::Reason::kForcedSigninPrimaryAccount) { | 2965 | reason == signin_metrics::Reason::kForcedSigninPrimaryAccount) { |
| @@ -3030,9 +2968,9 @@ | |||
| 3030 | } else { | 2968 | } else { |
| 3031 | if (!net::GetValueForKeyInQuery(current_url, "email", &default_email)) | 2969 | if (!net::GetValueForKeyInQuery(current_url, "email", &default_email)) |
| 3032 | default_email.clear(); | 2970 | default_email.clear(); |
| 3033 | --- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc | 2971 | --- chrome/browser/ui/webui/signin/inline_login_handler_impl.cc.orig |
| 3034 | +++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc | 2972 | +++ chrome/browser/ui/webui/signin/inline_login_handler_impl.cc |
| 3035 | @@ -67,7 +67,6 @@ | 2973 | @@ -70,7 +70,6 @@ |
| 3036 | #include "components/prefs/pref_service.h" | 2974 | #include "components/prefs/pref_service.h" |
| 3037 | #include "components/signin/core/browser/about_signin_internals.h" | 2975 | #include "components/signin/core/browser/about_signin_internals.h" |
| 3038 | #include "components/signin/public/base/signin_metrics.h" | 2976 | #include "components/signin/public/base/signin_metrics.h" |
| @@ -3040,9 +2978,9 @@ | |||
| 3040 | #include "components/signin/public/identity_manager/account_info.h" | 2978 | #include "components/signin/public/identity_manager/account_info.h" |
| 3041 | #include "components/signin/public/identity_manager/accounts_cookie_mutator.h" | 2979 | #include "components/signin/public/identity_manager/accounts_cookie_mutator.h" |
| 3042 | #include "components/signin/public/identity_manager/accounts_mutator.h" | 2980 | #include "components/signin/public/identity_manager/accounts_mutator.h" |
| 3043 | --- a/chrome/browser/ui/webui/signin/signin_error_ui.cc | 2981 | --- chrome/browser/ui/webui/signin/signin_error_ui.cc.orig |
| 3044 | +++ b/chrome/browser/ui/webui/signin/signin_error_ui.cc | 2982 | +++ chrome/browser/ui/webui/signin/signin_error_ui.cc |
| 3045 | @@ -27,7 +27,6 @@ | 2983 | @@ -23,7 +23,6 @@ |
| 3046 | #include "chrome/grit/generated_resources.h" | 2984 | #include "chrome/grit/generated_resources.h" |
| 3047 | #include "chrome/grit/signin_resources.h" | 2985 | #include "chrome/grit/signin_resources.h" |
| 3048 | #include "components/prefs/pref_service.h" | 2986 | #include "components/prefs/pref_service.h" |
| @@ -3050,7 +2988,7 @@ | |||
| 3050 | #include "components/strings/grit/components_strings.h" | 2988 | #include "components/strings/grit/components_strings.h" |
| 3051 | #include "content/public/browser/web_ui.h" | 2989 | #include "content/public/browser/web_ui.h" |
| 3052 | #include "content/public/browser/web_ui_data_source.h" | 2990 | #include "content/public/browser/web_ui_data_source.h" |
| 3053 | @@ -119,9 +118,7 @@ void SigninErrorUI::Initialize(Browser* | 2991 | @@ -115,9 +114,7 @@ void SigninErrorUI::Initialize(Browser* |
| 3054 | if (is_profile_blocked) { | 2992 | if (is_profile_blocked) { |
| 3055 | source->AddLocalizedString("profileBlockedMessage", | 2993 | source->AddLocalizedString("profileBlockedMessage", |
| 3056 | IDS_OLD_PROFILES_DISABLED_MESSAGE); | 2994 | IDS_OLD_PROFILES_DISABLED_MESSAGE); |
| @@ -3061,8 +2999,8 @@ | |||
| 3061 | if (allowed_domain.empty()) { | 2999 | if (allowed_domain.empty()) { |
| 3062 | source->AddLocalizedString( | 3000 | source->AddLocalizedString( |
| 3063 | "profileBlockedAddPersonSuggestion", | 3001 | "profileBlockedAddPersonSuggestion", |
| 3064 | --- a/chrome/browser/ui/webui/signin/signin_utils_desktop.cc | 3002 | --- chrome/browser/ui/webui/signin/signin_utils_desktop.cc.orig |
| 3065 | +++ b/chrome/browser/ui/webui/signin/signin_utils_desktop.cc | 3003 | +++ chrome/browser/ui/webui/signin/signin_utils_desktop.cc |
| 3066 | @@ -18,7 +18,6 @@ | 3004 | @@ -18,7 +18,6 @@ |
| 3067 | #include "chrome/grit/chromium_strings.h" | 3005 | #include "chrome/grit/chromium_strings.h" |
| 3068 | #include "chrome/grit/generated_resources.h" | 3006 | #include "chrome/grit/generated_resources.h" |
| @@ -3090,38 +3028,8 @@ | |||
| 3090 | return SigninUIError::ProfileWasUsedByAnotherAccount(email, last_email); | 3028 | return SigninUIError::ProfileWasUsedByAnotherAccount(email, last_email); |
| 3091 | } | 3029 | } |
| 3092 | } | 3030 | } |
| 3093 | --- a/chrome/browser/ui/webui/signin/turn_sync_on_helper.cc | 3031 | --- chrome/browser/ui/webui/welcome/welcome_ui.cc.orig |
| 3094 | +++ b/chrome/browser/ui/webui/signin/turn_sync_on_helper.cc | 3032 | +++ chrome/browser/ui/webui/welcome/welcome_ui.cc |
| 3095 | @@ -47,7 +47,6 @@ | ||
| 3096 | #include "components/policy/core/common/management/management_service.h" | ||
| 3097 | #include "components/prefs/pref_service.h" | ||
| 3098 | #include "components/signin/public/base/signin_metrics.h" | ||
| 3099 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 3100 | #include "components/signin/public/identity_manager/accounts_mutator.h" | ||
| 3101 | #include "components/signin/public/identity_manager/identity_manager.h" | ||
| 3102 | #include "components/signin/public/identity_manager/primary_account_mutator.h" | ||
| 3103 | @@ -226,8 +225,7 @@ TurnSyncOnHelper::TurnSyncOnHelper( | ||
| 3104 | // last authenticated account of the current profile, then Chrome will show a | ||
| 3105 | // confirmation dialog before starting sync. | ||
| 3106 | // TODO(skym): Warn for high risk upgrade scenario (https://crbug.com/572754). | ||
| 3107 | - std::string last_email = | ||
| 3108 | - profile_->GetPrefs()->GetString(prefs::kGoogleServicesLastUsername); | ||
| 3109 | + std::string last_email; | ||
| 3110 | delegate_->ShowMergeSyncDataConfirmation( | ||
| 3111 | last_email, account_info_.email, | ||
| 3112 | base::BindOnce(&TurnSyncOnHelper::OnMergeAccountConfirmation, | ||
| 3113 | --- a/chrome/browser/ui/webui/signin/turn_sync_on_helper_unittest.cc | ||
| 3114 | +++ b/chrome/browser/ui/webui/signin/turn_sync_on_helper_unittest.cc | ||
| 3115 | @@ -46,7 +46,6 @@ | ||
| 3116 | #include "components/signin/public/base/account_consistency_method.h" | ||
| 3117 | #include "components/signin/public/base/consent_level.h" | ||
| 3118 | #include "components/signin/public/base/signin_metrics.h" | ||
| 3119 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 3120 | #include "components/signin/public/base/signin_switches.h" | ||
| 3121 | #include "components/signin/public/identity_manager/identity_manager.h" | ||
| 3122 | #include "components/signin/public/identity_manager/identity_test_environment.h" | ||
| 3123 | --- a/chrome/browser/ui/webui/welcome/welcome_ui.cc | ||
| 3124 | +++ b/chrome/browser/ui/webui/welcome/welcome_ui.cc | ||
| 3125 | @@ -24,7 +24,6 @@ | 3033 | @@ -24,7 +24,6 @@ |
| 3126 | #include "chrome/grit/welcome_resources.h" | 3034 | #include "chrome/grit/welcome_resources.h" |
| 3127 | #include "chrome/grit/welcome_resources_map.h" | 3035 | #include "chrome/grit/welcome_resources_map.h" |
| @@ -3139,8 +3047,8 @@ | |||
| 3139 | html_source->SetRequestFilter( | 3047 | html_source->SetRequestFilter( |
| 3140 | base::BindRepeating(&ShouldHandleRequestCallback, | 3048 | base::BindRepeating(&ShouldHandleRequestCallback, |
| 3141 | weak_ptr_factory_.GetWeakPtr()), | 3049 | weak_ptr_factory_.GetWeakPtr()), |
| 3142 | --- a/chrome/browser/unified_consent/unified_consent_service_factory.cc | 3050 | --- chrome/browser/unified_consent/unified_consent_service_factory.cc.orig |
| 3143 | +++ b/chrome/browser/unified_consent/unified_consent_service_factory.cc | 3051 | +++ chrome/browser/unified_consent/unified_consent_service_factory.cc |
| 3144 | @@ -13,7 +13,6 @@ | 3052 | @@ -13,7 +13,6 @@ |
| 3145 | #include "components/embedder_support/pref_names.h" | 3053 | #include "components/embedder_support/pref_names.h" |
| 3146 | #include "components/keyed_service/content/browser_context_dependency_manager.h" | 3054 | #include "components/keyed_service/content/browser_context_dependency_manager.h" |
| @@ -3155,10 +3063,10 @@ | |||
| 3155 | prefs::kSearchSuggestEnabled, embedder_support::kAlternateErrorPagesEnabled, | 3063 | prefs::kSearchSuggestEnabled, embedder_support::kAlternateErrorPagesEnabled, |
| 3156 | - prefs::kSafeBrowsingEnabled, prefs::kSafeBrowsingScoutReportingEnabled, | 3064 | - prefs::kSafeBrowsingEnabled, prefs::kSafeBrowsingScoutReportingEnabled, |
| 3157 | spellcheck::prefs::kSpellCheckUseSpellingService, | 3065 | spellcheck::prefs::kSpellCheckUseSpellingService, |
| 3158 | #if BUILDFLAG(IS_ANDROID) | 3066 | #if defined(OS_ANDROID) |
| 3159 | prefs::kContextualSearchEnabled | 3067 | prefs::kContextualSearchEnabled |
| 3160 | --- a/chrome/common/extensions/api/privacy.json | 3068 | --- chrome/common/extensions/api/privacy.json.orig |
| 3161 | +++ b/chrome/common/extensions/api/privacy.json | 3069 | +++ chrome/common/extensions/api/privacy.json |
| 3162 | @@ -63,16 +63,6 @@ | 3070 | @@ -63,16 +63,6 @@ |
| 3163 | "value": ["passwordSavingEnabled", {"type":"boolean"}], | 3071 | "value": ["passwordSavingEnabled", {"type":"boolean"}], |
| 3164 | "description": "If enabled, the password manager will ask if you want to save passwords. This preference's value is a boolean, defaulting to <code>true</code>." | 3072 | "description": "If enabled, the password manager will ask if you want to save passwords. This preference's value is a boolean, defaulting to <code>true</code>." |
| @@ -3176,9 +3084,9 @@ | |||
| 3176 | "searchSuggestEnabled": { | 3084 | "searchSuggestEnabled": { |
| 3177 | "$ref": "types.ChromeSetting", | 3085 | "$ref": "types.ChromeSetting", |
| 3178 | "value": ["searchSuggestEnabled", {"type":"boolean"}], | 3086 | "value": ["searchSuggestEnabled", {"type":"boolean"}], |
| 3179 | --- a/components/password_manager/core/browser/leak_detection_delegate.cc | 3087 | --- components/password_manager/core/browser/leak_detection_delegate.cc.orig |
| 3180 | +++ b/components/password_manager/core/browser/leak_detection_delegate.cc | 3088 | +++ components/password_manager/core/browser/leak_detection_delegate.cc |
| 3181 | @@ -23,7 +23,6 @@ | 3089 | @@ -22,7 +22,6 @@ |
| 3182 | #include "components/password_manager/core/common/password_manager_features.h" | 3090 | #include "components/password_manager/core/common/password_manager_features.h" |
| 3183 | #include "components/password_manager/core/common/password_manager_pref_names.h" | 3091 | #include "components/password_manager/core/common/password_manager_pref_names.h" |
| 3184 | #include "components/prefs/pref_service.h" | 3092 | #include "components/prefs/pref_service.h" |
| @@ -3186,7 +3094,7 @@ | |||
| 3186 | #include "services/network/public/cpp/shared_url_loader_factory.h" | 3094 | #include "services/network/public/cpp/shared_url_loader_factory.h" |
| 3187 | 3095 | ||
| 3188 | namespace password_manager { | 3096 | namespace password_manager { |
| 3189 | @@ -176,28 +175,7 @@ void LeakDetectionDelegate::OnError(Leak | 3097 | @@ -169,28 +168,7 @@ void LeakDetectionDelegate::OnError(Leak |
| 3190 | 3098 | ||
| 3191 | bool CanStartLeakCheck(const PrefService& prefs, | 3099 | bool CanStartLeakCheck(const PrefService& prefs, |
| 3192 | const PasswordManagerClient* client) { | 3100 | const PasswordManagerClient* client) { |
| @@ -3216,18 +3124,18 @@ | |||
| 3216 | } | 3124 | } |
| 3217 | 3125 | ||
| 3218 | } // namespace password_manager | 3126 | } // namespace password_manager |
| 3219 | --- a/components/password_manager/core/browser/password_bubble_experiment.cc | 3127 | --- components/password_manager/core/browser/password_bubble_experiment.cc.orig |
| 3220 | +++ b/components/password_manager/core/browser/password_bubble_experiment.cc | 3128 | +++ components/password_manager/core/browser/password_bubble_experiment.cc |
| 3221 | @@ -18,7 +18,6 @@ | 3129 | @@ -18,7 +18,6 @@ |
| 3222 | #include "components/prefs/pref_registry_simple.h" | 3130 | #include "components/prefs/pref_registry_simple.h" |
| 3223 | #include "components/prefs/pref_service.h" | 3131 | #include "components/prefs/pref_service.h" |
| 3224 | #include "components/signin/public/base/signin_buildflags.h" | 3132 | #include "components/signin/public/base/signin_buildflags.h" |
| 3225 | -#include "components/signin/public/base/signin_pref_names.h" | 3133 | -#include "components/signin/public/base/signin_pref_names.h" |
| 3226 | #include "components/sync/base/user_selectable_type.h" | ||
| 3227 | #include "components/sync/driver/sync_service.h" | 3134 | #include "components/sync/driver/sync_service.h" |
| 3228 | #include "components/sync/driver/sync_user_settings.h" | 3135 | #include "components/sync/driver/sync_user_settings.h" |
| 3229 | --- a/components/password_manager/core/browser/password_reuse_detector.cc | 3136 | |
| 3230 | +++ b/components/password_manager/core/browser/password_reuse_detector.cc | 3137 | --- components/password_manager/core/browser/password_reuse_detector.cc.orig |
| 3138 | +++ components/password_manager/core/browser/password_reuse_detector.cc | ||
| 3231 | @@ -15,7 +15,6 @@ | 3139 | @@ -15,7 +15,6 @@ |
| 3232 | #include "components/password_manager/core/browser/password_reuse_detector_consumer.h" | 3140 | #include "components/password_manager/core/browser/password_reuse_detector_consumer.h" |
| 3233 | #include "components/password_manager/core/browser/password_store_consumer.h" | 3141 | #include "components/password_manager/core/browser/password_store_consumer.h" |
| @@ -3236,7 +3144,7 @@ | |||
| 3236 | #include "google_apis/gaia/gaia_auth_util.h" | 3144 | #include "google_apis/gaia/gaia_auth_util.h" |
| 3237 | #include "google_apis/gaia/gaia_urls.h" | 3145 | #include "google_apis/gaia/gaia_urls.h" |
| 3238 | #include "url/origin.h" | 3146 | #include "url/origin.h" |
| 3239 | @@ -216,9 +215,7 @@ PasswordReuseDetector::CheckNonGaiaEnter | 3147 | @@ -205,9 +204,7 @@ PasswordReuseDetector::CheckNonGaiaEnter |
| 3240 | // Skips password reuse check if |domain| matches enterprise login URL or | 3148 | // Skips password reuse check if |domain| matches enterprise login URL or |
| 3241 | // enterprise change password URL. | 3149 | // enterprise change password URL. |
| 3242 | GURL page_url(domain); | 3150 | GURL page_url(domain); |
| @@ -3247,8 +3155,8 @@ | |||
| 3247 | return absl::nullopt; | 3155 | return absl::nullopt; |
| 3248 | } | 3156 | } |
| 3249 | 3157 | ||
| 3250 | --- a/components/password_manager/core/browser/password_reuse_manager_impl.cc | 3158 | --- components/password_manager/core/browser/password_reuse_manager_impl.cc.orig |
| 3251 | +++ b/components/password_manager/core/browser/password_reuse_manager_impl.cc | 3159 | +++ components/password_manager/core/browser/password_reuse_manager_impl.cc |
| 3252 | @@ -9,7 +9,6 @@ | 3160 | @@ -9,7 +9,6 @@ |
| 3253 | #include "components/password_manager/core/browser/password_store_signin_notifier.h" | 3161 | #include "components/password_manager/core/browser/password_store_signin_notifier.h" |
| 3254 | #include "components/password_manager/core/common/password_manager_features.h" | 3162 | #include "components/password_manager/core/common/password_manager_features.h" |
| @@ -3257,7 +3165,7 @@ | |||
| 3257 | 3165 | ||
| 3258 | namespace password_manager { | 3166 | namespace password_manager { |
| 3259 | 3167 | ||
| 3260 | @@ -320,20 +319,6 @@ void PasswordReuseManagerImpl::ScheduleP | 3168 | @@ -318,20 +317,6 @@ void PasswordReuseManagerImpl::ScheduleP |
| 3261 | 3169 | ||
| 3262 | void PasswordReuseManagerImpl::ScheduleEnterprisePasswordURLUpdate() { | 3170 | void PasswordReuseManagerImpl::ScheduleEnterprisePasswordURLUpdate() { |
| 3263 | DCHECK(main_task_runner_->RunsTasksInCurrentSequence()); | 3171 | DCHECK(main_task_runner_->RunsTasksInCurrentSequence()); |
| @@ -3278,9 +3186,9 @@ | |||
| 3278 | } | 3186 | } |
| 3279 | 3187 | ||
| 3280 | void PasswordReuseManagerImpl::OnGetPasswordStoreResults( | 3188 | void PasswordReuseManagerImpl::OnGetPasswordStoreResults( |
| 3281 | --- a/components/password_manager/core/browser/password_store.cc | 3189 | --- components/password_manager/core/browser/password_store.cc.orig |
| 3282 | +++ b/components/password_manager/core/browser/password_store.cc | 3190 | +++ components/password_manager/core/browser/password_store.cc |
| 3283 | @@ -40,7 +40,6 @@ | 3191 | @@ -39,7 +39,6 @@ |
| 3284 | #include "components/password_manager/core/common/password_manager_features.h" | 3192 | #include "components/password_manager/core/common/password_manager_features.h" |
| 3285 | #include "components/password_manager/core/common/password_manager_pref_names.h" | 3193 | #include "components/password_manager/core/common/password_manager_pref_names.h" |
| 3286 | #include "components/prefs/pref_service.h" | 3194 | #include "components/prefs/pref_service.h" |
| @@ -3288,8 +3196,8 @@ | |||
| 3288 | #include "components/sync/model/proxy_model_type_controller_delegate.h" | 3196 | #include "components/sync/model/proxy_model_type_controller_delegate.h" |
| 3289 | 3197 | ||
| 3290 | namespace password_manager { | 3198 | namespace password_manager { |
| 3291 | --- a/components/password_manager/core/browser/password_sync_util.cc | 3199 | --- components/password_manager/core/browser/password_sync_util.cc.orig |
| 3292 | +++ b/components/password_manager/core/browser/password_sync_util.cc | 3200 | +++ components/password_manager/core/browser/password_sync_util.cc |
| 3293 | @@ -8,7 +8,6 @@ | 3201 | @@ -8,7 +8,6 @@ |
| 3294 | #include "build/build_config.h" | 3202 | #include "build/build_config.h" |
| 3295 | #include "components/password_manager/core/browser/password_form.h" | 3203 | #include "components/password_manager/core/browser/password_form.h" |
| @@ -3310,9 +3218,9 @@ | |||
| 3310 | return false; | 3218 | return false; |
| 3311 | } | 3219 | } |
| 3312 | 3220 | ||
| 3313 | --- a/components/password_manager/core/browser/sync_credentials_filter_unittest.cc | 3221 | --- components/password_manager/core/browser/sync_credentials_filter_unittest.cc.orig |
| 3314 | +++ b/components/password_manager/core/browser/sync_credentials_filter_unittest.cc | 3222 | +++ components/password_manager/core/browser/sync_credentials_filter_unittest.cc |
| 3315 | @@ -30,7 +30,6 @@ | 3223 | @@ -29,7 +29,6 @@ |
| 3316 | #include "components/password_manager/core/common/password_manager_features.h" | 3224 | #include "components/password_manager/core/common/password_manager_features.h" |
| 3317 | #include "components/prefs/pref_registry_simple.h" | 3225 | #include "components/prefs/pref_registry_simple.h" |
| 3318 | #include "components/prefs/testing_pref_service.h" | 3226 | #include "components/prefs/testing_pref_service.h" |
| @@ -3320,18 +3228,8 @@ | |||
| 3320 | #include "testing/gtest/include/gtest/gtest.h" | 3228 | #include "testing/gtest/include/gtest/gtest.h" |
| 3321 | 3229 | ||
| 3322 | namespace password_manager { | 3230 | namespace password_manager { |
| 3323 | --- a/components/reputation/core/safety_tips_config.cc | 3231 | --- components/safe_browsing/content/browser/base_blocking_page.cc.orig |
| 3324 | +++ b/components/reputation/core/safety_tips_config.cc | 3232 | +++ components/safe_browsing/content/browser/base_blocking_page.cc |
| 3325 | @@ -5,6 +5,7 @@ | ||
| 3326 | #include "components/reputation/core/safety_tips_config.h" | ||
| 3327 | |||
| 3328 | #include "base/no_destructor.h" | ||
| 3329 | +#include "base/notreached.h" | ||
| 3330 | #include "base/ranges/algorithm.h" | ||
| 3331 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" | ||
| 3332 | #include "third_party/re2/src/re2/re2.h" | ||
| 3333 | --- a/components/safe_browsing/content/browser/base_blocking_page.cc | ||
| 3334 | +++ b/components/safe_browsing/content/browser/base_blocking_page.cc | ||
| 3335 | @@ -13,7 +13,6 @@ | 3233 | @@ -13,7 +13,6 @@ |
| 3336 | #include "base/time/time.h" | 3234 | #include "base/time/time.h" |
| 3337 | #include "components/safe_browsing/content/browser/safe_browsing_controller_client.h" | 3235 | #include "components/safe_browsing/content/browser/safe_browsing_controller_client.h" |
| @@ -3340,9 +3238,9 @@ | |||
| 3340 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" | 3238 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" |
| 3341 | #include "components/security_interstitials/content/settings_page_helper.h" | 3239 | #include "components/security_interstitials/content/settings_page_helper.h" |
| 3342 | #include "components/security_interstitials/content/unsafe_resource_util.h" | 3240 | #include "components/security_interstitials/content/unsafe_resource_util.h" |
| 3343 | --- a/components/safe_browsing/content/browser/client_side_detection_service.cc | 3241 | --- components/safe_browsing/content/browser/client_side_detection_service.cc.orig |
| 3344 | +++ b/components/safe_browsing/content/browser/client_side_detection_service.cc | 3242 | +++ components/safe_browsing/content/browser/client_side_detection_service.cc |
| 3345 | @@ -27,7 +27,6 @@ | 3243 | @@ -28,7 +28,6 @@ |
| 3346 | #include "components/safe_browsing/core/common/features.h" | 3244 | #include "components/safe_browsing/core/common/features.h" |
| 3347 | #include "components/safe_browsing/core/common/proto/client_model.pb.h" | 3245 | #include "components/safe_browsing/core/common/proto/client_model.pb.h" |
| 3348 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 3246 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| @@ -3350,8 +3248,8 @@ | |||
| 3350 | #include "components/safe_browsing/core/common/safebrowsing_constants.h" | 3248 | #include "components/safe_browsing/core/common/safebrowsing_constants.h" |
| 3351 | #include "components/safe_browsing/core/common/utils.h" | 3249 | #include "components/safe_browsing/core/common/utils.h" |
| 3352 | #include "content/public/browser/browser_task_traits.h" | 3250 | #include "content/public/browser/browser_task_traits.h" |
| 3353 | --- a/components/safe_browsing/content/browser/safe_browsing_navigation_observer_manager.cc | 3251 | --- components/safe_browsing/content/browser/safe_browsing_navigation_observer_manager.cc.orig |
| 3354 | +++ b/components/safe_browsing/content/browser/safe_browsing_navigation_observer_manager.cc | 3252 | +++ components/safe_browsing/content/browser/safe_browsing_navigation_observer_manager.cc |
| 3355 | @@ -20,7 +20,6 @@ | 3253 | @@ -20,7 +20,6 @@ |
| 3356 | #include "components/safe_browsing/content/browser/safe_browsing_navigation_observer_manager_util.h" | 3254 | #include "components/safe_browsing/content/browser/safe_browsing_navigation_observer_manager_util.h" |
| 3357 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" | 3255 | #include "components/safe_browsing/content/browser/web_ui/safe_browsing_ui.h" |
| @@ -3359,8 +3257,8 @@ | |||
| 3359 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 3257 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 3360 | #include "components/safe_browsing/core/common/utils.h" | 3258 | #include "components/safe_browsing/core/common/utils.h" |
| 3361 | #include "components/sessions/content/session_tab_helper.h" | 3259 | #include "components/sessions/content/session_tab_helper.h" |
| 3362 | #include "content/public/browser/browser_context.h" | 3260 | #include "content/public/browser/navigation_details.h" |
| 3363 | @@ -339,7 +338,7 @@ GURL SafeBrowsingNavigationObserverManag | 3261 | @@ -306,7 +305,7 @@ GURL SafeBrowsingNavigationObserverManag |
| 3364 | bool SafeBrowsingNavigationObserverManager::IsEnabledAndReady( | 3262 | bool SafeBrowsingNavigationObserverManager::IsEnabledAndReady( |
| 3365 | PrefService* prefs, | 3263 | PrefService* prefs, |
| 3366 | bool has_safe_browsing_service) { | 3264 | bool has_safe_browsing_service) { |
| @@ -3369,8 +3267,8 @@ | |||
| 3369 | } | 3267 | } |
| 3370 | 3268 | ||
| 3371 | // static | 3269 | // static |
| 3372 | --- a/components/safe_browsing/content/browser/triggers/suspicious_site_trigger_unittest.cc | 3270 | --- components/safe_browsing/content/browser/triggers/suspicious_site_trigger_unittest.cc.orig |
| 3373 | +++ b/components/safe_browsing/content/browser/triggers/suspicious_site_trigger_unittest.cc | 3271 | +++ components/safe_browsing/content/browser/triggers/suspicious_site_trigger_unittest.cc |
| 3374 | @@ -11,7 +11,6 @@ | 3272 | @@ -11,7 +11,6 @@ |
| 3375 | #include "build/build_config.h" | 3273 | #include "build/build_config.h" |
| 3376 | #include "components/prefs/testing_pref_service.h" | 3274 | #include "components/prefs/testing_pref_service.h" |
| @@ -3379,9 +3277,9 @@ | |||
| 3379 | #include "content/public/test/browser_task_environment.h" | 3277 | #include "content/public/test/browser_task_environment.h" |
| 3380 | #include "content/public/test/navigation_simulator.h" | 3278 | #include "content/public/test/navigation_simulator.h" |
| 3381 | #include "content/public/test/test_renderer_host.h" | 3279 | #include "content/public/test/test_renderer_host.h" |
| 3382 | --- a/components/safe_browsing/content/browser/triggers/trigger_manager.cc | 3280 | --- components/safe_browsing/content/browser/triggers/trigger_manager.cc.orig |
| 3383 | +++ b/components/safe_browsing/content/browser/triggers/trigger_manager.cc | 3281 | +++ components/safe_browsing/content/browser/triggers/trigger_manager.cc |
| 3384 | @@ -13,7 +13,6 @@ | 3282 | @@ -12,7 +12,6 @@ |
| 3385 | #include "components/safe_browsing/content/browser/base_ui_manager.h" | 3283 | #include "components/safe_browsing/content/browser/base_ui_manager.h" |
| 3386 | #include "components/safe_browsing/content/browser/threat_details.h" | 3284 | #include "components/safe_browsing/content/browser/threat_details.h" |
| 3387 | #include "components/safe_browsing/core/common/features.h" | 3285 | #include "components/safe_browsing/core/common/features.h" |
| @@ -3389,7 +3287,7 @@ | |||
| 3389 | #include "components/security_interstitials/core/unsafe_resource.h" | 3287 | #include "components/security_interstitials/core/unsafe_resource.h" |
| 3390 | #include "content/public/browser/browser_context.h" | 3288 | #include "content/public/browser/browser_context.h" |
| 3391 | #include "content/public/browser/browser_thread.h" | 3289 | #include "content/public/browser/browser_thread.h" |
| 3392 | @@ -86,16 +85,16 @@ SBErrorOptions TriggerManager::GetSBErro | 3290 | @@ -85,16 +84,16 @@ SBErrorOptions TriggerManager::GetSBErro |
| 3393 | const PrefService& pref_service, | 3291 | const PrefService& pref_service, |
| 3394 | content::WebContents* web_contents) { | 3292 | content::WebContents* web_contents) { |
| 3395 | return SBErrorOptions(/*is_main_frame_load_blocked=*/false, | 3293 | return SBErrorOptions(/*is_main_frame_load_blocked=*/false, |
| @@ -3412,14 +3310,14 @@ | |||
| 3412 | /*help_center_article_link=*/std::string()); | 3310 | /*help_center_article_link=*/std::string()); |
| 3413 | } | 3311 | } |
| 3414 | 3312 | ||
| 3415 | --- a/components/safe_browsing/content/browser/triggers/trigger_throttler.cc | 3313 | --- components/safe_browsing/content/browser/triggers/trigger_throttler.cc.orig |
| 3416 | +++ b/components/safe_browsing/content/browser/triggers/trigger_throttler.cc | 3314 | +++ components/safe_browsing/content/browser/triggers/trigger_throttler.cc |
| 3417 | @@ -197,28 +197,6 @@ void TriggerThrottler::LoadTriggerEvents | 3315 | @@ -197,28 +197,6 @@ void TriggerThrottler::LoadTriggerEvents |
| 3418 | trigger_events_.clear(); | 3316 | trigger_events_.clear(); |
| 3419 | if (!local_state_prefs_) | 3317 | if (!local_state_prefs_) |
| 3420 | return; | 3318 | return; |
| 3421 | - | 3319 | - |
| 3422 | - const base::Value* event_dict = local_state_prefs_->GetDictionary( | 3320 | - const base::DictionaryValue* event_dict = local_state_prefs_->GetDictionary( |
| 3423 | - prefs::kSafeBrowsingTriggerEventTimestamps); | 3321 | - prefs::kSafeBrowsingTriggerEventTimestamps); |
| 3424 | - for (auto trigger_pair : event_dict->DictItems()) { | 3322 | - for (auto trigger_pair : event_dict->DictItems()) { |
| 3425 | - // Check that the first item in the pair is convertible to a trigger type | 3323 | - // Check that the first item in the pair is convertible to a trigger type |
| @@ -3434,7 +3332,7 @@ | |||
| 3434 | - continue; | 3332 | - continue; |
| 3435 | - | 3333 | - |
| 3436 | - const TriggerType trigger_type = static_cast<TriggerType>(trigger_type_int); | 3334 | - const TriggerType trigger_type = static_cast<TriggerType>(trigger_type_int); |
| 3437 | - for (const auto& timestamp : trigger_pair.second.GetListDeprecated()) { | 3335 | - for (const auto& timestamp : trigger_pair.second.GetList()) { |
| 3438 | - if (timestamp.is_double()) | 3336 | - if (timestamp.is_double()) |
| 3439 | - trigger_events_[trigger_type].push_back( | 3337 | - trigger_events_[trigger_type].push_back( |
| 3440 | - base::Time::FromDoubleT(timestamp.GetDouble())); | 3338 | - base::Time::FromDoubleT(timestamp.GetDouble())); |
| @@ -3453,8 +3351,8 @@ | |||
| 3453 | } | 3351 | } |
| 3454 | 3352 | ||
| 3455 | size_t TriggerThrottler::GetDailyQuotaForTrigger( | 3353 | size_t TriggerThrottler::GetDailyQuotaForTrigger( |
| 3456 | --- a/components/safe_browsing/content/browser/triggers/trigger_throttler_unittest.cc | 3354 | --- components/safe_browsing/content/browser/triggers/trigger_throttler_unittest.cc.orig |
| 3457 | +++ b/components/safe_browsing/content/browser/triggers/trigger_throttler_unittest.cc | 3355 | +++ components/safe_browsing/content/browser/triggers/trigger_throttler_unittest.cc |
| 3458 | @@ -9,7 +9,6 @@ | 3356 | @@ -9,7 +9,6 @@ |
| 3459 | #include "base/test/simple_test_clock.h" | 3357 | #include "base/test/simple_test_clock.h" |
| 3460 | #include "components/prefs/testing_pref_service.h" | 3358 | #include "components/prefs/testing_pref_service.h" |
| @@ -3463,9 +3361,9 @@ | |||
| 3463 | #include "testing/gmock/include/gmock/gmock.h" | 3361 | #include "testing/gmock/include/gmock/gmock.h" |
| 3464 | #include "testing/gtest/include/gtest/gtest.h" | 3362 | #include "testing/gtest/include/gtest/gtest.h" |
| 3465 | 3363 | ||
| 3466 | --- a/components/safe_browsing/content/browser/ui_manager.cc | 3364 | --- components/safe_browsing/content/browser/ui_manager.cc.orig |
| 3467 | +++ b/components/safe_browsing/content/browser/ui_manager.cc | 3365 | +++ components/safe_browsing/content/browser/ui_manager.cc |
| 3468 | @@ -17,7 +17,6 @@ | 3366 | @@ -18,7 +18,6 @@ |
| 3469 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" | 3367 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" |
| 3470 | #include "components/safe_browsing/core/browser/ping_manager.h" | 3368 | #include "components/safe_browsing/core/browser/ping_manager.h" |
| 3471 | #include "components/safe_browsing/core/common/features.h" | 3369 | #include "components/safe_browsing/core/common/features.h" |
| @@ -3473,9 +3371,9 @@ | |||
| 3473 | #include "components/security_interstitials/content/security_interstitial_tab_helper.h" | 3371 | #include "components/security_interstitials/content/security_interstitial_tab_helper.h" |
| 3474 | #include "components/security_interstitials/content/unsafe_resource_util.h" | 3372 | #include "components/security_interstitials/content/unsafe_resource_util.h" |
| 3475 | #include "components/security_interstitials/core/unsafe_resource.h" | 3373 | #include "components/security_interstitials/core/unsafe_resource.h" |
| 3476 | --- a/components/safe_browsing/content/browser/ui_manager_unittest.cc | 3374 | --- components/safe_browsing/content/browser/ui_manager_unittest.cc.orig |
| 3477 | +++ b/components/safe_browsing/content/browser/ui_manager_unittest.cc | 3375 | +++ components/safe_browsing/content/browser/ui_manager_unittest.cc |
| 3478 | @@ -15,7 +15,6 @@ | 3376 | @@ -14,7 +14,6 @@ |
| 3479 | #include "components/safe_browsing/content/browser/safe_browsing_controller_client.h" | 3377 | #include "components/safe_browsing/content/browser/safe_browsing_controller_client.h" |
| 3480 | #include "components/safe_browsing/content/browser/ui_manager.h" | 3378 | #include "components/safe_browsing/content/browser/ui_manager.h" |
| 3481 | #include "components/safe_browsing/core/browser/db/util.h" | 3379 | #include "components/safe_browsing/core/browser/db/util.h" |
| @@ -3483,38 +3381,38 @@ | |||
| 3483 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" | 3381 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" |
| 3484 | #include "components/security_interstitials/content/settings_page_helper.h" | 3382 | #include "components/security_interstitials/content/settings_page_helper.h" |
| 3485 | #include "components/security_interstitials/content/unsafe_resource_util.h" | 3383 | #include "components/security_interstitials/content/unsafe_resource_util.h" |
| 3486 | --- a/components/safe_browsing/content/browser/web_ui/safe_browsing_ui.cc | 3384 | --- components/safe_browsing/content/browser/web_ui/safe_browsing_ui.cc.orig |
| 3487 | +++ b/components/safe_browsing/content/browser/web_ui/safe_browsing_ui.cc | 3385 | +++ components/safe_browsing/content/browser/web_ui/safe_browsing_ui.cc |
| 3488 | @@ -32,7 +32,6 @@ | 3386 | @@ -32,7 +32,6 @@ |
| 3489 | #include "components/safe_browsing/core/browser/referrer_chain_provider.h" | 3387 | #include "components/safe_browsing/core/browser/referrer_chain_provider.h" |
| 3490 | #include "components/safe_browsing/core/common/features.h" | 3388 | #include "components/safe_browsing/core/common/features.h" |
| 3491 | #include "components/safe_browsing/core/common/proto/csd.pb.h" | 3389 | #include "components/safe_browsing/core/common/proto/csd.pb.h" |
| 3492 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 3390 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 3493 | #include "content/public/browser/global_routing_id.h" | ||
| 3494 | #include "services/network/public/mojom/cookie_manager.mojom.h" | 3391 | #include "services/network/public/mojom/cookie_manager.mojom.h" |
| 3495 | #if BUILDFLAG(FULL_SAFE_BROWSING) | 3392 | #if BUILDFLAG(FULL_SAFE_BROWSING) |
| 3496 | @@ -2050,18 +2049,13 @@ void SafeBrowsingUIHandler::GetPrefs(con | 3393 | #include "components/enterprise/common/proto/connectors.pb.h" |
| 3394 | @@ -2035,18 +2034,13 @@ void SafeBrowsingUIHandler::GetPrefs(con | ||
| 3497 | AllowJavascript(); | 3395 | AllowJavascript(); |
| 3498 | DCHECK(!args.empty()); | 3396 | DCHECK(!args->GetList().empty()); |
| 3499 | std::string callback_id = args[0].GetString(); | 3397 | std::string callback_id = args->GetList()[0].GetString(); |
| 3500 | - ResolveJavascriptCallback(base::Value(callback_id), | 3398 | - ResolveJavascriptCallback(base::Value(callback_id), |
| 3501 | - safe_browsing::GetSafeBrowsingPreferencesList( | 3399 | - safe_browsing::GetSafeBrowsingPreferencesList( |
| 3502 | - user_prefs::UserPrefs::Get(browser_context_))); | 3400 | - user_prefs::UserPrefs::Get(browser_context_))); |
| 3503 | + ResolveJavascriptCallback(base::Value(callback_id), base::ListValue()); | 3401 | + ResolveJavascriptCallback(base::Value(callback_id), base::ListValue()); |
| 3504 | } | 3402 | } |
| 3505 | 3403 | ||
| 3506 | void SafeBrowsingUIHandler::GetPolicies(const base::Value::List& args) { | 3404 | void SafeBrowsingUIHandler::GetPolicies(const base::ListValue* args) { |
| 3507 | AllowJavascript(); | 3405 | AllowJavascript(); |
| 3508 | DCHECK(!args.empty()); | 3406 | DCHECK(!args->GetList().empty()); |
| 3509 | std::string callback_id = args[0].GetString(); | 3407 | std::string callback_id = args->GetList()[0].GetString(); |
| 3510 | - ResolveJavascriptCallback(base::Value(callback_id), | 3408 | - ResolveJavascriptCallback(base::Value(callback_id), |
| 3511 | - safe_browsing::GetSafeBrowsingPoliciesList( | 3409 | - safe_browsing::GetSafeBrowsingPoliciesList( |
| 3512 | - user_prefs::UserPrefs::Get(browser_context_))); | 3410 | - user_prefs::UserPrefs::Get(browser_context_))); |
| 3513 | } | 3411 | } |
| 3514 | 3412 | ||
| 3515 | void SafeBrowsingUIHandler::GetCookie(const base::Value::List& args) { | 3413 | void SafeBrowsingUIHandler::GetCookie(const base::ListValue* args) { |
| 3516 | --- a/components/safe_browsing/core/browser/db/hit_report.h | 3414 | --- components/safe_browsing/core/browser/db/hit_report.h.orig |
| 3517 | +++ b/components/safe_browsing/core/browser/db/hit_report.h | 3415 | +++ components/safe_browsing/core/browser/db/hit_report.h |
| 3518 | @@ -8,7 +8,6 @@ | 3416 | @@ -8,7 +8,6 @@ |
| 3519 | #define COMPONENTS_SAFE_BROWSING_CORE_BROWSER_DB_HIT_REPORT_H_ | 3417 | #define COMPONENTS_SAFE_BROWSING_CORE_BROWSER_DB_HIT_REPORT_H_ |
| 3520 | 3418 | ||
| @@ -3531,8 +3429,8 @@ | |||
| 3531 | bool is_enhanced_protection = false; | 3429 | bool is_enhanced_protection = false; |
| 3532 | bool is_metrics_reporting_active; | 3430 | bool is_metrics_reporting_active; |
| 3533 | 3431 | ||
| 3534 | --- a/components/safe_browsing/core/browser/db/util.h | 3432 | --- components/safe_browsing/core/browser/db/util.h.orig |
| 3535 | +++ b/components/safe_browsing/core/browser/db/util.h | 3433 | +++ components/safe_browsing/core/browser/db/util.h |
| 3536 | @@ -18,7 +18,6 @@ | 3434 | @@ -18,7 +18,6 @@ |
| 3537 | #include "base/strings/string_piece.h" | 3435 | #include "base/strings/string_piece.h" |
| 3538 | #include "base/trace_event/traced_value.h" | 3436 | #include "base/trace_event/traced_value.h" |
| @@ -3541,9 +3439,9 @@ | |||
| 3541 | 3439 | ||
| 3542 | namespace safe_browsing { | 3440 | namespace safe_browsing { |
| 3543 | 3441 | ||
| 3544 | --- a/components/safe_browsing/core/browser/db/v4_local_database_manager.cc | 3442 | --- components/safe_browsing/core/browser/db/v4_local_database_manager.cc.orig |
| 3545 | +++ b/components/safe_browsing/core/browser/db/v4_local_database_manager.cc | 3443 | +++ components/safe_browsing/core/browser/db/v4_local_database_manager.cc |
| 3546 | @@ -334,10 +334,9 @@ const V4LocalDatabaseManager* | 3444 | @@ -337,10 +337,9 @@ const V4LocalDatabaseManager* |
| 3547 | scoped_refptr<V4LocalDatabaseManager> V4LocalDatabaseManager::Create( | 3445 | scoped_refptr<V4LocalDatabaseManager> V4LocalDatabaseManager::Create( |
| 3548 | const base::FilePath& base_path, | 3446 | const base::FilePath& base_path, |
| 3549 | scoped_refptr<base::SequencedTaskRunner> ui_task_runner, | 3447 | scoped_refptr<base::SequencedTaskRunner> ui_task_runner, |
| @@ -3556,7 +3454,7 @@ | |||
| 3556 | std::move(io_task_runner), nullptr)); | 3454 | std::move(io_task_runner), nullptr)); |
| 3557 | } | 3455 | } |
| 3558 | 3456 | ||
| 3559 | @@ -360,14 +359,12 @@ void V4LocalDatabaseManager::CollectData | 3457 | @@ -363,14 +362,12 @@ void V4LocalDatabaseManager::CollectData |
| 3560 | 3458 | ||
| 3561 | V4LocalDatabaseManager::V4LocalDatabaseManager( | 3459 | V4LocalDatabaseManager::V4LocalDatabaseManager( |
| 3562 | const base::FilePath& base_path, | 3460 | const base::FilePath& base_path, |
| @@ -3571,7 +3469,7 @@ | |||
| 3571 | list_infos_(GetListInfos()), | 3469 | list_infos_(GetListInfos()), |
| 3572 | task_runner_(task_runner_for_tests | 3470 | task_runner_(task_runner_for_tests |
| 3573 | ? task_runner_for_tests | 3471 | ? task_runner_for_tests |
| 3574 | @@ -1123,8 +1120,7 @@ void V4LocalDatabaseManager::SetupUpdate | 3472 | @@ -1137,8 +1134,7 @@ void V4LocalDatabaseManager::SetupUpdate |
| 3575 | weak_factory_.GetWeakPtr()); | 3473 | weak_factory_.GetWeakPtr()); |
| 3576 | 3474 | ||
| 3577 | v4_update_protocol_manager_ = V4UpdateProtocolManager::Create( | 3475 | v4_update_protocol_manager_ = V4UpdateProtocolManager::Create( |
| @@ -3581,9 +3479,9 @@ | |||
| 3581 | } | 3479 | } |
| 3582 | 3480 | ||
| 3583 | void V4LocalDatabaseManager::UpdateRequestCompleted( | 3481 | void V4LocalDatabaseManager::UpdateRequestCompleted( |
| 3584 | --- a/components/safe_browsing/core/browser/db/v4_local_database_manager.h | 3482 | --- components/safe_browsing/core/browser/db/v4_local_database_manager.h.orig |
| 3585 | +++ b/components/safe_browsing/core/browser/db/v4_local_database_manager.h | 3483 | +++ components/safe_browsing/core/browser/db/v4_local_database_manager.h |
| 3586 | @@ -39,8 +39,7 @@ class V4LocalDatabaseManager : public Sa | 3484 | @@ -37,8 +37,7 @@ class V4LocalDatabaseManager : public Sa |
| 3587 | static scoped_refptr<V4LocalDatabaseManager> Create( | 3485 | static scoped_refptr<V4LocalDatabaseManager> Create( |
| 3588 | const base::FilePath& base_path, | 3486 | const base::FilePath& base_path, |
| 3589 | scoped_refptr<base::SequencedTaskRunner> ui_task_runner, | 3487 | scoped_refptr<base::SequencedTaskRunner> ui_task_runner, |
| @@ -3593,7 +3491,7 @@ | |||
| 3593 | 3491 | ||
| 3594 | V4LocalDatabaseManager(const V4LocalDatabaseManager&) = delete; | 3492 | V4LocalDatabaseManager(const V4LocalDatabaseManager&) = delete; |
| 3595 | V4LocalDatabaseManager& operator=(const V4LocalDatabaseManager&) = delete; | 3493 | V4LocalDatabaseManager& operator=(const V4LocalDatabaseManager&) = delete; |
| 3596 | @@ -109,7 +108,6 @@ class V4LocalDatabaseManager : public Sa | 3494 | @@ -108,7 +107,6 @@ class V4LocalDatabaseManager : public Sa |
| 3597 | // Must be initialized by calling StartOnIOThread() before using. | 3495 | // Must be initialized by calling StartOnIOThread() before using. |
| 3598 | V4LocalDatabaseManager( | 3496 | V4LocalDatabaseManager( |
| 3599 | const base::FilePath& base_path, | 3497 | const base::FilePath& base_path, |
| @@ -3601,7 +3499,7 @@ | |||
| 3601 | scoped_refptr<base::SequencedTaskRunner> ui_task_runner, | 3499 | scoped_refptr<base::SequencedTaskRunner> ui_task_runner, |
| 3602 | scoped_refptr<base::SequencedTaskRunner> io_task_runner, | 3500 | scoped_refptr<base::SequencedTaskRunner> io_task_runner, |
| 3603 | scoped_refptr<base::SequencedTaskRunner> task_runner_for_tests); | 3501 | scoped_refptr<base::SequencedTaskRunner> task_runner_for_tests); |
| 3604 | @@ -369,10 +367,6 @@ class V4LocalDatabaseManager : public Sa | 3502 | @@ -367,10 +365,6 @@ class V4LocalDatabaseManager : public Sa |
| 3605 | // ready to process next update. | 3503 | // ready to process next update. |
| 3606 | DatabaseUpdatedCallback db_updated_callback_; | 3504 | DatabaseUpdatedCallback db_updated_callback_; |
| 3607 | 3505 | ||
| @@ -3612,9 +3510,9 @@ | |||
| 3612 | // The client_state of each list currently being synced. This is updated each | 3510 | // The client_state of each list currently being synced. This is updated each |
| 3613 | // time a database update completes, and used to send list client_state | 3511 | // time a database update completes, and used to send list client_state |
| 3614 | // information in the full hash request. | 3512 | // information in the full hash request. |
| 3615 | --- a/components/safe_browsing/core/browser/db/v4_protocol_manager_util.cc | 3513 | --- components/safe_browsing/core/browser/db/v4_protocol_manager_util.cc.orig |
| 3616 | +++ b/components/safe_browsing/core/browser/db/v4_protocol_manager_util.cc | 3514 | +++ components/safe_browsing/core/browser/db/v4_protocol_manager_util.cc |
| 3617 | @@ -89,7 +89,6 @@ void SetSbV4UrlPrefixForTesting(const ch | 3515 | @@ -88,7 +88,6 @@ void SetSbV4UrlPrefixForTesting(const ch |
| 3618 | 3516 | ||
| 3619 | std::string GetReportUrl(const V4ProtocolConfig& config, | 3517 | std::string GetReportUrl(const V4ProtocolConfig& config, |
| 3620 | const std::string& method, | 3518 | const std::string& method, |
| @@ -3622,7 +3520,7 @@ | |||
| 3622 | const bool is_enhanced_protection) { | 3520 | const bool is_enhanced_protection) { |
| 3623 | std::string url = base::StringPrintf( | 3521 | std::string url = base::StringPrintf( |
| 3624 | "%s/%s?client=%s&appver=%s&pver=4.0", kSbReportsURLPrefix, method.c_str(), | 3522 | "%s/%s?client=%s&appver=%s&pver=4.0", kSbReportsURLPrefix, method.c_str(), |
| 3625 | @@ -99,8 +98,6 @@ std::string GetReportUrl(const V4Protoco | 3523 | @@ -98,8 +97,6 @@ std::string GetReportUrl(const V4Protoco |
| 3626 | base::StringAppendF(&url, "&key=%s", | 3524 | base::StringAppendF(&url, "&key=%s", |
| 3627 | net::EscapeQueryParamValue(api_key, true).c_str()); | 3525 | net::EscapeQueryParamValue(api_key, true).c_str()); |
| 3628 | } | 3526 | } |
| @@ -3631,8 +3529,8 @@ | |||
| 3631 | if (is_enhanced_protection) | 3529 | if (is_enhanced_protection) |
| 3632 | url.append(base::StringPrintf("&enh=%d", is_enhanced_protection)); | 3530 | url.append(base::StringPrintf("&enh=%d", is_enhanced_protection)); |
| 3633 | return url; | 3531 | return url; |
| 3634 | --- a/components/safe_browsing/core/browser/db/v4_protocol_manager_util.h | 3532 | --- components/safe_browsing/core/browser/db/v4_protocol_manager_util.h.orig |
| 3635 | +++ b/components/safe_browsing/core/browser/db/v4_protocol_manager_util.h | 3533 | +++ components/safe_browsing/core/browser/db/v4_protocol_manager_util.h |
| 3636 | @@ -18,10 +18,11 @@ | 3534 | @@ -18,10 +18,11 @@ |
| 3637 | #include <vector> | 3535 | #include <vector> |
| 3638 | 3536 | ||
| @@ -3654,8 +3552,8 @@ | |||
| 3654 | const bool is_enhanced_protection = false); | 3552 | const bool is_enhanced_protection = false); |
| 3655 | 3553 | ||
| 3656 | // Different types of threats that SafeBrowsing protects against. This is the | 3554 | // Different types of threats that SafeBrowsing protects against. This is the |
| 3657 | --- a/components/safe_browsing/core/browser/db/v4_update_protocol_manager.cc | 3555 | --- components/safe_browsing/core/browser/db/v4_update_protocol_manager.cc.orig |
| 3658 | +++ b/components/safe_browsing/core/browser/db/v4_update_protocol_manager.cc | 3556 | +++ components/safe_browsing/core/browser/db/v4_update_protocol_manager.cc |
| 3659 | @@ -78,19 +78,8 @@ static const int kV4TimerStartIntervalSe | 3557 | @@ -78,19 +78,8 @@ static const int kV4TimerStartIntervalSe |
| 3660 | // Maximum time, in seconds, to wait for a response to an update request. | 3558 | // Maximum time, in seconds, to wait for a response to an update request. |
| 3661 | static const int kV4TimerUpdateWaitSecMax = 15 * 60; // 15 minutes | 3559 | static const int kV4TimerUpdateWaitSecMax = 15 * 60; // 15 minutes |
| @@ -3742,9 +3640,9 @@ | |||
| 3742 | V4ProtocolManagerUtil::SetClientInfoFromConfig(request.mutable_client(), | 3640 | V4ProtocolManagerUtil::SetClientInfoFromConfig(request.mutable_client(), |
| 3743 | config_); | 3641 | config_); |
| 3744 | 3642 | ||
| 3745 | --- a/components/safe_browsing/core/browser/db/v4_update_protocol_manager.h | 3643 | --- components/safe_browsing/core/browser/db/v4_update_protocol_manager.h.orig |
| 3746 | +++ b/components/safe_browsing/core/browser/db/v4_update_protocol_manager.h | 3644 | +++ components/safe_browsing/core/browser/db/v4_update_protocol_manager.h |
| 3747 | @@ -23,7 +23,6 @@ | 3645 | @@ -24,7 +24,6 @@ |
| 3748 | #include "components/safe_browsing/core/browser/db/util.h" | 3646 | #include "components/safe_browsing/core/browser/db/util.h" |
| 3749 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" | 3647 | #include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h" |
| 3750 | #include "components/safe_browsing/core/common/proto/webui.pb.h" | 3648 | #include "components/safe_browsing/core/common/proto/webui.pb.h" |
| @@ -3752,7 +3650,7 @@ | |||
| 3752 | #include "third_party/abseil-cpp/absl/types/optional.h" | 3650 | #include "third_party/abseil-cpp/absl/types/optional.h" |
| 3753 | 3651 | ||
| 3754 | class GURL; | 3652 | class GURL; |
| 3755 | @@ -44,9 +43,6 @@ class V4UpdateProtocolManagerFactory; | 3653 | @@ -45,9 +44,6 @@ class V4UpdateProtocolManagerFactory; |
| 3756 | using V4UpdateCallback = | 3654 | using V4UpdateCallback = |
| 3757 | base::RepeatingCallback<void(std::unique_ptr<ParsedServerResponse>)>; | 3655 | base::RepeatingCallback<void(std::unique_ptr<ParsedServerResponse>)>; |
| 3758 | 3656 | ||
| @@ -3762,7 +3660,7 @@ | |||
| 3762 | class V4UpdateProtocolManager { | 3660 | class V4UpdateProtocolManager { |
| 3763 | public: | 3661 | public: |
| 3764 | V4UpdateProtocolManager(const V4UpdateProtocolManager&) = delete; | 3662 | V4UpdateProtocolManager(const V4UpdateProtocolManager&) = delete; |
| 3765 | @@ -64,8 +60,7 @@ class V4UpdateProtocolManager { | 3663 | @@ -65,8 +61,7 @@ class V4UpdateProtocolManager { |
| 3766 | static std::unique_ptr<V4UpdateProtocolManager> Create( | 3664 | static std::unique_ptr<V4UpdateProtocolManager> Create( |
| 3767 | scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory, | 3665 | scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory, |
| 3768 | const V4ProtocolConfig& config, | 3666 | const V4ProtocolConfig& config, |
| @@ -3772,7 +3670,7 @@ | |||
| 3772 | 3670 | ||
| 3773 | void OnURLLoaderComplete(std::unique_ptr<std::string> response_body); | 3671 | void OnURLLoaderComplete(std::unique_ptr<std::string> response_body); |
| 3774 | 3672 | ||
| 3775 | @@ -87,8 +82,7 @@ class V4UpdateProtocolManager { | 3673 | @@ -88,8 +83,7 @@ class V4UpdateProtocolManager { |
| 3776 | V4UpdateProtocolManager( | 3674 | V4UpdateProtocolManager( |
| 3777 | scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory, | 3675 | scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory, |
| 3778 | const V4ProtocolConfig& config, | 3676 | const V4ProtocolConfig& config, |
| @@ -3782,7 +3680,7 @@ | |||
| 3782 | 3680 | ||
| 3783 | private: | 3681 | private: |
| 3784 | FRIEND_TEST_ALL_PREFIXES(V4UpdateProtocolManagerTest, | 3682 | FRIEND_TEST_ALL_PREFIXES(V4UpdateProtocolManagerTest, |
| 3785 | @@ -206,8 +200,6 @@ class V4UpdateProtocolManager { | 3683 | @@ -207,8 +201,6 @@ class V4UpdateProtocolManager { |
| 3786 | // complete. | 3684 | // complete. |
| 3787 | base::OneShotTimer timeout_timer_; | 3685 | base::OneShotTimer timeout_timer_; |
| 3788 | 3686 | ||
| @@ -3791,7 +3689,7 @@ | |||
| 3791 | SEQUENCE_CHECKER(sequence_checker_); | 3689 | SEQUENCE_CHECKER(sequence_checker_); |
| 3792 | }; | 3690 | }; |
| 3793 | 3691 | ||
| 3794 | @@ -225,8 +217,7 @@ class V4UpdateProtocolManagerFactory { | 3692 | @@ -226,8 +218,7 @@ class V4UpdateProtocolManagerFactory { |
| 3795 | virtual std::unique_ptr<V4UpdateProtocolManager> CreateProtocolManager( | 3693 | virtual std::unique_ptr<V4UpdateProtocolManager> CreateProtocolManager( |
| 3796 | scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory, | 3694 | scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory, |
| 3797 | const V4ProtocolConfig& config, | 3695 | const V4ProtocolConfig& config, |
| @@ -3801,8 +3699,8 @@ | |||
| 3801 | }; | 3699 | }; |
| 3802 | 3700 | ||
| 3803 | } // namespace safe_browsing | 3701 | } // namespace safe_browsing |
| 3804 | --- a/components/safe_browsing/core/browser/password_protection/password_protection_service_base.h | 3702 | --- components/safe_browsing/core/browser/password_protection/password_protection_service_base.h.orig |
| 3805 | +++ b/components/safe_browsing/core/browser/password_protection/password_protection_service_base.h | 3703 | +++ components/safe_browsing/core/browser/password_protection/password_protection_service_base.h |
| 3806 | @@ -28,7 +28,6 @@ | 3704 | @@ -28,7 +28,6 @@ |
| 3807 | #include "components/safe_browsing/core/browser/safe_browsing_metrics_collector.h" | 3705 | #include "components/safe_browsing/core/browser/safe_browsing_metrics_collector.h" |
| 3808 | #include "components/safe_browsing/core/browser/safe_browsing_token_fetcher.h" | 3706 | #include "components/safe_browsing/core/browser/safe_browsing_token_fetcher.h" |
| @@ -3811,7 +3709,7 @@ | |||
| 3811 | #include "components/sessions/core/session_id.h" | 3709 | #include "components/sessions/core/session_id.h" |
| 3812 | #include "components/signin/public/identity_manager/account_info.h" | 3710 | #include "components/signin/public/identity_manager/account_info.h" |
| 3813 | #include "components/signin/public/identity_manager/identity_manager.h" | 3711 | #include "components/signin/public/identity_manager/identity_manager.h" |
| 3814 | @@ -150,10 +149,6 @@ class PasswordProtectionServiceBase : pu | 3712 | @@ -149,10 +148,6 @@ class PasswordProtectionServiceBase : pu |
| 3815 | // Returns if the warning UI is enabled. | 3713 | // Returns if the warning UI is enabled. |
| 3816 | bool IsWarningEnabled(ReusedPasswordAccountType password_type); | 3714 | bool IsWarningEnabled(ReusedPasswordAccountType password_type); |
| 3817 | 3715 | ||
| @@ -3822,9 +3720,9 @@ | |||
| 3822 | // If |url| matches Safe Browsing allowlist domains, password protection | 3720 | // If |url| matches Safe Browsing allowlist domains, password protection |
| 3823 | // change password URL, or password protection login URLs in the enterprise | 3721 | // change password URL, or password protection login URLs in the enterprise |
| 3824 | // policy. | 3722 | // policy. |
| 3825 | --- a/components/safe_browsing/core/browser/ping_manager.cc | 3723 | --- components/safe_browsing/core/browser/ping_manager.cc.orig |
| 3826 | +++ b/components/safe_browsing/core/browser/ping_manager.cc | 3724 | +++ components/safe_browsing/core/browser/ping_manager.cc |
| 3827 | @@ -190,7 +190,7 @@ GURL PingManager::SafeBrowsingHitUrl( | 3725 | @@ -141,7 +141,7 @@ GURL PingManager::SafeBrowsingHitUrl( |
| 3828 | hit_report.threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING || | 3726 | hit_report.threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING || |
| 3829 | hit_report.threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE); | 3727 | hit_report.threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE); |
| 3830 | std::string url = | 3728 | std::string url = |
| @@ -3833,8 +3731,8 @@ | |||
| 3833 | hit_report.is_enhanced_protection); | 3731 | hit_report.is_enhanced_protection); |
| 3834 | std::string threat_list = "none"; | 3732 | std::string threat_list = "none"; |
| 3835 | switch (hit_report.threat_type) { | 3733 | switch (hit_report.threat_type) { |
| 3836 | --- a/components/safe_browsing/core/browser/realtime/policy_engine.cc | 3734 | --- components/safe_browsing/core/browser/realtime/policy_engine.cc.orig |
| 3837 | +++ b/components/safe_browsing/core/browser/realtime/policy_engine.cc | 3735 | +++ components/safe_browsing/core/browser/realtime/policy_engine.cc |
| 3838 | @@ -8,7 +8,6 @@ | 3736 | @@ -8,7 +8,6 @@ |
| 3839 | #include "base/metrics/histogram_macros.h" | 3737 | #include "base/metrics/histogram_macros.h" |
| 3840 | #include "build/build_config.h" | 3738 | #include "build/build_config.h" |
| @@ -3843,7 +3741,7 @@ | |||
| 3843 | #include "components/safe_browsing/core/common/utils.h" | 3741 | #include "components/safe_browsing/core/common/utils.h" |
| 3844 | #include "components/unified_consent/pref_names.h" | 3742 | #include "components/unified_consent/pref_names.h" |
| 3845 | #include "components/user_prefs/user_prefs.h" | 3743 | #include "components/user_prefs/user_prefs.h" |
| 3846 | @@ -36,7 +35,7 @@ bool RealTimePolicyEngine::IsUserMbbOpte | 3744 | @@ -35,7 +34,7 @@ bool RealTimePolicyEngine::IsUserMbbOpte |
| 3847 | 3745 | ||
| 3848 | // static | 3746 | // static |
| 3849 | bool RealTimePolicyEngine::IsUserEpOptedIn(PrefService* pref_service) { | 3747 | bool RealTimePolicyEngine::IsUserEpOptedIn(PrefService* pref_service) { |
| @@ -3852,7 +3750,7 @@ | |||
| 3852 | } | 3750 | } |
| 3853 | 3751 | ||
| 3854 | // static | 3752 | // static |
| 3855 | @@ -82,9 +81,7 @@ bool RealTimePolicyEngine::CanPerformEnt | 3753 | @@ -81,9 +80,7 @@ bool RealTimePolicyEngine::CanPerformEnt |
| 3856 | return false; | 3754 | return false; |
| 3857 | } | 3755 | } |
| 3858 | 3756 | ||
| @@ -3863,8 +3761,8 @@ | |||
| 3863 | } | 3761 | } |
| 3864 | 3762 | ||
| 3865 | // static | 3763 | // static |
| 3866 | --- a/components/safe_browsing/core/browser/realtime/url_lookup_service.cc | 3764 | --- components/safe_browsing/core/browser/realtime/url_lookup_service.cc.orig |
| 3867 | +++ b/components/safe_browsing/core/browser/realtime/url_lookup_service.cc | 3765 | +++ components/safe_browsing/core/browser/realtime/url_lookup_service.cc |
| 3868 | @@ -19,7 +19,6 @@ | 3766 | @@ -19,7 +19,6 @@ |
| 3869 | #include "components/safe_browsing/core/browser/referrer_chain_provider.h" | 3767 | #include "components/safe_browsing/core/browser/referrer_chain_provider.h" |
| 3870 | #include "components/safe_browsing/core/browser/safe_browsing_token_fetcher.h" | 3768 | #include "components/safe_browsing/core/browser/safe_browsing_token_fetcher.h" |
| @@ -3873,7 +3771,7 @@ | |||
| 3873 | #include "components/unified_consent/pref_names.h" | 3771 | #include "components/unified_consent/pref_names.h" |
| 3874 | #include "net/base/ip_address.h" | 3772 | #include "net/base/ip_address.h" |
| 3875 | #include "net/base/load_flags.h" | 3773 | #include "net/base/load_flags.h" |
| 3876 | @@ -62,10 +61,6 @@ RealTimeUrlLookupService::RealTimeUrlLoo | 3774 | @@ -61,10 +60,6 @@ RealTimeUrlLookupService::RealTimeUrlLoo |
| 3877 | variations_(variations_service) { | 3775 | variations_(variations_service) { |
| 3878 | pref_change_registrar_.Init(pref_service_); | 3776 | pref_change_registrar_.Init(pref_service_); |
| 3879 | pref_change_registrar_.Add( | 3777 | pref_change_registrar_.Add( |
| @@ -3884,7 +3782,7 @@ | |||
| 3884 | unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled, | 3782 | unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled, |
| 3885 | base::BindRepeating(&RealTimeUrlLookupService::OnPrefChanged, | 3783 | base::BindRepeating(&RealTimeUrlLookupService::OnPrefChanged, |
| 3886 | base::Unretained(this))); | 3784 | base::Unretained(this))); |
| 3887 | @@ -139,7 +134,7 @@ bool RealTimeUrlLookupService::CanSendPa | 3785 | @@ -144,7 +139,7 @@ bool RealTimeUrlLookupService::CanSendPa |
| 3888 | } | 3786 | } |
| 3889 | 3787 | ||
| 3890 | bool RealTimeUrlLookupService::CanCheckSubresourceURL() const { | 3788 | bool RealTimeUrlLookupService::CanCheckSubresourceURL() const { |
| @@ -3893,35 +3791,22 @@ | |||
| 3893 | } | 3791 | } |
| 3894 | 3792 | ||
| 3895 | bool RealTimeUrlLookupService::CanCheckSafeBrowsingDb() const { | 3793 | bool RealTimeUrlLookupService::CanCheckSafeBrowsingDb() const { |
| 3896 | @@ -149,11 +144,7 @@ bool RealTimeUrlLookupService::CanCheckS | 3794 | --- components/safe_browsing/core/browser/realtime/url_lookup_service_base.cc.orig |
| 3897 | } | 3795 | +++ components/safe_browsing/core/browser/realtime/url_lookup_service_base.cc |
| 3898 | 3796 | @@ -16,7 +16,6 @@ | |
| 3899 | bool RealTimeUrlLookupService::CanSendRTSampleRequest() const { | 3797 | #include "components/prefs/pref_service.h" |
| 3900 | - return IsExtendedReportingEnabled(*pref_service_) && | ||
| 3901 | - base::FeatureList::IsEnabled( | ||
| 3902 | - safe_browsing::kSendSampledPingsForProtegoAllowlistDomains) && | ||
| 3903 | - (bypass_protego_probability_for_tests_ || | ||
| 3904 | - base::RandDouble() <= kProbabilityForSendingSampledRequests); | ||
| 3905 | + return false; | ||
| 3906 | } | ||
| 3907 | |||
| 3908 | void RealTimeUrlLookupService::Shutdown() { | ||
| 3909 | --- a/components/safe_browsing/core/browser/realtime/url_lookup_service_base.cc | ||
| 3910 | +++ b/components/safe_browsing/core/browser/realtime/url_lookup_service_base.cc | ||
| 3911 | @@ -17,7 +17,6 @@ | ||
| 3912 | #include "components/safe_browsing/core/browser/referrer_chain_provider.h" | 3798 | #include "components/safe_browsing/core/browser/referrer_chain_provider.h" |
| 3913 | #include "components/safe_browsing/core/browser/verdict_cache_manager.h" | 3799 | #include "components/safe_browsing/core/browser/verdict_cache_manager.h" |
| 3914 | #include "components/safe_browsing/core/common/features.h" | ||
| 3915 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 3800 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 3916 | #include "components/safe_browsing/core/common/safebrowsing_constants.h" | 3801 | #include "components/safe_browsing/core/common/safebrowsing_constants.h" |
| 3917 | #include "components/safe_browsing/core/common/utils.h" | 3802 | #include "components/safe_browsing/core/common/utils.h" |
| 3918 | #include "net/base/ip_address.h" | 3803 | #include "net/base/ip_address.h" |
| 3919 | --- a/components/safe_browsing/core/browser/safe_browsing_metrics_collector.cc | 3804 | --- components/safe_browsing/core/browser/safe_browsing_metrics_collector.cc.orig |
| 3920 | +++ b/components/safe_browsing/core/browser/safe_browsing_metrics_collector.cc | 3805 | +++ components/safe_browsing/core/browser/safe_browsing_metrics_collector.cc |
| 3921 | @@ -12,13 +12,11 @@ | 3806 | @@ -11,13 +11,11 @@ |
| 3807 | #include "base/time/time.h" | ||
| 3922 | #include "components/prefs/pref_service.h" | 3808 | #include "components/prefs/pref_service.h" |
| 3923 | #include "components/prefs/scoped_user_pref_update.h" | 3809 | #include "components/prefs/scoped_user_pref_update.h" |
| 3924 | #include "components/safe_browsing/core/browser/db/hit_report.h" | ||
| 3925 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 3810 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 3926 | 3811 | ||
| 3927 | namespace { | 3812 | namespace { |
| @@ -3932,7 +3817,7 @@ | |||
| 3932 | 3817 | ||
| 3933 | const int kMetricsLoggingIntervalDay = 1; | 3818 | const int kMetricsLoggingIntervalDay = 1; |
| 3934 | 3819 | ||
| 3935 | @@ -59,11 +57,6 @@ SafeBrowsingMetricsCollector::SafeBrowsi | 3820 | @@ -54,11 +52,6 @@ SafeBrowsingMetricsCollector::SafeBrowsi |
| 3936 | PrefService* pref_service) | 3821 | PrefService* pref_service) |
| 3937 | : pref_service_(pref_service) { | 3822 | : pref_service_(pref_service) { |
| 3938 | pref_change_registrar_.Init(pref_service_); | 3823 | pref_change_registrar_.Init(pref_service_); |
| @@ -3944,7 +3829,7 @@ | |||
| 3944 | } | 3829 | } |
| 3945 | 3830 | ||
| 3946 | void SafeBrowsingMetricsCollector::Shutdown() { | 3831 | void SafeBrowsingMetricsCollector::Shutdown() { |
| 3947 | @@ -71,16 +64,6 @@ void SafeBrowsingMetricsCollector::Shutd | 3832 | @@ -66,16 +59,6 @@ void SafeBrowsingMetricsCollector::Shutd |
| 3948 | } | 3833 | } |
| 3949 | 3834 | ||
| 3950 | void SafeBrowsingMetricsCollector::StartLogging() { | 3835 | void SafeBrowsingMetricsCollector::StartLogging() { |
| @@ -3961,7 +3846,7 @@ | |||
| 3961 | } | 3846 | } |
| 3962 | 3847 | ||
| 3963 | void SafeBrowsingMetricsCollector::LogMetricsAndScheduleNextLogging() { | 3848 | void SafeBrowsingMetricsCollector::LogMetricsAndScheduleNextLogging() { |
| 3964 | @@ -88,9 +71,6 @@ void SafeBrowsingMetricsCollector::LogMe | 3849 | @@ -83,9 +66,6 @@ void SafeBrowsingMetricsCollector::LogMe |
| 3965 | LogDailyEventMetrics(); | 3850 | LogDailyEventMetrics(); |
| 3966 | RemoveOldEventsFromPref(); | 3851 | RemoveOldEventsFromPref(); |
| 3967 | 3852 | ||
| @@ -3971,7 +3856,7 @@ | |||
| 3971 | ScheduleNextLoggingAfterInterval(base::Days(kMetricsLoggingIntervalDay)); | 3856 | ScheduleNextLoggingAfterInterval(base::Days(kMetricsLoggingIntervalDay)); |
| 3972 | } | 3857 | } |
| 3973 | 3858 | ||
| 3974 | @@ -103,87 +83,16 @@ void SafeBrowsingMetricsCollector::Sched | 3859 | @@ -98,181 +78,40 @@ void SafeBrowsingMetricsCollector::Sched |
| 3975 | } | 3860 | } |
| 3976 | 3861 | ||
| 3977 | void SafeBrowsingMetricsCollector::LogDailyOptInMetrics() { | 3862 | void SafeBrowsingMetricsCollector::LogDailyOptInMetrics() { |
| @@ -4029,7 +3914,7 @@ | |||
| 4029 | void SafeBrowsingMetricsCollector::RemoveOldEventsFromPref() { | 3914 | void SafeBrowsingMetricsCollector::RemoveOldEventsFromPref() { |
| 4030 | - DictionaryPrefUpdate update(pref_service_, | 3915 | - DictionaryPrefUpdate update(pref_service_, |
| 4031 | - prefs::kSafeBrowsingEventTimestamps); | 3916 | - prefs::kSafeBrowsingEventTimestamps); |
| 4032 | - base::Value* mutable_state_dict = update.Get(); | 3917 | - base::DictionaryValue* mutable_state_dict = update.Get(); |
| 4033 | - bool is_pref_valid = mutable_state_dict->is_dict(); | 3918 | - bool is_pref_valid = mutable_state_dict->is_dict(); |
| 4034 | - base::UmaHistogramBoolean("SafeBrowsing.MetricsCollector.IsPrefValid", | 3919 | - base::UmaHistogramBoolean("SafeBrowsing.MetricsCollector.IsPrefValid", |
| 4035 | - is_pref_valid); | 3920 | - is_pref_valid); |
| @@ -4058,30 +3943,47 @@ | |||
| 4058 | - AddSafeBrowsingEventAndUserStateToPref(GetUserState(), event_type); | 3943 | - AddSafeBrowsingEventAndUserStateToPref(GetUserState(), event_type); |
| 4059 | } | 3944 | } |
| 4060 | 3945 | ||
| 4061 | void SafeBrowsingMetricsCollector::AddBypassEventToPref( | 3946 | absl::optional<base::Time> |
| 4062 | @@ -220,15 +129,7 @@ absl::optional<base::Time> | 3947 | SafeBrowsingMetricsCollector::GetLatestEventTimestamp(EventType event_type) { |
| 4063 | SafeBrowsingMetricsCollector::GetLatestEventTimestamp( | 3948 | - // Events are not logged when Safe Browsing is disabled. |
| 4064 | EventTypeFilter event_type_filter) { | ||
| 4065 | // Events are not logged when Safe Browsing is disabled. | ||
| 4066 | - SafeBrowsingState sb_state = GetSafeBrowsingState(*pref_service_); | 3949 | - SafeBrowsingState sb_state = GetSafeBrowsingState(*pref_service_); |
| 4067 | - if (sb_state == SafeBrowsingState::NO_SAFE_BROWSING) { | 3950 | - if (sb_state == SafeBrowsingState::NO_SAFE_BROWSING) { |
| 4068 | return absl::nullopt; | 3951 | return absl::nullopt; |
| 4069 | - } | 3952 | - } |
| 4070 | - | 3953 | - |
| 4071 | - const absl::optional<Event> event = | 3954 | - const absl::optional<Event> event = |
| 4072 | - GetLatestEventFromEventTypeFilter(GetUserState(), event_type_filter); | 3955 | - GetLatestEventFromEventType(GetUserState(), event_type); |
| 4073 | - return event ? absl::optional<base::Time>(event.value().timestamp) | 3956 | - return event ? absl::optional<base::Time>(event.value().timestamp) |
| 4074 | - : absl::nullopt; | 3957 | - : absl::nullopt; |
| 4075 | } | 3958 | } |
| 4076 | 3959 | ||
| 4077 | absl::optional<base::Time> | 3960 | absl::optional<base::Time> |
| 4078 | @@ -240,55 +141,14 @@ SafeBrowsingMetricsCollector::GetLatestS | 3961 | SafeBrowsingMetricsCollector::GetLatestSecuritySensitiveEventTimestamp() { |
| 3962 | - std::vector<absl::optional<base::Time>> security_sensitive_event_times{ | ||
| 3963 | - GetLatestEventTimestamp(SECURITY_SENSITIVE_SAFE_BROWSING_INTERSTITIAL), | ||
| 3964 | - GetLatestEventTimestamp(SECURITY_SENSITIVE_SSL_INTERSTITIAL), | ||
| 3965 | - GetLatestEventTimestamp(SECURITY_SENSITIVE_PASSWORD_PROTECTION), | ||
| 3966 | - GetLatestEventTimestamp(SECURITY_SENSITIVE_DOWNLOAD)}; | ||
| 3967 | absl::optional<base::Time> latest_event_time = absl::nullopt; | ||
| 3968 | - for (absl::optional<base::Time> security_sensitive_event_time : | ||
| 3969 | - security_sensitive_event_times) { | ||
| 3970 | - if (!security_sensitive_event_time) { | ||
| 3971 | - continue; | ||
| 3972 | - } | ||
| 3973 | - if (!latest_event_time || | ||
| 3974 | - (latest_event_time.value() < security_sensitive_event_time.value())) { | ||
| 3975 | - latest_event_time = security_sensitive_event_time; | ||
| 3976 | - } | ||
| 3977 | - } | ||
| 3978 | return latest_event_time; | ||
| 3979 | } | ||
| 3980 | |||
| 4079 | void SafeBrowsingMetricsCollector::AddSafeBrowsingEventAndUserStateToPref( | 3981 | void SafeBrowsingMetricsCollector::AddSafeBrowsingEventAndUserStateToPref( |
| 4080 | UserState user_state, | 3982 | UserState user_state, |
| 4081 | EventType event_type) { | 3983 | EventType event_type) { |
| 4082 | - DictionaryPrefUpdate update(pref_service_, | 3984 | - DictionaryPrefUpdate update(pref_service_, |
| 4083 | - prefs::kSafeBrowsingEventTimestamps); | 3985 | - prefs::kSafeBrowsingEventTimestamps); |
| 4084 | - base::Value* mutable_state_dict = update.Get(); | 3986 | - base::DictionaryValue* mutable_state_dict = update.Get(); |
| 4085 | - | 3987 | - |
| 4086 | - base::Value* event_dict = | 3988 | - base::Value* event_dict = |
| 4087 | - mutable_state_dict->FindDictKey(UserStateToPrefKey(user_state)); | 3989 | - mutable_state_dict->FindDictKey(UserStateToPrefKey(user_state)); |
| @@ -4099,8 +4001,8 @@ | |||
| 4099 | - } | 4001 | - } |
| 4100 | - | 4002 | - |
| 4101 | - // Remove the oldest timestamp if the length of the timestamps hits the limit. | 4003 | - // Remove the oldest timestamp if the length of the timestamps hits the limit. |
| 4102 | - while (timestamps->GetListDeprecated().size() >= kTimestampsMaxLength) { | 4004 | - while (timestamps->GetList().size() >= kTimestampsMaxLength) { |
| 4103 | - timestamps->EraseListIter(timestamps->GetListDeprecated().begin()); | 4005 | - timestamps->EraseListIter(timestamps->GetList().begin()); |
| 4104 | - } | 4006 | - } |
| 4105 | - | 4007 | - |
| 4106 | - timestamps->Append(TimeToPrefValue(base::Time::Now())); | 4008 | - timestamps->Append(TimeToPrefValue(base::Time::Now())); |
| @@ -4115,7 +4017,12 @@ | |||
| 4115 | - if (!pref_service_->GetBoolean(prefs::kSafeBrowsingEnhanced)) { | 4017 | - if (!pref_service_->GetBoolean(prefs::kSafeBrowsingEnhanced)) { |
| 4116 | - AddSafeBrowsingEventAndUserStateToPref(UserState::kEnhancedProtection, | 4018 | - AddSafeBrowsingEventAndUserStateToPref(UserState::kEnhancedProtection, |
| 4117 | - EventType::USER_STATE_DISABLED); | 4019 | - EventType::USER_STATE_DISABLED); |
| 4118 | - LogEnhancedProtectionDisabledMetrics(); | 4020 | - int disabled_times_last_week = GetEventCountSince( |
| 4021 | - UserState::kEnhancedProtection, EventType::USER_STATE_DISABLED, | ||
| 4022 | - base::Time::Now() - base::Days(7)); | ||
| 4023 | - if (disabled_times_last_week <= kEsbDisabledMetricsQuota) { | ||
| 4024 | - LogEnhancedProtectionDisabledMetrics(); | ||
| 4025 | - } | ||
| 4119 | - } else { | 4026 | - } else { |
| 4120 | - AddSafeBrowsingEventAndUserStateToPref(UserState::kEnhancedProtection, | 4027 | - AddSafeBrowsingEventAndUserStateToPref(UserState::kEnhancedProtection, |
| 4121 | - EventType::USER_STATE_ENABLED); | 4028 | - EventType::USER_STATE_ENABLED); |
| @@ -4124,7 +4031,7 @@ | |||
| 4124 | 4031 | ||
| 4125 | const base::Value* SafeBrowsingMetricsCollector::GetSafeBrowsingEventDictionary( | 4032 | const base::Value* SafeBrowsingMetricsCollector::GetSafeBrowsingEventDictionary( |
| 4126 | UserState user_state) { | 4033 | UserState user_state) { |
| 4127 | - const base::Value* state_dict = | 4034 | - const base::DictionaryValue* state_dict = |
| 4128 | - pref_service_->GetDictionary(prefs::kSafeBrowsingEventTimestamps); | 4035 | - pref_service_->GetDictionary(prefs::kSafeBrowsingEventTimestamps); |
| 4129 | - | 4036 | - |
| 4130 | - return state_dict->FindDictKey(UserStateToPrefKey(user_state)); | 4037 | - return state_dict->FindDictKey(UserStateToPrefKey(user_state)); |
| @@ -4132,7 +4039,7 @@ | |||
| 4132 | } | 4039 | } |
| 4133 | 4040 | ||
| 4134 | absl::optional<SafeBrowsingMetricsCollector::Event> | 4041 | absl::optional<SafeBrowsingMetricsCollector::Event> |
| 4135 | @@ -449,20 +309,7 @@ int SafeBrowsingMetricsCollector::GetEve | 4042 | @@ -370,20 +209,7 @@ int SafeBrowsingMetricsCollector::GetEve |
| 4136 | } | 4043 | } |
| 4137 | 4044 | ||
| 4138 | UserState SafeBrowsingMetricsCollector::GetUserState() { | 4045 | UserState SafeBrowsingMetricsCollector::GetUserState() { |
| @@ -4154,8 +4061,8 @@ | |||
| 4154 | } | 4061 | } |
| 4155 | 4062 | ||
| 4156 | bool SafeBrowsingMetricsCollector::IsBypassEventType(const EventType& type) { | 4063 | bool SafeBrowsingMetricsCollector::IsBypassEventType(const EventType& type) { |
| 4157 | --- a/components/safe_browsing/core/common/BUILD.gn | 4064 | --- components/safe_browsing/core/common/BUILD.gn.orig |
| 4158 | +++ b/components/safe_browsing/core/common/BUILD.gn | 4065 | +++ components/safe_browsing/core/common/BUILD.gn |
| 4159 | @@ -6,20 +6,8 @@ import("//build/config/features.gni") | 4066 | @@ -6,20 +6,8 @@ import("//build/config/features.gni") |
| 4160 | import("//components/safe_browsing/buildflags.gni") | 4067 | import("//components/safe_browsing/buildflags.gni") |
| 4161 | import("//mojo/public/tools/bindings/mojom.gni") | 4068 | import("//mojo/public/tools/bindings/mojom.gni") |
| @@ -4179,8 +4086,8 @@ | |||
| 4179 | } | 4086 | } |
| 4180 | 4087 | ||
| 4181 | source_set("safe_browsing_policy_handler") { | 4088 | source_set("safe_browsing_policy_handler") { |
| 4182 | --- a/components/safe_browsing/core/common/safe_browsing_policy_handler.cc | 4089 | --- components/safe_browsing/core/common/safe_browsing_policy_handler.cc.orig |
| 4183 | +++ b/components/safe_browsing/core/common/safe_browsing_policy_handler.cc | 4090 | +++ components/safe_browsing/core/common/safe_browsing_policy_handler.cc |
| 4184 | @@ -11,7 +11,6 @@ | 4091 | @@ -11,7 +11,6 @@ |
| 4185 | #include "components/policy/policy_constants.h" | 4092 | #include "components/policy/policy_constants.h" |
| 4186 | #include "components/prefs/pref_service.h" | 4093 | #include "components/prefs/pref_service.h" |
| @@ -4189,7 +4096,7 @@ | |||
| 4189 | #include "components/strings/grit/components_strings.h" | 4096 | #include "components/strings/grit/components_strings.h" |
| 4190 | #include "third_party/abseil-cpp/absl/types/optional.h" | 4097 | #include "third_party/abseil-cpp/absl/types/optional.h" |
| 4191 | 4098 | ||
| 4192 | @@ -180,34 +179,14 @@ void SafeBrowsingPolicyHandler::ApplyPol | 4099 | @@ -172,34 +171,14 @@ void SafeBrowsingPolicyHandler::ApplyPol |
| 4193 | 4100 | ||
| 4194 | if (!value.has_value()) | 4101 | if (!value.has_value()) |
| 4195 | return; | 4102 | return; |
| @@ -4226,7 +4133,7 @@ | |||
| 4226 | 4133 | ||
| 4227 | if (safe_browsing_enhanced) | 4134 | if (safe_browsing_enhanced) |
| 4228 | return ProtectionLevel::kEnhancedProtection; | 4135 | return ProtectionLevel::kEnhancedProtection; |
| 4229 | @@ -221,10 +200,8 @@ SafeBrowsingPolicyHandler::GetSafeBrowsi | 4136 | @@ -213,10 +192,8 @@ SafeBrowsingPolicyHandler::GetSafeBrowsi |
| 4230 | // static | 4137 | // static |
| 4231 | bool SafeBrowsingPolicyHandler::IsSafeBrowsingProtectionLevelSetByPolicy( | 4138 | bool SafeBrowsingPolicyHandler::IsSafeBrowsingProtectionLevelSetByPolicy( |
| 4232 | const PrefService* pref_service) { | 4139 | const PrefService* pref_service) { |
| @@ -4239,8 +4146,8 @@ | |||
| 4239 | DCHECK_EQ(is_safe_browsing_enabled_managed, | 4146 | DCHECK_EQ(is_safe_browsing_enabled_managed, |
| 4240 | is_safe_browsing_enhanced_managed); | 4147 | is_safe_browsing_enhanced_managed); |
| 4241 | return is_safe_browsing_enabled_managed && is_safe_browsing_enhanced_managed; | 4148 | return is_safe_browsing_enabled_managed && is_safe_browsing_enhanced_managed; |
| 4242 | --- a/components/safe_browsing/core/common/safe_browsing_prefs_unittest.cc | 4149 | --- components/safe_browsing/core/common/safe_browsing_prefs_unittest.cc.orig |
| 4243 | +++ b/components/safe_browsing/core/common/safe_browsing_prefs_unittest.cc | 4150 | +++ components/safe_browsing/core/common/safe_browsing_prefs_unittest.cc |
| 4244 | @@ -12,7 +12,6 @@ | 4151 | @@ -12,7 +12,6 @@ |
| 4245 | #include "components/prefs/pref_registry_simple.h" | 4152 | #include "components/prefs/pref_registry_simple.h" |
| 4246 | #include "components/prefs/testing_pref_service.h" | 4153 | #include "components/prefs/testing_pref_service.h" |
| @@ -4249,8 +4156,8 @@ | |||
| 4249 | #include "testing/gtest/include/gtest/gtest.h" | 4156 | #include "testing/gtest/include/gtest/gtest.h" |
| 4250 | #include "url/gurl.h" | 4157 | #include "url/gurl.h" |
| 4251 | 4158 | ||
| 4252 | --- a/components/safety_check/safety_check.cc | 4159 | --- components/safety_check/safety_check.cc.orig |
| 4253 | +++ b/components/safety_check/safety_check.cc | 4160 | +++ components/safety_check/safety_check.cc |
| 4254 | @@ -4,26 +4,9 @@ | 4161 | @@ -4,26 +4,9 @@ |
| 4255 | 4162 | ||
| 4256 | #include "components/safety_check/safety_check.h" | 4163 | #include "components/safety_check/safety_check.h" |
| @@ -4278,8 +4185,8 @@ | |||
| 4278 | return SafeBrowsingStatus::kDisabled; | 4185 | return SafeBrowsingStatus::kDisabled; |
| 4279 | } | 4186 | } |
| 4280 | 4187 | ||
| 4281 | --- a/components/security_interstitials/content/bad_clock_blocking_page.cc | 4188 | --- components/security_interstitials/content/bad_clock_blocking_page.cc.orig |
| 4282 | +++ b/components/security_interstitials/content/bad_clock_blocking_page.cc | 4189 | +++ components/security_interstitials/content/bad_clock_blocking_page.cc |
| 4283 | @@ -7,7 +7,6 @@ | 4190 | @@ -7,7 +7,6 @@ |
| 4284 | #include <utility> | 4191 | #include <utility> |
| 4285 | 4192 | ||
| @@ -4288,8 +4195,8 @@ | |||
| 4288 | #include "components/security_interstitials/content/cert_report_helper.h" | 4195 | #include "components/security_interstitials/content/cert_report_helper.h" |
| 4289 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" | 4196 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" |
| 4290 | #include "components/security_interstitials/content/security_interstitial_page.h" | 4197 | #include "components/security_interstitials/content/security_interstitial_page.h" |
| 4291 | --- a/components/security_interstitials/content/captive_portal_blocking_page.cc | 4198 | --- components/security_interstitials/content/captive_portal_blocking_page.cc.orig |
| 4292 | +++ b/components/security_interstitials/content/captive_portal_blocking_page.cc | 4199 | +++ components/security_interstitials/content/captive_portal_blocking_page.cc |
| 4293 | @@ -15,7 +15,6 @@ | 4200 | @@ -15,7 +15,6 @@ |
| 4294 | #include "build/build_config.h" | 4201 | #include "build/build_config.h" |
| 4295 | #include "components/captive_portal/core/captive_portal_detector.h" | 4202 | #include "components/captive_portal/core/captive_portal_detector.h" |
| @@ -4298,8 +4205,8 @@ | |||
| 4298 | #include "components/security_interstitials/content/cert_report_helper.h" | 4205 | #include "components/security_interstitials/content/cert_report_helper.h" |
| 4299 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" | 4206 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" |
| 4300 | #include "components/security_interstitials/content/ssl_cert_reporter.h" | 4207 | #include "components/security_interstitials/content/ssl_cert_reporter.h" |
| 4301 | --- a/components/security_interstitials/content/cert_report_helper.cc | 4208 | --- components/security_interstitials/content/cert_report_helper.cc.orig |
| 4302 | +++ b/components/security_interstitials/content/cert_report_helper.cc | 4209 | +++ components/security_interstitials/content/cert_report_helper.cc |
| 4303 | @@ -14,7 +14,6 @@ | 4210 | @@ -14,7 +14,6 @@ |
| 4304 | #include "build/branding_buildflags.h" | 4211 | #include "build/branding_buildflags.h" |
| 4305 | #include "build/build_config.h" | 4212 | #include "build/build_config.h" |
| @@ -4396,8 +4303,8 @@ | |||
| 4396 | } | 4303 | } |
| 4397 | 4304 | ||
| 4398 | bool CertReportHelper::ShouldReportCertificateError() { | 4305 | bool CertReportHelper::ShouldReportCertificateError() { |
| 4399 | --- a/components/security_interstitials/content/mitm_software_blocking_page.cc | 4306 | --- components/security_interstitials/content/mitm_software_blocking_page.cc.orig |
| 4400 | +++ b/components/security_interstitials/content/mitm_software_blocking_page.cc | 4307 | +++ components/security_interstitials/content/mitm_software_blocking_page.cc |
| 4401 | @@ -6,7 +6,6 @@ | 4308 | @@ -6,7 +6,6 @@ |
| 4402 | 4309 | ||
| 4403 | #include <utility> | 4310 | #include <utility> |
| @@ -4406,8 +4313,8 @@ | |||
| 4406 | #include "components/security_interstitials/content/cert_report_helper.h" | 4313 | #include "components/security_interstitials/content/cert_report_helper.h" |
| 4407 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" | 4314 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" |
| 4408 | #include "components/security_interstitials/content/security_interstitial_page.h" | 4315 | #include "components/security_interstitials/content/security_interstitial_page.h" |
| 4409 | --- a/components/security_interstitials/content/security_interstitial_controller_client.cc | 4316 | --- components/security_interstitials/content/security_interstitial_controller_client.cc.orig |
| 4410 | +++ b/components/security_interstitials/content/security_interstitial_controller_client.cc | 4317 | +++ components/security_interstitials/content/security_interstitial_controller_client.cc |
| 4411 | @@ -7,7 +7,6 @@ | 4318 | @@ -7,7 +7,6 @@ |
| 4412 | #include <utility> | 4319 | #include <utility> |
| 4413 | 4320 | ||
| @@ -4415,8 +4322,8 @@ | |||
| 4415 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" | 4322 | -#include "components/safe_browsing/core/common/safe_browsing_prefs.h" |
| 4416 | #include "components/security_interstitials/content/settings_page_helper.h" | 4323 | #include "components/security_interstitials/content/settings_page_helper.h" |
| 4417 | #include "components/security_interstitials/core/metrics_helper.h" | 4324 | #include "components/security_interstitials/core/metrics_helper.h" |
| 4418 | #include "content/public/browser/navigation_entry.h" | 4325 | #include "content/public/browser/web_contents.h" |
| 4419 | @@ -99,11 +98,6 @@ SecurityInterstitialControllerClient::Ge | 4326 | @@ -98,11 +97,6 @@ SecurityInterstitialControllerClient::Ge |
| 4420 | return prefs_; | 4327 | return prefs_; |
| 4421 | } | 4328 | } |
| 4422 | 4329 | ||
| @@ -4428,19 +4335,19 @@ | |||
| 4428 | bool SecurityInterstitialControllerClient::CanLaunchDateAndTimeSettings() { | 4335 | bool SecurityInterstitialControllerClient::CanLaunchDateAndTimeSettings() { |
| 4429 | NOTREACHED(); | 4336 | NOTREACHED(); |
| 4430 | return false; | 4337 | return false; |
| 4431 | --- a/components/security_interstitials/content/security_interstitial_controller_client.h | 4338 | --- components/security_interstitials/content/security_interstitial_controller_client.h.orig |
| 4432 | +++ b/components/security_interstitials/content/security_interstitial_controller_client.h | 4339 | +++ components/security_interstitials/content/security_interstitial_controller_client.h |
| 4433 | @@ -54,8 +54,6 @@ class SecurityInterstitialControllerClie | 4340 | @@ -54,8 +54,6 @@ class SecurityInterstitialControllerClie |
| 4434 | bool CanGoBackBeforeNavigation() override; | 4341 | bool CanGoBackBeforeNavigation() override; |
| 4435 | 4342 | ||
| 4436 | protected: | 4343 | protected: |
| 4437 | - // security_interstitials::ControllerClient overrides. | 4344 | - // security_interstitials::ControllerClient overrides. |
| 4438 | - const std::string GetExtendedReportingPrefName() const override; | 4345 | - const std::string GetExtendedReportingPrefName() const override; |
| 4439 | raw_ptr<content::WebContents> web_contents_; | 4346 | content::WebContents* web_contents_; |
| 4440 | 4347 | ||
| 4441 | private: | 4348 | private: |
| 4442 | --- a/components/security_interstitials/content/security_interstitial_page.cc | 4349 | --- components/security_interstitials/content/security_interstitial_page.cc.orig |
| 4443 | +++ b/components/security_interstitials/content/security_interstitial_page.cc | 4350 | +++ components/security_interstitials/content/security_interstitial_page.cc |
| 4444 | @@ -11,7 +11,6 @@ | 4351 | @@ -11,7 +11,6 @@ |
| 4445 | #include "base/values.h" | 4352 | #include "base/values.h" |
| 4446 | #include "components/grit/components_resources.h" | 4353 | #include "components/grit/components_resources.h" |
| @@ -4481,8 +4388,8 @@ | |||
| 4481 | } | 4388 | } |
| 4482 | 4389 | ||
| 4483 | std::u16string SecurityInterstitialPage::GetFormattedHostName() const { | 4390 | std::u16string SecurityInterstitialPage::GetFormattedHostName() const { |
| 4484 | --- a/components/security_interstitials/content/ssl_blocking_page.cc | 4391 | --- components/security_interstitials/content/ssl_blocking_page.cc.orig |
| 4485 | +++ b/components/security_interstitials/content/ssl_blocking_page.cc | 4392 | +++ components/security_interstitials/content/ssl_blocking_page.cc |
| 4486 | @@ -12,7 +12,6 @@ | 4393 | @@ -12,7 +12,6 @@ |
| 4487 | #include "base/metrics/histogram_macros.h" | 4394 | #include "base/metrics/histogram_macros.h" |
| 4488 | #include "base/strings/string_number_conversions.h" | 4395 | #include "base/strings/string_number_conversions.h" |
| @@ -4491,8 +4398,8 @@ | |||
| 4491 | #include "components/security_interstitials/content/cert_report_helper.h" | 4398 | #include "components/security_interstitials/content/cert_report_helper.h" |
| 4492 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" | 4399 | #include "components/security_interstitials/content/security_interstitial_controller_client.h" |
| 4493 | #include "components/security_interstitials/content/security_interstitial_page.h" | 4400 | #include "components/security_interstitials/content/security_interstitial_page.h" |
| 4494 | --- a/components/security_interstitials/core/controller_client.cc | 4401 | --- components/security_interstitials/core/controller_client.cc.orig |
| 4495 | +++ b/components/security_interstitials/core/controller_client.cc | 4402 | +++ components/security_interstitials/core/controller_client.cc |
| 4496 | @@ -36,7 +36,6 @@ MetricsHelper* ControllerClient::metrics | 4403 | @@ -36,7 +36,6 @@ MetricsHelper* ControllerClient::metrics |
| 4497 | 4404 | ||
| 4498 | void ControllerClient::SetReportingPreference(bool report) { | 4405 | void ControllerClient::SetReportingPreference(bool report) { |
| @@ -4501,9 +4408,9 @@ | |||
| 4501 | metrics_helper_->RecordUserInteraction( | 4408 | metrics_helper_->RecordUserInteraction( |
| 4502 | report ? MetricsHelper::SET_EXTENDED_REPORTING_ENABLED | 4409 | report ? MetricsHelper::SET_EXTENDED_REPORTING_ENABLED |
| 4503 | : MetricsHelper::SET_EXTENDED_REPORTING_DISABLED); | 4410 | : MetricsHelper::SET_EXTENDED_REPORTING_DISABLED); |
| 4504 | --- a/components/security_interstitials/core/controller_client.h | 4411 | --- components/security_interstitials/core/controller_client.h.orig |
| 4505 | +++ b/components/security_interstitials/core/controller_client.h | 4412 | +++ components/security_interstitials/core/controller_client.h |
| 4506 | @@ -121,9 +121,6 @@ class ControllerClient { | 4413 | @@ -122,9 +122,6 @@ class ControllerClient { |
| 4507 | 4414 | ||
| 4508 | void SetBaseHelpCenterUrlForTesting(const GURL& test_url); | 4415 | void SetBaseHelpCenterUrlForTesting(const GURL& test_url); |
| 4509 | 4416 | ||
| @@ -4513,8 +4420,8 @@ | |||
| 4513 | private: | 4420 | private: |
| 4514 | std::unique_ptr<MetricsHelper> metrics_helper_; | 4421 | std::unique_ptr<MetricsHelper> metrics_helper_; |
| 4515 | // Link to the help center. | 4422 | // Link to the help center. |
| 4516 | --- a/components/signin/core/browser/account_investigator.cc | 4423 | --- components/signin/core/browser/account_investigator.cc.orig |
| 4517 | +++ b/components/signin/core/browser/account_investigator.cc | 4424 | +++ components/signin/core/browser/account_investigator.cc |
| 4518 | @@ -13,7 +13,6 @@ | 4425 | @@ -13,7 +13,6 @@ |
| 4519 | #include "components/prefs/pref_registry_simple.h" | 4426 | #include "components/prefs/pref_registry_simple.h" |
| 4520 | #include "components/prefs/pref_service.h" | 4427 | #include "components/prefs/pref_service.h" |
| @@ -4589,9 +4496,9 @@ | |||
| 4589 | base::TimeDelta stable_age; | 4496 | base::TimeDelta stable_age; |
| 4590 | if (!last_changed.is_null()) | 4497 | if (!last_changed.is_null()) |
| 4591 | stable_age = std::max(now - last_changed, base::TimeDelta()); | 4498 | stable_age = std::max(now - last_changed, base::TimeDelta()); |
| 4592 | --- a/components/signin/core/browser/account_investigator_unittest.cc | 4499 | --- components/signin/core/browser/account_investigator_unittest.cc.orig |
| 4593 | +++ b/components/signin/core/browser/account_investigator_unittest.cc | 4500 | +++ components/signin/core/browser/account_investigator_unittest.cc |
| 4594 | @@ -13,7 +13,6 @@ | 4501 | @@ -12,7 +12,6 @@ |
| 4595 | #include "build/build_config.h" | 4502 | #include "build/build_config.h" |
| 4596 | #include "components/prefs/pref_registry_simple.h" | 4503 | #include "components/prefs/pref_registry_simple.h" |
| 4597 | #include "components/signin/public/base/signin_metrics.h" | 4504 | #include "components/signin/public/base/signin_metrics.h" |
| @@ -4599,8 +4506,8 @@ | |||
| 4599 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" | 4506 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" |
| 4600 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 4507 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 4601 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 4508 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 4602 | --- a/components/signin/core/browser/account_reconcilor_unittest.cc | 4509 | --- components/signin/core/browser/account_reconcilor_unittest.cc.orig |
| 4603 | +++ b/components/signin/core/browser/account_reconcilor_unittest.cc | 4510 | +++ components/signin/core/browser/account_reconcilor_unittest.cc |
| 4604 | @@ -29,7 +29,6 @@ | 4511 | @@ -29,7 +29,6 @@ |
| 4605 | #include "components/signin/public/base/list_accounts_test_utils.h" | 4512 | #include "components/signin/public/base/list_accounts_test_utils.h" |
| 4606 | #include "components/signin/public/base/signin_buildflags.h" | 4513 | #include "components/signin/public/base/signin_buildflags.h" |
| @@ -4609,8 +4516,8 @@ | |||
| 4609 | #include "components/signin/public/base/test_signin_client.h" | 4516 | #include "components/signin/public/base/test_signin_client.h" |
| 4610 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" | 4517 | #include "components/signin/public/identity_manager/accounts_in_cookie_jar_info.h" |
| 4611 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 4518 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 4612 | --- a/components/signin/core/browser/dice_account_reconcilor_delegate.cc | 4519 | --- components/signin/core/browser/dice_account_reconcilor_delegate.cc.orig |
| 4613 | +++ b/components/signin/core/browser/dice_account_reconcilor_delegate.cc | 4520 | +++ components/signin/core/browser/dice_account_reconcilor_delegate.cc |
| 4614 | @@ -12,7 +12,6 @@ | 4521 | @@ -12,7 +12,6 @@ |
| 4615 | #include "base/ranges/algorithm.h" | 4522 | #include "base/ranges/algorithm.h" |
| 4616 | #include "components/prefs/pref_service.h" | 4523 | #include "components/prefs/pref_service.h" |
| @@ -4619,8 +4526,8 @@ | |||
| 4619 | 4526 | ||
| 4620 | namespace signin { | 4527 | namespace signin { |
| 4621 | 4528 | ||
| 4622 | --- a/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc | 4529 | --- components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc.orig |
| 4623 | +++ b/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc | 4530 | +++ components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc |
| 4624 | @@ -8,7 +8,6 @@ | 4531 | @@ -8,7 +8,6 @@ |
| 4625 | 4532 | ||
| 4626 | #include "components/prefs/pref_registry_simple.h" | 4533 | #include "components/prefs/pref_registry_simple.h" |
| @@ -4629,8 +4536,8 @@ | |||
| 4629 | #include "components/signin/public/base/test_signin_client.h" | 4536 | #include "components/signin/public/base/test_signin_client.h" |
| 4630 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 4537 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 4631 | #include "google_apis/gaia/gaia_auth_util.h" | 4538 | #include "google_apis/gaia/gaia_auth_util.h" |
| 4632 | --- a/components/signin/core/browser/signin_investigator.cc | 4539 | --- components/signin/core/browser/signin_investigator.cc.orig |
| 4633 | +++ b/components/signin/core/browser/signin_investigator.cc | 4540 | +++ components/signin/core/browser/signin_investigator.cc |
| 4634 | @@ -7,7 +7,6 @@ | 4541 | @@ -7,7 +7,6 @@ |
| 4635 | #include "base/check.h" | 4542 | #include "base/check.h" |
| 4636 | #include "base/metrics/histogram_macros.h" | 4543 | #include "base/metrics/histogram_macros.h" |
| @@ -4667,8 +4574,8 @@ | |||
| 4667 | scenario = InvestigatedScenario::kFirstSignIn; | 4574 | scenario = InvestigatedScenario::kFirstSignIn; |
| 4668 | } else if (AreAccountsEqualWithFallback()) { | 4575 | } else if (AreAccountsEqualWithFallback()) { |
| 4669 | scenario = InvestigatedScenario::kSameAccount; | 4576 | scenario = InvestigatedScenario::kSameAccount; |
| 4670 | --- a/components/signin/core/browser/signin_investigator_unittest.cc | 4577 | --- components/signin/core/browser/signin_investigator_unittest.cc.orig |
| 4671 | +++ b/components/signin/core/browser/signin_investigator_unittest.cc | 4578 | +++ components/signin/core/browser/signin_investigator_unittest.cc |
| 4672 | @@ -9,7 +9,6 @@ | 4579 | @@ -9,7 +9,6 @@ |
| 4673 | #include "components/prefs/pref_registry_simple.h" | 4580 | #include "components/prefs/pref_registry_simple.h" |
| 4674 | #include "components/signin/core/browser/signin_investigator.h" | 4581 | #include "components/signin/core/browser/signin_investigator.h" |
| @@ -4677,9 +4584,9 @@ | |||
| 4677 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 4584 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 4678 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 4585 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 4679 | #include "testing/gtest/include/gtest/gtest.h" | 4586 | #include "testing/gtest/include/gtest/gtest.h" |
| 4680 | --- a/components/signin/internal/identity_manager/account_tracker_service.cc | 4587 | --- components/signin/internal/identity_manager/account_tracker_service.cc.orig |
| 4681 | +++ b/components/signin/internal/identity_manager/account_tracker_service.cc | 4588 | +++ components/signin/internal/identity_manager/account_tracker_service.cc |
| 4682 | @@ -31,7 +31,6 @@ | 4589 | @@ -29,7 +29,6 @@ |
| 4683 | #include "components/prefs/scoped_user_pref_update.h" | 4590 | #include "components/prefs/scoped_user_pref_update.h" |
| 4684 | #include "components/signin/internal/identity_manager/account_capabilities_constants.h" | 4591 | #include "components/signin/internal/identity_manager/account_capabilities_constants.h" |
| 4685 | #include "components/signin/internal/identity_manager/account_info_util.h" | 4592 | #include "components/signin/internal/identity_manager/account_info_util.h" |
| @@ -4687,7 +4594,7 @@ | |||
| 4687 | #include "components/signin/public/base/signin_switches.h" | 4594 | #include "components/signin/public/base/signin_switches.h" |
| 4688 | #include "components/signin/public/identity_manager/account_capabilities.h" | 4595 | #include "components/signin/public/identity_manager/account_capabilities.h" |
| 4689 | #include "components/signin/public/identity_manager/tribool.h" | 4596 | #include "components/signin/public/identity_manager/tribool.h" |
| 4690 | @@ -178,9 +177,6 @@ AccountTrackerService::~AccountTrackerSe | 4597 | @@ -152,9 +151,6 @@ AccountTrackerService::~AccountTrackerSe |
| 4691 | 4598 | ||
| 4692 | // static | 4599 | // static |
| 4693 | void AccountTrackerService::RegisterPrefs(PrefRegistrySimple* registry) { | 4600 | void AccountTrackerService::RegisterPrefs(PrefRegistrySimple* registry) { |
| @@ -4697,7 +4604,7 @@ | |||
| 4697 | } | 4604 | } |
| 4698 | 4605 | ||
| 4699 | void AccountTrackerService::Initialize(PrefService* pref_service, | 4606 | void AccountTrackerService::Initialize(PrefService* pref_service, |
| 4700 | @@ -481,14 +477,12 @@ AccountTrackerService::ComputeNewMigrati | 4607 | @@ -455,14 +451,12 @@ AccountTrackerService::ComputeNewMigrati |
| 4701 | 4608 | ||
| 4702 | void AccountTrackerService::SetMigrationState(AccountIdMigrationState state) { | 4609 | void AccountTrackerService::SetMigrationState(AccountIdMigrationState state) { |
| 4703 | DCHECK(state != MIGRATION_DONE || AreAllAccountsMigrated()); | 4610 | DCHECK(state != MIGRATION_DONE || AreAllAccountsMigrated()); |
| @@ -4713,7 +4620,7 @@ | |||
| 4713 | } | 4620 | } |
| 4714 | 4621 | ||
| 4715 | base::FilePath AccountTrackerService::GetImagePathFor( | 4622 | base::FilePath AccountTrackerService::GetImagePathFor( |
| 4716 | @@ -545,27 +539,6 @@ void AccountTrackerService::OnAccountIma | 4623 | @@ -519,24 +513,7 @@ void AccountTrackerService::OnAccountIma |
| 4717 | const CoreAccountId& account_id, | 4624 | const CoreAccountId& account_id, |
| 4718 | const std::string& image_url_with_size, | 4625 | const std::string& image_url_with_size, |
| 4719 | bool success) { | 4626 | bool success) { |
| @@ -4722,15 +4629,12 @@ | |||
| 4722 | - | 4629 | - |
| 4723 | - base::DictionaryValue* dict = nullptr; | 4630 | - base::DictionaryValue* dict = nullptr; |
| 4724 | - ListPrefUpdate update(pref_service_, prefs::kAccountInfo); | 4631 | - ListPrefUpdate update(pref_service_, prefs::kAccountInfo); |
| 4725 | - for (size_t i = 0; i < update->GetListDeprecated().size(); | 4632 | - for (size_t i = 0; i < update->GetList().size(); ++i, dict = nullptr) { |
| 4726 | - ++i, dict = nullptr) { | 4633 | - if (update->GetDictionary(i, &dict)) { |
| 4727 | - base::Value& dict_value = update->GetListDeprecated()[i]; | 4634 | - std::string value; |
| 4728 | - if (dict_value.is_dict()) { | 4635 | - if (dict->GetString(kAccountKeyPath, &value) && |
| 4729 | - dict = static_cast<base::DictionaryValue*>(&dict_value); | 4636 | - value == account_id.ToString()) |
| 4730 | - const std::string* account_key = dict->FindStringKey(kAccountKeyPath); | ||
| 4731 | - if (account_key && *account_key == account_id.ToString()) { | ||
| 4732 | - break; | 4637 | - break; |
| 4733 | - } | ||
| 4734 | - } | 4638 | - } |
| 4735 | - } | 4639 | - } |
| 4736 | - | 4640 | - |
| @@ -4738,177 +4642,67 @@ | |||
| 4738 | - return; | 4642 | - return; |
| 4739 | - } | 4643 | - } |
| 4740 | - dict->SetString(kLastDownloadedImageURLWithSizePath, image_url_with_size); | 4644 | - dict->SetString(kLastDownloadedImageURLWithSizePath, image_url_with_size); |
| 4645 | + return; | ||
| 4741 | } | 4646 | } |
| 4742 | 4647 | ||
| 4743 | void AccountTrackerService::RemoveAccountImageFromDisk( | 4648 | void AccountTrackerService::RemoveAccountImageFromDisk( |
| 4744 | @@ -577,181 +550,16 @@ void AccountTrackerService::RemoveAccoun | 4649 | @@ -548,11 +525,10 @@ void AccountTrackerService::RemoveAccoun |
| 4745 | } | 4650 | } |
| 4746 | 4651 | ||
| 4747 | void AccountTrackerService::LoadFromPrefs() { | 4652 | void AccountTrackerService::LoadFromPrefs() { |
| 4748 | - const base::Value* list = pref_service_->GetList(prefs::kAccountInfo); | 4653 | - const base::ListValue* list = pref_service_->GetList(prefs::kAccountInfo); |
| 4749 | - std::set<CoreAccountId> to_remove; | 4654 | std::set<CoreAccountId> to_remove; |
| 4750 | - for (size_t i = 0; i < list->GetListDeprecated().size(); ++i) { | 4655 | - for (size_t i = 0; i < list->GetList().size(); ++i) { |
| 4751 | - const base::Value& dict_value = list->GetListDeprecated()[i]; | 4656 | + for (size_t i = 0; false; ++i) { |
| 4752 | - if (dict_value.is_dict()) { | 4657 | const base::DictionaryValue* dict = nullptr; |
| 4753 | - const base::DictionaryValue& dict = | 4658 | - if (list->GetDictionary(i, &dict)) { |
| 4754 | - base::Value::AsDictionaryValue(dict_value); | 4659 | + if (false) { |
| 4755 | - if (const std::string* account_key = | 4660 | std::string value; |
| 4756 | - dict.FindStringKey(kAccountKeyPath)) { | 4661 | if (dict->GetString(kAccountKeyPath, &value)) { |
| 4757 | - // Ignore incorrectly persisted non-canonical account ids. | 4662 | // Ignore incorrectly persisted non-canonical account ids. |
| 4758 | - if (account_key->find('@') != std::string::npos && | 4663 | @@ -588,14 +564,6 @@ void AccountTrackerService::LoadFromPref |
| 4759 | - *account_key != gaia::CanonicalizeEmail(*account_key)) { | 4664 | account_info.is_child_account = is_child_status.value() |
| 4760 | - to_remove.insert(CoreAccountId::FromString(*account_key)); | 4665 | ? signin::Tribool::kTrue |
| 4761 | - continue; | 4666 | : signin::Tribool::kFalse; |
| 4762 | - } | ||
| 4763 | - | ||
| 4764 | - CoreAccountId account_id = CoreAccountId::FromString(*account_key); | ||
| 4765 | - StartTrackingAccount(account_id); | ||
| 4766 | - AccountInfo& account_info = accounts_[account_id]; | ||
| 4767 | - | ||
| 4768 | - GetString(dict, kAccountGaiaPath, account_info.gaia); | ||
| 4769 | - GetString(dict, kAccountEmailPath, account_info.email); | ||
| 4770 | - GetString(dict, kAccountHostedDomainPath, account_info.hosted_domain); | ||
| 4771 | - GetString(dict, kAccountFullNamePath, account_info.full_name); | ||
| 4772 | - GetString(dict, kAccountGivenNamePath, account_info.given_name); | ||
| 4773 | - GetString(dict, kAccountLocalePath, account_info.locale); | ||
| 4774 | - GetString(dict, kAccountPictureURLPath, account_info.picture_url); | ||
| 4775 | - GetString(dict, kLastDownloadedImageURLWithSizePath, | ||
| 4776 | - account_info.last_downloaded_image_url_with_size); | ||
| 4777 | - | ||
| 4778 | - if (absl::optional<bool> is_child_status = | ||
| 4779 | - dict.FindBoolKey(kDeprecatedChildStatusPath)) { | ||
| 4780 | - account_info.is_child_account = is_child_status.value() | ||
| 4781 | - ? signin::Tribool::kTrue | ||
| 4782 | - : signin::Tribool::kFalse; | ||
| 4783 | - // Migrate to kAccountChildAttributePath. | 4667 | - // Migrate to kAccountChildAttributePath. |
| 4784 | - ListPrefUpdate update(pref_service_, prefs::kAccountInfo); | 4668 | - ListPrefUpdate update(pref_service_, prefs::kAccountInfo); |
| 4785 | - base::Value* update_dict = &update->GetListDeprecated()[i]; | 4669 | - base::DictionaryValue* update_dict = nullptr; |
| 4786 | - DCHECK(update_dict->is_dict()); | 4670 | - update->GetDictionary(i, &update_dict); |
| 4787 | - update_dict->SetIntPath( | 4671 | - DCHECK(update_dict); |
| 4788 | - kAccountChildAttributePath, | 4672 | - SetAccountCapabilityPath(update_dict, kAccountChildAttributePath, |
| 4789 | - static_cast<int>(account_info.is_child_account)); | 4673 | - account_info.is_child_account); |
| 4790 | - update_dict->RemoveKey(kDeprecatedChildStatusPath); | 4674 | - update_dict->RemoveKey(kDeprecatedChildStatusPath); |
| 4791 | - } else { | 4675 | } else { |
| 4792 | - account_info.is_child_account = | 4676 | account_info.is_child_account = |
| 4793 | - ParseTribool(dict.FindIntPath(kAccountChildAttributePath)); | 4677 | FindAccountCapabilityPath(*dict, kAccountChildAttributePath); |
| 4794 | - } | 4678 | @@ -654,13 +622,11 @@ void AccountTrackerService::LoadFromPref |
| 4795 | - | ||
| 4796 | - absl::optional<bool> is_under_advanced_protection = | ||
| 4797 | - dict.FindBoolKey(kAdvancedProtectionAccountStatusPath); | ||
| 4798 | - if (is_under_advanced_protection.has_value()) { | ||
| 4799 | - account_info.is_under_advanced_protection = | ||
| 4800 | - is_under_advanced_protection.value(); | ||
| 4801 | - } | ||
| 4802 | - | ||
| 4803 | - if (absl::optional<int> can_offer_extended_chrome_sync_promos = | ||
| 4804 | - dict.FindIntPath( | ||
| 4805 | - kDeprecatedCanOfferExtendedChromeSyncPromosPrefPath)) { | ||
| 4806 | - // Migrate to Capability names based pref paths. | ||
| 4807 | - ListPrefUpdate update(pref_service_, prefs::kAccountInfo); | ||
| 4808 | - base::Value* update_dict = &update->GetListDeprecated()[i]; | ||
| 4809 | - DCHECK(update_dict->is_dict()); | ||
| 4810 | - SetAccountCapabilityState( | ||
| 4811 | - update_dict, kCanOfferExtendedChromeSyncPromosCapabilityName, | ||
| 4812 | - ParseTribool(can_offer_extended_chrome_sync_promos)); | ||
| 4813 | - update_dict->RemovePath( | ||
| 4814 | - kDeprecatedCanOfferExtendedChromeSyncPromosPrefPath); | ||
| 4815 | - } | ||
| 4816 | - | ||
| 4817 | - for (const std::string& name : | ||
| 4818 | - AccountCapabilities::GetSupportedAccountCapabilityNames()) { | ||
| 4819 | - switch (FindAccountCapabilityState(dict, name)) { | ||
| 4820 | - case signin::Tribool::kUnknown: | ||
| 4821 | - account_info.capabilities.capabilities_map_.erase(name); | ||
| 4822 | - break; | ||
| 4823 | - case signin::Tribool::kTrue: | ||
| 4824 | - account_info.capabilities.capabilities_map_[name] = true; | ||
| 4825 | - break; | ||
| 4826 | - case signin::Tribool::kFalse: | ||
| 4827 | - account_info.capabilities.capabilities_map_[name] = false; | ||
| 4828 | - break; | ||
| 4829 | - } | ||
| 4830 | - } | ||
| 4831 | - | ||
| 4832 | - if (!account_info.gaia.empty()) | ||
| 4833 | - NotifyAccountUpdated(account_info); | ||
| 4834 | - } | ||
| 4835 | - } | ||
| 4836 | - } | ||
| 4837 | - | ||
| 4838 | - // Remove any obsolete prefs. | ||
| 4839 | - for (auto account_id : to_remove) { | ||
| 4840 | - AccountInfo account_info; | ||
| 4841 | - account_info.account_id = account_id; | ||
| 4842 | - RemoveFromPrefs(account_info); | ||
| 4843 | - RemoveAccountImageFromDisk(account_id); | ||
| 4844 | - } | ||
| 4845 | - | ||
| 4846 | - if (GetMigrationState() != MIGRATION_DONE) { | ||
| 4847 | - const AccountIdMigrationState new_state = ComputeNewMigrationState(); | ||
| 4848 | - SetMigrationState(new_state); | ||
| 4849 | - | ||
| 4850 | - if (new_state == MIGRATION_IN_PROGRESS) { | ||
| 4851 | - MigrateToGaiaId(); | ||
| 4852 | - } | ||
| 4853 | - } | ||
| 4854 | - | ||
| 4855 | - DCHECK(GetMigrationState() != MIGRATION_DONE || AreAllAccountsMigrated()); | ||
| 4856 | - UMA_HISTOGRAM_ENUMERATION("Signin.AccountTracker.GaiaIdMigrationState", | ||
| 4857 | - GetMigrationState(), NUM_MIGRATION_STATES); | ||
| 4858 | - | ||
| 4859 | - UMA_HISTOGRAM_COUNTS_100("Signin.AccountTracker.CountOfLoadedAccounts", | ||
| 4860 | - accounts_.size()); | ||
| 4861 | } | 4679 | } |
| 4862 | 4680 | ||
| 4863 | void AccountTrackerService::SaveToPrefs(const AccountInfo& account_info) { | 4681 | void AccountTrackerService::SaveToPrefs(const AccountInfo& account_info) { |
| 4864 | - if (!pref_service_) | 4682 | - if (!pref_service_) |
| 4865 | - return; | 4683 | - return; |
| 4866 | - | 4684 | + return; |
| 4867 | - base::DictionaryValue* dict = nullptr; | 4685 | |
| 4686 | base::DictionaryValue* dict = nullptr; | ||
| 4868 | - ListPrefUpdate update(pref_service_, prefs::kAccountInfo); | 4687 | - ListPrefUpdate update(pref_service_, prefs::kAccountInfo); |
| 4869 | - for (size_t i = 0; i < update->GetListDeprecated().size(); | 4688 | - for (size_t i = 0; i < update->GetList().size(); ++i, dict = nullptr) { |
| 4870 | - ++i, dict = nullptr) { | 4689 | - if (update->GetDictionary(i, &dict)) { |
| 4871 | - base::Value& dict_value = update->GetListDeprecated()[i]; | 4690 | + if (false) { |
| 4872 | - if (dict_value.is_dict()) { | 4691 | + while (false) { |
| 4873 | - dict = static_cast<base::DictionaryValue*>(&dict_value); | 4692 | std::string value; |
| 4874 | - const std::string* account_key = dict->FindStringKey(kAccountKeyPath); | 4693 | if (dict->GetString(kAccountKeyPath, &value) && |
| 4875 | - if (account_key && *account_key == account_info.account_id.ToString()) { | 4694 | value == account_info.account_id.ToString()) |
| 4876 | - break; | 4695 | @@ -670,9 +636,6 @@ void AccountTrackerService::SaveToPrefs( |
| 4877 | - } | 4696 | |
| 4878 | - } | 4697 | if (!dict) { |
| 4879 | - } | 4698 | dict = new base::DictionaryValue(); |
| 4880 | - | 4699 | - update->Append(base::WrapUnique(dict)); |
| 4881 | - if (!dict) { | 4700 | - // |dict| is invalidated at this point, so it needs to be reset. |
| 4882 | - update->Append(base::Value(base::Value::Type::DICTIONARY)); | 4701 | - update->GetDictionary(update->GetList().size() - 1, &dict); |
| 4883 | - base::Value& dict_value = update->GetListDeprecated().back(); | 4702 | dict->SetString(kAccountKeyPath, account_info.account_id.ToString()); |
| 4884 | - DCHECK(dict_value.is_dict()); | 4703 | } |
| 4885 | - dict = static_cast<base::DictionaryValue*>(&dict_value); | ||
| 4886 | - dict->SetString(kAccountKeyPath, account_info.account_id.ToString()); | ||
| 4887 | - } | ||
| 4888 | - | ||
| 4889 | - dict->SetString(kAccountEmailPath, account_info.email); | ||
| 4890 | - dict->SetString(kAccountGaiaPath, account_info.gaia); | ||
| 4891 | - dict->SetString(kAccountHostedDomainPath, account_info.hosted_domain); | ||
| 4892 | - dict->SetString(kAccountFullNamePath, account_info.full_name); | ||
| 4893 | - dict->SetString(kAccountGivenNamePath, account_info.given_name); | ||
| 4894 | - dict->SetString(kAccountLocalePath, account_info.locale); | ||
| 4895 | - dict->SetString(kAccountPictureURLPath, account_info.picture_url); | ||
| 4896 | - dict->SetIntPath(kAccountChildAttributePath, | ||
| 4897 | - static_cast<int>(account_info.is_child_account)); | ||
| 4898 | - dict->SetBoolean(kAdvancedProtectionAccountStatusPath, | ||
| 4899 | - account_info.is_under_advanced_protection); | ||
| 4900 | - // |kLastDownloadedImageURLWithSizePath| should only be set after the GAIA | ||
| 4901 | - // picture is successufly saved to disk. Otherwise, there is no guarantee that | ||
| 4902 | - // |kLastDownloadedImageURLWithSizePath| matches the picture on disk. | ||
| 4903 | - for (const std::string& name : | ||
| 4904 | - AccountCapabilities::GetSupportedAccountCapabilityNames()) { | ||
| 4905 | - signin::Tribool capability_state = | ||
| 4906 | - account_info.capabilities.GetCapabilityByName(name); | ||
| 4907 | - SetAccountCapabilityState(dict, name, capability_state); | ||
| 4908 | - } | ||
| 4909 | } | ||
| 4910 | 4704 | ||
| 4911 | void AccountTrackerService::RemoveFromPrefs(const AccountInfo& account_info) { | 4705 | @@ -699,14 +662,7 @@ void AccountTrackerService::RemoveFromPr |
| 4912 | if (!pref_service_) | 4706 | if (!pref_service_) |
| 4913 | return; | 4707 | return; |
| 4914 | 4708 | ||
| @@ -4923,9 +4717,9 @@ | |||
| 4923 | } | 4717 | } |
| 4924 | 4718 | ||
| 4925 | CoreAccountId AccountTrackerService::PickAccountIdForAccount( | 4719 | CoreAccountId AccountTrackerService::PickAccountIdForAccount( |
| 4926 | --- a/components/signin/internal/identity_manager/account_tracker_service.h | 4720 | --- components/signin/internal/identity_manager/account_tracker_service.h.orig |
| 4927 | +++ b/components/signin/internal/identity_manager/account_tracker_service.h | 4721 | +++ components/signin/internal/identity_manager/account_tracker_service.h |
| 4928 | @@ -235,6 +235,8 @@ class AccountTrackerService { | 4722 | @@ -236,6 +236,8 @@ class AccountTrackerService { |
| 4929 | AccountInfoCallback on_account_updated_callback_; | 4723 | AccountInfoCallback on_account_updated_callback_; |
| 4930 | AccountInfoCallback on_account_removed_callback_; | 4724 | AccountInfoCallback on_account_removed_callback_; |
| 4931 | 4725 | ||
| @@ -4934,18 +4728,18 @@ | |||
| 4934 | // Task runner used for file operations on avatar images. | 4728 | // Task runner used for file operations on avatar images. |
| 4935 | scoped_refptr<base::SequencedTaskRunner> image_storage_task_runner_; | 4729 | scoped_refptr<base::SequencedTaskRunner> image_storage_task_runner_; |
| 4936 | 4730 | ||
| 4937 | --- a/components/signin/internal/identity_manager/account_tracker_service_unittest.cc | 4731 | --- components/signin/internal/identity_manager/account_tracker_service_unittest.cc.orig |
| 4938 | +++ b/components/signin/internal/identity_manager/account_tracker_service_unittest.cc | 4732 | +++ components/signin/internal/identity_manager/account_tracker_service_unittest.cc |
| 4939 | @@ -28,7 +28,6 @@ | 4733 | @@ -26,7 +26,6 @@ |
| 4940 | #include "components/signin/internal/identity_manager/fake_account_capabilities_fetcher_factory.h" | 4734 | #include "components/signin/internal/identity_manager/account_tracker_service.h" |
| 4941 | #include "components/signin/internal/identity_manager/fake_profile_oauth2_token_service.h" | 4735 | #include "components/signin/internal/identity_manager/fake_profile_oauth2_token_service.h" |
| 4942 | #include "components/signin/public/base/avatar_icon_util.h" | 4736 | #include "components/signin/public/base/avatar_icon_util.h" |
| 4943 | -#include "components/signin/public/base/signin_pref_names.h" | 4737 | -#include "components/signin/public/base/signin_pref_names.h" |
| 4944 | #include "components/signin/public/base/signin_switches.h" | 4738 | #include "components/signin/public/base/signin_switches.h" |
| 4945 | #include "components/signin/public/base/test_signin_client.h" | 4739 | #include "components/signin/public/base/test_signin_client.h" |
| 4946 | #include "components/signin/public/identity_manager/account_capabilities.h" | 4740 | #include "components/signin/public/identity_manager/account_capabilities.h" |
| 4947 | --- a/components/signin/internal/identity_manager/gaia_cookie_manager_service.cc | 4741 | --- components/signin/internal/identity_manager/gaia_cookie_manager_service.cc.orig |
| 4948 | +++ b/components/signin/internal/identity_manager/gaia_cookie_manager_service.cc | 4742 | +++ components/signin/internal/identity_manager/gaia_cookie_manager_service.cc |
| 4949 | @@ -29,7 +29,6 @@ | 4743 | @@ -29,7 +29,6 @@ |
| 4950 | #include "components/signin/internal/identity_manager/ubertoken_fetcher_impl.h" | 4744 | #include "components/signin/internal/identity_manager/ubertoken_fetcher_impl.h" |
| 4951 | #include "components/signin/public/base/signin_buildflags.h" | 4745 | #include "components/signin/public/base/signin_buildflags.h" |
| @@ -4954,7 +4748,7 @@ | |||
| 4954 | #include "components/signin/public/identity_manager/set_accounts_in_cookie_result.h" | 4748 | #include "components/signin/public/identity_manager/set_accounts_in_cookie_result.h" |
| 4955 | #include "google_apis/gaia/gaia_constants.h" | 4749 | #include "google_apis/gaia/gaia_constants.h" |
| 4956 | #include "google_apis/gaia/gaia_urls.h" | 4750 | #include "google_apis/gaia/gaia_urls.h" |
| 4957 | @@ -451,9 +450,7 @@ GaiaCookieManagerService::GaiaCookieMana | 4751 | @@ -456,9 +455,7 @@ GaiaCookieManagerService::GaiaCookieMana |
| 4958 | listAccountsUnexpectedServerResponseRetried_(false), | 4752 | listAccountsUnexpectedServerResponseRetried_(false), |
| 4959 | external_cc_result_fetched_(false), | 4753 | external_cc_result_fetched_(false), |
| 4960 | list_accounts_stale_(true) { | 4754 | list_accounts_stale_(true) { |
| @@ -4965,7 +4759,7 @@ | |||
| 4965 | 4759 | ||
| 4966 | if (!gaia_cookie_last_list_accounts_data.empty()) { | 4760 | if (!gaia_cookie_last_list_accounts_data.empty()) { |
| 4967 | if (!gaia::ParseListAccountsData(gaia_cookie_last_list_accounts_data, | 4761 | if (!gaia::ParseListAccountsData(gaia_cookie_last_list_accounts_data, |
| 4968 | @@ -477,8 +474,6 @@ GaiaCookieManagerService::~GaiaCookieMan | 4762 | @@ -482,8 +479,6 @@ GaiaCookieManagerService::~GaiaCookieMan |
| 4969 | 4763 | ||
| 4970 | // static | 4764 | // static |
| 4971 | void GaiaCookieManagerService::RegisterPrefs(PrefRegistrySimple* registry) { | 4765 | void GaiaCookieManagerService::RegisterPrefs(PrefRegistrySimple* registry) { |
| @@ -4974,7 +4768,7 @@ | |||
| 4974 | } | 4768 | } |
| 4975 | 4769 | ||
| 4976 | void GaiaCookieManagerService::InitCookieListener() { | 4770 | void GaiaCookieManagerService::InitCookieListener() { |
| 4977 | @@ -896,16 +891,12 @@ void GaiaCookieManagerService::OnListAcc | 4771 | @@ -906,16 +901,12 @@ void GaiaCookieManagerService::OnListAcc |
| 4978 | &signed_out_accounts_)) { | 4772 | &signed_out_accounts_)) { |
| 4979 | listed_accounts_.clear(); | 4773 | listed_accounts_.clear(); |
| 4980 | signed_out_accounts_.clear(); | 4774 | signed_out_accounts_.clear(); |
| @@ -4991,9 +4785,9 @@ | |||
| 4991 | RecordListAccountsFailure(GoogleServiceAuthError::NONE); | 4785 | RecordListAccountsFailure(GoogleServiceAuthError::NONE); |
| 4992 | 4786 | ||
| 4993 | InitializeListedAccountsIds(); | 4787 | InitializeListedAccountsIds(); |
| 4994 | --- a/components/signin/internal/identity_manager/gaia_cookie_manager_service_unittest.cc | 4788 | --- components/signin/internal/identity_manager/gaia_cookie_manager_service_unittest.cc.orig |
| 4995 | +++ b/components/signin/internal/identity_manager/gaia_cookie_manager_service_unittest.cc | 4789 | +++ components/signin/internal/identity_manager/gaia_cookie_manager_service_unittest.cc |
| 4996 | @@ -24,7 +24,6 @@ | 4790 | @@ -25,7 +25,6 @@ |
| 4997 | #include "components/prefs/testing_pref_service.h" | 4791 | #include "components/prefs/testing_pref_service.h" |
| 4998 | #include "components/signin/internal/identity_manager/account_tracker_service.h" | 4792 | #include "components/signin/internal/identity_manager/account_tracker_service.h" |
| 4999 | #include "components/signin/internal/identity_manager/fake_profile_oauth2_token_service.h" | 4793 | #include "components/signin/internal/identity_manager/fake_profile_oauth2_token_service.h" |
| @@ -5001,8 +4795,8 @@ | |||
| 5001 | #include "components/signin/public/base/test_signin_client.h" | 4795 | #include "components/signin/public/base/test_signin_client.h" |
| 5002 | #include "google_apis/gaia/gaia_constants.h" | 4796 | #include "google_apis/gaia/gaia_constants.h" |
| 5003 | #include "google_apis/gaia/gaia_urls.h" | 4797 | #include "google_apis/gaia/gaia_urls.h" |
| 5004 | --- a/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc | 4798 | --- components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc.orig |
| 5005 | +++ b/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc | 4799 | +++ components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc |
| 5006 | @@ -17,7 +17,6 @@ | 4800 | @@ -17,7 +17,6 @@ |
| 5007 | #include "components/prefs/pref_service.h" | 4801 | #include "components/prefs/pref_service.h" |
| 5008 | #include "components/signin/public/base/signin_client.h" | 4802 | #include "components/signin/public/base/signin_client.h" |
| @@ -5057,8 +4851,8 @@ | |||
| 5057 | - client_->GetPrefs()->SetBoolean(prefs::kTokenServiceDiceCompatible, true); | 4851 | - client_->GetPrefs()->SetBoolean(prefs::kTokenServiceDiceCompatible, true); |
| 5058 | } | 4852 | } |
| 5059 | } | 4853 | } |
| 5060 | --- a/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc | 4854 | --- components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc.orig |
| 5061 | +++ b/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc | 4855 | +++ components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc |
| 5062 | @@ -25,7 +25,6 @@ | 4856 | @@ -25,7 +25,6 @@ |
| 5063 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service.h" | 4857 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service.h" |
| 5064 | #include "components/signin/public/base/account_consistency_method.h" | 4858 | #include "components/signin/public/base/account_consistency_method.h" |
| @@ -5067,8 +4861,8 @@ | |||
| 5067 | #include "components/signin/public/base/test_signin_client.h" | 4861 | #include "components/signin/public/base/test_signin_client.h" |
| 5068 | #include "components/signin/public/identity_manager/account_info.h" | 4862 | #include "components/signin/public/identity_manager/account_info.h" |
| 5069 | #include "components/signin/public/webdata/token_web_data.h" | 4863 | #include "components/signin/public/webdata/token_web_data.h" |
| 5070 | --- a/components/signin/internal/identity_manager/primary_account_manager.cc | 4864 | --- components/signin/internal/identity_manager/primary_account_manager.cc.orig |
| 5071 | +++ b/components/signin/internal/identity_manager/primary_account_manager.cc | 4865 | +++ components/signin/internal/identity_manager/primary_account_manager.cc |
| 5072 | @@ -22,7 +22,6 @@ | 4866 | @@ -22,7 +22,6 @@ |
| 5073 | #include "components/signin/public/base/account_consistency_method.h" | 4867 | #include "components/signin/public/base/account_consistency_method.h" |
| 5074 | #include "components/signin/public/base/signin_client.h" | 4868 | #include "components/signin/public/base/signin_client.h" |
| @@ -5077,7 +4871,7 @@ | |||
| 5077 | #include "components/signin/public/base/signin_switches.h" | 4871 | #include "components/signin/public/base/signin_switches.h" |
| 5078 | 4872 | ||
| 5079 | using signin::PrimaryAccountChangeEvent; | 4873 | using signin::PrimaryAccountChangeEvent; |
| 5080 | @@ -44,22 +43,10 @@ PrimaryAccountManager::~PrimaryAccountMa | 4874 | @@ -47,22 +46,10 @@ PrimaryAccountManager::~PrimaryAccountMa |
| 5081 | 4875 | ||
| 5082 | // static | 4876 | // static |
| 5083 | void PrimaryAccountManager::RegisterProfilePrefs(PrefRegistrySimple* registry) { | 4877 | void PrimaryAccountManager::RegisterProfilePrefs(PrefRegistrySimple* registry) { |
| @@ -5100,7 +4894,7 @@ | |||
| 5100 | } | 4894 | } |
| 5101 | 4895 | ||
| 5102 | void PrimaryAccountManager::Initialize(PrefService* local_state) { | 4896 | void PrimaryAccountManager::Initialize(PrefService* local_state) { |
| 5103 | @@ -67,25 +54,7 @@ void PrimaryAccountManager::Initialize(P | 4897 | @@ -70,25 +57,7 @@ void PrimaryAccountManager::Initialize(P |
| 5104 | DCHECK(!IsInitialized()); | 4898 | DCHECK(!IsInitialized()); |
| 5105 | initialized_ = true; | 4899 | initialized_ = true; |
| 5106 | 4900 | ||
| @@ -5127,7 +4921,7 @@ | |||
| 5127 | 4921 | ||
| 5128 | if (!pref_account_id.empty()) { | 4922 | if (!pref_account_id.empty()) { |
| 5129 | if (account_tracker_service_->GetMigrationState() == | 4923 | if (account_tracker_service_->GetMigrationState() == |
| 5130 | @@ -95,14 +64,11 @@ void PrimaryAccountManager::Initialize(P | 4924 | @@ -98,14 +67,11 @@ void PrimaryAccountManager::Initialize(P |
| 5131 | // |account_info.gaia| could be empty if |account_id| is already gaia id. | 4925 | // |account_info.gaia| could be empty if |account_id| is already gaia id. |
| 5132 | if (!account_info.gaia.empty()) { | 4926 | if (!account_info.gaia.empty()) { |
| 5133 | pref_account_id = account_info.gaia; | 4927 | pref_account_id = account_info.gaia; |
| @@ -5143,7 +4937,7 @@ | |||
| 5143 | CoreAccountId account_id = CoreAccountId::FromString(pref_account_id); | 4937 | CoreAccountId account_id = CoreAccountId::FromString(pref_account_id); |
| 5144 | CoreAccountInfo account_info = | 4938 | CoreAccountInfo account_info = |
| 5145 | account_tracker_service_->GetAccountInfo(account_id); | 4939 | account_tracker_service_->GetAccountInfo(account_id); |
| 5146 | @@ -176,8 +142,7 @@ void PrimaryAccountManager::SetSyncPrima | 4940 | @@ -166,8 +132,7 @@ void PrimaryAccountManager::SetSyncPrima |
| 5147 | 4941 | ||
| 5148 | #if DCHECK_IS_ON() | 4942 | #if DCHECK_IS_ON() |
| 5149 | { | 4943 | { |
| @@ -5153,7 +4947,7 @@ | |||
| 5153 | bool consented_to_sync = | 4947 | bool consented_to_sync = |
| 5154 | client_->GetPrefs()->GetBoolean(prefs::kGoogleServicesConsentedToSync); | 4948 | client_->GetPrefs()->GetBoolean(prefs::kGoogleServicesConsentedToSync); |
| 5155 | 4949 | ||
| 5156 | @@ -193,10 +158,6 @@ void PrimaryAccountManager::SetSyncPrima | 4950 | @@ -183,10 +148,6 @@ void PrimaryAccountManager::SetSyncPrima |
| 5157 | // Go ahead and update the last signed in account info here as well. Once a | 4951 | // Go ahead and update the last signed in account info here as well. Once a |
| 5158 | // user is signed in the corresponding preferences should match. Doing it here | 4952 | // user is signed in the corresponding preferences should match. Doing it here |
| 5159 | // as opposed to on signin allows us to catch the upgrade scenario. | 4953 | // as opposed to on signin allows us to catch the upgrade scenario. |
| @@ -5164,7 +4958,7 @@ | |||
| 5164 | 4958 | ||
| 5165 | // Commit primary sync account info immediately so that it does not get lost | 4959 | // Commit primary sync account info immediately so that it does not get lost |
| 5166 | // if Chrome crashes before the next commit interval. | 4960 | // if Chrome crashes before the next commit interval. |
| 5167 | @@ -210,20 +171,11 @@ void PrimaryAccountManager::SetPrimaryAc | 4961 | @@ -200,20 +161,11 @@ void PrimaryAccountManager::SetPrimaryAc |
| 5168 | 4962 | ||
| 5169 | PrefService* prefs = client_->GetPrefs(); | 4963 | PrefService* prefs = client_->GetPrefs(); |
| 5170 | const std::string& account_id = primary_account_info_.account_id.ToString(); | 4964 | const std::string& account_id = primary_account_info_.account_id.ToString(); |
| @@ -5186,27 +4980,27 @@ | |||
| 5186 | if (primary_account_info().account_id.empty()) { | 4980 | if (primary_account_info().account_id.empty()) { |
| 5187 | DCHECK(!consented_pref); | 4981 | DCHECK(!consented_pref); |
| 5188 | return false; | 4982 | return false; |
| 5189 | --- a/components/signin/internal/identity_manager/primary_account_manager_unittest.cc | 4983 | --- components/signin/internal/identity_manager/primary_account_manager_unittest.cc.orig |
| 5190 | +++ b/components/signin/internal/identity_manager/primary_account_manager_unittest.cc | 4984 | +++ components/signin/internal/identity_manager/primary_account_manager_unittest.cc |
| 5191 | @@ -25,7 +25,6 @@ | 4985 | @@ -24,7 +24,6 @@ |
| 5192 | #include "components/signin/internal/identity_manager/fake_account_capabilities_fetcher_factory.h" | ||
| 5193 | #include "components/signin/internal/identity_manager/fake_profile_oauth2_token_service_delegate.h" | 4986 | #include "components/signin/internal/identity_manager/fake_profile_oauth2_token_service_delegate.h" |
| 4987 | #include "components/signin/internal/identity_manager/primary_account_policy_manager.h" | ||
| 5194 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service.h" | 4988 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service.h" |
| 5195 | -#include "components/signin/public/base/signin_pref_names.h" | 4989 | -#include "components/signin/public/base/signin_pref_names.h" |
| 5196 | #include "components/signin/public/base/signin_switches.h" | 4990 | #include "components/signin/public/base/signin_switches.h" |
| 5197 | #include "components/signin/public/base/test_signin_client.h" | 4991 | #include "components/signin/public/base/test_signin_client.h" |
| 5198 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 4992 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 5199 | --- a/components/signin/internal/identity_manager/primary_account_mutator_impl.cc | 4993 | --- components/signin/internal/identity_manager/primary_account_mutator_impl.cc.orig |
| 5200 | +++ b/components/signin/internal/identity_manager/primary_account_mutator_impl.cc | 4994 | +++ components/signin/internal/identity_manager/primary_account_mutator_impl.cc |
| 5201 | @@ -15,7 +15,6 @@ | 4995 | @@ -14,7 +14,6 @@ |
| 5202 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service.h" | 4996 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service.h" |
| 5203 | #include "components/signin/public/base/signin_buildflags.h" | 4997 | #include "components/signin/public/base/signin_buildflags.h" |
| 5204 | #include "components/signin/public/base/signin_metrics.h" | 4998 | #include "components/signin/public/base/signin_metrics.h" |
| 5205 | -#include "components/signin/public/base/signin_pref_names.h" | 4999 | -#include "components/signin/public/base/signin_pref_names.h" |
| 5206 | #include "components/signin/public/base/signin_switches.h" | ||
| 5207 | #include "google_apis/gaia/core_account_id.h" | 5000 | #include "google_apis/gaia/core_account_id.h" |
| 5208 | 5001 | ||
| 5209 | @@ -60,7 +59,7 @@ PrimaryAccountMutatorImpl::SetPrimaryAcc | 5002 | namespace signin { |
| 5003 | @@ -58,7 +57,7 @@ PrimaryAccountMutatorImpl::SetPrimaryAcc | ||
| 5210 | DCHECK(!account_info.gaia.empty()); | 5004 | DCHECK(!account_info.gaia.empty()); |
| 5211 | 5005 | ||
| 5212 | #if !BUILDFLAG(IS_CHROMEOS_ASH) | 5006 | #if !BUILDFLAG(IS_CHROMEOS_ASH) |
| @@ -5215,8 +5009,59 @@ | |||
| 5215 | #if BUILDFLAG(IS_CHROMEOS_LACROS) | 5009 | #if BUILDFLAG(IS_CHROMEOS_LACROS) |
| 5216 | // Check that `prefs::kSigninAllowed` has not been set to false in a context | 5010 | // Check that `prefs::kSigninAllowed` has not been set to false in a context |
| 5217 | // where Lacros wants to set a Primary Account. Lacros doesn't offer account | 5011 | // where Lacros wants to set a Primary Account. Lacros doesn't offer account |
| 5218 | --- a/components/signin/internal/identity_manager/profile_oauth2_token_service.cc | 5012 | --- components/signin/internal/identity_manager/primary_account_policy_manager_impl.cc.orig |
| 5219 | +++ b/components/signin/internal/identity_manager/profile_oauth2_token_service.cc | 5013 | +++ components/signin/internal/identity_manager/primary_account_policy_manager_impl.cc |
| 5014 | @@ -10,7 +10,6 @@ | ||
| 5015 | #include "components/signin/internal/identity_manager/primary_account_manager.h" | ||
| 5016 | #include "components/signin/public/base/signin_client.h" | ||
| 5017 | #include "components/signin/public/base/signin_metrics.h" | ||
| 5018 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 5019 | #include "components/signin/public/identity_manager/account_info.h" | ||
| 5020 | #include "components/signin/public/identity_manager/identity_utils.h" | ||
| 5021 | |||
| 5022 | @@ -28,18 +27,7 @@ void PrimaryAccountPolicyManagerImpl::In | ||
| 5023 | // local_state can be null during unit tests. | ||
| 5024 | if (local_state) { | ||
| 5025 | local_state_pref_registrar_.Init(local_state); | ||
| 5026 | - local_state_pref_registrar_.Add( | ||
| 5027 | - prefs::kGoogleServicesUsernamePattern, | ||
| 5028 | - base::BindRepeating(&PrimaryAccountPolicyManagerImpl:: | ||
| 5029 | - OnGoogleServicesUsernamePatternChanged, | ||
| 5030 | - weak_pointer_factory_.GetWeakPtr(), | ||
| 5031 | - primary_account_manager)); | ||
| 5032 | } | ||
| 5033 | - signin_allowed_.Init( | ||
| 5034 | - prefs::kSigninAllowed, client_->GetPrefs(), | ||
| 5035 | - base::BindRepeating( | ||
| 5036 | - &PrimaryAccountPolicyManagerImpl::OnSigninAllowedPrefChanged, | ||
| 5037 | - base::Unretained(this), primary_account_manager)); | ||
| 5038 | |||
| 5039 | CoreAccountInfo account_info = primary_account_manager->GetPrimaryAccountInfo( | ||
| 5040 | signin::ConsentLevel::kSync); | ||
| 5041 | --- components/signin/internal/identity_manager/primary_account_policy_manager_impl.h.orig | ||
| 5042 | +++ components/signin/internal/identity_manager/primary_account_policy_manager_impl.h | ||
| 5043 | @@ -56,9 +56,6 @@ class PrimaryAccountPolicyManagerImpl : | ||
| 5044 | // profile-specific local prefs (like kGoogleServicesUsernamePattern). | ||
| 5045 | PrefChangeRegistrar local_state_pref_registrar_; | ||
| 5046 | |||
| 5047 | - // Helper object to listen for changes to the signin allowed preference. | ||
| 5048 | - BooleanPrefMember signin_allowed_; | ||
| 5049 | - | ||
| 5050 | base::WeakPtrFactory<PrimaryAccountPolicyManagerImpl> weak_pointer_factory_{ | ||
| 5051 | this}; | ||
| 5052 | }; | ||
| 5053 | --- components/signin/internal/identity_manager/primary_account_policy_manager_impl_unittest.cc.orig | ||
| 5054 | +++ components/signin/internal/identity_manager/primary_account_policy_manager_impl_unittest.cc | ||
| 5055 | @@ -15,7 +15,6 @@ | ||
| 5056 | #include "components/signin/internal/identity_manager/primary_account_policy_manager_impl.h" | ||
| 5057 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service.h" | ||
| 5058 | #include "components/signin/public/base/account_consistency_method.h" | ||
| 5059 | -#include "components/signin/public/base/signin_pref_names.h" | ||
| 5060 | #include "components/signin/public/base/test_signin_client.h" | ||
| 5061 | #include "components/sync_preferences/testing_pref_service_syncable.h" | ||
| 5062 | #include "testing/gtest/include/gtest/gtest.h" | ||
| 5063 | --- components/signin/internal/identity_manager/profile_oauth2_token_service.cc.orig | ||
| 5064 | +++ components/signin/internal/identity_manager/profile_oauth2_token_service.cc | ||
| 5220 | @@ -12,7 +12,6 @@ | 5065 | @@ -12,7 +12,6 @@ |
| 5221 | #include "components/prefs/pref_registry_simple.h" | 5066 | #include "components/prefs/pref_registry_simple.h" |
| 5222 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service_delegate.h" | 5067 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service_delegate.h" |
| @@ -5234,9 +5079,9 @@ | |||
| 5234 | } | 5079 | } |
| 5235 | 5080 | ||
| 5236 | ProfileOAuth2TokenServiceDelegate* ProfileOAuth2TokenService::GetDelegate() { | 5081 | ProfileOAuth2TokenServiceDelegate* ProfileOAuth2TokenService::GetDelegate() { |
| 5237 | --- a/components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos_unittest.cc | 5082 | --- components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos_unittest.cc.orig |
| 5238 | +++ b/components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos_unittest.cc | 5083 | +++ components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos_unittest.cc |
| 5239 | @@ -24,7 +24,6 @@ | 5084 | @@ -25,7 +25,6 @@ |
| 5240 | #include "components/account_manager_core/mock_account_manager_facade.h" | 5085 | #include "components/account_manager_core/mock_account_manager_facade.h" |
| 5241 | #include "components/signin/internal/identity_manager/account_tracker_service.h" | 5086 | #include "components/signin/internal/identity_manager/account_tracker_service.h" |
| 5242 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service_observer.h" | 5087 | #include "components/signin/internal/identity_manager/profile_oauth2_token_service_observer.h" |
| @@ -5244,8 +5089,8 @@ | |||
| 5244 | #include "components/signin/public/base/test_signin_client.h" | 5089 | #include "components/signin/public/base/test_signin_client.h" |
| 5245 | #include "components/signin/public/identity_manager/account_info.h" | 5090 | #include "components/signin/public/identity_manager/account_info.h" |
| 5246 | #include "components/sync_preferences/testing_pref_service_syncable.h" | 5091 | #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 5247 | --- a/components/signin/public/base/BUILD.gn | 5092 | --- components/signin/public/base/BUILD.gn.orig |
| 5248 | +++ b/components/signin/public/base/BUILD.gn | 5093 | +++ components/signin/public/base/BUILD.gn |
| 5249 | @@ -34,8 +34,6 @@ static_library("base") { | 5094 | @@ -34,8 +34,6 @@ static_library("base") { |
| 5250 | "signin_client.h", | 5095 | "signin_client.h", |
| 5251 | "signin_metrics.cc", | 5096 | "signin_metrics.cc", |
| @@ -5255,8 +5100,8 @@ | |||
| 5255 | "signin_switches.cc", | 5100 | "signin_switches.cc", |
| 5256 | "signin_switches.h", | 5101 | "signin_switches.h", |
| 5257 | ] | 5102 | ] |
| 5258 | --- a/components/signin/public/base/device_id_helper.cc | 5103 | --- components/signin/public/base/device_id_helper.cc.orig |
| 5259 | +++ b/components/signin/public/base/device_id_helper.cc | 5104 | +++ components/signin/public/base/device_id_helper.cc |
| 5260 | @@ -9,7 +9,6 @@ | 5105 | @@ -9,7 +9,6 @@ |
| 5261 | #include "base/guid.h" | 5106 | #include "base/guid.h" |
| 5262 | #include "build/chromeos_buildflags.h" | 5107 | #include "build/chromeos_buildflags.h" |
| @@ -5301,8 +5146,8 @@ | |||
| 5301 | } | 5146 | } |
| 5302 | 5147 | ||
| 5303 | #endif | 5148 | #endif |
| 5304 | --- a/components/signin/public/base/device_id_helper_unittest.cc | 5149 | --- components/signin/public/base/device_id_helper_unittest.cc.orig |
| 5305 | +++ b/components/signin/public/base/device_id_helper_unittest.cc | 5150 | +++ components/signin/public/base/device_id_helper_unittest.cc |
| 5306 | @@ -8,7 +8,6 @@ | 5151 | @@ -8,7 +8,6 @@ |
| 5307 | 5152 | ||
| 5308 | #include "build/build_config.h" | 5153 | #include "build/build_config.h" |
| @@ -5352,8 +5197,8 @@ | |||
| 5352 | } | 5197 | } |
| 5353 | 5198 | ||
| 5354 | #endif | 5199 | #endif |
| 5355 | --- a/components/signin/public/identity_manager/identity_utils.cc | 5200 | --- components/signin/public/identity_manager/identity_utils.cc.orig |
| 5356 | +++ b/components/signin/public/identity_manager/identity_utils.cc | 5201 | +++ components/signin/public/identity_manager/identity_utils.cc |
| 5357 | @@ -11,7 +11,6 @@ | 5202 | @@ -11,7 +11,6 @@ |
| 5358 | #include "base/strings/string_util.h" | 5203 | #include "base/strings/string_util.h" |
| 5359 | #include "base/strings/utf_string_conversions.h" | 5204 | #include "base/strings/utf_string_conversions.h" |
| @@ -5372,8 +5217,8 @@ | |||
| 5372 | } | 5217 | } |
| 5373 | 5218 | ||
| 5374 | } // namespace signin | 5219 | } // namespace signin |
| 5375 | --- a/components/signin/public/identity_manager/identity_utils_unittest.cc | 5220 | --- components/signin/public/identity_manager/identity_utils_unittest.cc.orig |
| 5376 | +++ b/components/signin/public/identity_manager/identity_utils_unittest.cc | 5221 | +++ components/signin/public/identity_manager/identity_utils_unittest.cc |
| 5377 | @@ -7,7 +7,6 @@ | 5222 | @@ -7,7 +7,6 @@ |
| 5378 | #include "components/prefs/pref_registry_simple.h" | 5223 | #include "components/prefs/pref_registry_simple.h" |
| 5379 | #include "components/prefs/pref_service.h" | 5224 | #include "components/prefs/pref_service.h" |
| @@ -5382,19 +5227,19 @@ | |||
| 5382 | #include "testing/gtest/include/gtest/gtest.h" | 5227 | #include "testing/gtest/include/gtest/gtest.h" |
| 5383 | 5228 | ||
| 5384 | namespace { | 5229 | namespace { |
| 5385 | --- a/components/signin/public/identity_manager/primary_account_mutator_unittest.cc | 5230 | --- components/signin/public/identity_manager/primary_account_mutator_unittest.cc.orig |
| 5386 | +++ b/components/signin/public/identity_manager/primary_account_mutator_unittest.cc | 5231 | +++ components/signin/public/identity_manager/primary_account_mutator_unittest.cc |
| 5387 | @@ -16,7 +16,6 @@ | 5232 | @@ -15,7 +15,6 @@ |
| 5388 | #include "components/signin/public/base/consent_level.h" | 5233 | #include "build/chromeos_buildflags.h" |
| 5389 | #include "components/signin/public/base/signin_buildflags.h" | 5234 | #include "components/signin/public/base/signin_buildflags.h" |
| 5390 | #include "components/signin/public/base/signin_metrics.h" | 5235 | #include "components/signin/public/base/signin_metrics.h" |
| 5391 | -#include "components/signin/public/base/signin_pref_names.h" | 5236 | -#include "components/signin/public/base/signin_pref_names.h" |
| 5392 | #include "components/signin/public/base/signin_switches.h" | 5237 | #include "components/signin/public/identity_manager/consent_level.h" |
| 5393 | #include "components/signin/public/identity_manager/identity_test_environment.h" | 5238 | #include "components/signin/public/identity_manager/identity_test_environment.h" |
| 5394 | #include "components/signin/public/identity_manager/identity_test_utils.h" | 5239 | #include "components/signin/public/identity_manager/identity_test_utils.h" |
| 5395 | --- a/tools/metrics/histograms/enums.xml | 5240 | --- tools/metrics/histograms/enums.xml.orig |
| 5396 | +++ b/tools/metrics/histograms/enums.xml | 5241 | +++ tools/metrics/histograms/enums.xml |
| 5397 | @@ -90465,7 +90465,6 @@ Full version information for the fingerp | 5242 | @@ -83754,7 +83754,6 @@ Full version information for the fingerp |
| 5398 | <int value="3" label="kRestoreOnStartup"/> | 5243 | <int value="3" label="kRestoreOnStartup"/> |
| 5399 | <int value="4" label="kURLsToRestoreOnStartup"/> | 5244 | <int value="4" label="kURLsToRestoreOnStartup"/> |
| 5400 | <int value="5" label="extensions::pref_names::kExtensions"/> | 5245 | <int value="5" label="extensions::pref_names::kExtensions"/> |
| @@ -5402,7 +5247,7 @@ | |||
| 5402 | <int value="7" label="kSearchProviderOverrides"/> | 5247 | <int value="7" label="kSearchProviderOverrides"/> |
| 5403 | <int value="8" label="kDefaultSearchProviderSearchURL (Obsolete 12/2016)"/> | 5248 | <int value="8" label="kDefaultSearchProviderSearchURL (Obsolete 12/2016)"/> |
| 5404 | <int value="9" label="kDefaultSearchProviderKeyword (Obsolete 12/2016)"/> | 5249 | <int value="9" label="kDefaultSearchProviderKeyword (Obsolete 12/2016)"/> |
| 5405 | @@ -90480,10 +90479,7 @@ Full version information for the fingerp | 5250 | @@ -83769,10 +83768,7 @@ Full version information for the fingerp |
| 5406 | <int value="18" label="kSafeBrowsingIncidentsSent"/> | 5251 | <int value="18" label="kSafeBrowsingIncidentsSent"/> |
| 5407 | <int value="19" label="kSwReporterPromptVersion"/> | 5252 | <int value="19" label="kSwReporterPromptVersion"/> |
| 5408 | <int value="20" label="kSwReporterPromptReason"/> | 5253 | <int value="20" label="kSwReporterPromptReason"/> |
