qmk_firmware

commit 3444e9656d031bf23d78b0a4ab56d84ed0f10757
parent 55f226159b2e06265ccb8f2105ef1c95f2f7f005
Author: Albert Y <76888457+filterpaper@users.noreply.github.com>
Date:   Sun, 11 Jun 2023 14:55:03 +0800

Refactor the rain lighting decision operator (#21139)


Diffstat:
M
quantum/rgb_matrix/animations/pixel_rain_anim.h
 | 
10
+++-------

1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/quantum/rgb_matrix/animations/pixel_rain_anim.h b/quantum/rgb_matrix/animations/pixel_rain_anim.h
@@ -16,13 +16,9 @@ static bool PIXEL_RAIN(effect_params_t* params) {
         if (!HAS_ANY_FLAGS(g_led_config.flags[led_index], params->flags)) {
             return;
         }
-        if (random8() & 2) {
-            rgb_matrix_set_color(led_index, 0, 0, 0);
-        } else {
-            HSV hsv = {random8(), random8_min_max(127, 255), rgb_matrix_config.hsv.v};
-            RGB rgb = rgb_matrix_hsv_to_rgb(hsv);
-            rgb_matrix_set_color(led_index, rgb.r, rgb.g, rgb.b);
-        }
+        HSV hsv = (random8() & 2) ? (HSV){0, 0, 0} : (HSV){random8(), random8_min_max(127, 255), rgb_matrix_config.hsv.v};
+        RGB rgb = rgb_matrix_hsv_to_rgb(hsv);
+        rgb_matrix_set_color(led_index, rgb.r, rgb.g, rgb.b);
         wait_timer = g_rgb_timer + interval();
     }