commit 3e0ee6fb74e125d14ac22c922d80def4649f6784 parent 6cc4e32e61a275a624061fd9be643973476cad9c Author: Ryan <fauxpark@gmail.com> Date: Wed, 26 Jan 2022 00:40:55 +1100 Fix joystick button off-by-one error (#16037) Diffstat:
| M | quantum/process_keycode/process_joystick.c | | | 5 | +++-- |
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/quantum/process_keycode/process_joystick.c b/quantum/process_keycode/process_joystick.c @@ -28,10 +28,11 @@ bool process_joystick_buttons(uint16_t keycode, keyrecord_t *record) { if (keycode < JS_BUTTON0 || keycode > JS_BUTTON_MAX) { return true; } else { + uint8_t button_idx = (keycode - JS_BUTTON0); if (record->event.pressed) { - joystick_status.buttons[(keycode - JS_BUTTON0) / 8] |= 1 << (keycode % 8); + joystick_status.buttons[button_idx / 8] |= 1 << (button_idx % 8); } else { - joystick_status.buttons[(keycode - JS_BUTTON0) / 8] &= ~(1 << (keycode % 8)); + joystick_status.buttons[button_idx / 8] &= ~(1 << (button_idx % 8)); } joystick_status.status |= JS_UPDATED;