diff options
| author | Ryan <fauxpark@gmail.com> | 2023-08-15 20:06:57 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-15 11:06:57 +0100 |
| commit | 1c069b13b9c410d30cb3b0126b21b984284c405c (patch) | |
| tree | e1c8ed8a6e4a50fb7afb8fe9b017743f0b0b87c9 | |
| parent | 3ece80f73f781a719ea6665af1d01b99922388e9 (diff) | |
rgblight: driver selection cleanups (#21558)
43 files changed, 27 insertions, 44 deletions
diff --git a/builddefs/common_features.mk b/builddefs/common_features.mk index 47fe56e4aa..906a793df7 100644 --- a/builddefs/common_features.mk +++ b/builddefs/common_features.mk | |||
| @@ -317,14 +317,10 @@ ifneq ($(strip $(FLASH_DRIVER)), none) | |||
| 317 | endif | 317 | endif |
| 318 | 318 | ||
| 319 | RGBLIGHT_ENABLE ?= no | 319 | RGBLIGHT_ENABLE ?= no |
| 320 | VALID_RGBLIGHT_TYPES := WS2812 APA102 custom | 320 | VALID_RGBLIGHT_TYPES := ws2812 apa102 custom |
| 321 | |||
| 322 | ifeq ($(strip $(RGBLIGHT_CUSTOM_DRIVER)), yes) | ||
| 323 | RGBLIGHT_DRIVER ?= custom | ||
| 324 | endif | ||
| 325 | 321 | ||
| 326 | ifeq ($(strip $(RGBLIGHT_ENABLE)), yes) | 322 | ifeq ($(strip $(RGBLIGHT_ENABLE)), yes) |
| 327 | RGBLIGHT_DRIVER ?= WS2812 | 323 | RGBLIGHT_DRIVER ?= ws2812 |
| 328 | 324 | ||
| 329 | ifeq ($(filter $(RGBLIGHT_DRIVER),$(VALID_RGBLIGHT_TYPES)),) | 325 | ifeq ($(filter $(RGBLIGHT_DRIVER),$(VALID_RGBLIGHT_TYPES)),) |
| 330 | $(call CATASTROPHIC_ERROR,Invalid RGBLIGHT_DRIVER,RGBLIGHT_DRIVER="$(RGBLIGHT_DRIVER)" is not a valid RGB type) | 326 | $(call CATASTROPHIC_ERROR,Invalid RGBLIGHT_DRIVER,RGBLIGHT_DRIVER="$(RGBLIGHT_DRIVER)" is not a valid RGB type) |
| @@ -338,11 +334,11 @@ ifeq ($(strip $(RGBLIGHT_ENABLE)), yes) | |||
| 338 | RGB_KEYCODES_ENABLE := yes | 334 | RGB_KEYCODES_ENABLE := yes |
| 339 | endif | 335 | endif |
| 340 | 336 | ||
| 341 | ifeq ($(strip $(RGBLIGHT_DRIVER)), WS2812) | 337 | ifeq ($(strip $(RGBLIGHT_DRIVER)), ws2812) |
| 342 | WS2812_DRIVER_REQUIRED := yes | 338 | WS2812_DRIVER_REQUIRED := yes |
| 343 | endif | 339 | endif |
| 344 | 340 | ||
| 345 | ifeq ($(strip $(RGBLIGHT_DRIVER)), APA102) | 341 | ifeq ($(strip $(RGBLIGHT_DRIVER)), apa102) |
| 346 | APA102_DRIVER_REQUIRED := yes | 342 | APA102_DRIVER_REQUIRED := yes |
| 347 | endif | 343 | endif |
| 348 | 344 | ||
diff --git a/builddefs/show_options.mk b/builddefs/show_options.mk index c21f907881..563d089880 100644 --- a/builddefs/show_options.mk +++ b/builddefs/show_options.mk | |||
| @@ -17,7 +17,7 @@ HARDWARE_OPTION_NAMES = \ | |||
| 17 | BACKLIGHT_ENABLE \ | 17 | BACKLIGHT_ENABLE \ |
| 18 | BACKLIGHT_DRIVER \ | 18 | BACKLIGHT_DRIVER \ |
| 19 | RGBLIGHT_ENABLE \ | 19 | RGBLIGHT_ENABLE \ |
| 20 | RGBLIGHT_CUSTOM_DRIVER \ | 20 | RGBLIGHT_DRIVER \ |
| 21 | RGB_MATRIX_ENABLE \ | 21 | RGB_MATRIX_ENABLE \ |
| 22 | RGB_MATRIX_DRIVER \ | 22 | RGB_MATRIX_DRIVER \ |
| 23 | CIE1931_CURVE \ | 23 | CIE1931_CURVE \ |
diff --git a/data/mappings/info_rules.hjson b/data/mappings/info_rules.hjson index bf8ec05cb2..07191551da 100644 --- a/data/mappings/info_rules.hjson +++ b/data/mappings/info_rules.hjson | |||
| @@ -35,6 +35,7 @@ | |||
| 35 | "PS2_ENABLE": {"info_key": "ps2.enabled", "value_type": "bool"}, | 35 | "PS2_ENABLE": {"info_key": "ps2.enabled", "value_type": "bool"}, |
| 36 | "PS2_MOUSE_ENABLE": {"info_key": "ps2.mouse_enabled", "value_type": "bool"}, | 36 | "PS2_MOUSE_ENABLE": {"info_key": "ps2.mouse_enabled", "value_type": "bool"}, |
| 37 | "RGB_MATRIX_DRIVER": {"info_key": "rgb_matrix.driver"}, | 37 | "RGB_MATRIX_DRIVER": {"info_key": "rgb_matrix.driver"}, |
| 38 | "RGBLIGHT_DRIVER": {"info_key": "rgblight.driver"}, | ||
| 38 | "SECURE_ENABLE": {"info_key": "secure.enabled", "value_type": "bool"}, | 39 | "SECURE_ENABLE": {"info_key": "secure.enabled", "value_type": "bool"}, |
| 39 | "SPLIT_KEYBOARD": {"info_key": "split.enabled", "value_type": "bool"}, | 40 | "SPLIT_KEYBOARD": {"info_key": "split.enabled", "value_type": "bool"}, |
| 40 | "SPLIT_TRANSPORT": {"info_key": "split.transport.protocol", "to_c": false}, | 41 | "SPLIT_TRANSPORT": {"info_key": "split.transport.protocol", "to_c": false}, |
diff --git a/data/schemas/keyboard.jsonschema b/data/schemas/keyboard.jsonschema index cdea662192..aea76af50a 100644 --- a/data/schemas/keyboard.jsonschema +++ b/data/schemas/keyboard.jsonschema | |||
| @@ -477,6 +477,10 @@ | |||
| 477 | } | 477 | } |
| 478 | }, | 478 | }, |
| 479 | "brightness_steps": {"$ref": "qmk.definitions.v1#/unsigned_int"}, | 479 | "brightness_steps": {"$ref": "qmk.definitions.v1#/unsigned_int"}, |
| 480 | "driver": { | ||
| 481 | "type": "string", | ||
| 482 | "enum": ["apa102", "custom", "ws2812"] | ||
| 483 | }, | ||
| 480 | "hue_steps": {"$ref": "qmk.definitions.v1#/unsigned_int"}, | 484 | "hue_steps": {"$ref": "qmk.definitions.v1#/unsigned_int"}, |
| 481 | "layers": { | 485 | "layers": { |
| 482 | "type": "object", | 486 | "type": "object", |
diff --git a/docs/feature_rgblight.md b/docs/feature_rgblight.md index fef856f7df..39b7e6a6f1 100644 --- a/docs/feature_rgblight.md +++ b/docs/feature_rgblight.md | |||
| @@ -28,7 +28,7 @@ For APA102 LEDs, add the following to your `rules.mk`: | |||
| 28 | 28 | ||
| 29 | ```make | 29 | ```make |
| 30 | RGBLIGHT_ENABLE = yes | 30 | RGBLIGHT_ENABLE = yes |
| 31 | RGBLIGHT_DRIVER = APA102 | 31 | RGBLIGHT_DRIVER = apa102 |
| 32 | ``` | 32 | ``` |
| 33 | 33 | ||
| 34 | At minimum you must define the data pin your LED strip is connected to, and the number of LEDs in the strip, in your `config.h`. For APA102 LEDs, you must also define the clock pin. If your keyboard has onboard RGB LEDs, and you are simply creating a keymap, you usually won't need to modify these. | 34 | At minimum you must define the data pin your LED strip is connected to, and the number of LEDs in the strip, in your `config.h`. For APA102 LEDs, you must also define the clock pin. If your keyboard has onboard RGB LEDs, and you are simply creating a keymap, you usually won't need to modify these. |
diff --git a/keyboards/capsunlocked/cu75/info.json b/keyboards/capsunlocked/cu75/info.json index 5698fc101e..aa738d1f75 100644 --- a/keyboards/capsunlocked/cu75/info.json +++ b/keyboards/capsunlocked/cu75/info.json | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | "levels": 8 | 18 | "levels": 8 |
| 19 | }, | 19 | }, |
| 20 | "rgblight": { | 20 | "rgblight": { |
| 21 | "driver": "custom", | ||
| 21 | "hue_steps": 10, | 22 | "hue_steps": 10, |
| 22 | "led_count": 24 | 23 | "led_count": 24 |
| 23 | }, | 24 | }, |
diff --git a/keyboards/capsunlocked/cu75/keymaps/default/rules.mk b/keyboards/capsunlocked/cu75/keymaps/default/rules.mk index aefb10a8b1..483baa7993 100644 --- a/keyboards/capsunlocked/cu75/keymaps/default/rules.mk +++ b/keyboards/capsunlocked/cu75/keymaps/default/rules.mk | |||
| @@ -7,7 +7,6 @@ NKRO_ENABLE = yes | |||
| 7 | BACKLIGHT_ENABLE = yes # Disable keyboard backlight functionality | 7 | BACKLIGHT_ENABLE = yes # Disable keyboard backlight functionality |
| 8 | AUDIO_ENABLE = no # Audio output | 8 | AUDIO_ENABLE = no # Audio output |
| 9 | RGBLIGHT_ENABLE = yes # Disable RGB underlight | 9 | RGBLIGHT_ENABLE = yes # Disable RGB underlight |
| 10 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 11 | SLEEP_LED_ENABLE = yes | 10 | SLEEP_LED_ENABLE = yes |
| 12 | 11 | ||
| 13 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 12 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/capsunlocked/cu75/keymaps/iso/rules.mk b/keyboards/capsunlocked/cu75/keymaps/iso/rules.mk index 26239f265e..0058113605 100644 --- a/keyboards/capsunlocked/cu75/keymaps/iso/rules.mk +++ b/keyboards/capsunlocked/cu75/keymaps/iso/rules.mk | |||
| @@ -7,7 +7,6 @@ NKRO_ENABLE = yes | |||
| 7 | # BACKLIGHT_ENABLE = no # Disable keyboard backlight functionality | 7 | # BACKLIGHT_ENABLE = no # Disable keyboard backlight functionality |
| 8 | AUDIO_ENABLE = no # Audio output | 8 | AUDIO_ENABLE = no # Audio output |
| 9 | RGBLIGHT_ENABLE = no # Disable RGB underlight | 9 | RGBLIGHT_ENABLE = no # Disable RGB underlight |
| 10 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 11 | SLEEP_LED_ENABLE = yes | 10 | SLEEP_LED_ENABLE = yes |
| 12 | 11 | ||
| 13 | ISSI_ENABLE = no # If the I2C pullup resistors aren't install this must be disabled | 12 | ISSI_ENABLE = no # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/handwired/onekey/keymaps/apa102/rules.mk b/keyboards/handwired/onekey/keymaps/apa102/rules.mk index 70932cb751..5f15fa9e70 100644 --- a/keyboards/handwired/onekey/keymaps/apa102/rules.mk +++ b/keyboards/handwired/onekey/keymaps/apa102/rules.mk | |||
| @@ -1,2 +1,2 @@ | |||
| 1 | RGBLIGHT_ENABLE = yes | 1 | RGBLIGHT_ENABLE = yes |
| 2 | RGBLIGHT_DRIVER = APA102 | 2 | RGBLIGHT_DRIVER = apa102 |
diff --git a/keyboards/handwired/uthol/rev2/rules.mk b/keyboards/handwired/uthol/rev2/rules.mk index 445e503d0b..c6e22b8dd2 100644 --- a/keyboards/handwired/uthol/rev2/rules.mk +++ b/keyboards/handwired/uthol/rev2/rules.mk | |||
| @@ -6,4 +6,3 @@ EXTRAKEY_ENABLE = yes | |||
| 6 | NKRO_ENABLE = yes | 6 | NKRO_ENABLE = yes |
| 7 | LTO_ENABLE = yes | 7 | LTO_ENABLE = yes |
| 8 | RGBLIGHT_ENABLE = yes | 8 | RGBLIGHT_ENABLE = yes |
| 9 | RGBLIGHT_DRIVER = WS2812 | ||
diff --git a/keyboards/handwired/uthol/rev3/rules.mk b/keyboards/handwired/uthol/rev3/rules.mk index f0f9be4985..1577cf8a77 100644 --- a/keyboards/handwired/uthol/rev3/rules.mk +++ b/keyboards/handwired/uthol/rev3/rules.mk | |||
| @@ -9,4 +9,3 @@ WPM_ENABLE = yes | |||
| 9 | EXTRAKEY_ENABLE = yes | 9 | EXTRAKEY_ENABLE = yes |
| 10 | ENCODER_ENABLE = yes | 10 | ENCODER_ENABLE = yes |
| 11 | RGBLIGHT_ENABLE = yes | 11 | RGBLIGHT_ENABLE = yes |
| 12 | RGBLIGHT_DRIVER = WS2812 | ||
diff --git a/keyboards/kprepublic/jj40/keymaps/fun40/rules.mk b/keyboards/kprepublic/jj40/keymaps/fun40/rules.mk index cc9508d7d6..9018bddfe3 100644 --- a/keyboards/kprepublic/jj40/keymaps/fun40/rules.mk +++ b/keyboards/kprepublic/jj40/keymaps/fun40/rules.mk | |||
| @@ -13,9 +13,5 @@ UNICODE_ENABLE = no # Unicode | |||
| 13 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 13 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
| 14 | 14 | ||
| 15 | RGBLIGHT_ENABLE = yes | 15 | RGBLIGHT_ENABLE = yes |
| 16 | RGBLIGHT_CUSTOM_DRIVER = yes | ||
| 17 | DISABLE_WS2812 = yes | ||
| 18 | |||
| 19 | 16 | ||
| 20 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 17 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 21 | |||
diff --git a/keyboards/kprepublic/jj40/keymaps/waples/rules.mk b/keyboards/kprepublic/jj40/keymaps/waples/rules.mk index b9b67d1c73..8f678e6b59 100644 --- a/keyboards/kprepublic/jj40/keymaps/waples/rules.mk +++ b/keyboards/kprepublic/jj40/keymaps/waples/rules.mk | |||
| @@ -6,5 +6,4 @@ CONSOLE_ENABLE = no | |||
| 6 | COMMAND_ENABLE = yes | 6 | COMMAND_ENABLE = yes |
| 7 | BACKLIGHT_ENABLE = yes | 7 | BACKLIGHT_ENABLE = yes |
| 8 | RGBLIGHT_ENABLE = yes | 8 | RGBLIGHT_ENABLE = yes |
| 9 | RGBLIGHT_CUSTOM_DRIVER = yes | ||
| 10 | KEY_LOCK_ENABLE = yes | 9 | KEY_LOCK_ENABLE = yes |
diff --git a/keyboards/lfkeyboards/lfk78/keymaps/ca178858/rules.mk b/keyboards/lfkeyboards/lfk78/keymaps/ca178858/rules.mk index f1836baa27..481ff1407b 100644 --- a/keyboards/lfkeyboards/lfk78/keymaps/ca178858/rules.mk +++ b/keyboards/lfkeyboards/lfk78/keymaps/ca178858/rules.mk | |||
| @@ -10,7 +10,6 @@ AUDIO_ENABLE = no # Audio output on port C6 | |||
| 10 | UNICODE_ENABLE = no # Unicode | 10 | UNICODE_ENABLE = no # Unicode |
| 11 | BLUETOOTH_ENABLE = no # Disable Bluetooth with the Adafruit EZ-Key HID | 11 | BLUETOOTH_ENABLE = no # Disable Bluetooth with the Adafruit EZ-Key HID |
| 12 | RGBLIGHT_ENABLE = no # Enable RGB underlight | 12 | RGBLIGHT_ENABLE = no # Enable RGB underlight |
| 13 | RGBLIGHT_CUSTOM_DRIVER = no # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 14 | SLEEP_LED_ENABLE = yes | 13 | SLEEP_LED_ENABLE = yes |
| 15 | TAP_DANCE_ENABLE = yes | 14 | TAP_DANCE_ENABLE = yes |
| 16 | 15 | ||
diff --git a/keyboards/lfkeyboards/lfk78/revb/info.json b/keyboards/lfkeyboards/lfk78/revb/info.json index bee0a0305b..f4319acd16 100644 --- a/keyboards/lfkeyboards/lfk78/revb/info.json +++ b/keyboards/lfkeyboards/lfk78/revb/info.json | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | "levels": 8 | 18 | "levels": 8 |
| 19 | }, | 19 | }, |
| 20 | "rgblight": { | 20 | "rgblight": { |
| 21 | "driver": "custom", | ||
| 21 | "hue_steps": 10, | 22 | "hue_steps": 10, |
| 22 | "led_count": 31 | 23 | "led_count": 31 |
| 23 | }, | 24 | }, |
diff --git a/keyboards/lfkeyboards/lfk78/revc/info.json b/keyboards/lfkeyboards/lfk78/revc/info.json index a0f3327dda..742289e796 100644 --- a/keyboards/lfkeyboards/lfk78/revc/info.json +++ b/keyboards/lfkeyboards/lfk78/revc/info.json | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | "levels": 8 | 18 | "levels": 8 |
| 19 | }, | 19 | }, |
| 20 | "rgblight": { | 20 | "rgblight": { |
| 21 | "driver": "custom", | ||
| 21 | "hue_steps": 10, | 22 | "hue_steps": 10, |
| 22 | "led_count": 27 | 23 | "led_count": 27 |
| 23 | }, | 24 | }, |
diff --git a/keyboards/lfkeyboards/lfk78/revj/info.json b/keyboards/lfkeyboards/lfk78/revj/info.json index 3bfbcc147a..72494c71eb 100644 --- a/keyboards/lfkeyboards/lfk78/revj/info.json +++ b/keyboards/lfkeyboards/lfk78/revj/info.json | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | "levels": 8 | 18 | "levels": 8 |
| 19 | }, | 19 | }, |
| 20 | "rgblight": { | 20 | "rgblight": { |
| 21 | "driver": "custom", | ||
| 21 | "hue_steps": 10, | 22 | "hue_steps": 10, |
| 22 | "led_count": 27 | 23 | "led_count": 27 |
| 23 | }, | 24 | }, |
diff --git a/keyboards/lfkeyboards/lfk78/rules.mk b/keyboards/lfkeyboards/lfk78/rules.mk index 6c0b7f6d8d..4e3f7b9256 100644 --- a/keyboards/lfkeyboards/lfk78/rules.mk +++ b/keyboards/lfkeyboards/lfk78/rules.mk | |||
| @@ -10,7 +10,6 @@ NKRO_ENABLE = yes # Enable N-Key Rollover | |||
| 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 11 | AUDIO_ENABLE = no # Audio output | 11 | AUDIO_ENABLE = no # Audio output |
| 12 | RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. | 12 | RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. |
| 13 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lfkeyboards, not qmk base | ||
| 14 | SLEEP_LED_ENABLE = yes | 13 | SLEEP_LED_ENABLE = yes |
| 15 | 14 | ||
| 16 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 15 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/lfkeyboards/lfk87/info.json b/keyboards/lfkeyboards/lfk87/info.json index d76ee0c693..6a2d5eb796 100644 --- a/keyboards/lfkeyboards/lfk87/info.json +++ b/keyboards/lfkeyboards/lfk87/info.json | |||
| @@ -12,6 +12,9 @@ | |||
| 12 | "driver": "custom", | 12 | "driver": "custom", |
| 13 | "levels": 10 | 13 | "levels": 10 |
| 14 | }, | 14 | }, |
| 15 | "rgblight": { | ||
| 16 | "driver": "custom" | ||
| 17 | }, | ||
| 15 | "ws2812": { | 18 | "ws2812": { |
| 16 | "pin": "F4" | 19 | "pin": "F4" |
| 17 | }, | 20 | }, |
diff --git a/keyboards/lfkeyboards/lfk87/keymaps/ca178858/rules.mk b/keyboards/lfkeyboards/lfk87/keymaps/ca178858/rules.mk index ab5bc0930d..8d2c18f6dd 100644 --- a/keyboards/lfkeyboards/lfk87/keymaps/ca178858/rules.mk +++ b/keyboards/lfkeyboards/lfk87/keymaps/ca178858/rules.mk | |||
| @@ -10,7 +10,6 @@ AUDIO_ENABLE = yes # Audio output on port C6 | |||
| 10 | UNICODE_ENABLE = no # Unicode | 10 | UNICODE_ENABLE = no # Unicode |
| 11 | BLUETOOTH_ENABLE = no # Disable Bluetooth with the Adafruit EZ-Key HID | 11 | BLUETOOTH_ENABLE = no # Disable Bluetooth with the Adafruit EZ-Key HID |
| 12 | RGBLIGHT_ENABLE = yes # Enable RGB underlight | 12 | RGBLIGHT_ENABLE = yes # Enable RGB underlight |
| 13 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 14 | SLEEP_LED_ENABLE = yes | 13 | SLEEP_LED_ENABLE = yes |
| 15 | TAP_DANCE_ENABLE = yes | 14 | TAP_DANCE_ENABLE = yes |
| 16 | 15 | ||
diff --git a/keyboards/lfkeyboards/lfk87/keymaps/default/rules.mk b/keyboards/lfkeyboards/lfk87/keymaps/default/rules.mk index 9babefffc8..ec4ce1afba 100644 --- a/keyboards/lfkeyboards/lfk87/keymaps/default/rules.mk +++ b/keyboards/lfkeyboards/lfk87/keymaps/default/rules.mk | |||
| @@ -7,7 +7,6 @@ NKRO_ENABLE = yes | |||
| 7 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 7 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 8 | AUDIO_ENABLE = yes # Audio output | 8 | AUDIO_ENABLE = yes # Audio output |
| 9 | RGBLIGHT_ENABLE = yes # Enable RGB underlight | 9 | RGBLIGHT_ENABLE = yes # Enable RGB underlight |
| 10 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 11 | SLEEP_LED_ENABLE = yes | 10 | SLEEP_LED_ENABLE = yes |
| 12 | 11 | ||
| 13 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 12 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/lfkeyboards/lfk87/keymaps/gbchk/rules.mk b/keyboards/lfkeyboards/lfk87/keymaps/gbchk/rules.mk index 9a6b4ff65a..01b8506d3a 100644 --- a/keyboards/lfkeyboards/lfk87/keymaps/gbchk/rules.mk +++ b/keyboards/lfkeyboards/lfk87/keymaps/gbchk/rules.mk | |||
| @@ -10,7 +10,6 @@ AUDIO_ENABLE = yes # Audio output on port C6 | |||
| 10 | UNICODE_ENABLE = no # Unicode | 10 | UNICODE_ENABLE = no # Unicode |
| 11 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 11 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
| 12 | RGBLIGHT_ENABLE = yes # Enable RGB underlight | 12 | RGBLIGHT_ENABLE = yes # Enable RGB underlight |
| 13 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 14 | SLEEP_LED_ENABLE = yes | 13 | SLEEP_LED_ENABLE = yes |
| 15 | 14 | ||
| 16 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 15 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/lfkeyboards/lfk87/keymaps/iso/rules.mk b/keyboards/lfkeyboards/lfk87/keymaps/iso/rules.mk index 0e7008aa20..7baa40317a 100644 --- a/keyboards/lfkeyboards/lfk87/keymaps/iso/rules.mk +++ b/keyboards/lfkeyboards/lfk87/keymaps/iso/rules.mk | |||
| @@ -7,7 +7,6 @@ NKRO_ENABLE = yes | |||
| 7 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 7 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 8 | AUDIO_ENABLE = yes # Audio output | 8 | AUDIO_ENABLE = yes # Audio output |
| 9 | RGBLIGHT_ENABLE = yes # Enable RGB underlight | 9 | RGBLIGHT_ENABLE = yes # Enable RGB underlight |
| 10 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 11 | SLEEP_LED_ENABLE = yes | 10 | SLEEP_LED_ENABLE = yes |
| 12 | 11 | ||
| 13 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 12 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/lfkeyboards/lfk87/rules.mk b/keyboards/lfkeyboards/lfk87/rules.mk index 2dc08f71f6..154e03fe77 100644 --- a/keyboards/lfkeyboards/lfk87/rules.mk +++ b/keyboards/lfkeyboards/lfk87/rules.mk | |||
| @@ -11,7 +11,6 @@ NKRO_ENABLE = yes # Enable N-Key Rollover | |||
| 11 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 11 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 12 | AUDIO_ENABLE = yes # Audio output | 12 | AUDIO_ENABLE = yes # Audio output |
| 13 | RGBLIGHT_ENABLE = yes # Enable RGB underlight | 13 | RGBLIGHT_ENABLE = yes # Enable RGB underlight |
| 14 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 15 | SLEEP_LED_ENABLE = yes | 14 | SLEEP_LED_ENABLE = yes |
| 16 | 15 | ||
| 17 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 16 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/lfkeyboards/lfkpad/info.json b/keyboards/lfkeyboards/lfkpad/info.json index 5a9ee2bdaa..b1970fe28c 100644 --- a/keyboards/lfkeyboards/lfkpad/info.json +++ b/keyboards/lfkeyboards/lfkpad/info.json | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | "device_version": "0.0.1" | 9 | "device_version": "0.0.1" |
| 10 | }, | 10 | }, |
| 11 | "rgblight": { | 11 | "rgblight": { |
| 12 | "driver": "custom", | ||
| 12 | "hue_steps": 10, | 13 | "hue_steps": 10, |
| 13 | "led_count": 28 | 14 | "led_count": 28 |
| 14 | }, | 15 | }, |
diff --git a/keyboards/lfkeyboards/lfkpad/rules.mk b/keyboards/lfkeyboards/lfkpad/rules.mk index b60f4b532f..ec8efa88bf 100644 --- a/keyboards/lfkeyboards/lfkpad/rules.mk +++ b/keyboards/lfkeyboards/lfkpad/rules.mk | |||
| @@ -9,7 +9,6 @@ COMMAND_ENABLE = no # Commands for debug and configuration | |||
| 9 | NKRO_ENABLE = no # Enable N-Key Rollover | 9 | NKRO_ENABLE = no # Enable N-Key Rollover |
| 10 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | 10 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality |
| 11 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 11 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
| 12 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lfkeyboards, not qmk base | ||
| 13 | AUDIO_ENABLE = no # Audio output | 12 | AUDIO_ENABLE = no # Audio output |
| 14 | SLEEP_LED_ENABLE = yes | 13 | SLEEP_LED_ENABLE = yes |
| 15 | 14 | ||
diff --git a/keyboards/lfkeyboards/mini1800/info.json b/keyboards/lfkeyboards/mini1800/info.json index 5d877ea6fd..019789bee0 100644 --- a/keyboards/lfkeyboards/mini1800/info.json +++ b/keyboards/lfkeyboards/mini1800/info.json | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | "levels": 10 | 18 | "levels": 10 |
| 19 | }, | 19 | }, |
| 20 | "rgblight": { | 20 | "rgblight": { |
| 21 | "driver": "custom", | ||
| 21 | "hue_steps": 10, | 22 | "hue_steps": 10, |
| 22 | "led_count": 26 | 23 | "led_count": 26 |
| 23 | }, | 24 | }, |
diff --git a/keyboards/lfkeyboards/mini1800/reva/rules.mk b/keyboards/lfkeyboards/mini1800/reva/rules.mk index edd26e498d..473bcb10ae 100644 --- a/keyboards/lfkeyboards/mini1800/reva/rules.mk +++ b/keyboards/lfkeyboards/mini1800/reva/rules.mk | |||
| @@ -10,9 +10,6 @@ NKRO_ENABLE = yes # Enable N-Key Rollover | |||
| 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 11 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 11 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
| 12 | AUDIO_ENABLE = yes # Audio output | 12 | AUDIO_ENABLE = yes # Audio output |
| 13 | |||
| 14 | # RGB code is implemented in lfkeyboards, not WS2812 | ||
| 15 | RGBLIGHT_CUSTOM_DRIVER = yes | ||
| 16 | SLEEP_LED_ENABLE = yes | 13 | SLEEP_LED_ENABLE = yes |
| 17 | 14 | ||
| 18 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 15 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/lfkeyboards/mini1800/revc/rules.mk b/keyboards/lfkeyboards/mini1800/revc/rules.mk index edd26e498d..473bcb10ae 100644 --- a/keyboards/lfkeyboards/mini1800/revc/rules.mk +++ b/keyboards/lfkeyboards/mini1800/revc/rules.mk | |||
| @@ -10,9 +10,6 @@ NKRO_ENABLE = yes # Enable N-Key Rollover | |||
| 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 11 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 11 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
| 12 | AUDIO_ENABLE = yes # Audio output | 12 | AUDIO_ENABLE = yes # Audio output |
| 13 | |||
| 14 | # RGB code is implemented in lfkeyboards, not WS2812 | ||
| 15 | RGBLIGHT_CUSTOM_DRIVER = yes | ||
| 16 | SLEEP_LED_ENABLE = yes | 13 | SLEEP_LED_ENABLE = yes |
| 17 | 14 | ||
| 18 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled | 15 | ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled |
diff --git a/keyboards/lfkeyboards/smk65/revb/info.json b/keyboards/lfkeyboards/smk65/revb/info.json index 85c853cba0..3f92ea3b27 100644 --- a/keyboards/lfkeyboards/smk65/revb/info.json +++ b/keyboards/lfkeyboards/smk65/revb/info.json | |||
| @@ -6,6 +6,7 @@ | |||
| 6 | "levels": 8 | 6 | "levels": 8 |
| 7 | }, | 7 | }, |
| 8 | "rgblight": { | 8 | "rgblight": { |
| 9 | "driver": "custom", | ||
| 9 | "hue_steps": 10, | 10 | "hue_steps": 10, |
| 10 | "led_count": 20 | 11 | "led_count": 20 |
| 11 | }, | 12 | }, |
diff --git a/keyboards/lfkeyboards/smk65/revb/rules.mk b/keyboards/lfkeyboards/smk65/revb/rules.mk index 57bf01d4cf..1bd6ebc6a6 100644 --- a/keyboards/lfkeyboards/smk65/revb/rules.mk +++ b/keyboards/lfkeyboards/smk65/revb/rules.mk | |||
| @@ -3,7 +3,6 @@ | |||
| 3 | # | 3 | # |
| 4 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | 4 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality |
| 5 | RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow | 5 | RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow |
| 6 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
| 7 | AUDIO_ENABLE = no # Audio output | 6 | AUDIO_ENABLE = no # Audio output |
| 8 | 7 | ||
| 9 | # Extra source files for IS3731 lighting | 8 | # Extra source files for IS3731 lighting |
diff --git a/keyboards/lfkeyboards/smk65/revf/info.json b/keyboards/lfkeyboards/smk65/revf/info.json index 086e7e38c8..50c039b76c 100644 --- a/keyboards/lfkeyboards/smk65/revf/info.json +++ b/keyboards/lfkeyboards/smk65/revf/info.json | |||
| @@ -5,6 +5,7 @@ | |||
| 5 | "processor": "atmega32u4", | 5 | "processor": "atmega32u4", |
| 6 | "bootloader": "halfkay", | 6 | "bootloader": "halfkay", |
| 7 | "rgblight": { | 7 | "rgblight": { |
| 8 | "driver": "custom", | ||
| 8 | "led_count": 28 | 9 | "led_count": 28 |
| 9 | }, | 10 | }, |
| 10 | "layouts": { | 11 | "layouts": { |
diff --git a/keyboards/lfkeyboards/smk65/revf/rules.mk b/keyboards/lfkeyboards/smk65/revf/rules.mk index 2545747959..e372473a50 100644 --- a/keyboards/lfkeyboards/smk65/revf/rules.mk +++ b/keyboards/lfkeyboards/smk65/revf/rules.mk | |||
| @@ -2,4 +2,3 @@ | |||
| 2 | # change yes to no to disable | 2 | # change yes to no to disable |
| 3 | # | 3 | # |
| 4 | RGBLIGHT_ENABLE = no # TODO: Enable keyboard RGB underglow | 4 | RGBLIGHT_ENABLE = no # TODO: Enable keyboard RGB underglow |
| 5 | RGBLIGHT_CUSTOM_DRIVER = yes # RGB code is implemented in lefkeyboards, not WS2812 | ||
diff --git a/keyboards/matrix/noah/info.json b/keyboards/matrix/noah/info.json index 67c5fe0221..4550f7d70a 100644 --- a/keyboards/matrix/noah/info.json +++ b/keyboards/matrix/noah/info.json | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | "device_version": "0.0.1" | 9 | "device_version": "0.0.1" |
| 10 | }, | 10 | }, |
| 11 | "rgblight": { | 11 | "rgblight": { |
| 12 | "driver": "custom", | ||
| 12 | "led_count": 7 | 13 | "led_count": 7 |
| 13 | }, | 14 | }, |
| 14 | "ws2812": { | 15 | "ws2812": { |
diff --git a/keyboards/matrix/noah/rules.mk b/keyboards/matrix/noah/rules.mk index 55ea2f42b0..3b75264222 100644 --- a/keyboards/matrix/noah/rules.mk +++ b/keyboards/matrix/noah/rules.mk | |||
| @@ -27,7 +27,6 @@ NO_USB_STARTUP_CHECK = yes # Disable initialization only when usb is plugged in | |||
| 27 | RGB_MATRIX_ENABLE = yes | 27 | RGB_MATRIX_ENABLE = yes |
| 28 | 28 | ||
| 29 | RGBLIGHT_ENABLE = yes | 29 | RGBLIGHT_ENABLE = yes |
| 30 | RGBLIGHT_CUSTOM_DRIVER = yes | ||
| 31 | WS2812_DRIVER_REQUIRED = yes | 30 | WS2812_DRIVER_REQUIRED = yes |
| 32 | 31 | ||
| 33 | CUSTOM_MATRIX = yes | 32 | CUSTOM_MATRIX = yes |
diff --git a/keyboards/pearl/keymaps/cijanzen/rules.mk b/keyboards/pearl/keymaps/cijanzen/rules.mk index c800dc98f8..900468e149 100644 --- a/keyboards/pearl/keymaps/cijanzen/rules.mk +++ b/keyboards/pearl/keymaps/cijanzen/rules.mk | |||
| @@ -6,6 +6,5 @@ CONSOLE_ENABLE = no | |||
| 6 | COMMAND_ENABLE = yes | 6 | COMMAND_ENABLE = yes |
| 7 | BACKLIGHT_ENABLE = yes | 7 | BACKLIGHT_ENABLE = yes |
| 8 | RGBLIGHT_ENABLE = yes | 8 | RGBLIGHT_ENABLE = yes |
| 9 | RGBLIGHT_CUSTOM_DRIVER = yes | ||
| 10 | # TAP_DANCE_ENABLE = yes | 9 | # TAP_DANCE_ENABLE = yes |
| 11 | AUTO_SHIFT_ENABLE = yes | 10 | AUTO_SHIFT_ENABLE = yes |
diff --git a/keyboards/prototypist/oceanographer/rules.mk b/keyboards/prototypist/oceanographer/rules.mk index 5f37eac2f6..e18a6cecee 100644 --- a/keyboards/prototypist/oceanographer/rules.mk +++ b/keyboards/prototypist/oceanographer/rules.mk | |||
| @@ -2,5 +2,4 @@ OLED_ENABLE = yes | |||
| 2 | AUDIO_ENABLE = yes | 2 | AUDIO_ENABLE = yes |
| 3 | LTO_ENABLE = yes | 3 | LTO_ENABLE = yes |
| 4 | RGBLIGHT_ENABLE = yes | 4 | RGBLIGHT_ENABLE = yes |
| 5 | RGBLIGHT_DRIVER = WS2812 | ||
| 6 | ENCODER_ENABLE = yes | 5 | ENCODER_ENABLE = yes |
diff --git a/keyboards/v60_type_r/info.json b/keyboards/v60_type_r/info.json index 760a4f7356..1d7c104f4f 100644 --- a/keyboards/v60_type_r/info.json +++ b/keyboards/v60_type_r/info.json | |||
| @@ -19,6 +19,7 @@ | |||
| 19 | "on_state": 0 | 19 | "on_state": 0 |
| 20 | }, | 20 | }, |
| 21 | "rgblight": { | 21 | "rgblight": { |
| 22 | "driver": "custom", | ||
| 22 | "led_count": 1 | 23 | "led_count": 1 |
| 23 | }, | 24 | }, |
| 24 | "processor": "atmega32u4", | 25 | "processor": "atmega32u4", |
diff --git a/keyboards/v60_type_r/keymaps/ifohancroft/readme.md b/keyboards/v60_type_r/keymaps/ifohancroft/readme.md index b2d2249081..c8106ae0cd 100644 --- a/keyboards/v60_type_r/keymaps/ifohancroft/readme.md +++ b/keyboards/v60_type_r/keymaps/ifohancroft/readme.md | |||
| @@ -7,7 +7,7 @@ | |||
| 7 | - Layer 3: An empty layer in-case I need something on-the-fly so I can remap with VIA. | 7 | - Layer 3: An empty layer in-case I need something on-the-fly so I can remap with VIA. |
| 8 | - Layer 4: An empty layer in-case I need something on-the-fly so I can remap with VIA. | 8 | - Layer 4: An empty layer in-case I need something on-the-fly so I can remap with VIA. |
| 9 | 9 | ||
| 10 | This keymap also sets the polling rate of the keyboard to 1ms, disables the MOUSEKEY, EXTRAKEY, BACKLIGHT, RGBLIGHT and RGBLIGHT_CUSTOM_DRIVER features, and enables the following features: | 10 | This keymap also sets the polling rate of the keyboard to 1ms, disables the MOUSEKEY, EXTRAKEY, BACKLIGHT, and RGBLIGHT features, and enables the following features: |
| 11 | 11 | ||
| 12 | - NKRO (forced on) | 12 | - NKRO (forced on) |
| 13 | - VIA | 13 | - VIA |
diff --git a/keyboards/v60_type_r/keymaps/ifohancroft/rules.mk b/keyboards/v60_type_r/keymaps/ifohancroft/rules.mk index b7d5bb5198..03be782d45 100644 --- a/keyboards/v60_type_r/keymaps/ifohancroft/rules.mk +++ b/keyboards/v60_type_r/keymaps/ifohancroft/rules.mk | |||
| @@ -2,6 +2,5 @@ MOUSEKEY_ENABLE = no | |||
| 2 | EXTRAKEY_ENABLE = no | 2 | EXTRAKEY_ENABLE = no |
| 3 | BACKLIGHT_ENABLE = no | 3 | BACKLIGHT_ENABLE = no |
| 4 | RGBLIGHT_ENABLE = no | 4 | RGBLIGHT_ENABLE = no |
| 5 | RGBLIGHT_CUSTOM_DRIVER = no | ||
| 6 | NKRO_ENABLE = yes | 5 | NKRO_ENABLE = yes |
| 7 | VIA_ENABLE = yes \ No newline at end of file | 6 | VIA_ENABLE = yes \ No newline at end of file |
diff --git a/keyboards/v60_type_r/rules.mk b/keyboards/v60_type_r/rules.mk index 77b555c20c..d6654ffea6 100644 --- a/keyboards/v60_type_r/rules.mk +++ b/keyboards/v60_type_r/rules.mk | |||
| @@ -9,7 +9,6 @@ COMMAND_ENABLE = yes # Commands for debug and configuration | |||
| 9 | NKRO_ENABLE = no # Enable N-Key Rollover | 9 | NKRO_ENABLE = no # Enable N-Key Rollover |
| 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 10 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 11 | RGBLIGHT_ENABLE = yes # Enable the RGB Underglow | 11 | RGBLIGHT_ENABLE = yes # Enable the RGB Underglow |
| 12 | RGBLIGHT_CUSTOM_DRIVER = yes | ||
| 13 | AUDIO_ENABLE = no # Audio output | 12 | AUDIO_ENABLE = no # Audio output |
| 14 | 13 | ||
| 15 | LTO_ENABLE = yes | 14 | LTO_ENABLE = yes |
diff --git a/keyboards/yandrstudio/buff67v3/rules.mk b/keyboards/yandrstudio/buff67v3/rules.mk index 663aac2420..421ae9fce1 100644 --- a/keyboards/yandrstudio/buff67v3/rules.mk +++ b/keyboards/yandrstudio/buff67v3/rules.mk | |||
| @@ -12,5 +12,4 @@ COMMAND_ENABLE = no # Commands for debug and configuration | |||
| 12 | NKRO_ENABLE = yes # Enable N-Key Rollover | 12 | NKRO_ENABLE = yes # Enable N-Key Rollover |
| 13 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | 13 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality |
| 14 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 14 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
| 15 | RGBLIGHT_DRIVER = WS2812 # RGB driver support | ||
| 16 | AUDIO_ENABLE = no # Audio output | 15 | AUDIO_ENABLE = no # Audio output |
diff --git a/layouts/community/60_iso/unxmaal/rules.mk b/layouts/community/60_iso/unxmaal/rules.mk index c2d3c6b075..5c9eb2a26d 100644 --- a/layouts/community/60_iso/unxmaal/rules.mk +++ b/layouts/community/60_iso/unxmaal/rules.mk | |||
| @@ -1,7 +1,7 @@ | |||
| 1 | # Only enable RGBLIGHT on avr boards | 1 | # Only enable RGBLIGHT on avr boards |
| 2 | ifeq ($(strip $(PLATFORM_KEY)),avr) | 2 | ifeq ($(strip $(PLATFORM_KEY)),avr) |
| 3 | # ...that are at least prepared for it | 3 | # ...that are at least prepared for it |
| 4 | ifdef RGBLIGHT_DRIVER | 4 | ifeq ($(strip $(RGBLIGHT_SUPPORTED)),yes) |
| 5 | RGBLIGHT_ENABLE = yes # Enable RGB Underglow | 5 | RGBLIGHT_ENABLE = yes # Enable RGB Underglow |
| 6 | endif | 6 | endif |
| 7 | endif | 7 | endif |
