diff options
| author | Joel Challis <git@zvecr.com> | 2022-02-10 17:45:51 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-10 09:45:51 -0800 |
| commit | f7e7671f691cfd42f322198f04690727f6493d73 (patch) | |
| tree | 9c705a6a1a594263ab273cba62affa3fa7e5d28e | |
| parent | 7a0fd646e37795aa843d369a5c80d99118cca868 (diff) | |
Migrate more makefile utilities to builddefs sub-directory (#16002)
| -rw-r--r-- | Makefile | 6 | ||||
| -rw-r--r-- | builddefs/build_full_test.mk (renamed from build_full_test.mk) | 0 | ||||
| -rw-r--r-- | builddefs/build_json.mk (renamed from build_json.mk) | 0 | ||||
| -rw-r--r-- | builddefs/build_keyboard.mk (renamed from build_keyboard.mk) | 8 | ||||
| -rw-r--r-- | builddefs/build_layout.mk (renamed from build_layout.mk) | 0 | ||||
| -rw-r--r-- | builddefs/build_test.mk (renamed from build_test.mk) | 6 | ||||
| -rw-r--r-- | builddefs/common_features.mk (renamed from common_features.mk) | 0 | ||||
| -rw-r--r-- | builddefs/common_rules.mk (renamed from tmk_core/rules.mk) | 0 | ||||
| -rw-r--r-- | builddefs/testlist.mk (renamed from testlist.mk) | 0 | ||||
| -rwxr-xr-x | lib/python/qmk/cli/multibuild.py | 2 | ||||
| -rw-r--r-- | lib/python/qmk/commands.py | 2 | ||||
| -rw-r--r-- | paths.mk | 4 |
12 files changed, 15 insertions, 13 deletions
| @@ -275,7 +275,7 @@ define PARSE_KEYMAP | |||
| 275 | # Specify the variables that we are passing forward to submake | 275 | # Specify the variables that we are passing forward to submake |
| 276 | MAKE_VARS := KEYBOARD=$$(CURRENT_KB) KEYMAP=$$(CURRENT_KM) REQUIRE_PLATFORM_KEY=$$(REQUIRE_PLATFORM_KEY) QMK_BIN=$$(QMK_BIN) | 276 | MAKE_VARS := KEYBOARD=$$(CURRENT_KB) KEYMAP=$$(CURRENT_KM) REQUIRE_PLATFORM_KEY=$$(REQUIRE_PLATFORM_KEY) QMK_BIN=$$(QMK_BIN) |
| 277 | # And the first part of the make command | 277 | # And the first part of the make command |
| 278 | MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f build_keyboard.mk $$(MAKE_TARGET) | 278 | MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f $(BUILDDEFS_PATH)/build_keyboard.mk $$(MAKE_TARGET) |
| 279 | # The message to display | 279 | # The message to display |
| 280 | MAKE_MSG := $$(MSG_MAKE_KB) | 280 | MAKE_MSG := $$(MSG_MAKE_KB) |
| 281 | # We run the command differently, depending on if we want more output or not | 281 | # We run the command differently, depending on if we want more output or not |
| @@ -317,7 +317,7 @@ define BUILD_TEST | |||
| 317 | TEST_NAME := $$(notdir $$(TEST_PATH)) | 317 | TEST_NAME := $$(notdir $$(TEST_PATH)) |
| 318 | MAKE_TARGET := $2 | 318 | MAKE_TARGET := $2 |
| 319 | COMMAND := $1 | 319 | COMMAND := $1 |
| 320 | MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f build_test.mk $$(MAKE_TARGET) | 320 | MAKE_CMD := $$(MAKE) -r -R -C $(ROOT_DIR) -f $(BUILDDEFS_PATH)/build_test.mk $$(MAKE_TARGET) |
| 321 | MAKE_VARS := TEST=$$(TEST_NAME) TEST_PATH=$$(TEST_PATH) FULL_TESTS="$$(FULL_TESTS)" | 321 | MAKE_VARS := TEST=$$(TEST_NAME) TEST_PATH=$$(TEST_PATH) FULL_TESTS="$$(FULL_TESTS)" |
| 322 | MAKE_MSG := $$(MSG_MAKE_TEST) | 322 | MAKE_MSG := $$(MSG_MAKE_TEST) |
| 323 | $$(eval $$(call BUILD)) | 323 | $$(eval $$(call BUILD)) |
| @@ -339,7 +339,7 @@ define PARSE_TEST | |||
| 339 | TESTS := | 339 | TESTS := |
| 340 | TEST_NAME := $$(firstword $$(subst :, ,$$(RULE))) | 340 | TEST_NAME := $$(firstword $$(subst :, ,$$(RULE))) |
| 341 | TEST_TARGET := $$(subst $$(TEST_NAME),,$$(subst $$(TEST_NAME):,,$$(RULE))) | 341 | TEST_TARGET := $$(subst $$(TEST_NAME),,$$(subst $$(TEST_NAME):,,$$(RULE))) |
| 342 | include $(ROOT_DIR)/testlist.mk | 342 | include $(BUILDDEFS_PATH)/testlist.mk |
| 343 | ifeq ($$(TEST_NAME),all) | 343 | ifeq ($$(TEST_NAME),all) |
| 344 | MATCHED_TESTS := $$(TEST_LIST) | 344 | MATCHED_TESTS := $$(TEST_LIST) |
| 345 | else | 345 | else |
diff --git a/build_full_test.mk b/builddefs/build_full_test.mk index 4e4b4e4bfd..4e4b4e4bfd 100644 --- a/build_full_test.mk +++ b/builddefs/build_full_test.mk | |||
diff --git a/build_json.mk b/builddefs/build_json.mk index 0c034eb2ae..0c034eb2ae 100644 --- a/build_json.mk +++ b/builddefs/build_json.mk | |||
diff --git a/build_keyboard.mk b/builddefs/build_keyboard.mk index f727760465..d5efcb4193 100644 --- a/build_keyboard.mk +++ b/builddefs/build_keyboard.mk | |||
| @@ -111,7 +111,7 @@ INFO_RULES_MK = $(shell $(QMK_BIN) generate-rules-mk --quiet --escape --keyboard | |||
| 111 | include $(INFO_RULES_MK) | 111 | include $(INFO_RULES_MK) |
| 112 | 112 | ||
| 113 | # Check for keymap.json first, so we can regenerate keymap.c | 113 | # Check for keymap.json first, so we can regenerate keymap.c |
| 114 | include build_json.mk | 114 | include $(BUILDDEFS_PATH)/build_json.mk |
| 115 | 115 | ||
| 116 | # Pull in keymap level rules.mk | 116 | # Pull in keymap level rules.mk |
| 117 | ifeq ("$(wildcard $(KEYMAP_PATH))", "") | 117 | ifeq ("$(wildcard $(KEYMAP_PATH))", "") |
| @@ -138,7 +138,7 @@ ifeq ("$(wildcard $(KEYMAP_PATH))", "") | |||
| 138 | KEYMAP_PATH := $(MAIN_KEYMAP_PATH_1) | 138 | KEYMAP_PATH := $(MAIN_KEYMAP_PATH_1) |
| 139 | else ifneq ($(LAYOUTS),) | 139 | else ifneq ($(LAYOUTS),) |
| 140 | # If we haven't found a keymap yet fall back to community layouts | 140 | # If we haven't found a keymap yet fall back to community layouts |
| 141 | include build_layout.mk | 141 | include $(BUILDDEFS_PATH)/build_layout.mk |
| 142 | else | 142 | else |
| 143 | $(call CATASTROPHIC_ERROR,Invalid keymap,Could not find keymap) | 143 | $(call CATASTROPHIC_ERROR,Invalid keymap,Could not find keymap) |
| 144 | # this state should never be reached | 144 | # this state should never be reached |
| @@ -398,7 +398,7 @@ VPATH += $(COMMON_VPATH) | |||
| 398 | VPATH += $(KEYBOARD_OUTPUT)/src | 398 | VPATH += $(KEYBOARD_OUTPUT)/src |
| 399 | VPATH += $(KEYMAP_OUTPUT)/src | 399 | VPATH += $(KEYMAP_OUTPUT)/src |
| 400 | 400 | ||
| 401 | include common_features.mk | 401 | include $(BUILDDEFS_PATH)/common_features.mk |
| 402 | include $(BUILDDEFS_PATH)/generic_features.mk | 402 | include $(BUILDDEFS_PATH)/generic_features.mk |
| 403 | include $(TMK_PATH)/protocol.mk | 403 | include $(TMK_PATH)/protocol.mk |
| 404 | include $(PLATFORM_PATH)/common.mk | 404 | include $(PLATFORM_PATH)/common.mk |
| @@ -460,7 +460,7 @@ check-md5: build | |||
| 460 | objs-size: build | 460 | objs-size: build |
| 461 | 461 | ||
| 462 | include $(BUILDDEFS_PATH)/show_options.mk | 462 | include $(BUILDDEFS_PATH)/show_options.mk |
| 463 | include $(TMK_PATH)/rules.mk | 463 | include $(BUILDDEFS_PATH)/common_rules.mk |
| 464 | 464 | ||
| 465 | # Ensure we have generated files available for each of the objects | 465 | # Ensure we have generated files available for each of the objects |
| 466 | define GEN_FILES | 466 | define GEN_FILES |
diff --git a/build_layout.mk b/builddefs/build_layout.mk index 6166bd847c..6166bd847c 100644 --- a/build_layout.mk +++ b/builddefs/build_layout.mk | |||
diff --git a/build_test.mk b/builddefs/build_test.mk index ec6699b4ea..7226004aab 100644 --- a/build_test.mk +++ b/builddefs/build_test.mk | |||
| @@ -54,7 +54,7 @@ include tests/test_common/build.mk | |||
| 54 | include $(TEST_PATH)/test.mk | 54 | include $(TEST_PATH)/test.mk |
| 55 | endif | 55 | endif |
| 56 | 56 | ||
| 57 | include common_features.mk | 57 | include $(BUILDDEFS_PATH)/common_features.mk |
| 58 | include $(BUILDDEFS_PATH)/generic_features.mk | 58 | include $(BUILDDEFS_PATH)/generic_features.mk |
| 59 | include $(PLATFORM_PATH)/common.mk | 59 | include $(PLATFORM_PATH)/common.mk |
| 60 | include $(TMK_PATH)/protocol.mk | 60 | include $(TMK_PATH)/protocol.mk |
| @@ -63,7 +63,7 @@ include $(QUANTUM_PATH)/encoder/tests/rules.mk | |||
| 63 | include $(QUANTUM_PATH)/sequencer/tests/rules.mk | 63 | include $(QUANTUM_PATH)/sequencer/tests/rules.mk |
| 64 | include $(PLATFORM_PATH)/test/rules.mk | 64 | include $(PLATFORM_PATH)/test/rules.mk |
| 65 | ifneq ($(filter $(FULL_TESTS),$(TEST)),) | 65 | ifneq ($(filter $(FULL_TESTS),$(TEST)),) |
| 66 | include build_full_test.mk | 66 | include $(BUILDDEFS_PATH)/build_full_test.mk |
| 67 | endif | 67 | endif |
| 68 | 68 | ||
| 69 | $(TEST)_SRC += \ | 69 | $(TEST)_SRC += \ |
| @@ -77,7 +77,7 @@ $(TEST_OBJ)/$(TEST)_DEFS := $($(TEST)_DEFS) | |||
| 77 | $(TEST_OBJ)/$(TEST)_CONFIG := $($(TEST)_CONFIG) | 77 | $(TEST_OBJ)/$(TEST)_CONFIG := $($(TEST)_CONFIG) |
| 78 | 78 | ||
| 79 | include $(PLATFORM_PATH)/$(PLATFORM_KEY)/platform.mk | 79 | include $(PLATFORM_PATH)/$(PLATFORM_KEY)/platform.mk |
| 80 | include $(TMK_PATH)/rules.mk | 80 | include $(BUILDDEFS_PATH)/common_rules.mk |
| 81 | 81 | ||
| 82 | 82 | ||
| 83 | $(shell mkdir -p $(BUILD_DIR)/test 2>/dev/null) | 83 | $(shell mkdir -p $(BUILD_DIR)/test 2>/dev/null) |
diff --git a/common_features.mk b/builddefs/common_features.mk index 7ff19e8084..7ff19e8084 100644 --- a/common_features.mk +++ b/builddefs/common_features.mk | |||
diff --git a/tmk_core/rules.mk b/builddefs/common_rules.mk index b303a87919..b303a87919 100644 --- a/tmk_core/rules.mk +++ b/builddefs/common_rules.mk | |||
diff --git a/testlist.mk b/builddefs/testlist.mk index 86da5668ac..86da5668ac 100644 --- a/testlist.mk +++ b/builddefs/testlist.mk | |||
diff --git a/lib/python/qmk/cli/multibuild.py b/lib/python/qmk/cli/multibuild.py index ad059edff3..dff8c88422 100755 --- a/lib/python/qmk/cli/multibuild.py +++ b/lib/python/qmk/cli/multibuild.py | |||
| @@ -69,7 +69,7 @@ def multibuild(cli): | |||
| 69 | all: {keyboard_safe}_binary | 69 | all: {keyboard_safe}_binary |
| 70 | {keyboard_safe}_binary: | 70 | {keyboard_safe}_binary: |
| 71 | @rm -f "{QMK_FIRMWARE}/.build/failed.log.{keyboard_safe}" || true | 71 | @rm -f "{QMK_FIRMWARE}/.build/failed.log.{keyboard_safe}" || true |
| 72 | +@$(MAKE) -C "{QMK_FIRMWARE}" -f "{QMK_FIRMWARE}/build_keyboard.mk" KEYBOARD="{keyboard_name}" KEYMAP="{cli.args.keymap}" REQUIRE_PLATFORM_KEY= COLOR=true SILENT=false {' '.join(cli.args.env)} \\ | 72 | +@$(MAKE) -C "{QMK_FIRMWARE}" -f "{QMK_FIRMWARE}/builddefs/build_keyboard.mk" KEYBOARD="{keyboard_name}" KEYMAP="{cli.args.keymap}" REQUIRE_PLATFORM_KEY= COLOR=true SILENT=false {' '.join(cli.args.env)} \\ |
| 73 | >>"{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" 2>&1 \\ | 73 | >>"{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" 2>&1 \\ |
| 74 | || cp "{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" "{QMK_FIRMWARE}/.build/failed.log.{os.getpid()}.{keyboard_safe}" | 74 | || cp "{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" "{QMK_FIRMWARE}/.build/failed.log.{os.getpid()}.{keyboard_safe}" |
| 75 | @{{ grep '\[ERRORS\]' "{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" >/dev/null 2>&1 && printf "Build %-64s \e[1;31m[ERRORS]\e[0m\\n" "{keyboard_name}:{cli.args.keymap}" ; }} \\ | 75 | @{{ grep '\[ERRORS\]' "{QMK_FIRMWARE}/.build/build.log.{os.getpid()}.{keyboard_safe}" >/dev/null 2>&1 && printf "Build %-64s \e[1;31m[ERRORS]\e[0m\\n" "{keyboard_name}:{cli.args.keymap}" ; }} \\ |
diff --git a/lib/python/qmk/commands.py b/lib/python/qmk/commands.py index 90a68ca3cd..275cd72e5c 100644 --- a/lib/python/qmk/commands.py +++ b/lib/python/qmk/commands.py | |||
| @@ -213,7 +213,7 @@ def compile_configurator_json(user_keymap, bootloader=None, parallel=1, **env_va | |||
| 213 | '-r', | 213 | '-r', |
| 214 | '-R', | 214 | '-R', |
| 215 | '-f', | 215 | '-f', |
| 216 | 'build_keyboard.mk', | 216 | 'builddefs/build_keyboard.mk', |
| 217 | ]) | 217 | ]) |
| 218 | 218 | ||
| 219 | if bootloader: | 219 | if bootloader: |
| @@ -2,7 +2,9 @@ | |||
| 2 | TOP_DIR = . | 2 | TOP_DIR = . |
| 3 | TMK_DIR = tmk_core | 3 | TMK_DIR = tmk_core |
| 4 | TMK_PATH = $(TMK_DIR) | 4 | TMK_PATH = $(TMK_DIR) |
| 5 | LIB_PATH = lib | 5 | |
| 6 | LIB_DIR = lib | ||
| 7 | LIB_PATH = $(LIB_DIR) | ||
| 6 | 8 | ||
| 7 | QUANTUM_DIR = quantum | 9 | QUANTUM_DIR = quantum |
| 8 | QUANTUM_PATH = $(QUANTUM_DIR) | 10 | QUANTUM_PATH = $(QUANTUM_DIR) |
