diff options
| author | precondition <57645186+precondition@users.noreply.github.com> | 2022-02-11 20:53:26 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-11 19:53:26 +0000 |
| commit | 7148a69d5ea7d75119c81cf9b7c579f3136c4fd3 (patch) | |
| tree | 4a7172b6e068ff7f162ee311b0d64583dbb0a4c7 /quantum/action_tapping.c | |
| parent | 39bec3bfa5ff63ee99f0fd15293967fd8655a154 (diff) | |
Pass in the keyrecord_t of the dual-role/tapping key when calling per-key tap hold functions (#15938)
* Replace keyp by &tapping_key in the record arg of per-key tap hold funcs
* Replace NULL by &(keyrecord_t){} in 2nd arg of get_tapping_term
Diffstat (limited to 'quantum/action_tapping.c')
| -rw-r--r-- | quantum/action_tapping.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/quantum/action_tapping.c b/quantum/action_tapping.c index d2c93f85e3..4ba38bee8d 100644 --- a/quantum/action_tapping.c +++ b/quantum/action_tapping.c | |||
| @@ -124,7 +124,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 124 | # if defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT) | 124 | # if defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT) |
| 125 | || ( | 125 | || ( |
| 126 | # ifdef RETRO_TAPPING_PER_KEY | 126 | # ifdef RETRO_TAPPING_PER_KEY |
| 127 | get_retro_tapping(tapping_keycode, keyp) && | 127 | get_retro_tapping(tapping_keycode, &tapping_key) && |
| 128 | # endif | 128 | # endif |
| 129 | (RETRO_SHIFT + 0) != 0 && TIMER_DIFF_16(event.time, tapping_key.event.time) < (RETRO_SHIFT + 0) | 129 | (RETRO_SHIFT + 0) != 0 && TIMER_DIFF_16(event.time, tapping_key.event.time) < (RETRO_SHIFT + 0) |
| 130 | ) | 130 | ) |
| @@ -158,7 +158,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 158 | ( | 158 | ( |
| 159 | ( | 159 | ( |
| 160 | # ifdef TAPPING_TERM_PER_KEY | 160 | # ifdef TAPPING_TERM_PER_KEY |
| 161 | get_tapping_term(tapping_keycode, keyp) | 161 | get_tapping_term(tapping_keycode, &tapping_key) |
| 162 | # else | 162 | # else |
| 163 | g_tapping_term | 163 | g_tapping_term |
| 164 | # endif | 164 | # endif |
| @@ -166,7 +166,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 166 | ) | 166 | ) |
| 167 | 167 | ||
| 168 | # ifdef PERMISSIVE_HOLD_PER_KEY | 168 | # ifdef PERMISSIVE_HOLD_PER_KEY |
| 169 | || get_permissive_hold(tapping_keycode, keyp) | 169 | || get_permissive_hold(tapping_keycode, &tapping_key) |
| 170 | # elif defined(PERMISSIVE_HOLD) | 170 | # elif defined(PERMISSIVE_HOLD) |
| 171 | || true | 171 | || true |
| 172 | # endif | 172 | # endif |
| @@ -177,7 +177,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 177 | # if defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT) | 177 | # if defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT) |
| 178 | || ( | 178 | || ( |
| 179 | # ifdef RETRO_TAPPING_PER_KEY | 179 | # ifdef RETRO_TAPPING_PER_KEY |
| 180 | get_retro_tapping(tapping_keycode, keyp) && | 180 | get_retro_tapping(tapping_keycode, &tapping_key) && |
| 181 | # endif | 181 | # endif |
| 182 | ( | 182 | ( |
| 183 | // Rolled over the two keys. | 183 | // Rolled over the two keys. |
| @@ -188,7 +188,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 188 | || ( | 188 | || ( |
| 189 | IS_LT(tapping_keycode) | 189 | IS_LT(tapping_keycode) |
| 190 | # ifdef HOLD_ON_OTHER_KEY_PRESS_PER_KEY | 190 | # ifdef HOLD_ON_OTHER_KEY_PRESS_PER_KEY |
| 191 | && get_hold_on_other_key_press(tapping_keycode, keyp) | 191 | && get_hold_on_other_key_press(tapping_keycode, &tapping_key) |
| 192 | # endif | 192 | # endif |
| 193 | ) | 193 | ) |
| 194 | # endif | 194 | # endif |
| @@ -196,7 +196,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 196 | || ( | 196 | || ( |
| 197 | IS_MT(tapping_keycode) | 197 | IS_MT(tapping_keycode) |
| 198 | # ifdef IGNORE_MOD_TAP_INTERRUPT_PER_KEY | 198 | # ifdef IGNORE_MOD_TAP_INTERRUPT_PER_KEY |
| 199 | && !get_ignore_mod_tap_interrupt(tapping_keycode, keyp) | 199 | && !get_ignore_mod_tap_interrupt(tapping_keycode, &tapping_key) |
| 200 | # endif | 200 | # endif |
| 201 | ) | 201 | ) |
| 202 | # endif | 202 | # endif |
| @@ -252,7 +252,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 252 | tapping_key.tap.interrupted = true; | 252 | tapping_key.tap.interrupted = true; |
| 253 | # if defined(HOLD_ON_OTHER_KEY_PRESS) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY) | 253 | # if defined(HOLD_ON_OTHER_KEY_PRESS) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY) |
| 254 | # if defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY) | 254 | # if defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY) |
| 255 | if (get_hold_on_other_key_press(tapping_keycode, keyp)) | 255 | if (get_hold_on_other_key_press(tapping_keycode, &tapping_key)) |
| 256 | # endif | 256 | # endif |
| 257 | { | 257 | { |
| 258 | debug("Tapping: End. No tap. Interfered by pressed key\n"); | 258 | debug("Tapping: End. No tap. Interfered by pressed key\n"); |
| @@ -360,7 +360,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 360 | # if defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT) | 360 | # if defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT) |
| 361 | || ( | 361 | || ( |
| 362 | # ifdef RETRO_TAPPING_PER_KEY | 362 | # ifdef RETRO_TAPPING_PER_KEY |
| 363 | get_retro_tapping(tapping_keycode, keyp) && | 363 | get_retro_tapping(tapping_keycode, &tapping_key) && |
| 364 | # endif | 364 | # endif |
| 365 | (RETRO_SHIFT + 0) != 0 && TIMER_DIFF_16(event.time, tapping_key.event.time) < (RETRO_SHIFT + 0) | 365 | (RETRO_SHIFT + 0) != 0 && TIMER_DIFF_16(event.time, tapping_key.event.time) < (RETRO_SHIFT + 0) |
| 366 | ) | 366 | ) |
| @@ -373,7 +373,7 @@ bool process_tapping(keyrecord_t *keyp) { | |||
| 373 | # if !defined(TAPPING_FORCE_HOLD) || defined(TAPPING_FORCE_HOLD_PER_KEY) | 373 | # if !defined(TAPPING_FORCE_HOLD) || defined(TAPPING_FORCE_HOLD_PER_KEY) |
| 374 | if ( | 374 | if ( |
| 375 | # ifdef TAPPING_FORCE_HOLD_PER_KEY | 375 | # ifdef TAPPING_FORCE_HOLD_PER_KEY |
| 376 | !get_tapping_force_hold(tapping_keycode, keyp) && | 376 | !get_tapping_force_hold(tapping_keycode, &tapping_key) && |
| 377 | # endif | 377 | # endif |
| 378 | !tapping_key.tap.interrupted && tapping_key.tap.count > 0) { | 378 | !tapping_key.tap.interrupted && tapping_key.tap.count > 0) { |
| 379 | // sequential tap. | 379 | // sequential tap. |
