diff options
| author | Albert Y <76888457+filterpaper@users.noreply.github.com> | 2022-12-12 23:52:22 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-12 16:52:22 +0100 |
| commit | cbabc8dbe6a8476d3082e8bc649d330f87e7b904 (patch) | |
| tree | 55e73275367047981295d046867d9f70352814c7 /quantum/action_tapping.h | |
| parent | 8698d109d7c2f4554e0f3c01b017738a0a47f162 (diff) | |
[Core] Replace Tapping Force Hold feature with Quick Tap Term (#17007)
* Replace Tapping Force Hold feature with Quick Tap Term
* Replace keyboard level TAPPING_FORCE_HOLD with QUICK_TAP_TERM 0
* Deprecate force hold in info_config.json
* Before and after quick tap term unit tests
* Quick tap unit tests iteration
* Keymap config.h correction
* Remove TAPPING_FORCE_HOLD_PER_KEY macros that were missed
* Add two more test cases for quick tap
* Replace TAPPING_FORCE_HOLD with QUICK_TAP_TERM in configs #2
* Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in configs #2
* Add function declaration for get_quick_tap_term
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
Diffstat (limited to 'quantum/action_tapping.h')
| -rw-r--r-- | quantum/action_tapping.h | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/quantum/action_tapping.h b/quantum/action_tapping.h index bcccc7ac45..c078488c04 100644 --- a/quantum/action_tapping.h +++ b/quantum/action_tapping.h | |||
| @@ -22,6 +22,11 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 22 | # define TAPPING_TERM 200 | 22 | # define TAPPING_TERM 200 |
| 23 | #endif | 23 | #endif |
| 24 | 24 | ||
| 25 | /* period of quick tap(ms) */ | ||
| 26 | #if !defined(QUICK_TAP_TERM) || QUICK_TAP_TERM > TAPPING_TERM | ||
| 27 | # define QUICK_TAP_TERM TAPPING_TERM | ||
| 28 | #endif | ||
| 29 | |||
| 25 | /* tap count needed for toggling a feature */ | 30 | /* tap count needed for toggling a feature */ |
| 26 | #ifndef TAPPING_TOGGLE | 31 | #ifndef TAPPING_TOGGLE |
| 27 | # define TAPPING_TOGGLE 5 | 32 | # define TAPPING_TOGGLE 5 |
| @@ -36,9 +41,9 @@ void action_tapping_process(keyrecord_t record); | |||
| 36 | #endif | 41 | #endif |
| 37 | 42 | ||
| 38 | uint16_t get_tapping_term(uint16_t keycode, keyrecord_t *record); | 43 | uint16_t get_tapping_term(uint16_t keycode, keyrecord_t *record); |
| 44 | uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record); | ||
| 39 | bool get_permissive_hold(uint16_t keycode, keyrecord_t *record); | 45 | bool get_permissive_hold(uint16_t keycode, keyrecord_t *record); |
| 40 | bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record); | 46 | bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record); |
| 41 | bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record); | ||
| 42 | bool get_retro_tapping(uint16_t keycode, keyrecord_t *record); | 47 | bool get_retro_tapping(uint16_t keycode, keyrecord_t *record); |
| 43 | bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record); | 48 | bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record); |
| 44 | 49 | ||
| @@ -53,3 +58,9 @@ extern uint16_t g_tapping_term; | |||
| 53 | #else | 58 | #else |
| 54 | # define GET_TAPPING_TERM(keycode, record) (TAPPING_TERM) | 59 | # define GET_TAPPING_TERM(keycode, record) (TAPPING_TERM) |
| 55 | #endif | 60 | #endif |
| 61 | |||
| 62 | #ifdef QUICK_TAP_TERM_PER_KEY | ||
| 63 | # define GET_QUICK_TAP_TERM(keycode, record) get_quick_tap_term(keycode, record) | ||
| 64 | #else | ||
| 65 | # define GET_QUICK_TAP_TERM(keycode, record) (QUICK_TAP_TERM) | ||
| 66 | #endif | ||
