summaryrefslogtreecommitdiff
path: root/quantum/serial_link/tests/byte_stuffer_tests.cpp
diff options
context:
space:
mode:
authorskullY <skullydazed@gmail.com>2019-08-30 11:19:03 -0700
committerskullydazed <skullydazed@users.noreply.github.com>2019-08-30 15:01:52 -0700
commitb624f32f944acdc59dcb130674c09090c5c404cb (patch)
treebc13adbba137d122d9a2c2fb2fafcbb08ac10e25 /quantum/serial_link/tests/byte_stuffer_tests.cpp
parent61af76a10d00aba185b8338604171de490a13e3b (diff)
clang-format changes
Diffstat (limited to 'quantum/serial_link/tests/byte_stuffer_tests.cpp')
-rw-r--r--quantum/serial_link/tests/byte_stuffer_tests.cpp211
1 files changed, 89 insertions, 122 deletions
diff --git a/quantum/serial_link/tests/byte_stuffer_tests.cpp b/quantum/serial_link/tests/byte_stuffer_tests.cpp
index ff49d727bb..9e4e1768f4 100644
--- a/quantum/serial_link/tests/byte_stuffer_tests.cpp
+++ b/quantum/serial_link/tests/byte_stuffer_tests.cpp
@@ -33,25 +33,21 @@ extern "C" {
33} 33}
34 34
35using testing::_; 35using testing::_;
36using testing::ElementsAreArray;
37using testing::Args; 36using testing::Args;
37using testing::ElementsAreArray;
38 38
39class ByteStuffer : public ::testing::Test{ 39class ByteStuffer : public ::testing::Test {
40public: 40 public:
41 ByteStuffer() { 41 ByteStuffer() {
42 Instance = this; 42 Instance = this;
43 init_byte_stuffer(); 43 init_byte_stuffer();
44 } 44 }
45 45
46 ~ByteStuffer() { 46 ~ByteStuffer() { Instance = nullptr; }
47 Instance = nullptr;
48 }
49 47
50 MOCK_METHOD3(validator_recv_frame, void (uint8_t link, uint8_t* data, uint16_t size)); 48 MOCK_METHOD3(validator_recv_frame, void(uint8_t link, uint8_t* data, uint16_t size));
51 49
52 void send_data(uint8_t link, const uint8_t* data, uint16_t size) { 50 void send_data(uint8_t link, const uint8_t* data, uint16_t size) { std::copy(data, data + size, std::back_inserter(sent_data)); }
53 std::copy(data, data + size, std::back_inserter(sent_data));
54 }
55 std::vector<uint8_t> sent_data; 51 std::vector<uint8_t> sent_data;
56 52
57 static ByteStuffer* Instance; 53 static ByteStuffer* Instance;
@@ -60,52 +56,42 @@ public:
60ByteStuffer* ByteStuffer::Instance = nullptr; 56ByteStuffer* ByteStuffer::Instance = nullptr;
61 57
62extern "C" { 58extern "C" {
63 void validator_recv_frame(uint8_t link, uint8_t* data, uint16_t size) { 59void validator_recv_frame(uint8_t link, uint8_t* data, uint16_t size) { ByteStuffer::Instance->validator_recv_frame(link, data, size); }
64 ByteStuffer::Instance->validator_recv_frame(link, data, size);
65 }
66 60
67 void send_data(uint8_t link, const uint8_t* data, uint16_t size) { 61void send_data(uint8_t link, const uint8_t* data, uint16_t size) { ByteStuffer::Instance->send_data(link, data, size); }
68 ByteStuffer::Instance->send_data(link, data, size);
69 }
70} 62}
71 63
72TEST_F(ByteStuffer, receives_no_frame_for_a_single_zero_byte) { 64TEST_F(ByteStuffer, receives_no_frame_for_a_single_zero_byte) {
73 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 65 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).Times(0);
74 .Times(0);
75 byte_stuffer_recv_byte(0, 0); 66 byte_stuffer_recv_byte(0, 0);
76} 67}
77 68
78TEST_F(ByteStuffer, receives_no_frame_for_a_single_FF_byte) { 69TEST_F(ByteStuffer, receives_no_frame_for_a_single_FF_byte) {
79 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 70 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).Times(0);
80 .Times(0);
81 byte_stuffer_recv_byte(0, 0xFF); 71 byte_stuffer_recv_byte(0, 0xFF);
82} 72}
83 73
84TEST_F(ByteStuffer, receives_no_frame_for_a_single_random_byte) { 74TEST_F(ByteStuffer, receives_no_frame_for_a_single_random_byte) {
85 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 75 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).Times(0);
86 .Times(0);
87 byte_stuffer_recv_byte(0, 0x4A); 76 byte_stuffer_recv_byte(0, 0x4A);
88} 77}
89 78
90TEST_F(ByteStuffer, receives_no_frame_for_a_zero_length_frame) { 79TEST_F(ByteStuffer, receives_no_frame_for_a_zero_length_frame) {
91 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 80 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).Times(0);
92 .Times(0);
93 byte_stuffer_recv_byte(0, 1); 81 byte_stuffer_recv_byte(0, 1);
94 byte_stuffer_recv_byte(0, 0); 82 byte_stuffer_recv_byte(0, 0);
95} 83}
96 84
97TEST_F(ByteStuffer, receives_single_byte_valid_frame) { 85TEST_F(ByteStuffer, receives_single_byte_valid_frame) {
98 uint8_t expected[] = {0x37}; 86 uint8_t expected[] = {0x37};
99 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 87 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
100 .With(Args<1, 2>(ElementsAreArray(expected)));
101 byte_stuffer_recv_byte(0, 2); 88 byte_stuffer_recv_byte(0, 2);
102 byte_stuffer_recv_byte(0, 0x37); 89 byte_stuffer_recv_byte(0, 0x37);
103 byte_stuffer_recv_byte(0, 0); 90 byte_stuffer_recv_byte(0, 0);
104} 91}
105TEST_F(ByteStuffer, receives_three_bytes_valid_frame) { 92TEST_F(ByteStuffer, receives_three_bytes_valid_frame) {
106 uint8_t expected[] = {0x37, 0x99, 0xFF}; 93 uint8_t expected[] = {0x37, 0x99, 0xFF};
107 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 94 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
108 .With(Args<1, 2>(ElementsAreArray(expected)));
109 byte_stuffer_recv_byte(0, 4); 95 byte_stuffer_recv_byte(0, 4);
110 byte_stuffer_recv_byte(0, 0x37); 96 byte_stuffer_recv_byte(0, 0x37);
111 byte_stuffer_recv_byte(0, 0x99); 97 byte_stuffer_recv_byte(0, 0x99);
@@ -115,8 +101,7 @@ TEST_F(ByteStuffer, receives_three_bytes_valid_frame) {
115 101
116TEST_F(ByteStuffer, receives_single_zero_valid_frame) { 102TEST_F(ByteStuffer, receives_single_zero_valid_frame) {
117 uint8_t expected[] = {0}; 103 uint8_t expected[] = {0};
118 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 104 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
119 .With(Args<1, 2>(ElementsAreArray(expected)));
120 byte_stuffer_recv_byte(0, 1); 105 byte_stuffer_recv_byte(0, 1);
121 byte_stuffer_recv_byte(0, 1); 106 byte_stuffer_recv_byte(0, 1);
122 byte_stuffer_recv_byte(0, 0); 107 byte_stuffer_recv_byte(0, 0);
@@ -124,8 +109,7 @@ TEST_F(ByteStuffer, receives_single_zero_valid_frame) {
124 109
125TEST_F(ByteStuffer, receives_valid_frame_with_zeroes) { 110TEST_F(ByteStuffer, receives_valid_frame_with_zeroes) {
126 uint8_t expected[] = {5, 0, 3, 0}; 111 uint8_t expected[] = {5, 0, 3, 0};
127 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 112 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
128 .With(Args<1, 2>(ElementsAreArray(expected)));
129 byte_stuffer_recv_byte(0, 2); 113 byte_stuffer_recv_byte(0, 2);
130 byte_stuffer_recv_byte(0, 5); 114 byte_stuffer_recv_byte(0, 5);
131 byte_stuffer_recv_byte(0, 2); 115 byte_stuffer_recv_byte(0, 2);
@@ -134,14 +118,11 @@ TEST_F(ByteStuffer, receives_valid_frame_with_zeroes) {
134 byte_stuffer_recv_byte(0, 0); 118 byte_stuffer_recv_byte(0, 0);
135} 119}
136 120
137
138TEST_F(ByteStuffer, receives_two_valid_frames) { 121TEST_F(ByteStuffer, receives_two_valid_frames) {
139 uint8_t expected1[] = {5, 0}; 122 uint8_t expected1[] = {5, 0};
140 uint8_t expected2[] = {3}; 123 uint8_t expected2[] = {3};
141 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 124 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected1)));
142 .With(Args<1, 2>(ElementsAreArray(expected1))); 125 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected2)));
143 EXPECT_CALL(*this, validator_recv_frame(_, _, _))
144 .With(Args<1, 2>(ElementsAreArray(expected2)));
145 byte_stuffer_recv_byte(1, 2); 126 byte_stuffer_recv_byte(1, 2);
146 byte_stuffer_recv_byte(1, 5); 127 byte_stuffer_recv_byte(1, 5);
147 byte_stuffer_recv_byte(1, 1); 128 byte_stuffer_recv_byte(1, 1);
@@ -153,8 +134,7 @@ TEST_F(ByteStuffer, receives_two_valid_frames) {
153 134
154TEST_F(ByteStuffer, receives_valid_frame_after_unexpected_zero) { 135TEST_F(ByteStuffer, receives_valid_frame_after_unexpected_zero) {
155 uint8_t expected[] = {5, 7}; 136 uint8_t expected[] = {5, 7};
156 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 137 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
157 .With(Args<1, 2>(ElementsAreArray(expected)));
158 byte_stuffer_recv_byte(1, 3); 138 byte_stuffer_recv_byte(1, 3);
159 byte_stuffer_recv_byte(1, 1); 139 byte_stuffer_recv_byte(1, 1);
160 byte_stuffer_recv_byte(1, 0); 140 byte_stuffer_recv_byte(1, 0);
@@ -166,11 +146,10 @@ TEST_F(ByteStuffer, receives_valid_frame_after_unexpected_zero) {
166 146
167TEST_F(ByteStuffer, receives_valid_frame_after_unexpected_non_zero) { 147TEST_F(ByteStuffer, receives_valid_frame_after_unexpected_non_zero) {
168 uint8_t expected[] = {5, 7}; 148 uint8_t expected[] = {5, 7};
169 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 149 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
170 .With(Args<1, 2>(ElementsAreArray(expected)));
171 byte_stuffer_recv_byte(0, 2); 150 byte_stuffer_recv_byte(0, 2);
172 byte_stuffer_recv_byte(0, 9); 151 byte_stuffer_recv_byte(0, 9);
173 byte_stuffer_recv_byte(0, 4); // This should have been zero 152 byte_stuffer_recv_byte(0, 4); // This should have been zero
174 byte_stuffer_recv_byte(0, 0); 153 byte_stuffer_recv_byte(0, 0);
175 byte_stuffer_recv_byte(0, 3); 154 byte_stuffer_recv_byte(0, 3);
176 byte_stuffer_recv_byte(0, 5); 155 byte_stuffer_recv_byte(0, 5);
@@ -180,31 +159,29 @@ TEST_F(ByteStuffer, receives_valid_frame_after_unexpected_non_zero) {
180 159
181TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_and_then_end_of_frame) { 160TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_and_then_end_of_frame) {
182 uint8_t expected[254]; 161 uint8_t expected[254];
183 int i; 162 int i;
184 for (i=0;i<254;i++) { 163 for (i = 0; i < 254; i++) {
185 expected[i] = i + 1; 164 expected[i] = i + 1;
186 } 165 }
187 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 166 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
188 .With(Args<1, 2>(ElementsAreArray(expected)));
189 byte_stuffer_recv_byte(0, 0xFF); 167 byte_stuffer_recv_byte(0, 0xFF);
190 for (i=0;i<254;i++) { 168 for (i = 0; i < 254; i++) {
191 byte_stuffer_recv_byte(0, i+1); 169 byte_stuffer_recv_byte(0, i + 1);
192 } 170 }
193 byte_stuffer_recv_byte(0, 0); 171 byte_stuffer_recv_byte(0, 0);
194} 172}
195 173
196TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_next_byte_is_non_zero) { 174TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_next_byte_is_non_zero) {
197 uint8_t expected[255]; 175 uint8_t expected[255];
198 int i; 176 int i;
199 for (i=0;i<254;i++) { 177 for (i = 0; i < 254; i++) {
200 expected[i] = i + 1; 178 expected[i] = i + 1;
201 } 179 }
202 expected[254] = 7; 180 expected[254] = 7;
203 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 181 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
204 .With(Args<1, 2>(ElementsAreArray(expected)));
205 byte_stuffer_recv_byte(0, 0xFF); 182 byte_stuffer_recv_byte(0, 0xFF);
206 for (i=0;i<254;i++) { 183 for (i = 0; i < 254; i++) {
207 byte_stuffer_recv_byte(0, i+1); 184 byte_stuffer_recv_byte(0, i + 1);
208 } 185 }
209 byte_stuffer_recv_byte(0, 2); 186 byte_stuffer_recv_byte(0, 2);
210 byte_stuffer_recv_byte(0, 7); 187 byte_stuffer_recv_byte(0, 7);
@@ -213,16 +190,15 @@ TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_next_byte_is_
213 190
214TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_next_byte_is_zero) { 191TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_next_byte_is_zero) {
215 uint8_t expected[255]; 192 uint8_t expected[255];
216 int i; 193 int i;
217 for (i=0;i<254;i++) { 194 for (i = 0; i < 254; i++) {
218 expected[i] = i + 1; 195 expected[i] = i + 1;
219 } 196 }
220 expected[254] = 0; 197 expected[254] = 0;
221 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 198 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
222 .With(Args<1, 2>(ElementsAreArray(expected)));
223 byte_stuffer_recv_byte(0, 0xFF); 199 byte_stuffer_recv_byte(0, 0xFF);
224 for (i=0;i<254;i++) { 200 for (i = 0; i < 254; i++) {
225 byte_stuffer_recv_byte(0, i+1); 201 byte_stuffer_recv_byte(0, i + 1);
226 } 202 }
227 byte_stuffer_recv_byte(0, 1); 203 byte_stuffer_recv_byte(0, 1);
228 byte_stuffer_recv_byte(0, 1); 204 byte_stuffer_recv_byte(0, 1);
@@ -231,25 +207,24 @@ TEST_F(ByteStuffer, receives_a_valid_frame_with_over254_non_zeroes_next_byte_is_
231 207
232TEST_F(ByteStuffer, receives_two_long_frames_and_some_more) { 208TEST_F(ByteStuffer, receives_two_long_frames_and_some_more) {
233 uint8_t expected[515]; 209 uint8_t expected[515];
234 int i; 210 int i;
235 int j; 211 int j;
236 for (j=0;j<2;j++) { 212 for (j = 0; j < 2; j++) {
237 for (i=0;i<254;i++) { 213 for (i = 0; i < 254; i++) {
238 expected[i+254*j] = i + 1; 214 expected[i + 254 * j] = i + 1;
239 } 215 }
240 } 216 }
241 for (i=0;i<7;i++) { 217 for (i = 0; i < 7; i++) {
242 expected[254*2+i] = i + 1; 218 expected[254 * 2 + i] = i + 1;
243 } 219 }
244 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 220 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
245 .With(Args<1, 2>(ElementsAreArray(expected)));
246 byte_stuffer_recv_byte(0, 0xFF); 221 byte_stuffer_recv_byte(0, 0xFF);
247 for (i=0;i<254;i++) { 222 for (i = 0; i < 254; i++) {
248 byte_stuffer_recv_byte(0, i+1); 223 byte_stuffer_recv_byte(0, i + 1);
249 } 224 }
250 byte_stuffer_recv_byte(0, 0xFF); 225 byte_stuffer_recv_byte(0, 0xFF);
251 for (i=0;i<254;i++) { 226 for (i = 0; i < 254; i++) {
252 byte_stuffer_recv_byte(0, i+1); 227 byte_stuffer_recv_byte(0, i + 1);
253 } 228 }
254 byte_stuffer_recv_byte(0, 8); 229 byte_stuffer_recv_byte(0, 8);
255 byte_stuffer_recv_byte(0, 1); 230 byte_stuffer_recv_byte(0, 1);
@@ -264,24 +239,22 @@ TEST_F(ByteStuffer, receives_two_long_frames_and_some_more) {
264 239
265TEST_F(ByteStuffer, receives_an_all_zeros_frame_that_is_maximum_size) { 240TEST_F(ByteStuffer, receives_an_all_zeros_frame_that_is_maximum_size) {
266 uint8_t expected[MAX_FRAME_SIZE] = {}; 241 uint8_t expected[MAX_FRAME_SIZE] = {};
267 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 242 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
268 .With(Args<1, 2>(ElementsAreArray(expected)));
269 int i; 243 int i;
270 byte_stuffer_recv_byte(0, 1); 244 byte_stuffer_recv_byte(0, 1);
271 for(i=0;i<MAX_FRAME_SIZE;i++) { 245 for (i = 0; i < MAX_FRAME_SIZE; i++) {
272 byte_stuffer_recv_byte(0, 1); 246 byte_stuffer_recv_byte(0, 1);
273 } 247 }
274 byte_stuffer_recv_byte(0, 0); 248 byte_stuffer_recv_byte(0, 0);
275} 249}
276 250
277TEST_F(ByteStuffer, doesnt_recv_a_frame_thats_too_long_all_zeroes) { 251TEST_F(ByteStuffer, doesnt_recv_a_frame_thats_too_long_all_zeroes) {
278 uint8_t expected[1] = {0}; 252 uint8_t expected[1] = {0};
279 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 253 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).Times(0);
280 .Times(0);
281 int i; 254 int i;
282 byte_stuffer_recv_byte(0, 1); 255 byte_stuffer_recv_byte(0, 1);
283 for(i=0;i<MAX_FRAME_SIZE;i++) { 256 for (i = 0; i < MAX_FRAME_SIZE; i++) {
284 byte_stuffer_recv_byte(0, 1); 257 byte_stuffer_recv_byte(0, 1);
285 } 258 }
286 byte_stuffer_recv_byte(0, 1); 259 byte_stuffer_recv_byte(0, 1);
287 byte_stuffer_recv_byte(0, 0); 260 byte_stuffer_recv_byte(0, 0);
@@ -289,12 +262,11 @@ TEST_F(ByteStuffer, doesnt_recv_a_frame_thats_too_long_all_zeroes) {
289 262
290TEST_F(ByteStuffer, received_frame_is_aborted_when_its_too_long) { 263TEST_F(ByteStuffer, received_frame_is_aborted_when_its_too_long) {
291 uint8_t expected[1] = {1}; 264 uint8_t expected[1] = {1};
292 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 265 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(expected)));
293 .With(Args<1, 2>(ElementsAreArray(expected)));
294 int i; 266 int i;
295 byte_stuffer_recv_byte(0, 1); 267 byte_stuffer_recv_byte(0, 1);
296 for(i=0;i<MAX_FRAME_SIZE;i++) { 268 for (i = 0; i < MAX_FRAME_SIZE; i++) {
297 byte_stuffer_recv_byte(0, 1); 269 byte_stuffer_recv_byte(0, 1);
298 } 270 }
299 byte_stuffer_recv_byte(0, 2); 271 byte_stuffer_recv_byte(0, 2);
300 byte_stuffer_recv_byte(0, 1); 272 byte_stuffer_recv_byte(0, 1);
@@ -364,14 +336,14 @@ TEST_F(ByteStuffer, sends_three_byte_frame_with_all_zeroes) {
364 336
365TEST_F(ByteStuffer, sends_frame_with_254_non_zeroes) { 337TEST_F(ByteStuffer, sends_frame_with_254_non_zeroes) {
366 uint8_t data[254]; 338 uint8_t data[254];
367 int i; 339 int i;
368 for(i=0;i<254;i++) { 340 for (i = 0; i < 254; i++) {
369 data[i] = i + 1; 341 data[i] = i + 1;
370 } 342 }
371 byte_stuffer_send_frame(0, data, 254); 343 byte_stuffer_send_frame(0, data, 254);
372 uint8_t expected[256]; 344 uint8_t expected[256];
373 expected[0] = 0xFF; 345 expected[0] = 0xFF;
374 for(i=1;i<255;i++) { 346 for (i = 1; i < 255; i++) {
375 expected[i] = i; 347 expected[i] = i;
376 } 348 }
377 expected[255] = 0; 349 expected[255] = 0;
@@ -380,14 +352,14 @@ TEST_F(ByteStuffer, sends_frame_with_254_non_zeroes) {
380 352
381TEST_F(ByteStuffer, sends_frame_with_255_non_zeroes) { 353TEST_F(ByteStuffer, sends_frame_with_255_non_zeroes) {
382 uint8_t data[255]; 354 uint8_t data[255];
383 int i; 355 int i;
384 for(i=0;i<255;i++) { 356 for (i = 0; i < 255; i++) {
385 data[i] = i + 1; 357 data[i] = i + 1;
386 } 358 }
387 byte_stuffer_send_frame(0, data, 255); 359 byte_stuffer_send_frame(0, data, 255);
388 uint8_t expected[258]; 360 uint8_t expected[258];
389 expected[0] = 0xFF; 361 expected[0] = 0xFF;
390 for(i=1;i<255;i++) { 362 for (i = 1; i < 255; i++) {
391 expected[i] = i; 363 expected[i] = i;
392 } 364 }
393 expected[255] = 2; 365 expected[255] = 2;
@@ -398,15 +370,15 @@ TEST_F(ByteStuffer, sends_frame_with_255_non_zeroes) {
398 370
399TEST_F(ByteStuffer, sends_frame_with_254_non_zeroes_followed_by_zero) { 371TEST_F(ByteStuffer, sends_frame_with_254_non_zeroes_followed_by_zero) {
400 uint8_t data[255]; 372 uint8_t data[255];
401 int i; 373 int i;
402 for(i=0;i<254;i++) { 374 for (i = 0; i < 254; i++) {
403 data[i] = i + 1; 375 data[i] = i + 1;
404 } 376 }
405 data[254] = 0; 377 data[254] = 0;
406 byte_stuffer_send_frame(0, data, 255); 378 byte_stuffer_send_frame(0, data, 255);
407 uint8_t expected[258]; 379 uint8_t expected[258];
408 expected[0] = 0xFF; 380 expected[0] = 0xFF;
409 for(i=1;i<255;i++) { 381 for (i = 1; i < 255; i++) {
410 expected[i] = i; 382 expected[i] = i;
411 } 383 }
412 expected[255] = 1; 384 expected[255] = 1;
@@ -416,68 +388,63 @@ TEST_F(ByteStuffer, sends_frame_with_254_non_zeroes_followed_by_zero) {
416} 388}
417 389
418TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_small_packet) { 390TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_small_packet) {
419 uint8_t original_data[] = { 1, 2, 3}; 391 uint8_t original_data[] = {1, 2, 3};
420 byte_stuffer_send_frame(0, original_data, sizeof(original_data)); 392 byte_stuffer_send_frame(0, original_data, sizeof(original_data));
421 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 393 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(original_data)));
422 .With(Args<1, 2>(ElementsAreArray(original_data)));
423 int i; 394 int i;
424 for(auto& d : sent_data) { 395 for (auto& d : sent_data) {
425 byte_stuffer_recv_byte(1, d); 396 byte_stuffer_recv_byte(1, d);
426 } 397 }
427} 398}
428 399
429TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_small_packet_with_zeros) { 400TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_small_packet_with_zeros) {
430 uint8_t original_data[] = { 1, 0, 3, 0, 0, 9}; 401 uint8_t original_data[] = {1, 0, 3, 0, 0, 9};
431 byte_stuffer_send_frame(1, original_data, sizeof(original_data)); 402 byte_stuffer_send_frame(1, original_data, sizeof(original_data));
432 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 403 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(original_data)));
433 .With(Args<1, 2>(ElementsAreArray(original_data)));
434 int i; 404 int i;
435 for(auto& d : sent_data) { 405 for (auto& d : sent_data) {
436 byte_stuffer_recv_byte(1, d); 406 byte_stuffer_recv_byte(1, d);
437 } 407 }
438} 408}
439 409
440TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_254_bytes) { 410TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_254_bytes) {
441 uint8_t original_data[254]; 411 uint8_t original_data[254];
442 int i; 412 int i;
443 for(i=0;i<254;i++) { 413 for (i = 0; i < 254; i++) {
444 original_data[i] = i + 1; 414 original_data[i] = i + 1;
445 } 415 }
446 byte_stuffer_send_frame(0, original_data, sizeof(original_data)); 416 byte_stuffer_send_frame(0, original_data, sizeof(original_data));
447 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 417 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(original_data)));
448 .With(Args<1, 2>(ElementsAreArray(original_data))); 418 for (auto& d : sent_data) {
449 for(auto& d : sent_data) { 419 byte_stuffer_recv_byte(1, d);
450 byte_stuffer_recv_byte(1, d);
451 } 420 }
452} 421}
453 422
454TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_256_bytes) { 423TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_256_bytes) {
455 uint8_t original_data[256]; 424 uint8_t original_data[256];
456 int i; 425 int i;
457 for(i=0;i<254;i++) { 426 for (i = 0; i < 254; i++) {
458 original_data[i] = i + 1; 427 original_data[i] = i + 1;
459 } 428 }
460 original_data[254] = 22; 429 original_data[254] = 22;
461 original_data[255] = 23; 430 original_data[255] = 23;
462 byte_stuffer_send_frame(0, original_data, sizeof(original_data)); 431 byte_stuffer_send_frame(0, original_data, sizeof(original_data));
463 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 432 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(original_data)));
464 .With(Args<1, 2>(ElementsAreArray(original_data))); 433 for (auto& d : sent_data) {
465 for(auto& d : sent_data) { 434 byte_stuffer_recv_byte(1, d);
466 byte_stuffer_recv_byte(1, d);
467 } 435 }
468} 436}
469 437
470TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_254_bytes_and_then_zero) { 438TEST_F(ByteStuffer, sends_and_receives_full_roundtrip_254_bytes_and_then_zero) {
471 uint8_t original_data[255]; 439 uint8_t original_data[255];
472 int i; 440 int i;
473 for(i=0;i<254;i++) { 441 for (i = 0; i < 254; i++) {
474 original_data[i] = i + 1; 442 original_data[i] = i + 1;
475 } 443 }
476 original_data[254] = 0; 444 original_data[254] = 0;
477 byte_stuffer_send_frame(0, original_data, sizeof(original_data)); 445 byte_stuffer_send_frame(0, original_data, sizeof(original_data));
478 EXPECT_CALL(*this, validator_recv_frame(_, _, _)) 446 EXPECT_CALL(*this, validator_recv_frame(_, _, _)).With(Args<1, 2>(ElementsAreArray(original_data)));
479 .With(Args<1, 2>(ElementsAreArray(original_data))); 447 for (auto& d : sent_data) {
480 for(auto& d : sent_data) { 448 byte_stuffer_recv_byte(1, d);
481 byte_stuffer_recv_byte(1, d);
482 } 449 }
483} 450}