summaryrefslogtreecommitdiff
path: root/quantum
diff options
context:
space:
mode:
authorJoel Challis <git@zvecr.com>2023-02-12 17:09:34 +0000
committerGitHub <noreply@github.com>2023-02-12 17:09:34 +0000
commit6ceff1367d1d3c6fbf6f903ea9ef7aff9099eec5 (patch)
treeb073196d43f2133f3a1e515712194cc649159b6c /quantum
parent13af26526837c9a82b53a42b1820ce19d587553c (diff)
Tidy up use of keycode range helpers (#19813)
Diffstat (limited to 'quantum')
-rw-r--r--quantum/action.c10
-rw-r--r--quantum/keycode.h3
-rw-r--r--quantum/keycodes.h2
3 files changed, 6 insertions, 9 deletions
diff --git a/quantum/action.c b/quantum/action.c
index 72f132eaa8..0f8219a3d1 100644
--- a/quantum/action.c
+++ b/quantum/action.c
@@ -323,7 +323,7 @@ void register_mouse(uint8_t mouse_keycode, bool pressed) {
323#elif defined(POINTING_DEVICE_ENABLE) 323#elif defined(POINTING_DEVICE_ENABLE)
324 // if mousekeys isn't enabled, and pointing device is enabled, then 324 // if mousekeys isn't enabled, and pointing device is enabled, then
325 // let pointing device do all the heavy lifting, then 325 // let pointing device do all the heavy lifting, then
326 if IS_MOUSEKEY (mouse_keycode) { 326 if IS_MOUSE_KEYCODE (mouse_keycode) {
327 pointing_device_keycode_handler(mouse_keycode, pressed); 327 pointing_device_keycode_handler(mouse_keycode, pressed);
328 } 328 }
329#endif 329#endif
@@ -895,13 +895,13 @@ __attribute__((weak)) void register_code(uint8_t code) {
895 send_keyboard_report(); 895 send_keyboard_report();
896 896
897#ifdef EXTRAKEY_ENABLE 897#ifdef EXTRAKEY_ENABLE
898 } else if IS_SYSTEM (code) { 898 } else if IS_SYSTEM_KEYCODE (code) {
899 host_system_send(KEYCODE2SYSTEM(code)); 899 host_system_send(KEYCODE2SYSTEM(code));
900 } else if IS_CONSUMER (code) { 900 } else if IS_CONSUMER_KEYCODE (code) {
901 host_consumer_send(KEYCODE2CONSUMER(code)); 901 host_consumer_send(KEYCODE2CONSUMER(code));
902#endif 902#endif
903 903
904 } else if IS_MOUSEKEY (code) { 904 } else if IS_MOUSE_KEYCODE (code) {
905 register_mouse(code, true); 905 register_mouse(code, true);
906 } 906 }
907} 907}
@@ -958,7 +958,7 @@ __attribute__((weak)) void unregister_code(uint8_t code) {
958 host_consumer_send(0); 958 host_consumer_send(0);
959#endif 959#endif
960 960
961 } else if IS_MOUSEKEY (code) { 961 } else if IS_MOUSE_KEYCODE (code) {
962 register_mouse(code, false); 962 register_mouse(code, false);
963 } 963 }
964} 964}
diff --git a/quantum/keycode.h b/quantum/keycode.h
index 03989ed8f6..701c078ad0 100644
--- a/quantum/keycode.h
+++ b/quantum/keycode.h
@@ -28,9 +28,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
28 28
29#define IS_ANY(code) (KC_A <= (code) && (code) <= 0xFF) 29#define IS_ANY(code) (KC_A <= (code) && (code) <= 0xFF)
30 30
31#define IS_SYSTEM(code) IS_SYSTEM_KEYCODE(code)
32#define IS_CONSUMER(code) IS_MEDIA_KEYCODE(code)
33
34#define IS_MOUSEKEY(code) IS_MOUSE_KEYCODE(code) 31#define IS_MOUSEKEY(code) IS_MOUSE_KEYCODE(code)
35#define IS_MOUSEKEY_MOVE(code) (KC_MS_UP <= (code) && (code) <= KC_MS_RIGHT) 32#define IS_MOUSEKEY_MOVE(code) (KC_MS_UP <= (code) && (code) <= KC_MS_RIGHT)
36#define IS_MOUSEKEY_BUTTON(code) (KC_MS_BTN1 <= (code) && (code) <= KC_MS_BTN8) 33#define IS_MOUSEKEY_BUTTON(code) (KC_MS_BTN1 <= (code) && (code) <= KC_MS_BTN8)
diff --git a/quantum/keycodes.h b/quantum/keycodes.h
index cb1499dede..73b86ce9b9 100644
--- a/quantum/keycodes.h
+++ b/quantum/keycodes.h
@@ -1323,7 +1323,7 @@ enum qk_keycode_defines {
1323#define IS_INTERNAL_KEYCODE(code) ((code) >= KC_NO && (code) <= KC_TRANSPARENT) 1323#define IS_INTERNAL_KEYCODE(code) ((code) >= KC_NO && (code) <= KC_TRANSPARENT)
1324#define IS_BASIC_KEYCODE(code) ((code) >= KC_A && (code) <= KC_EXSEL) 1324#define IS_BASIC_KEYCODE(code) ((code) >= KC_A && (code) <= KC_EXSEL)
1325#define IS_SYSTEM_KEYCODE(code) ((code) >= KC_SYSTEM_POWER && (code) <= KC_SYSTEM_WAKE) 1325#define IS_SYSTEM_KEYCODE(code) ((code) >= KC_SYSTEM_POWER && (code) <= KC_SYSTEM_WAKE)
1326#define IS_MEDIA_KEYCODE(code) ((code) >= KC_AUDIO_MUTE && (code) <= KC_ASSISTANT) 1326#define IS_CONSUMER_KEYCODE(code) ((code) >= KC_AUDIO_MUTE && (code) <= KC_ASSISTANT)
1327#define IS_MOUSE_KEYCODE(code) ((code) >= KC_MS_UP && (code) <= KC_MS_ACCEL2) 1327#define IS_MOUSE_KEYCODE(code) ((code) >= KC_MS_UP && (code) <= KC_MS_ACCEL2)
1328#define IS_MODIFIER_KEYCODE(code) ((code) >= KC_LEFT_CTRL && (code) <= KC_RIGHT_GUI) 1328#define IS_MODIFIER_KEYCODE(code) ((code) >= KC_LEFT_CTRL && (code) <= KC_RIGHT_GUI)
1329#define IS_SWAP_HANDS_KEYCODE(code) ((code) >= QK_SWAP_HANDS_TOGGLE && (code) <= QK_SWAP_HANDS_ONE_SHOT) 1329#define IS_SWAP_HANDS_KEYCODE(code) ((code) >= QK_SWAP_HANDS_TOGGLE && (code) <= QK_SWAP_HANDS_ONE_SHOT)