diff options
| author | Stefan Kerkmann <karlk90@pm.me> | 2022-12-18 21:55:14 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-18 21:55:14 +0100 |
| commit | c2b13bd77b71ea73db12a6cda64871565036a6dc (patch) | |
| tree | e24c99abb8260a929b9fcc4cba21705475514c07 /tests/basic/test_keypress.cpp | |
| parent | 7aa2d791f69244a5f17ec0d00908ec5a05d21103 (diff) | |
Introduce VERIFY_AND_CLEAR shorthand (#19370)
Which is just a syntactic sugar for
testing::Mock::VerifyAndClearExpectations to reduce the visual clutter
in unit-tests.
Diffstat (limited to 'tests/basic/test_keypress.cpp')
| -rw-r--r-- | tests/basic/test_keypress.cpp | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/tests/basic/test_keypress.cpp b/tests/basic/test_keypress.cpp index 6d5b502a00..34682654b0 100644 --- a/tests/basic/test_keypress.cpp +++ b/tests/basic/test_keypress.cpp | |||
| @@ -175,23 +175,23 @@ TEST_F(KeyPress, PressPlusEqualReleaseBeforePress) { | |||
| 175 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); | 175 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); |
| 176 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); | 176 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); |
| 177 | run_one_scan_loop(); | 177 | run_one_scan_loop(); |
| 178 | testing::Mock::VerifyAndClearExpectations(&driver); | 178 | VERIFY_AND_CLEAR(driver); |
| 179 | 179 | ||
| 180 | key_plus.release(); | 180 | key_plus.release(); |
| 181 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); | 181 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); |
| 182 | EXPECT_EMPTY_REPORT(driver); | 182 | EXPECT_EMPTY_REPORT(driver); |
| 183 | run_one_scan_loop(); | 183 | run_one_scan_loop(); |
| 184 | testing::Mock::VerifyAndClearExpectations(&driver); | 184 | VERIFY_AND_CLEAR(driver); |
| 185 | 185 | ||
| 186 | key_eql.press(); | 186 | key_eql.press(); |
| 187 | EXPECT_REPORT(driver, (key_eql.report_code)); | 187 | EXPECT_REPORT(driver, (key_eql.report_code)); |
| 188 | run_one_scan_loop(); | 188 | run_one_scan_loop(); |
| 189 | testing::Mock::VerifyAndClearExpectations(&driver); | 189 | VERIFY_AND_CLEAR(driver); |
| 190 | 190 | ||
| 191 | key_eql.release(); | 191 | key_eql.release(); |
| 192 | EXPECT_EMPTY_REPORT(driver); | 192 | EXPECT_EMPTY_REPORT(driver); |
| 193 | run_one_scan_loop(); | 193 | run_one_scan_loop(); |
| 194 | testing::Mock::VerifyAndClearExpectations(&driver); | 194 | VERIFY_AND_CLEAR(driver); |
| 195 | } | 195 | } |
| 196 | 196 | ||
| 197 | TEST_F(KeyPress, PressPlusEqualDontReleaseBeforePress) { | 197 | TEST_F(KeyPress, PressPlusEqualDontReleaseBeforePress) { |
| @@ -206,24 +206,24 @@ TEST_F(KeyPress, PressPlusEqualDontReleaseBeforePress) { | |||
| 206 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); | 206 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); |
| 207 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); | 207 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); |
| 208 | run_one_scan_loop(); | 208 | run_one_scan_loop(); |
| 209 | testing::Mock::VerifyAndClearExpectations(&driver); | 209 | VERIFY_AND_CLEAR(driver); |
| 210 | 210 | ||
| 211 | key_eql.press(); | 211 | key_eql.press(); |
| 212 | EXPECT_EMPTY_REPORT(driver); | 212 | EXPECT_EMPTY_REPORT(driver); |
| 213 | EXPECT_REPORT(driver, (KC_EQUAL)); | 213 | EXPECT_REPORT(driver, (KC_EQUAL)); |
| 214 | run_one_scan_loop(); | 214 | run_one_scan_loop(); |
| 215 | testing::Mock::VerifyAndClearExpectations(&driver); | 215 | VERIFY_AND_CLEAR(driver); |
| 216 | 216 | ||
| 217 | key_plus.release(); | 217 | key_plus.release(); |
| 218 | // BUG: Should really still return KC_EQUAL, but this is fine too | 218 | // BUG: Should really still return KC_EQUAL, but this is fine too |
| 219 | EXPECT_EMPTY_REPORT(driver); | 219 | EXPECT_EMPTY_REPORT(driver); |
| 220 | run_one_scan_loop(); | 220 | run_one_scan_loop(); |
| 221 | testing::Mock::VerifyAndClearExpectations(&driver); | 221 | VERIFY_AND_CLEAR(driver); |
| 222 | 222 | ||
| 223 | key_eql.release(); | 223 | key_eql.release(); |
| 224 | EXPECT_NO_REPORT(driver); | 224 | EXPECT_NO_REPORT(driver); |
| 225 | run_one_scan_loop(); | 225 | run_one_scan_loop(); |
| 226 | testing::Mock::VerifyAndClearExpectations(&driver); | 226 | VERIFY_AND_CLEAR(driver); |
| 227 | } | 227 | } |
| 228 | 228 | ||
| 229 | TEST_F(KeyPress, PressEqualPlusReleaseBeforePress) { | 229 | TEST_F(KeyPress, PressEqualPlusReleaseBeforePress) { |
| @@ -237,24 +237,24 @@ TEST_F(KeyPress, PressEqualPlusReleaseBeforePress) { | |||
| 237 | key_eql.press(); | 237 | key_eql.press(); |
| 238 | EXPECT_REPORT(driver, (KC_EQUAL)); | 238 | EXPECT_REPORT(driver, (KC_EQUAL)); |
| 239 | run_one_scan_loop(); | 239 | run_one_scan_loop(); |
| 240 | testing::Mock::VerifyAndClearExpectations(&driver); | 240 | VERIFY_AND_CLEAR(driver); |
| 241 | 241 | ||
| 242 | key_eql.release(); | 242 | key_eql.release(); |
| 243 | EXPECT_EMPTY_REPORT(driver); | 243 | EXPECT_EMPTY_REPORT(driver); |
| 244 | run_one_scan_loop(); | 244 | run_one_scan_loop(); |
| 245 | testing::Mock::VerifyAndClearExpectations(&driver); | 245 | VERIFY_AND_CLEAR(driver); |
| 246 | 246 | ||
| 247 | key_plus.press(); | 247 | key_plus.press(); |
| 248 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); | 248 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); |
| 249 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); | 249 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); |
| 250 | run_one_scan_loop(); | 250 | run_one_scan_loop(); |
| 251 | testing::Mock::VerifyAndClearExpectations(&driver); | 251 | VERIFY_AND_CLEAR(driver); |
| 252 | 252 | ||
| 253 | key_plus.release(); | 253 | key_plus.release(); |
| 254 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); | 254 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); |
| 255 | EXPECT_EMPTY_REPORT(driver); | 255 | EXPECT_EMPTY_REPORT(driver); |
| 256 | run_one_scan_loop(); | 256 | run_one_scan_loop(); |
| 257 | testing::Mock::VerifyAndClearExpectations(&driver); | 257 | VERIFY_AND_CLEAR(driver); |
| 258 | } | 258 | } |
| 259 | 259 | ||
| 260 | TEST_F(KeyPress, PressEqualPlusDontReleaseBeforePress) { | 260 | TEST_F(KeyPress, PressEqualPlusDontReleaseBeforePress) { |
| @@ -268,7 +268,7 @@ TEST_F(KeyPress, PressEqualPlusDontReleaseBeforePress) { | |||
| 268 | key_eql.press(); | 268 | key_eql.press(); |
| 269 | EXPECT_REPORT(driver, (KC_EQUAL)); | 269 | EXPECT_REPORT(driver, (KC_EQUAL)); |
| 270 | run_one_scan_loop(); | 270 | run_one_scan_loop(); |
| 271 | testing::Mock::VerifyAndClearExpectations(&driver); | 271 | VERIFY_AND_CLEAR(driver); |
| 272 | 272 | ||
| 273 | key_plus.press(); | 273 | key_plus.press(); |
| 274 | // BUG: The sequence is a bit strange, but it works, the end result is that | 274 | // BUG: The sequence is a bit strange, but it works, the end result is that |
| @@ -277,16 +277,16 @@ TEST_F(KeyPress, PressEqualPlusDontReleaseBeforePress) { | |||
| 277 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); | 277 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); |
| 278 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); | 278 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT, KC_EQUAL)); |
| 279 | run_one_scan_loop(); | 279 | run_one_scan_loop(); |
| 280 | testing::Mock::VerifyAndClearExpectations(&driver); | 280 | VERIFY_AND_CLEAR(driver); |
| 281 | 281 | ||
| 282 | key_eql.release(); | 282 | key_eql.release(); |
| 283 | // I guess it's fine to still report shift here | 283 | // I guess it's fine to still report shift here |
| 284 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); | 284 | EXPECT_REPORT(driver, (KC_LEFT_SHIFT)); |
| 285 | run_one_scan_loop(); | 285 | run_one_scan_loop(); |
| 286 | testing::Mock::VerifyAndClearExpectations(&driver); | 286 | VERIFY_AND_CLEAR(driver); |
| 287 | 287 | ||
| 288 | key_plus.release(); | 288 | key_plus.release(); |
| 289 | EXPECT_EMPTY_REPORT(driver); | 289 | EXPECT_EMPTY_REPORT(driver); |
| 290 | run_one_scan_loop(); | 290 | run_one_scan_loop(); |
| 291 | testing::Mock::VerifyAndClearExpectations(&driver); | 291 | VERIFY_AND_CLEAR(driver); |
| 292 | } | 292 | } |
