qmk_firmware

commit ad4233d07849ad96096fb84d01b0ed3200030b09
parent 2c34b480fc2c560e9905052ec26a7f4cb1ff856c
Author: フィルターペーパー <76888457+filterpaper@users.noreply.github.com>
Date:   Sun, 13 Jul 2025 23:38:32 +0800

Clamp reactive offset value (#25489)

* Avoids underflow of the unsigned 8-bit
Diffstat:
M
quantum/rgb_matrix/animations/solid_reactive_anim.h
 | 
1
+
M
quantum/rgb_matrix/animations/solid_reactive_simple_anim.h
 | 
1
+

2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/quantum/rgb_matrix/animations/solid_reactive_anim.h b/quantum/rgb_matrix/animations/solid_reactive_anim.h
@@ -4,6 +4,7 @@ RGB_MATRIX_EFFECT(SOLID_REACTIVE)
 #        ifdef RGB_MATRIX_CUSTOM_EFFECT_IMPLS
 
 static hsv_t SOLID_REACTIVE_math(hsv_t hsv, uint16_t offset) {
+    if (offset > 255) offset = 255;
 #            ifdef RGB_MATRIX_SOLID_REACTIVE_GRADIENT_MODE
     hsv.h = scale16by8(g_rgb_timer, qadd8(rgb_matrix_config.speed, 8) >> 4);
 #            endif
diff --git a/quantum/rgb_matrix/animations/solid_reactive_simple_anim.h b/quantum/rgb_matrix/animations/solid_reactive_simple_anim.h
@@ -4,6 +4,7 @@ RGB_MATRIX_EFFECT(SOLID_REACTIVE_SIMPLE)
 #        ifdef RGB_MATRIX_CUSTOM_EFFECT_IMPLS
 
 static hsv_t SOLID_REACTIVE_SIMPLE_math(hsv_t hsv, uint16_t offset) {
+    if (offset > 255) offset = 255;
 #            ifdef RGB_MATRIX_SOLID_REACTIVE_GRADIENT_MODE
     hsv.h = scale16by8(g_rgb_timer, qadd8(rgb_matrix_config.speed, 8) >> 4);
 #            endif